From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12EB7C433EF for ; Thu, 13 Jan 2022 22:21:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F43F6B0072; Thu, 13 Jan 2022 17:21:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A3DA6B0073; Thu, 13 Jan 2022 17:21:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 643E46B0074; Thu, 13 Jan 2022 17:21:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0072.hostedemail.com [216.40.44.72]) by kanga.kvack.org (Postfix) with ESMTP id 523626B0072 for ; Thu, 13 Jan 2022 17:21:46 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 05D11181EBF15 for ; Thu, 13 Jan 2022 22:21:46 +0000 (UTC) X-FDA: 79026687012.06.404F31C Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf11.hostedemail.com (Postfix) with ESMTP id 9A55A40006 for ; Thu, 13 Jan 2022 22:21:45 +0000 (UTC) Received: by mail-ed1-f46.google.com with SMTP id q25so28365286edb.2 for ; Thu, 13 Jan 2022 14:21:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=t04p2ii6Hefu+J0FU1SBf69tfsJronr05DckYo9YxB4=; b=UxDIkWANdAVQxzY2DKo/y0YGsq+HxzDigg9pN9KakOqG5YCg14k40bOeBQWRKqyW2f eo2J47JKBiaNEIpAuyZZyIJn+vBzR5IJ3ndHQM5vYFQOSc/pgARuEV02lr/iTw1MSdos vk04gdfqQyQIOn90MUucEIbZbO6xzUqmNMN7s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=t04p2ii6Hefu+J0FU1SBf69tfsJronr05DckYo9YxB4=; b=Zh5gMhE5viUI47Bao0l7EXDp4DasaH3ShbYnjTRFapdFMMG6O/nQqm3GI8TKgQ8Z6X NOhEmVbbAvhGN7A+UN1XIcFi56OAchjoMKI26AcDDhwwz7ErbOSf/Lu6EbkbsBGUos4y ZqU5CTnw6maHKGSNtFKIbdVl3o88pU6yGMNkCsQlQQtrvoJS6x4BTeKBPPYC7KWVJH8u BfEtTUu/mshsExSCUfWKtrHQZf0ONLkKlagIKSW8xDVjUsAKJBM2ApYUc+bbP9Vrwo+r ZxZLr4xJ9mNIMPl4DGlmfS6zUYrlznU6wskr9/iVHyiZumLtO34l1ZZtSWTdaJRiqo2s v7aQ== X-Gm-Message-State: AOAM531c+Q5W3aYwUQEEPZ2OcvYTYNFkys0oGqqKdQeB3Njwh8Th5ths sWACITzjbdnJ+NvbxxMiCu9fa0WYsB1mg7pD X-Google-Smtp-Source: ABdhPJyqOkRyRHTMFthQivTAzcsBDLxTvA8HeldKtWZhDoP7CeOBRGvB0LxvKnNwOyWAJSNDcWyWEw== X-Received: by 2002:a17:906:ae87:: with SMTP id md7mr5444030ejb.32.1642112504025; Thu, 13 Jan 2022 14:21:44 -0800 (PST) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com. [209.85.128.49]) by smtp.gmail.com with ESMTPSA id c8sm1617312edu.60.2022.01.13.14.21.41 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jan 2022 14:21:41 -0800 (PST) Received: by mail-wm1-f49.google.com with SMTP id l12-20020a7bc34c000000b003467c58cbdfso6275793wmj.2 for ; Thu, 13 Jan 2022 14:21:41 -0800 (PST) X-Received: by 2002:a1c:19c6:: with SMTP id 189mr12965606wmz.155.1642112501219; Thu, 13 Jan 2022 14:21:41 -0800 (PST) MIME-Version: 1.0 References: <20220113140318.11117-1-zhangliang5@huawei.com> <172ccfbb-7e24-db21-7d84-8c8d8c3805fd@redhat.com> In-Reply-To: From: Linus Torvalds Date: Thu, 13 Jan 2022 14:21:29 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mm: reuse the unshared swapcache page in do_wp_page To: Matthew Wilcox Cc: David Hildenbrand , Liang Zhang , Andrew Morton , Linux-MM , Linux Kernel Mailing List , wangzhigang17@huawei.com Content-Type: multipart/alternative; boundary="000000000000511a5f05d57e1cc7" X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 9A55A40006 X-Stat-Signature: 4hqmdcczji1oe3nt5ng7ftf3ee5hfi11 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=UxDIkWAN; dmarc=none; spf=pass (imf11.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.46 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org X-HE-Tag: 1642112505-542797 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --000000000000511a5f05d57e1cc7 Content-Type: text/plain; charset="UTF-8" [ sorry for html crud, I'm at the airport reading email on my phone ] On Thu, Jan 13, 2022, 13:07 Matthew Wilcox wrote: > On Thu, > + if (page_count(page) > 5) > goto copy; Heh. That 5 was just supposed to be an example situation, not an actual value to test. Using 1+PageSwapCache(page) is fine with a comment about how it's an optimistic comment Linus > > --000000000000511a5f05d57e1cc7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
[ sorry for html crud, I'm at the airport readin= g email on my phone ]

On Thu, Jan 13, 2022, 13:07 Matthew Wilcox <willy@infradead.org> wrote:
On Thu,=C2=A0
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (page_count(page= ) > 5)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 goto copy;

<= div dir=3D"auto">Heh. That 5 was just supposed to be an example situation, = not an actual value to test.

Using 1+PageSwapCache(page) is fine with a comment about how it's = an optimistic comment

= =C2=A0 =C2=A0 =C2=A0 Linus
=C2=A0
--000000000000511a5f05d57e1cc7--