From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB4A5C3DA4A for ; Fri, 9 Aug 2024 15:13:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 651176B0098; Fri, 9 Aug 2024 11:13:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D8DA6B009A; Fri, 9 Aug 2024 11:13:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 479CC6B009C; Fri, 9 Aug 2024 11:13:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 263306B0098 for ; Fri, 9 Aug 2024 11:13:31 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D5B651410A3 for ; Fri, 9 Aug 2024 15:13:30 +0000 (UTC) X-FDA: 82433050980.07.95C9490 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf24.hostedemail.com (Postfix) with ESMTP id B21DC18000C for ; Fri, 9 Aug 2024 15:13:28 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=NU5tNWt6; dmarc=none; spf=pass (imf24.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.49 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723216360; a=rsa-sha256; cv=none; b=Qh/o00ch2bHlQkURSNwX49svr+39xJfHNHHk9e0B1Hvo4dQ4iGpaMjawUf1kR0NEGjkEc2 pzUbDFioY2vrl8blMViuIhJx6hR1We86mF3BphEDeuCz0lAGvwCHKfXmbK2/a0T/GWExua FZoY1yKXJ++ri77M3GBo0y3v4licVes= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=NU5tNWt6; dmarc=none; spf=pass (imf24.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.49 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723216360; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SQb4P6KW7DwW15iPQt+xRBs0vTrFbvLGmJcOvQXiPP0=; b=1HHDTLWq/TZFqLJugE6v2raGBr68uGro2IFG5r/j8AKc0Sgu9/o7Tzx73YlEpTvitiwah6 10/jknjw0HgPtB/h1lyepOg++FepVBZvtx1MZx1VkUlSQVZPVSJuFnoACeW7UXr2oyXDZc +7ss9F+nJ7OI3qVp2V2OJaTEVnz1/5U= Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a7aa212c1c9so296540166b.2 for ; Fri, 09 Aug 2024 08:13:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1723216407; x=1723821207; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=SQb4P6KW7DwW15iPQt+xRBs0vTrFbvLGmJcOvQXiPP0=; b=NU5tNWt6B0zmId7CQaA9w4bsm8Y+LM2jMjnLqPTPM4Q5rRiQk4uQ5qglees/YplhHT zWAT+UK6rxTC10OCJq7bTZkh29IIjxjuCeKpeGmaZwWdj3E47+kARd98u3sE5krMwM15 /WDVTzZYqC0wqQpocJ0XEqPIx9y4dH0Sk220k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723216407; x=1723821207; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SQb4P6KW7DwW15iPQt+xRBs0vTrFbvLGmJcOvQXiPP0=; b=MHIzpBpizDaZaGKxGWXwcWJRyykr/B3gFTgrYIlBe2fyIQQBskgwFVKejA+yW+W4Tb 80J0MkgQzfHDQvAYxh1dIFWza44vTGOWm+XFkemRMAieV98aT8tsmyhYwiP/6LwSCehd DAWXkFkfgDWNicnGXeDaZCkk2uFNk6sLEVTR+eqdynuRf0UiW0zJwxFsnGP5tz6I7Ebp OTRwxq5MDqSALSEuZA9Y50OT2cgavqprEwXDjYzUTi0FuifS4HExYJIIFUGh4b7H2PxX C1r5LF5tq45cAJRWl6z+ujI9LL5UrSKknN+Ja6gqS15Kxlpjmlcx7Bo1vW06u6j65/Yb Ra3A== X-Forwarded-Encrypted: i=1; AJvYcCUNcaqMyDP92ixGnehJj+lA4nLHRSiMUk2Ye0XZEN58xGOGWUw9mvsYg2R/Bka1cIKgWOqs+kyprZ0D1UCoeqly3VE= X-Gm-Message-State: AOJu0YzcnIdWMmH1y2nAbftvM1fug5uAa1RrR5Zjx3Z5JCGe+5Ow17+A oTLacBUL2o+l5lVFJh0BJ19lQXy7gA3ppqPLNb0L6zEN+8b/E/eZZ/8sVkwTvtBmEMqfLIIrNG+ o5ncIrQ== X-Google-Smtp-Source: AGHT+IH2NOHEM0nNfgMacowjx+aZRue+BMHGwiQjtLKgDSQZYBSI8ZF5fY/P+7qN8EbgX8zXRn4AVw== X-Received: by 2002:a17:907:846:b0:a75:23bb:6087 with SMTP id a640c23a62f3a-a80aa5dbe00mr158180366b.29.1723216406659; Fri, 09 Aug 2024 08:13:26 -0700 (PDT) Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com. [209.85.218.53]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7dc9bc3bd7sm849024066b.34.2024.08.09.08.13.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Aug 2024 08:13:25 -0700 (PDT) Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a7aa212c1c9so296535266b.2 for ; Fri, 09 Aug 2024 08:13:25 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWheuTfe+/c5nCw3p/fOwBdZETg+8mwddW179uH3gdn1RuG7aiFOnJaCBaf6wP1KSmpUebYayyutKe+636QNzXCgfM= X-Received: by 2002:a17:907:7e92:b0:a7a:ab8a:391 with SMTP id a640c23a62f3a-a80aa65c854mr137777266b.45.1723216405166; Fri, 09 Aug 2024 08:13:25 -0700 (PDT) MIME-Version: 1.0 References: <036CD6AE-C560-4FC7-9B02-ADD08E380DC9@juniper.net> <875xs93glh.fsf@email.froward.int.ebiederm.org> In-Reply-To: <875xs93glh.fsf@email.froward.int.ebiederm.org> From: Linus Torvalds Date: Fri, 9 Aug 2024 08:13:09 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3] binfmt_elf: Dump smaller VMAs first in ELF cores To: "Eric W. Biederman" Cc: Brian Mak , Kees Cook , Alexander Viro , Christian Brauner , Jan Kara , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Oleg Nesterov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: B21DC18000C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: zcym5ha7xgk8xabern6m3xco6f3inh3h X-HE-Tag: 1723216408-491572 X-HE-Meta: U2FsdGVkX19PaL+sUWU0G7KS9V8CxPC97sYhSUyuEvCCoCSkSpZUXm1GtwpEMWNf5ySirPMuU7XhZrAm0mjVjAofAU8ONxyWQyNnKFX780lVsEuU06xyGOqOGc/RcvA9RrX4wpmbMvZUyvphxEdVfjVv6QwoOQnJh1sculFNMtrepzCvr5jvmPUWD8gpfN2+mdCxNW1+zCa8lxW9hPhTuh+dGrrKba0m3jAmpTboxs4OnXLYUi/M3oRnaXJI6Avs59zV6F1gXB2umzNtCzsc1q7F9fzTBDR5vwP+E94bLumDzME2YLl45842D0orAiwMaJ0gj0xsgzKOMCs/MJUNEa/1JJV3apYbz06m2zt4Ur3o/nwIgL9T0nWwkxd0487F4rS6H5bDWLHTDE9hs1TjrDHMEy95PnSUFheavGKXNPwJf/FJjYHUb9gvQLwQaIFiDa2C1RR49tNx9AXbFasFQ7WM16bcTR73kETOR5ixuN3O5g1l/pjIYHohwqR6rPJ1n20gbRI/nYU723aXLPP5N+CP4AZjJj9JZ6bF6F8C8/DIFgjZo8THlvsQylvBvOJSdIaG2aSp52UMbJkV+q3ZBVsBfogz7P7dDSvbqBx/T+UN71tXwu5yG+Mj5Y5sT30U56QiP07Y1QOkj1tP8RyXg4IPDnsK35+HeNq+7jlMbf3NcqCrbiZzi/4UzJF/R1K9lVG8Lf5s1IZFDo3waYk9O6HzTJWSp4UHDoQhUNMurdIhX/97BDOpoXJt0k+nSOMEKyJAJtDgp0WUUW1iJm/lM6IZ5taIdkoGLfxRfX7OnfFvDB2k3y19ts9LqJyQRCNn8eoij6HkRPym2SKGruNoWwIbZGX/hQoSymmynKMuofumbUlgbcR3/SIRs0h1KWhaWFpnYYRo3t73EnATFj8TjO90SFoLcumDzOfTlmmsEIQH7bsafKnbpyRc2uapha9cptnp1NI/OJzuh44NJdX pPBm6sWa voFFmeB+d9lJHKOcgpfd8D6HxBlRH+MHqq9TrfKNj4qQeHt7mmA0HpY4Lwcx2hvwCTio5lFZfuG68fyaHt6670I+wfzLRWFt2Y1Nh6ycRLlWEmJ39foGvz/A6uFrq0nv1bJUEr3LwbIcFH1fL0UFD/3SYFUMAyWMZtcW/6lRpGefr67K+H7weEaJ9NAwk08GAJbqzvPj0KxBCuQzgf8qTVDEnsn7x3jS/sPfdrzyL3OfRtam3H8COcE+IyOz+rRSxwZ86NpykmunyK20oa/xsEY994ByVJ3qUBLRmgo9zfO5/jktmEY1X0gi2dNxK1ybgEDCRojXWr+uo2iyKZwKHH2IMttX5EVlEFyNh71jnWIi0U1nr8mDo3ACJ9swMiPz5coXNHMhpKYmaxxbpsSSQMuQz5ALfTK9ruiP7GVOSH+8pnPu7DbtsIaDYOCyYLrMT74uqm8Bn8RECw4F9w3bT80tOtFII/HGSqaGgMwtK+4lSAGNiRis1Ar9dG1rY1C4RR8HHWDrkTsYKoFyH8UFQj9XHtCEBw6ggFeEdXUIcKYL1X6DK4A6kyX+C1x8OSbP30pfmpLtPLHvwKeSD2ApnHig+ombZ7JjLp14eL6MBGHp0OCspkT9Ev/NuCXds3Z16iM0c X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 9 Aug 2024 at 07:40, Eric W. Biederman wrote: > > I asked him to perform this at snapshot time. Plus it is obvious at > snapshot time that you can change the allocated array, while it is > not so obvious in the ->core_dump methods. Fair enough. The days when we supported a.out dumps are obviously long long gone, and aren't coming back. So I am not adamant that it has to be done in the dumper, and I probably just have that historical "we have multiple different dumpers with different rules" mindset that isn't really relevant any more. > I would argue that the long term maintainable thing to do is to > merge elf_core_dump and elf_fdpic_core_dump and put all of the code > in fs/coredump.c I wouldn't object. It's not like there's any foreseeable new core dump format that we'd expect, and the indirection makes the code flow harder to follow. Not that most people look at this code a lot. Linus