From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BC14C433EF for ; Wed, 25 May 2022 18:30:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C7EE68D0003; Wed, 25 May 2022 14:30:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE0978D0001; Wed, 25 May 2022 14:30:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA71A8D0003; Wed, 25 May 2022 14:30:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 973948D0001 for ; Wed, 25 May 2022 14:30:06 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6469E34F32 for ; Wed, 25 May 2022 18:30:06 +0000 (UTC) X-FDA: 79505104812.09.E6795B7 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf28.hostedemail.com (Postfix) with ESMTP id 215DEC001C for ; Wed, 25 May 2022 18:29:32 +0000 (UTC) Received: by mail-ej1-f41.google.com with SMTP id gi33so34851059ejc.3 for ; Wed, 25 May 2022 11:30:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DUPOWrnWYG2slQmT/3VeC1AcGFORkCFgaKQE4X/RHDA=; b=R6aB8fP9pXh4hwqOoBWTR2Xa0tql8u9D5G1OIwlU3BtL9xkcnR8mFdbDe1RUN8UGDB M8UZIi8F34PJnXVcdavCnLyCXg/7VaJk9hcDFEZi5+scJUn/33F/UiOadDpaBFNwoesD SjxHJejls7YoLiENznvp/43y/U1FCYBx+Ik/Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DUPOWrnWYG2slQmT/3VeC1AcGFORkCFgaKQE4X/RHDA=; b=oQoMyWOWttsgm5GlJE3NaFNvjQB5PxcTDzfO3ezM2nz03EBwzO8sqWu1MeXXgKO8kJ dAfOz4uMDlY0TstJn/E8mRp+m98fr3LbyHBkFcc7I2tQ/NtJr5do7uxQRPvEk2+XUWuy igF5k5TzndYSkp/9BQ8Xc8vKyaKyo0ge0NFCOM+AV+sMDQYXOPai5w8aKZcYxIe6adlX XKZ2/fQYuTBBb/tt4/SSNh4wdJu2rOzkYUT4jciCJj86SvtasvDOHhKj7MUdcAdqheZ9 qTwj/ejinra7ASZFHwfykLEjizTQyCetUe9+AhcAUwqI3rdRVDJ28WWxIs5bi2OExWW/ blmg== X-Gm-Message-State: AOAM532ls+sKCCpI4YfEVMbNAeuh0YwRyUxP9c1TdQmBVjBOWvyw8yjf jv1uy+Ddvv/8wMJU4tqyg7vtvtBo2L5UpKMSOEw= X-Google-Smtp-Source: ABdhPJz3yYE07a30NSPFuMNaOpcbLwHKC6jv7LtIVP+efwi0KkM6Ymlqd7wTxPSU5HlYwit52r7Nwg== X-Received: by 2002:a17:907:6e86:b0:6ff:1770:b8da with SMTP id sh6-20020a1709076e8600b006ff1770b8damr2740332ejc.376.1653503404215; Wed, 25 May 2022 11:30:04 -0700 (PDT) Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com. [209.85.221.43]) by smtp.gmail.com with ESMTPSA id a24-20020a509b58000000b0042bd2875f86sm276193edj.7.2022.05.25.11.30.01 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 May 2022 11:30:01 -0700 (PDT) Received: by mail-wr1-f43.google.com with SMTP id e28so30644870wra.10 for ; Wed, 25 May 2022 11:30:01 -0700 (PDT) X-Received: by 2002:a5d:59ac:0:b0:20e:6fd6:88c1 with SMTP id p12-20020a5d59ac000000b0020e6fd688c1mr25884560wrr.442.1653503401048; Wed, 25 May 2022 11:30:01 -0700 (PDT) MIME-Version: 1.0 References: <8062f61e-5a4d-00a5-be1a-7921d3277e9d@suse.cz> In-Reply-To: <8062f61e-5a4d-00a5-be1a-7921d3277e9d@suse.cz> From: Linus Torvalds Date: Wed, 25 May 2022 11:29:45 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] slab for 5.19 To: Vlastimil Babka Cc: David Rientjes , Joonsoo Kim , Christoph Lameter , Pekka Enberg , Andrew Morton , "linux-mm@kvack.org" , LKML , patches@lists.linux.dev, Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 215DEC001C X-Stat-Signature: gsttye9xqytfj36f9krb9aty3f6jytog X-Rspam-User: Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=R6aB8fP9; spf=pass (imf28.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.41 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-HE-Tag: 1653503372-616983 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 23, 2022 at 2:54 AM Vlastimil Babka wrote: > > The stackdepot conversion was already attempted last year but > reverted by ae14c63a9f20. The memory overhead (while not actually > enabled on boot) has been meanwhile solved by making the large > stackdepot allocation dynamic. Why do I still see +config STACK_HASH_ORDER + int "stack depot hash size (12 => 4KB, 20 => 1024KB)" + range 12 20 + default 20 there then? All that seems to have happened is that it's not a static allocation any more, but it's still a big allocation very early at boot by default. The people who complained about this last time were on m68k machines iirc, and 1MB there is not insignificant. It's not at all clear to me why that allocation should be that kind of fixed number, and if it's a fixed number, why it should be the maximum one by default. That seems entirely broken. I've pulled this, but considering that it got reverted once, I'm really fed up with this kind of thing. This needs to be fixed. Because I'm _this_ close to just reverting it again, and saying "No, you tried this crap already, didn't learn from the last time, and then did the same thing all over again just in a different guise". Linus