From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27872C6FA8E for ; Fri, 24 Feb 2023 19:06:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 842916B0071; Fri, 24 Feb 2023 14:06:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CBA56B0073; Fri, 24 Feb 2023 14:06:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 645C06B0074; Fri, 24 Feb 2023 14:06:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4E7976B0071 for ; Fri, 24 Feb 2023 14:06:03 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 230A2C0176 for ; Fri, 24 Feb 2023 19:06:03 +0000 (UTC) X-FDA: 80503115406.21.2C793F9 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by imf05.hostedemail.com (Postfix) with ESMTP id 329DE100020 for ; Fri, 24 Feb 2023 19:06:00 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=QgJzE1UX; spf=pass (imf05.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.41 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677265561; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gOnW98lyJGpYbD3eJjqqzz7gc3Ub1QIGFkaXHUv4Ygw=; b=w4A++SjltpIWBLVK3U5rPt5QzKV6BHvdQqg4ko4CthM0AWe+TI0cBuMBUS2ou/akRDwCyJ feswiSIUyLO7mpOR2vTaFjZ2tvZohMe4VpzlZB7OBMtnDNHJGSwUOuy7r1DthiSUdEFKZI rFxgZpadA25mC5gj+C8qhtzQwvjUVrM= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=QgJzE1UX; spf=pass (imf05.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.41 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677265561; a=rsa-sha256; cv=none; b=Trtf0LPEOs2quMsCy0UEWrs2jQyXhU+hJQvZCGuCkjl//j+HQmA2V0gV3P0/RZOVrN2+27 QNnhMJWmX9sZcI0TNq1gpE0xe8KHpI9sOK42DhPFrFN2Fh7uXwMPfVbI6WAN5kKxN+Nfwt AfPB/LXJBKCZcQ4bIUvujUKhVjNzaKY= Received: by mail-ed1-f41.google.com with SMTP id h16so1114556edz.10 for ; Fri, 24 Feb 2023 11:06:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=gOnW98lyJGpYbD3eJjqqzz7gc3Ub1QIGFkaXHUv4Ygw=; b=QgJzE1UXmKimaRQyvLPX5eOzT51cg/7f32m8GMjg3xQqoxdyxololhdOn94vv4mfJZ mNXn+/IMq2NgXpZq0dV9JUbm82Tv+OpUNyfJDu6dpCaBqQQlbZTu21GCYsC9+zVH0n42 DBThtYurcSf7Bo98gVQ42RJLZrWoPKpK6t+u4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gOnW98lyJGpYbD3eJjqqzz7gc3Ub1QIGFkaXHUv4Ygw=; b=suz3mRCYe3xgBJ62jPF7YUnpr42+/yf/xsWGA6vRmASvPeGRa/VflLflPtTjtE0D1B /+zgA7JCKcFRb6uT9t3j2/F39H6OWXrNHZDUZdZq3ECPkbGlqVAImFm0oSVgxs4M7Z1M 6uEcCgj2H/qWsNMlRquGzNwH2EqmyHCnicCfQMFuEnlESb0iv9Lp2psMExwEHOhfu8PP In8xm+5Hf/CKoM4iAu/8fdcaNaPM8ElRyZxQEPUyChKz830HTIqrBzXT+SJ0+bQmqW7/ MAPTo46ApD2X2bdLoQxCWcWdJM9B1P1ieK7KLma+y0KErXu4dsjXQ7dL63KoYxMOLJEa f3yg== X-Gm-Message-State: AO0yUKUSO5jsNf50jDIGKNsQg3MOTdqhMxolnyq7qsKd5RYjJVmoD1Rm ieO30c/D+zODk4HUZJE/o++Hgk/Jhe1vkw1syMq2Lw== X-Google-Smtp-Source: AK7set+IV+wpI7SdHNGVf4N1JOqxhx13LRD0Jq79+lok1YxIMVf3hXwGoyDAhI6n6zKzSx8nTEyVVA== X-Received: by 2002:a05:6402:8c6:b0:4ac:be53:178e with SMTP id d6-20020a05640208c600b004acbe53178emr16068490edz.6.1677265559839; Fri, 24 Feb 2023 11:05:59 -0800 (PST) Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com. [209.85.208.49]) by smtp.gmail.com with ESMTPSA id u30-20020a50951e000000b004af6a7cf249sm31316eda.61.2023.02.24.11.05.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Feb 2023 11:05:59 -0800 (PST) Received: by mail-ed1-f49.google.com with SMTP id o12so1130416edb.9 for ; Fri, 24 Feb 2023 11:05:59 -0800 (PST) X-Received: by 2002:a50:baa7:0:b0:4ae:e5f1:7c50 with SMTP id x36-20020a50baa7000000b004aee5f17c50mr7747187ede.5.1677265559017; Fri, 24 Feb 2023 11:05:59 -0800 (PST) MIME-Version: 1.0 References: <2009825.1677229488@warthog.procyon.org.uk> <20230220135225.91b0f28344c01d5306c31230@linux-foundation.org> <2134430.1677240738@warthog.procyon.org.uk> <2213409.1677249075@warthog.procyon.org.uk> <2385284.1677259167@warthog.procyon.org.uk> In-Reply-To: From: Linus Torvalds Date: Fri, 24 Feb 2023 11:05:42 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC][PATCH] cifs: Fix cifs_writepages_region() To: David Howells Cc: Steve French , Vishal Moola , Andrew Morton , Jan Kara , Paulo Alcantara , Matthew Wilcox , Huang Ying , Baolin Wang , Xin Hao , linux-mm@kvack.org, mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 329DE100020 X-Stat-Signature: 8h3dbsn3mxdehq1td1g3hqex7nkkfpir X-Rspam-User: X-HE-Tag: 1677265560-92464 X-HE-Meta: U2FsdGVkX1+oTmhncVVtsNq0y68z0x8UXV2QSBW7p8doUHEJuAui2M84FPsVa8WgQ2S/n72AKJiDyml0rqO6C67V29BAUj2P36TukiqmnfvJUON2FRcB2AHQkG3ng9M069R9KqW7hnlktcodpLufbmXxgym6McU2hno/LsiK5mSGV9Ef1Zqga7bi995JC4FOG5z8/lkYly6f8uciXkDgJ9MPnxEQKZaGDbrlldXrr+d5Te2sJ7KTaZ4GM/ZP+WvRuQ0WRLQHzUojBeZ1MixLBZU8s5bZKTs/bM1Cu88L/r6zL4P+ko5aHYo1MNaQZ3Sf7LQMN4rKa2SFRxh7GFsvhv0rdkhUmhmcBPAwfwowhbqI6PGAuYanvG9YMHz7V6F5zw5K56/4gBxjgKiYL8kL2/Cdeb2nrLS6UfY+OkQ3mMLc3GWVxszfY/BPPhsA+o9/kjfEbUP+Fm8UFRixKmegD3BakU6SnTzloHwE4nL75R981FBvXeNNmSrDSudC8JVfK5fiXmI1oMRBdEP7W0lPLUUcGP3Q9QgOgZh/yOiz/yooR+raiXBfqEq3Ur8o5JtUdodWOjnQFrcSpGhBjYN1x6QSbHeLhocBTjf33KIYLzlx7aEs9vNjlZs/fDJ21sOCTeXxz2aRA3RuyUNX7Lrv5EfI5PMAZtl2TejkyiW7zDRouF2Ix0rxUnVhFdveLf5EqnP1i8oCkJFZ8V3bPu6cgTgekAwzTzP1bf/eH4JsVbdG2TFZD+HwCowEvistBMe3gt9PrN3/sdPbV+/Tn60+GnxT79sibAMas865j3vrj+5S4u7+c3YaveuX7fmGkC535LvUznKj53T3GnZAlfXkk9D4JMTFgtqLwL5x17Gp7JmjDjOt4zcg5KwiWArxjfJQIN6kC3vDmRZvTcCy33F8LmW9wecD9eAnT2+qaxDYfqqOMDzyQhMzzh9indkdq4LS5CyUiTmUek65MA1lSD1 /ZlL/zpo sHBSkhoL9utybeFOp89FvSuk22q6SiKnuocMV/CLgA6UhaWU+vEz0vBueZdk7ByPFCdpaVStfLdcMBGS2gLPjiLdBWTXkU0ZrmoGpwQniiUyhDakUENXHilaxUZLBXevaihj3/E9c8ZPEK3HyPVCM4Qr2o20PfltJK92ANcUle7wx/Fwgx6v7yzCYxKbCD5uOLdlikZAGTBglc4a0mt5SO0p21YTRu3XgF5lXYmW4Q4qIdzZU8B3FInq4z3QsCVI85iNLiFmLW5aTxnVzdKDrB/G6l0N4v+xFsyYjs5SOddwoEtLC2k5FWkzuJZdUIXqX2dI7/x/ec1EwR/DgF0+2ie8vbM7rD8cgcuLzcOvF871KX+KE9kqwKO8HBodKc0zLmtJQf2uJsBuvyIl6TD+zEBguX5WHYI7rDMrVdbD6qBX+A+tcSIdbYU3dyhE9Jf1r3kVlm6yMqMpc+BuedKYMXRNcMFswZdkhsNlHqT/mnodXSE6hVmYDdzM7W+cgFhj/CUN8pE6/NzHpy285qf2lCUf4g9oCYnSR4QLpaE96iexVycDfNvucblooBg/Ukrr3ykdZea8v5yG/Isnr+CQZtPUPCr48sK1Y9H7At7RiiMWyILf6pEUePKJg8w+4WRNJU/KVsB/k7e+UhDAqbEkRAJAgs/70UzAPGCD7eacW/pha9jzahuHSmbn2Z4JFKEvshcz0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 24, 2023 at 10:58 AM Linus Torvalds wrote: > > I'll apply that minimal fix for now - I think the right thing to do is > your bigger patch, but that needs more thinking (or at least splitting > up). Minimal fix applied - that way I can drop this for now, and we can discuss the whole "maybe we can just use write_cache_pages()" instead. Because that _would_ be lovely, even if it's possible that the generic helper might need some extra love to work better for cifs/afs. Linus