From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 416E0C3DA4A for ; Tue, 20 Aug 2024 01:11:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77ED26B007B; Mon, 19 Aug 2024 21:11:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 72EE26B0083; Mon, 19 Aug 2024 21:11:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F5EE6B0085; Mon, 19 Aug 2024 21:11:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 412FD6B007B for ; Mon, 19 Aug 2024 21:11:47 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AE1441C4242 for ; Tue, 20 Aug 2024 01:11:46 +0000 (UTC) X-FDA: 82470846612.24.3BF783F Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf15.hostedemail.com (Postfix) with ESMTP id 730FDA000D for ; Tue, 20 Aug 2024 01:11:44 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=AQDDHbrd; spf=pass (imf15.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.47 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724116266; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J5Wu1obaVVIh98VUfFJoSH8iTiA4TVMtHy8zZl6wgS4=; b=lj0llbKqqIqqpydIBj7DbUzf1i6L6NrYZj207DYVt1jIJXx3ZdzEjfvivAHOBLd3/RAlu+ +ra3XUIojDGIH3F70DUWqq8aFVtprQnxVBgT8avVdYiXPJ70og7en5X8mXnzk4yCcSZ9Oy 9Ddad7yCvnJHH36bIE1dJEz/6VNo3CA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=AQDDHbrd; spf=pass (imf15.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.47 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724116266; a=rsa-sha256; cv=none; b=D0mS7kuuJzcH1dpDQtoWY7GaINDM3RYMucrnjKrQFLkwHz5Yoqpl1Vv2qrUqT17MERC8gA JkITQ5yErKf5BMatx4TQ96uPUOcNeHZlE1MctyD4ghujgu7nAWMGIzQBcu1eXKPMMzYawq 8gnL0sYMuD9B/dAVahj4bVv28NZY0hU= Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5befe420fc2so1955258a12.3 for ; Mon, 19 Aug 2024 18:11:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1724116303; x=1724721103; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=J5Wu1obaVVIh98VUfFJoSH8iTiA4TVMtHy8zZl6wgS4=; b=AQDDHbrddERVnw+60Eu1sKlEy4vWzarLxU+UOEA5OrMgTBXiWHwxE/Up5WBPBbFJTb XKa0FqmSCJl/VdVDpGqum2Hf/MUfQ57zdQ/rDqvPIzbFbkd9KCCSmY0KPsBzENMht6b+ yKmuBl8U0wlq2q2daExJLfODaM1iv1a7OuLho= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724116303; x=1724721103; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=J5Wu1obaVVIh98VUfFJoSH8iTiA4TVMtHy8zZl6wgS4=; b=TMzl5+ei8sT6aZs25Dx8KhePAQOqyFyIxqZ6kkSWfLs07g76n8Y76NiAH+paJewfct BUEiiwpFCm7wIuvr/vCA/FaFLpDQkKaI+l3zAk89Bgs+VxTlK3yu9L9kIaOdmlW9Tp8V OiLB518cVo8Lfg+mM/lISE7oVmEjlqDguBBFg+dlV/uoXbTMiXCIMoyX/ircVcd/0osl H5Ip/UUFgZldwnmyXsUrQUU9xsqijE5GmJAVP8WO7wDTBCEMilPynv6O+ePiaR0EK0IU BQNq2mjK/brQBDlinKqHAhW8fIwiuZKyWXJUIWCGmsLNH0JjUacebzytlrZsypfbOVFB aEuQ== X-Forwarded-Encrypted: i=1; AJvYcCXtTdhrGr8i+2EcEibMGVx69GiPd2lDaw3YyNXm3LOGsB/xk6ql8Yh7ZtOernzFBC4xLM309WYOkC+ibeHYEKDIQ10= X-Gm-Message-State: AOJu0Yz1ubBx515P0rGxan3eimfHQ/RHKsUlbxOnQwF01pJIJrsXYRoN LyTm43CrbkDBwy5eqtIwS83D1Egyk1IjIF/YhJP777RZ++uvcs/9D5VyUL3tZHncZiYWxP+FwCV bpo0lMQ== X-Google-Smtp-Source: AGHT+IFKx7dNiq6HST06sUb+nksjv3/FqYNTJEV+t0kluuglTlT2sxn7bRpA1A2BhpIaqG0kzI0t6Q== X-Received: by 2002:a05:6402:34c7:b0:5a1:369b:bb61 with SMTP id 4fb4d7f45d1cf-5bf0d2cf10cmr450281a12.36.1724116302369; Mon, 19 Aug 2024 18:11:42 -0700 (PDT) Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com. [209.85.208.46]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5bebbde3849sm6050658a12.21.2024.08.19.18.11.41 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Aug 2024 18:11:42 -0700 (PDT) Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5bef295a429so2300653a12.2 for ; Mon, 19 Aug 2024 18:11:41 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCX79cA8c+WWElYIjU4A+DkpsyJkJZIrkK3bPLC/pBYI+1c8crXe6BPMgpqPj5utJ15zy6Z9z3XcITOBQZenFZRsmdI= X-Received: by 2002:a05:6402:1d50:b0:5b8:f69b:65e8 with SMTP id 4fb4d7f45d1cf-5bf0cfbca19mr536978a12.0.1724116301657; Mon, 19 Aug 2024 18:11:41 -0700 (PDT) MIME-Version: 1.0 References: <20240812082605.743814-1-mpe@ellerman.id.au> <20240819185253.GA2333884@thelio-3990X> <20240819195120.GA1113263@thelio-3990X> <20240819180548.9f5dac3ac0bd09a26c0d0948@linux-foundation.org> In-Reply-To: <20240819180548.9f5dac3ac0bd09a26c0d0948@linux-foundation.org> From: Linus Torvalds Date: Mon, 19 Aug 2024 18:11:24 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/4] mm: Add optional close() to struct vm_special_mapping To: Andrew Morton Cc: Nathan Chancellor , Guo Ren , Brian Cain , Dinh Nguyen , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Richard Weinberger , Anton Ivanov , Johannes Berg , Michael Ellerman , linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, christophe.leroy@csgroup.eu, jeffxu@google.com, Liam.Howlett@oracle.com, linux-kernel@vger.kernel.org, npiggin@gmail.com, oliver.sang@intel.com, pedro.falcato@gmail.com, linux-um@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon , Linux-sh list Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 730FDA000D X-Stat-Signature: 5y9uj8b6bse5jznapxxb53f5cnfen1cp X-HE-Tag: 1724116304-786920 X-HE-Meta: U2FsdGVkX19dA2UpCsvTfFJz6qRJezIjIjEiGyb43K01+wodF+Cr8FWzxOKou0Q19jj8ao9w/KxpebjvOffOSoMN5Yv+jdQod8zY4GyW1FIpEBW7Nfj2eQ8gHhFGvl+lLqOQYhQ7jraf9RcXW1jEdWyeqy9kfEtGnVUIfTkDka8MKB8/SmHhv7qfTmM89U1ybZphRK4AV8YjF6nWebe+Lr0l2XWSbx4tfoITB9pIqVXK2aCaCS9yciwXNic4bNkqBGRB8PcvtCl7GnR3cOF8AaK2YrkNHN8kcUkkPtdjVuPCOJ8RPjVu1qfJ5frA4cLohCzTGMUfOUmF2pp8xDvNr37XwmBcmyWSEtO7JgaeeMy4xV3joU8fGbQNLazu3L83mDIqpmv9e7adG6wQoBW1r01ttiYBf1FauUTKnaoAR6WIuWbozFTzyCC46sSZdh9Fjd37nby7sT4f3qrOP4wWEwIYOs96+j2/aaIOCB9OwknKMe74IaGjP4cvvqsIn0IMuRrWCK9PZBX0GJYjTb3WZR6vgWM/cAoLjX1+G5QtfDXhXmiaL3t6VEVUgB1ZKZpOj5862j4XpPMG+0As2Wz27Y/KWulqgECV+F1Ap70AJpPkpT3fni1NaeBBfJT7xBXOKFSHe9peiTwS2p1hzWC0sGzxR0AJfPJXAaq33z1Bar5qNKpLAatBSQTIyy9DDIvOyoS92B/Tjawa54OdbQux06XyX73RTbO10kpHnZbqjEYDdUPTSx2JvO/tqYzizm9rngpiruZrAxNvf1p0ohXQfRAYCGloC4Bjm9M6UlijilmOL4A0VA2hkMbPbu6WQJcXXzNfjlu/2l8/zAFGd/JgihFhmiMBItDWoDByTENIIbWDcICiyxVOGNdtT/sy9wPLGcav+0uuikPD4Ua5zwxYwFgNzSKcRq4VFdG8SAylPhGfuhboM7snl9/IZiEyiuYNYvcsxnpmEeLROgCSYUz LIxE93gt FETNlb7rmC0g4KIDRVz5iJIhDYZQIRh5A1XzPIgH317H/Jxw3+hffeXZTKVCS9r/2+ydZ/u21S4ai94OGJyNXOsbWIZO+kMay5tvOytbxT2dCcD8pflGhgPdHNzyGxPvS0nda3VYEzoU/avFK9sdCx1/0SOwNu2UX7JvrP5g6n2D8743GgtxMK+b/aRptHE6RdbmxnkDU+oaKg5QuYwPqAF24EYEftOrefbGPNLv/gstjey1xJf3iCIxs8+Uvlq4zGJDfze0QHById763lh4J+GkH1kpZP1tXvodgk3+SpbRmTQVcrcnLxVC8pQtHQ0lLhujX4zr/+yEamxO8N1iWVMPHunziVqedx7Pewq8EH5sZ1qiTHxvLL6IkbRrf4TNk2Yk/qXwDAoNlaWlxH5qapUGRrfJUMGYa/Z/JFc4TlGujRqvYJdndg8MsXU5oFNxPdKUPrNN2sSlQBGkc+nERqhPuKY9ekfE4RSYQOBy0qxzzSKwUnk6bnsCL8tZAYPZ1R5VtD74uWY+ziuje7JLbXjv70ZYEXnQHebFKoYNFUeDSEDkEJRb9+Vwke3dUTm6LctLDGZDd6qUkW8J2kpcnsfWdxi01zD7WNUAft8PWAds/tkUrIWLM3CGQBg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 19 Aug 2024 at 18:05, Andrew Morton wrote: > > > > > I forgot to actually attach that "this". Here it is. For real, this time. > > Thanks. Do you think your one-liner remains desirable with this fix in > place? That patch actually removes the whole 'legacy_special_mapping_vmops' that my one-liner then removed the '.close' field from, so no - my one-liner just becomes a non-issue. NOTE! That patch of mine *will* conflict with Michael's patch series, since my patch to remove legacy_special_mapping_vmops was done on top of my current -git tree. But it should be an obvious conflict, in that it just means that the addition of .close never happens. Linus