From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71FA0C47073 for ; Sun, 7 Jan 2024 18:42:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DEB286B0075; Sun, 7 Jan 2024 13:42:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D9B266B0078; Sun, 7 Jan 2024 13:42:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C89D26B0087; Sun, 7 Jan 2024 13:42:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BA8806B0075 for ; Sun, 7 Jan 2024 13:42:12 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8CF641C0B09 for ; Sun, 7 Jan 2024 18:42:12 +0000 (UTC) X-FDA: 81653384904.29.A2E24D3 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by imf07.hostedemail.com (Postfix) with ESMTP id 92D6B40009 for ; Sun, 7 Jan 2024 18:42:10 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=VnsSg+Zs; dmarc=none; spf=pass (imf07.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.46 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704652930; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s0prdEAj89MfCO6uINX9NF3GFv49wanD+YL5iJFREZs=; b=FAwfDEs+GPhXLct90n5+ltSOO4QmPq0IGQsJYr5aVf+bXz1WWTo/k5Y59hjMDwFxPPpDw6 qfxF1Zl52JBXls1fzYbutJhzjnVfnfz1FA8ZDC23NDhRlDmF6Hzdju3aJmYNUFIEkVhGqP sUaEUtEJWnyOivQDp32xdPrJqrRwv/o= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=VnsSg+Zs; dmarc=none; spf=pass (imf07.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.46 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704652930; a=rsa-sha256; cv=none; b=kKfUkfErgIa5RVzEhNbhqvetoM8Cr6q70LCmWnrj7IxvGLg240+i4cK0iJB5TEt7SSON8q iBFrymWzMbvRFPYxc+GZXFcLZ5PYL1JkHbNDjNocbD37htYOwEe3ZGxufUNpnAawwQHnEj ve75mgNxnKNN9MHxOSwEjYyaq6EgxV0= Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-50e7d6565b5so1118933e87.0 for ; Sun, 07 Jan 2024 10:42:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1704652928; x=1705257728; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=s0prdEAj89MfCO6uINX9NF3GFv49wanD+YL5iJFREZs=; b=VnsSg+ZsEAo8wPMD77Hbtk+HD2NnhDm//mrTHdzQ/eG/uwkOvI/uoBYBQUwj4vBif/ /v6fzh4v07vNWbMajXeThkfOtuVOqYMrCzWrWkpcZKiIJbldOgJ39H2tlVRwUL2JVmzy RbApl9jartYZhpkKTEPvdlyANvsafvHq+rumI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704652928; x=1705257728; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=s0prdEAj89MfCO6uINX9NF3GFv49wanD+YL5iJFREZs=; b=dEU+mE61IsWYX5ASFOm+/q5GiTtWJWtekbxnGpPmkJMEb9yetWZ0uMOH6lC2M7kFy8 nHTyISWwCtqPe08L9bWAyENYumTcjW20HxkM7sjiOcvaass5AurcTX6WsDWSFZ10zTU+ bLbhxzGke0WwWAnVQb98NDCiluOqT6GbwA1DTcaZs9jOOifC6ZxpiehtV9sH7cR2YF8m TLsFtxw+YBBAtQ2ukoxcx2LhU57XOfPw5N5DjTBKFeXJ+HKxYQC/OldaDxT+SzCkqXh8 0gI1ZvC3j0AQaYuq2FCSMZr7eas5GZ0Witlk0agAZ1NgcNX8lUw1KgGFfFXdLec/CJim I55w== X-Gm-Message-State: AOJu0YxJCjgwx/onaBgk6IrRuvfADzapkXzuRCoaWSIZJ2fi7q+2lA51 32OmLGNSSRQquVYciA1vhKyGdHrUPRugPerjPEezVTS0H9q5iimh X-Google-Smtp-Source: AGHT+IEuwydTdo/+r5NCoo9WhuxXTID74fI74VFWmACnOtSKzhWUUQ0DJXvirx2pTqiyOOHhMPfMXw== X-Received: by 2002:a19:760b:0:b0:50e:38ac:c3cc with SMTP id c11-20020a19760b000000b0050e38acc3ccmr879322lff.119.1704652928542; Sun, 07 Jan 2024 10:42:08 -0800 (PST) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com. [209.85.167.42]) by smtp.gmail.com with ESMTPSA id p8-20020a056512312800b0050e806e633fsm886990lfd.220.2024.01.07.10.42.07 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Jan 2024 10:42:08 -0800 (PST) Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-50ea8fbf261so1104125e87.2 for ; Sun, 07 Jan 2024 10:42:07 -0800 (PST) X-Received: by 2002:ac2:548b:0:b0:50e:7dca:7f93 with SMTP id t11-20020ac2548b000000b0050e7dca7f93mr823836lfk.77.1704652927542; Sun, 07 Jan 2024 10:42:07 -0800 (PST) MIME-Version: 1.0 References: <20240104185138.169307-1-jeffxu@chromium.org> <20240104185138.169307-3-jeffxu@chromium.org> In-Reply-To: <20240104185138.169307-3-jeffxu@chromium.org> From: Linus Torvalds Date: Sun, 7 Jan 2024 10:41:50 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH v4 2/4] mseal: add mseal syscall To: jeffxu@chromium.org Cc: akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, sroettger@google.com, willy@infradead.org, gregkh@linuxfoundation.org, usama.anjum@collabora.com, jeffxu@google.com, jorgelo@chromium.org, groeck@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, pedro.falcato@gmail.com, dave.hansen@intel.com, linux-hardening@vger.kernel.org, deraadt@openbsd.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 92D6B40009 X-Stat-Signature: gw31gha8bj1qznuta84791ww5as1how8 X-HE-Tag: 1704652930-303643 X-HE-Meta: U2FsdGVkX19Gqu8Mj7HrFsI3y+FALgd6ir2KF844qXVB5wA4s6bmKxccpgHgqkeaSU/dAprwofPauigFZFqMf7uvdeqku+ay4arn9KeJdMqrKVFkRK8EFudPCylfHS9hDRmxIghTHYAW2RVX9iB7hjRxFgCvQ8hg9/78FxZ2VE1xvFbZN4Tw14JaQSDO5HJ7n1n6IgB65kCgqncsNj1ecw/708fEFyiXONXERIeZyrXGunLod9AGcAtO8K/8l0FV1x2hHdYgZLrCSaJsKcXS2r+hwHPZrsU+n1JK9nJOE24NTE/GZdl//yQhyj3zYhWjr8NlnicUD9I4WVynGReLFparXhKcaL8k0+LqYOJrQXY3wr8Hv0YXdC3BWjUd8OrSDHjFSPntA7RLt8AfbgkUwnW21QQJruCUCivhpJe7ri/IIOkgsp1KqSZ+CrsgDRJjtWIbo/J/Wq5tnyF0oV9qIHCQC81z8RBumjnKhJB3nlPAh28vZk/PRk3T405Ys+BNHp/Lf8MimhgKFHiFtznnJnKrB6m60wBUNQJZ8jZHbaYuW9aFyoSJUl1oQ/L4AzedczZDifq4FXXWOfWl83vjSnZMm9hktFSpt8cb3ghyb3XFuyPNeDqfOh7HUJeTaxpPpWdPVfbjvRNMm/GJfRJX5a8u536ilYo8QiKbsYQE2RHsFz2DgWCydZO5R5Y3KfHEc5nNEs5WdruzbF3bVOiM+eT8uFktq4GHdfvJPUrM4KhMcMIjH9wyqOFz7lke7M41S3Dj8Nzq4iipITxi92DuZZnkE8Fqn+ytNXDdB7q17XQQPKxu00H202WsVwrrx6vucL3DGrRKik5eN1Lo9J/SVnEDtlcNNfAvvAAlHlZBn1hpzh+iEwU4GL5NF0iqe8TL1HGYRbKINeiy7X9xZ67VGOT7T5+W55Bk9Ve2MwBYqOFdGDPeo341fgDjsdci5fEk+t3kqKiZKFXpnkyHE02 J5eY5jsu ZCg2bpW7kiFfDBqDh48mjc6zbfaBj0MOnRluRaQBd41bIFDNy/KquGrUdkdoaiEucu1daEjaBfG1qsxM9hppPu6CQShJRdskdU1ZgZ5A1QLVUlQUmhb2mT9U0nuQcEwUHMzlVztxnCSP5Rlr5UnmgiF7jHCY6O6KiznPrNNt1bMK9cXd0MObM0Kq4kyzYu8lXqATq/V40IJHSnlMH9CjIdCGqKuqqASKtQiFb2wbWzxn3b14UJ3sJXB3z/nSkjztbBXm5dcZMjvBJpAfgyjaiMGQ3S7DI3Ff3qWZMl9UhPpsrn18pfMNXGO7UzirszVZVA/+zUG6rmSUkRvG7QKaNz4nLmLtMnyQQlclJQ6+irN2fDRN8v0jMeW9EEdzxCwC/1XyiHJsz7o082EvzFG2eu1EfiU2MoSS+kMGsZtEXHJ6/ljazqdru6NoyAKZE2IUDiMYs3GDOHOpDYMpAhU0MVpDUwKKz3ob2g4e0TOwUDi39NpGRMzDBlvK6eXb4i9xLLjPHD5DxGOF+wdh/0Eg5/UgJwCNb2CDK95Ho3YoKHYlt2rXo6Phv6ha0C8qM3B2zUsu85Yr0mCUATVPvHQslVaTn7ei0ODfthCCsSnDCi58PbprUbi0qBQjgXBDsD0N9OL/L X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: One comment: On Thu, 4 Jan 2024 at 10:51, wrote: > > diff --git a/kernel/sys_ni.c b/kernel/sys_ni.c > index 9a846439b36a..02280199069b 100644 > --- a/kernel/sys_ni.c > +++ b/kernel/sys_ni.c > @@ -193,6 +193,7 @@ COND_SYSCALL(migrate_pages); > COND_SYSCALL(move_pages); > COND_SYSCALL(set_mempolicy_home_node); > COND_SYSCALL(cachestat); > +COND_SYSCALL(mseal); > > COND_SYSCALL(perf_event_open); > COND_SYSCALL(accept4); Move this part to PATCH 1/1, so that it all builds cleanly. Other than that, this seems all reasonable to me now. Linus