From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C0D9C433ED for ; Thu, 6 May 2021 22:31:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E5F8C613B5 for ; Thu, 6 May 2021 22:31:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5F8C613B5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 416E86B0070; Thu, 6 May 2021 18:31:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A1816B0071; Thu, 6 May 2021 18:31:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CC606B0072; Thu, 6 May 2021 18:31:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0177.hostedemail.com [216.40.44.177]) by kanga.kvack.org (Postfix) with ESMTP id F16F46B0070 for ; Thu, 6 May 2021 18:31:05 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B3091180AD83E for ; Thu, 6 May 2021 22:31:05 +0000 (UTC) X-FDA: 78112252890.05.28F4093 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by imf30.hostedemail.com (Postfix) with ESMTP id 673A1E0011F4 for ; Thu, 6 May 2021 22:30:39 +0000 (UTC) Received: by mail-lj1-f178.google.com with SMTP id u20so9049164lja.13 for ; Thu, 06 May 2021 15:31:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=htNAnGunm2mFYSv2XzhlQsCDD0LeBwjAb0MYMtun6cM=; b=BORPcZuE9+rrQQNFUoJnt6f4FpTDIRpdNZeTdxMdbIECzBdY5oiwCD0JpZedlSNZ+7 bix+fDrgKkNKxnNlizSFTjxEzgqSzLtT6D02CJDWAGt9oBFGQ4VHrgxc6tYB6CmAeE2+ 8YQ9a8BVm4oo8k7TJnGL+6WsOCsGhg6VQJj04= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=htNAnGunm2mFYSv2XzhlQsCDD0LeBwjAb0MYMtun6cM=; b=Oek3ShD4ExIVScZHWcydNrHf20b+WTzHoE3iUsjAGLBwQKO0IpfArgjxY8ctAPoUXt zXMi2FKxq3aRg7XqPM4h/Y+tyEc83DfAKeFHd/SeIyCv7aP0hUsJPvVeypKgU3LXgUur nBwwjKG2nEwUXVnS4lGQ029DuDLTQ+/u40RibZypG40g/xFslaxym5L2mUmJpdI260et DEnTSwF74ry1I2r/kmqkUJuyKT3l1S05RS6Yk/9A1O/wVzWeXhJtsbxXUVeSho7TBOfI B4hBbVEV9TnID857MD9uwE8QH++f73wgHFSmrYrxbpcP+XRcrVRMpiL8sW07cGSwI6VC Sdaw== X-Gm-Message-State: AOAM530H26Tu0WrgARxDsApKI5ejb2kHhqaQD4rGx/rssBt+zW0a6Ros 61u+Whz470GNZ6qmQIYbkf6rFcSYYScsFjPy X-Google-Smtp-Source: ABdhPJys9SQZusOMibNigNPcbyLJ9lKUPKnGy54rpnhMYKb4Xiv34FTM6YN+CIBBqFqYBhZ+Bv7w4A== X-Received: by 2002:a2e:3a11:: with SMTP id h17mr5347276lja.363.1620340262949; Thu, 06 May 2021 15:31:02 -0700 (PDT) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com. [209.85.167.51]) by smtp.gmail.com with ESMTPSA id 134sm979977lff.165.2021.05.06.15.31.02 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 May 2021 15:31:02 -0700 (PDT) Received: by mail-lf1-f51.google.com with SMTP id i9so3480990lfe.13 for ; Thu, 06 May 2021 15:31:02 -0700 (PDT) X-Received: by 2002:a05:6512:1095:: with SMTP id j21mr4272160lfg.40.1620340261797; Thu, 06 May 2021 15:31:01 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Thu, 6 May 2021 15:30:45 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PULL] topic/iomem-mmap-vs-gup To: Daniel Vetter Cc: DRI Development , LKML , Linux-MM , Linux ARM , Linux Media Mailing List , linux-samsung-soc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=BORPcZuE; spf=pass (imf30.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.178 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 673A1E0011F4 X-Stat-Signature: wi5tp8c195h1hcwixkeuq6xc8gbdu8k7 Received-SPF: none (linuxfoundation.org>: No applicable sender policy available) receiver=imf30; identity=mailfrom; envelope-from=""; helo=mail-lj1-f178.google.com; client-ip=209.85.208.178 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620340239-971724 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: [ You had a really odd Reply-to on this one ] On Mon, May 3, 2021 at 12:15 PM Daniel Vetter wrote: > > Anyway here's a small pull for you to ponder, now that the big ones are > all through. Well, _now_ I'm all caught up. Knock wood. Anyway, time to look at it: > Follow-up to my pull from last merge window: kvm and vfio lost their > very unsafe use of follow_pfn, this appropriately marks up the very > last user for some userptr-as-buffer use-cases in media. There was > some resistance to outright removing it, maybe we can do this in a few > releases. Hmm. So this looks mostly ok to me, although I think the change to the nommu case is pretty ridiculous. On nommu, unsafe_follow_pfn() should just be a wrapper around follow_pfn(). There's no races when you can't remap anything. No? Do the two media cases even work on nommu? Finally - did you intend fo this to be a real pull request? Because the email read to me like "think about this and tell me what you think" rather than "please pull".. And I have now fulfilled that "think about and tell me" part ;) Linus