From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B223C3DA4A for ; Thu, 8 Aug 2024 23:33:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EDC9D6B0083; Thu, 8 Aug 2024 19:33:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E8D336B008A; Thu, 8 Aug 2024 19:33:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D54776B008C; Thu, 8 Aug 2024 19:33:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B770E6B0083 for ; Thu, 8 Aug 2024 19:33:30 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5B9EE1A03DA for ; Thu, 8 Aug 2024 23:33:30 +0000 (UTC) X-FDA: 82430682180.02.70F5812 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by imf30.hostedemail.com (Postfix) with ESMTP id 3A87C80013 for ; Thu, 8 Aug 2024 23:33:27 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=RZ94rBgX; dmarc=none; spf=pass (imf30.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.44 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723159960; a=rsa-sha256; cv=none; b=EidgzHTx+vKHiXm7Pg6vz47L3rFjYgUvtG+i28tu4H990qe0YQNvt/EZdErcvxCRbZN/ny HLgMivW8DILBF4FvyuUi4UIKzmPDAgJO3C3Pp4/2zer2sPmxgN0ehpJCvV9yMAGgxPy3eW JwXkwrmeuz6U3Wd4XkxIpJMcDC1ag18= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=RZ94rBgX; dmarc=none; spf=pass (imf30.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.44 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723159960; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rqlZbaQMZu+3GtlIS+SGt/2J89sdAOurpYSJPp/fzz4=; b=BtLT21ONAu87IJc00bTQnlUbrD5Z1yRa0NDFisQ7rcLKfQhgojYMYN/Mwcy/PTDfDBDjea J3bgA1w+flsQCU3A6cpWoLV5zozlhyCSK9m9KElBbwxXhCiiEHT3jrTLWHRmv0rtiwM922 E7tu0TayRe0TdR4UtP42AdkV31Xyhjw= Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-530e2548dfdso1560579e87.1 for ; Thu, 08 Aug 2024 16:33:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1723160006; x=1723764806; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=rqlZbaQMZu+3GtlIS+SGt/2J89sdAOurpYSJPp/fzz4=; b=RZ94rBgXw7XWpCrkfWkAWBg08nPQjGUG8TUunq/hznbxrRecprxrymwB/Zk5yf2T73 DrovvoBYoocUAYQQ3zpCginREp51djISGC5QP48qUusKYFWjwl9UImnJvqdUCdgB6+ys Sqg9DTE1PImxGkyYlJV57F38mYKnnvVpNl1ZY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723160006; x=1723764806; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rqlZbaQMZu+3GtlIS+SGt/2J89sdAOurpYSJPp/fzz4=; b=ODP+ZcOqNi22B/uk7Y/6JXaGUSd6y7BIBehIqalNvnxjQ8s7PqMLpJU/O8+a9RMkGo 0D5CUl0cH8tdVVMUhZJw1kw6Uc48Y6fKuGgOFCYN+UEQZxCMqJvbJ+1r0kyXgTIP2xba 5sQ1ctFTIBsuW7SLnCFv9ZKPlVNyvh5D4eiJFLpF1VuLz3/8RWXExEVG56hgfONeFNS9 Ny/obX+Alq7TRH+hZ2J021T78IlcjZ+VkJgSxvKOfIPt6sQKyuzcrPFb9eS70FC+Bqgt MEEpBKobq6Kfl+vEYpaf2ywxuT49Aqx8OW4i2VVx+bbibiLWYdFSz6ASy4p4P8q5kTJV B5PQ== X-Forwarded-Encrypted: i=1; AJvYcCWKR/V3x4l53WhpSqOb4gr0v5I33Mbiam2n2gAY+xcg9xgdusG5qTBFUnyZ5cm2tTV1QJkyAoZsMQ==@kvack.org X-Gm-Message-State: AOJu0YzRASMDFQDN6kcJrkuQmeO08Hfbn81elHV+hfIbRXUopzg8/G8k m6Fsyt1wzHVd4jjhDwepBeEUVQm+yVM0SvDb7AIlM9E2Ac20c7fqMvyR0XWT8jgXusOIUMEPRw+ exT5euA== X-Google-Smtp-Source: AGHT+IGl9gZYCgxYc5vfXUiUyymtAurhhhyvEHdADOpw8l6lGjafs2pk4W78XnrEdWUcP2N7sggJtw== X-Received: by 2002:a05:6512:230b:b0:52e:fc01:ddfa with SMTP id 2adb3069b0e04-530e585b980mr2156519e87.7.1723160005886; Thu, 08 Aug 2024 16:33:25 -0700 (PDT) Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com. [209.85.208.46]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7dc9bcad8asm785860866b.41.2024.08.08.16.33.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Aug 2024 16:33:24 -0700 (PDT) Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5a10bb7bcd0so1887036a12.3 for ; Thu, 08 Aug 2024 16:33:24 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXJ1Wd15+0PmI1ZL5Z8lHr0Do3jEwpF8jxPcBGCylhJml6d8iDxuGZETrPpsJJH1EyOiAuRzyeDyA==@kvack.org X-Received: by 2002:a17:906:bc02:b0:a77:db36:1ccf with SMTP id a640c23a62f3a-a8090e40894mr247283366b.42.1723160003998; Thu, 08 Aug 2024 16:33:23 -0700 (PDT) MIME-Version: 1.0 References: <20240731095022.970699670@linuxfoundation.org> <718b8afe-222f-4b3a-96d3-93af0e4ceff1@roeck-us.net> <53b2e1f2-4291-48e5-a668-7cf57d900ecd@suse.cz> <87le194kuq.ffs@tglx> <90e02d99-37a2-437e-ad42-44b80c4e94f6@suse.cz> <87frrh44mf.ffs@tglx> <76c643ee-17d6-463b-8ee1-4e30b0133671@roeck-us.net> <87plqjz6aa.ffs@tglx> <87a5hnyox6.ffs@tglx> <8734nezz0g.ffs@tglx> <37f94771-4ebc-46d2-ad10-f145d139dd9d@bell.net> In-Reply-To: <37f94771-4ebc-46d2-ad10-f145d139dd9d@bell.net> From: Linus Torvalds Date: Thu, 8 Aug 2024 16:33:06 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 6.10 000/809] 6.10.3-rc3 review To: John David Anglin Cc: Guenter Roeck , Thomas Gleixner , Vlastimil Babka , linux-kernel@vger.kernel.org, Linux-MM , Helge Deller , linux-parisc@vger.kernel.org, Richard Henderson Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 3A87C80013 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 79su7hny35e6t4g6p8sdz75gzr1h4du5 X-HE-Tag: 1723160007-645003 X-HE-Meta: U2FsdGVkX18fEktNuQ4hlua6H3b3iX+qL4P8/t7F6XjrWsJKu96pJUKq7ngxwfz2GWUdmYoRwRWobH2UwUUTWAJv0BY5S2pgy6U0+bBSuLXZqMJIm2APBz2UzYFtRW9AssZeb3+PkyxlEG5/Q8N/+Rgpb4SLw4GcL3FhCt8dNKTCU254HvFdZMo97ueb//vbtS+KkowsManXcuykPkg4Q+Ivj7VJbY9BDkRnJwT9KX6TvmFbbtV8c8OvtQY/se9V3i98SEArzuaEZDRr05Tfl6diY9d0+MY5b5aGjOZoh2dU4cdRJueoDS+AuH2WhqOqpKq6AWFhK/toCycHBkbRJSkV/gFSK6VIHmcfSBsHpftGTuQOGdMiV3qG+Y8n/JbOEcxsTbX2L7212eQEDrN9D1QuOxve16v5gqxwtZJjUFqgsoViC29z1acDEv71OWW84X25F8zANPSy9aS/t9kbqs5rShst9lgwA2Npu9qolxEAD1OZQ9wIUJ6SGrAtFwRzYM6SeI17UEnjfbBdbPV8ULNxHHJogGKP5C10DfNVHL7eLZVAj731q9Ucw4ahjc47DSF4q7oYXJlBmfDDPf3Vkvzj4Rr1hkoiHGo1eavEfrT0H9YhapxlzVfihHLwnPDRs/1TUUFE8OTKawrAUBO3wqb3SaUqYTiVYt7Df+tfIi9U0pKs9qm1Dfo42OnVDZGNphaxg1DAEkJvrfTh4biDNfRz9S6A+7HX2crmPrgzpxORcP+HK1/8InziLlP4T7KTa8Au8X3iJLGPCFonip3BGRptjrZOmms4zhmjwrEsTrZCeZd1Q2DB5hEV0SlBnrzxb3gUiqMzunO3V3vvIH1vX1tUGCvpMF3AJxjut4jvgaHkj6TjemDTElzttCxXHqh2cXmcUuvJSKJ5AXutHFmP0XfpjSTtXnthGyPRlyDxB2Qq+4nZDcDCMm1BHxH7PflLtRIJkMA4nQOfgwn5lSX V3bb/Bms ejPTjaLljkMEpZp0JDuhxnXNU0X09zKOdDBJnwVKYAYncCHm1gE7DF0xatMoJsixTOPtTzhyJPl7eTlocX3PfZqWMVWGuYfmdSVX723Xgf8Ywo6xAiScIAxsQrR4kg47e3itIFGJ81i3vcInqlnERvdu19RcPSahCVztqtoFL77LLsankOQYTVZCYuNE5SUsZ4n0GTd6m7EjIabXTr2YzwLrXUf51QfsKC3VxScgD6qUOlCcY701AWd5m2OP91PQveih24xUUTeoh/JUnX66aPwz0Sgq5f3SZ+uJY00gP565PlTeu3ZV7PdARhzEgd+rRbcYww5DtfvNf+Iczcfg/67eQpV/b5m8eIpBlrEmsxL1TdmvE5JEIEjg8G+5hN4javi+KXLs88sPLkCsLunrE1LxjhqbCyd0xsegMs2/4NhAOZ/Zfb4tOBA+4S1HHhlugHtAuMfoAu8qttlCLaxuNFNnEaoZqibVxAtBhl6e+Ol8OEl1fEqVwuvwUrz7bL3GAbM9yeU8+a/vjoUFaqKaZWt6jeLhubsePaYJn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 8 Aug 2024 at 15:30, John David Anglin wrote: > > > I believe the shladd instruction should be changed to shladd,l (shift left and add logical). > > diff --git a/arch/parisc/kernel/entry.S b/arch/parisc/kernel/entry.S > index ab23e61a6f01..1ec60406f841 100644 > --- a/arch/parisc/kernel/entry.S > +++ b/arch/parisc/kernel/entry.S > @@ -399,7 +399,7 @@ > - shladd \index,BITS_PER_PTE_ENTRY,\pmd,\pmd /* pmd is now pte */ > + shladd,l \index,BITS_PER_PTE_ENTRY,\pmd,\pmd /* pmd is now pte */ This doesn't seem wrong, but doesn't RFIR already restore the status word? So even if the itlb fill modifies C/B, I don't see why that should actually matter. But again, parisc is very much not one of the architectures I've ever worked with, so.. Linus