From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F5B7C52D70 for ; Tue, 6 Aug 2024 17:50:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C50F96B007B; Tue, 6 Aug 2024 13:50:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C01416B0082; Tue, 6 Aug 2024 13:50:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC8506B0083; Tue, 6 Aug 2024 13:50:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8E3AC6B007B for ; Tue, 6 Aug 2024 13:50:22 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3D1F51C1068 for ; Tue, 6 Aug 2024 17:50:22 +0000 (UTC) X-FDA: 82422559884.06.26C5343 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by imf15.hostedemail.com (Postfix) with ESMTP id 15EDDA001B for ; Tue, 6 Aug 2024 17:50:19 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=AW1w9X+B; spf=pass (imf15.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.54 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722966571; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z0zMo04KKh0y+kNNC4Vm6QM8kJTTcnqycTCj7GXfBl0=; b=QVoE0/DnlYOkt9kq8cENsfnkoHUNeOiBW8MLQmQKrO51R0BrElDjOgVo4g0B3cyxbjcTmd dd+Gsv9eVVmuprsTBWPq5DUEfoeY4wrmDR2bkCfPmYQVfdyrhDE+9EQ4SdVyA1mwrMqbCJ hCMUiVmQozp8fsexblwd0W9QejMLys4= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=AW1w9X+B; spf=pass (imf15.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.54 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722966571; a=rsa-sha256; cv=none; b=UWRzSCCzwOCL1JB0HoUuu3lG1ykSPOnUv+HuWXDPVjJDv7rcNFkeEjI584b0KYElNesfhK xzuxK+cMbvnFZEjj71cnK5tos8Iw3kpu9NxsEFoSmoDqbDYgqbSDUT7v6eINeRtSayteSH X4GDQsEwYfC0b5Fjzo2p/8ODSaSSoLY= Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5a309d1a788so986819a12.3 for ; Tue, 06 Aug 2024 10:50:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1722966618; x=1723571418; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=z0zMo04KKh0y+kNNC4Vm6QM8kJTTcnqycTCj7GXfBl0=; b=AW1w9X+B1FBayGYO3UQfbbUqZnzdRgpnRxV0Z2FGHg2W4MYbUPOY8pgwMYE1vvwI7N PuNEQkkQW9gUpDenyjSnTp18Vaj/JthHhFFif3VAQSR6aanyQvZ+WF+Cn/2Y4G8rpb7n sbWVU+mE5Q5PAe4PXeAzWHo8OcIVBVyXvtKvA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722966618; x=1723571418; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=z0zMo04KKh0y+kNNC4Vm6QM8kJTTcnqycTCj7GXfBl0=; b=MDdyePWQ6/37JkVjGpGdGBzIQ3zraJlgLMzMhlgf8GmprSSc7mXPs+n838fRQhl/jv gSkrkWooiNRdcWtcnZkJn9tjVi22ZtXyhMLTwuDHBGk/B5CXH6IV9LADne6ojfA6IlEn Q0npMkyP1ZZ/SfnrI6olsK5vFHMRspLXzTD34sEdVJS+DP7SNxs6pVtcN5/zhYk0MmCk MxI8u9uh8bbeRVzL7UraREqtc50vYfrjkHDbzseq0NZDSc86Gky+2aBHF3igmUyt0y5/ 5lit/OKzS5vIiAd+j5U1wRal9xAA+JAPJ6/g3y+mx1c2103lJWyhqzolWNdbIqwp23Sw H61g== X-Forwarded-Encrypted: i=1; AJvYcCUH4T0mEON3H+NJZtCnfJHZmmsVv93vjmRP8zPzPEWU1cnL20DZdo+TcreadkIkEZZm501/SP+WZ/kkf3MEfhgQ3ag= X-Gm-Message-State: AOJu0YzONwPlByIYXd/M8GRBWU4TebLfv4qVQWtxqyudjD/VZBl3ZPjb n4jfUlIiDxTbVIPpQNtY/3LErZPQr+953tbHumzCY7cHd4MRojrVydu5lSJvQ1ZPBWrpinxEcSh hh7wknw== X-Google-Smtp-Source: AGHT+IFK8ZGIBMF9N4gLq8CHVGsdL5h98fjr1WymXixiHATaWy6QKkxI0ffFXuUKASk4Q9RAUHOEOg== X-Received: by 2002:a17:907:c26:b0:a7a:abd8:77b1 with SMTP id a640c23a62f3a-a7dc50a1576mr1137332166b.60.1722966617872; Tue, 06 Aug 2024 10:50:17 -0700 (PDT) Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com. [209.85.208.49]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7dc9ec8899sm562697466b.207.2024.08.06.10.50.16 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Aug 2024 10:50:16 -0700 (PDT) Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-5bb477e3a6dso1120874a12.0 for ; Tue, 06 Aug 2024 10:50:16 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWUSq8WtL5O7lGj5QWRZDNqXwosLkgkFF99PtINLJ2aIz4sij97Z13PlU98wRbB1dx7hgokYTMFPlYXLFBDK3iiZLU= X-Received: by 2002:a17:907:9715:b0:a77:cacf:58b5 with SMTP id a640c23a62f3a-a7dc4da659bmr1188256466b.1.1722966615960; Tue, 06 Aug 2024 10:50:15 -0700 (PDT) MIME-Version: 1.0 References: <20240731095022.970699670@linuxfoundation.org> <718b8afe-222f-4b3a-96d3-93af0e4ceff1@roeck-us.net> <53b2e1f2-4291-48e5-a668-7cf57d900ecd@suse.cz> In-Reply-To: From: Linus Torvalds Date: Tue, 6 Aug 2024 10:49:58 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 6.10 000/809] 6.10.3-rc3 review To: Guenter Roeck , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger Cc: Vlastimil Babka , linux-kernel@vger.kernel.org, Linux-MM , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 4moacb3e6h9dzrt64e6ey3qcchnqezhm X-Rspam-User: X-Rspamd-Queue-Id: 15EDDA001B X-Rspamd-Server: rspam02 X-HE-Tag: 1722966619-818379 X-HE-Meta: U2FsdGVkX19rVlNTfjAu7gdR8YZio4LI62Z+Qx7BaA8BcPbpV8gZBW7wUOSRmDnX5FQE1SCfPBbQYojVxYZzM4nxiKtgrPxJ7xGSUE8kKHgTNtE5WO/60xV7461o/PUN8nbVUKHpUuvlzXY80H6DrVh5jP5KFfBTRB8YI7RL1gOgXp8M9mUtWhL6Kcg1h9VIJdKNOV2FLAos2uxxGUrR1MBqNzNpgn5M8FMqiR68Volvgkw0/8EVAPPIi++k4NfjZpbFXJhvfE/L591LQw2e1H/DNf4HuVVZi7u1t6+3WQzFL3szVb8+urmdXplDh1p6yLO+Vca22tdLXPbqrupdytWotbJkqos7984858ESzCJCX5ukWX7mA1uyTJAXcvRwCONyMPIW6uowt2FPys1uaw7mInSoyX97NK2sCtwcAVs0vxnbtWsQiHabWcvqLGzG5JEh04OqqZoPOJdux2v3dPCLFR0UiCYpalHkX/vq4UzkCvnmmRZAiscTAaA09pHo/q9n2gsbi6lylo7X7G3PS0OMCfJ4N/N6Kj6Wsy80UqBkm8yq6DevNrVxJD9JBE0MhIk5myDc/kSr9GhAML4fyYyIOZ4XEbLkwTVP1vzCvW3COKp6dvHma3RdRViLh6gl36Cx7yMCzNyZ24aX/XEQ5W8nieuBwPNQQiwMIH06QCGvMUjKKDROwXHU6W7DVsr5hrCxj4rUUMd44w6TguCj/FY3NK//MgQnxJHx9xyfe9sM8yYGSuXq34tojmFyiaLJLu3cfpubLNxnbpq90GH/cyFjjBMS0Vc8QiRgwuqyzCycGbxc3uZWkI3jxlC241JJHnVpiUpKcxbAELTZGbSQ6tFqBmn4JYKl8824bD8LCYHIbOlGzS1DHpA6Qr/xws5XLZutyuzusyOfube8wTPp+wQL7ePCiVIFH7+cWljipBJfnxJ3aiNlCMDthHNDjX2hKfjBlGfQXwBoIq5elWb aeQ+dn3F aZfrUuTpkIYhoSDpk/T24KEikL3LQ5NmxsSnglmz5GwX2XzpuPDWEoDinHVSt8w4dj22qaMNna897h9JtiP99sJIvUKnO+kEFfSvqao9RW6IfIgPp6ucziGbNlZ6IRPJ4R7mso70utsqLdbkpjVA6/HKSAIob6J0QHRodZMFyFQLLOqE538b0Y+CBsAG7gC7bpwONKYpY3cp2Y1eCleh2hqc7HYxkppmwTsTMCAGa4kZRsAQMQ1okU0u+LgfG4lxO/AyXmD/MS2zsPuoqw0tx/pBcOQ7Tm8q6J5Y7ueH6q4sm0BUMj8YrW3zOh0yzoENsZuc0NAHvNEawKy8RP5ahgxqxQapZIcTel57Ym6UNfr0irAOfzQbwKpsS2fDNrPWWCl7wsotJexB8AISTRjmkchKFyrmW04Mo2bv9xVXDv0K4fzuWwvqTpzdUiIk+uFBaZZcXbbEqYCe6ciDLLaFuSpWDnP38bjVwaz4kfTw7SCw4FAx2tkKPBaYEQA31/5Xb4aCUKgH0w6Xss3spLQYXAd4mudI3W+a4schjHz7tM9OifYs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: [ Adding s390 people, this is strange ] New people, see https://lore.kernel.org/all/CAHk-=wjmumbT73xLkSAnnxDwaFE__Ny=QCp6B_LE2aG1SUqiTg@mail.gmail.com/ for context. There's a heisenbug that depends on random code layout issues on s390. On Tue, 6 Aug 2024 at 10:34, Linus Torvalds wrote: > > Hmm. Do we have some alignment confusion? > > The alignment rules for 192 are to align it to 64-byte boundaries > (because that's the largest power of two that divides it), and that > means it stays at 192, and that would give 21 objects per 4kB page. > > But if we use the "align up to next power of two", you get 256 bytes, > and 16 objects per page. > > And that 21-vs-16 confusion would seem to match this pretty well: > > [ 0.000000] BUG kmem_cache_node (Not tainted): objects 21 > max 16 > > which makes me wonder... I'd suspect commit ad59baa31695 ("slab, rust: extend kmalloc() alignment guarantees to remove Rust padding"), perhaps with some odd s390 code generation issue for 'ffs()'. IOW, this new code in mm/slab_common.c if (flags & SLAB_KMALLOC) align = max(align, 1U << (ffs(size) - 1)); might not match some other alignment code. Or maybe it's the s390 ffs(). It looks like static inline int ffs(int word) { unsigned long mask = 2 * BITS_PER_LONG - 1; unsigned int val = (unsigned int)word; return (1 + (__flogr(-val & val) ^ (BITS_PER_LONG - 1))) & mask; } where s390 has this very odd "flogr" instruction ("find last one G register"?) for the non-constant case. That uses a "union register_pair" but only ever uses the "even" register without ever using the full 128-bit part or the odd register. So the other register in the register pair is uninitialized. Does that cause random compiler issues based on register allocation? Just for fun, does something like this make any difference? --- a/arch/s390/include/asm/bitops.h +++ b/arch/s390/include/asm/bitops.h @@ -305,6 +305,7 @@ static inline unsigned char __flogr(unsigned long word) union register_pair rp; rp.even = word; + rp.odd = 0; asm volatile( " flogr %[rp],%[rp]\n" : [rp] "+d" (rp.pair) : : "cc"); Thomas notices that the special "div by constant" routines moved around, and I'm not seeing how *that* would matter, but it's all obviously very strange. Linus