From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 553B8C433DF for ; Sat, 23 May 2020 19:10:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E2EF32070A for ; Sat, 23 May 2020 19:10:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="PmcDHo5T" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2EF32070A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8469080008; Sat, 23 May 2020 15:10:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F72180007; Sat, 23 May 2020 15:10:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BE5080008; Sat, 23 May 2020 15:10:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0039.hostedemail.com [216.40.44.39]) by kanga.kvack.org (Postfix) with ESMTP id 51C8880007 for ; Sat, 23 May 2020 15:10:48 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 1507C442A for ; Sat, 23 May 2020 19:10:48 +0000 (UTC) X-FDA: 76848925776.26.note63_6f614dfd0156 X-HE-Tag: note63_6f614dfd0156 X-Filterd-Recvd-Size: 4366 Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Sat, 23 May 2020 19:10:47 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id w15so8368450lfe.11 for ; Sat, 23 May 2020 12:10:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bPVlPhew8dfbVslQICn0yPbyyO1M5AJGUTcDYlXCCuQ=; b=PmcDHo5TDVjmactGyJauJx2vquRisjETelm5YCAZsL/PWW/8gtghY4b8iacXkMIe3k bl22kofKBJdtVoo2sxyq93gkdH28uokIlIRHNTJqVCv9IeaRpHWkrHAC3q5CSb7HG9s8 3HrXSr+5qMPzvhbU5HVJbVr3oygsjBkVcbPQE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bPVlPhew8dfbVslQICn0yPbyyO1M5AJGUTcDYlXCCuQ=; b=fK4uoBSe0VIA5LjQM8SGZKpVbUaAYMlXy5ZRulaZIOkoOhH5aQ9ePSpxmMqKFniQRT 7KNXUfGWo0PdKQH5L26bk11ezAbaYGDL8ZeBgUWjzKyxC5mqwZn9E6qX4Ug2LlBbz7vj yhXyRsRyjfI/SRsXBy8KSMFsDh6/kcCuNtx+O6i0PAvRezvcHWIkVNzVg3G1mlcOIDYX 6AX93jL9FpztWJpkJ0+gizAxqK4J8YnivP4ePP15Trwguvm+S+KqGn7l3703dd2Qnsvq /yI+NsQPfs6W0ybCIanTzem7rtRb17Y9hrx3P4Z7xZQiztvg97Kzn4v6t9LaeQwVo4z3 lucA== X-Gm-Message-State: AOAM531AvNdzcqG5688OqGq8fC3a1sALJPhR1PpSluKEEMSsW3reP0rO Fs1hWB+YHSYdUl3hmxxFwQt/ee5UnLI= X-Google-Smtp-Source: ABdhPJwSi9gJja6vansvnUYUANhPDKr4HVRj5PXkitEtzxx1hr5JyEtYsVi19wxwoL95MVzeU97Vtg== X-Received: by 2002:a19:f204:: with SMTP id q4mr4024719lfh.63.1590261045360; Sat, 23 May 2020 12:10:45 -0700 (PDT) Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com. [209.85.208.175]) by smtp.gmail.com with ESMTPSA id g142sm961096lfd.59.2020.05.23.12.10.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 May 2020 12:10:44 -0700 (PDT) Received: by mail-lj1-f175.google.com with SMTP id m18so16568462ljo.5 for ; Sat, 23 May 2020 12:10:43 -0700 (PDT) X-Received: by 2002:a2e:150f:: with SMTP id s15mr10043967ljd.102.1590261043584; Sat, 23 May 2020 12:10:43 -0700 (PDT) MIME-Version: 1.0 References: <20200522222217.ee14ad7eda7aab1e6697da6c@linux-foundation.org> <20200523052309.4caVN81-C%akpm@linux-foundation.org> <20200523190145.GX1059226@linux.ibm.com> In-Reply-To: <20200523190145.GX1059226@linux.ibm.com> From: Linus Torvalds Date: Sat, 23 May 2020 12:10:27 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 09/11] sparc32: use PUD rather than PGD to get PMD in srmmu_nocache_init() To: Mike Rapoport Cc: Andrew Morton , David Miller , Linux-MM , kernel test robot , Anatoly Pugachev , mm-commits@vger.kernel.org, stable Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 23, 2020 at 12:02 PM Mike Rapoport wrote: > > Unfortunately, this fixes a compile warning but breaks the boot :( Argh. I delayed applying/merging this overnight to see if there were any reports, but this came in after I'd already merged Andrew's patches and pushed them out. So it's in my tree now as commit c2bc26f7ca1f ("sparc32: use PUD rather than PGD to get PMD in srmmu_nocache_init()") > The correcteted patch is below, boot tested with qemu-systems-sparc. Mind sending a patch relative to the previous one that already got merged? Also, would it perhaps be worth it to just make __nocache_fix() not throw the type away? IOW, make it do something like #define __nocache_fix(VADDR) \ ((__typeof__(VADDR))__va(__nocache_pa(VADDR))) or whatever? Wouldn't that show when those pgd/p4d/pud pointers get mis-used because they don't end up dropping the type info.. Linus