From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 086C3C77B7A for ; Thu, 25 May 2023 17:26:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D98B900008; Thu, 25 May 2023 13:26:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68A38900002; Thu, 25 May 2023 13:26:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 551F6900008; Thu, 25 May 2023 13:26:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 45CF3900002 for ; Thu, 25 May 2023 13:26:04 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 17FFD160811 for ; Thu, 25 May 2023 17:26:04 +0000 (UTC) X-FDA: 80829455448.02.BD2C821 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by imf10.hostedemail.com (Postfix) with ESMTP id A45F0C0017 for ; Thu, 25 May 2023 17:26:01 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=Ok2oHq3c; dmarc=none; spf=pass (imf10.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.52 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685035561; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EJa+li1Oy5bbsqG6UFm3MUpvaFnPsLyMyN5vhg0qjCI=; b=ZHKD+XA082ckS9aV7DhkqYgBJhebn3p25b0g1btOikl4Hy+jYrJqh/7TuegL3XAUon9VUQ ffeKhI1hMqfaK+w9Ss+OPMH9zwThYy+rPyi9PSUpGa9Q0P5+aTlJyy1GDGu/NdrBnHll0y JVBlaLtzYR1eCDai3Rs/NV04pM0If+k= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=Ok2oHq3c; dmarc=none; spf=pass (imf10.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.52 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685035561; a=rsa-sha256; cv=none; b=mPzLGiqINrGGOHT9p8HeyPDgTaEj+s1+/xvcbgnaybirJoGC8GIWuwY56P0nqxyHJt3uQw Hr7aRL+6jb1yT1hQqsDnVKVWmJE2r5jTSL8PVbiXABTLc1JY2U69yNfYb1Y6K3ZivkfwZI 1E6nt8hkV4Iy+6L9KXvd0H+jklyZEDc= Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-514454733b8so1285257a12.3 for ; Thu, 25 May 2023 10:26:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1685035560; x=1687627560; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=EJa+li1Oy5bbsqG6UFm3MUpvaFnPsLyMyN5vhg0qjCI=; b=Ok2oHq3cev+oksqRUcG1p3USoN99IbgxduJYBtiM1ZppktJCef7OJEAeTtiFyV4Pla ualjpqrKd+WIl8n4NZV9wQWuCy1d7zew36uRaxySx+XcHvwZotJwo3OYIopLB4A7A7Jg Af69GCES8xqOENGnIFKoV7WULD0sjK3aGPWqU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685035560; x=1687627560; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EJa+li1Oy5bbsqG6UFm3MUpvaFnPsLyMyN5vhg0qjCI=; b=BqkI57inu65A2tyUKXy0693i7gCbCnHHH/0Ju8LTBCdSb7j3vqR6jJ+v1tephnzdLX Y9Ip80htG6FgLrGrMo7BfrrAhQDV2jBV033BaFVTWZ8ZPxirMJiSnRraqawDgK1l4weO e2QY+eps8tKlTNQD8aTi7cRBGxbe3QuGglNepI/XyhS6KdhYIYBvgooUsGU0tG8GuC6q WW096iXQH2AJzHP8QG49+JVoNsJOsub0Wg0HO2+6YHmYPwVB7xyNKf8ucotvzNq54op5 jB7AUAfdQ9bnw+P2LzKLI3vvMEKyA1RDJFgyTpKmnRXLS24zz8tykcg/kcLisMC6Ymei 9hVg== X-Gm-Message-State: AC+VfDzGFHm8CSOQTC5bSZdbNtFlVwFv8xz/h8668geA1NKX4dHvQcVC UzqYxBREx7qp+M6AYOkHlbIRfeRhP394rBo+YPd0Wx/u X-Google-Smtp-Source: ACHHUZ506lcg6W7G/wRy3E4xD1ynVW3j9SDC1BWq3nMM92lkyBIwH9Ey/N5Z14vi3Nb/L5JnBSqQJQ== X-Received: by 2002:a17:907:97cd:b0:94f:6058:4983 with SMTP id js13-20020a17090797cd00b0094f60584983mr2386914ejc.76.1685035560238; Thu, 25 May 2023 10:26:00 -0700 (PDT) Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com. [209.85.218.53]) by smtp.gmail.com with ESMTPSA id u13-20020a170906408d00b009659fa6eeddsm1089602ejj.196.2023.05.25.10.25.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 May 2023 10:26:00 -0700 (PDT) Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-970056276acso141436566b.2 for ; Thu, 25 May 2023 10:25:59 -0700 (PDT) X-Received: by 2002:a17:906:7954:b0:96a:37af:ff37 with SMTP id l20-20020a170906795400b0096a37afff37mr2274160ejo.15.1685035559397; Thu, 25 May 2023 10:25:59 -0700 (PDT) MIME-Version: 1.0 References: <20230522205744.2825689-1-dhowells@redhat.com> <3068545.1684872971@warthog.procyon.org.uk> <3215177.1684918030@warthog.procyon.org.uk> <144598.1685034915@warthog.procyon.org.uk> In-Reply-To: <144598.1685034915@warthog.procyon.org.uk> From: Linus Torvalds Date: Thu, 25 May 2023 10:25:42 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Extending page pinning into fs/direct-io.c To: David Howells Cc: David Hildenbrand , Christoph Hellwig , Jens Axboe , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A45F0C0017 X-Stat-Signature: q57y3n8js5zbhdkhss91mbs99ab4p6zt X-HE-Tag: 1685035561-443898 X-HE-Meta: U2FsdGVkX1+sFfxI9S4XPbpBEi1ZK4dHPOCvAbf3inucTB4jnozM5CZUylXy+sBDuL16QjIFQPaD4iEkKGqWlyAfGGlOYGBZjv8vJMxZa0iakRudUbb3zoOCzkheUezJub+b9wMUU+kBMIYp3iGoKJ/8MOMK1PROUmRrfMt+I4gNsN/RZtoXPN5EDkC5Grtw+AaW2xipjA7pEm9DLByJWUjdHCIb/ga45ayX9s2XrXB5Az3En7LKKUrcqXd/Lp5IPk3dCEJgERsK7TM13dc8lR+UffrHeBb/q4M8UoKhnxSxMVz+BzVIumfeND7NbJX2QRxXJaMfaiU1om3m65bUf00ulU+hOn+JEo5fydKTGlm+HjsfCN8IZG62jXqZBT+3spiAFmNbY8Y1eHrEbFKP6DX8mLAiZGql7DN9PU6O51ihlBF7QB4RuW4u8CQvMBqRDFmZGFF1GYzPC0+9sk0riMeP2xnXRkixoQmDGkLvu27cdAVXZs486LkWsEwO8JF2BlLfueTcpMtxpge8UEblflCA/KY1Ea8znzSfbuAY13+kBlpTdDJa1v1NZPxxcEVrn2GgOKb0NwE/8PG1oPWvBbr4nnhYFlVwmg+HfOyDfs5LZrxT+jWQ40oH+0eP4sw5SQidmYBRSyhcN8gqLDDMlq2zO2cRDcD4XJ5lMVThdeXZDIeeozTFiQiVc63OZ3kQtvksumnUvJHyV8UWuB9H/AvNMGvX6pC/UuLHs7qGDfr7rH10pTzwOvaAYiRL6oAqQYO01xCAZTyBVjufAVnbFHHUwJ2Mb69O+0pIPOY1h18P8dSh2UjTX78DzT7ySXfaMsmITlcXghATqMp5QKROfD5cIiQsqo9C5Q9tOlS2g1E6jcGmqff/0N/kLd9vJ30jqCOaHV0yj7DlvV8PM+/CSruTotjaZub9KOYs1QmZljQY16Tg4CXltDELV07AGRlbDuVSSRjvvbOLR377/Ke dEQxyJYi CyYKlJR67BDnOW4wz4qN++/gM8SstTLpSde/XF97AB/cxlJb819iFoNxZ9p5ZTt41Z1wc1sHtjbx+8TfdzwPKVK7YRlUN+M+X5ppc06rsbM8NVCuPmR/+xgVWhgFBR1RcRzSJf6uHIGszMLBgNb21rRfZRRKTH61GxOw6a8qf2zakDBpxvkjO7IFv5E4r+xciOhCEV38Dk9Z9aSi++O3cOtoegh2uJJftHYy8U0bPICESYd7N6AezhSJILyZBo6zQz6dIKj0JqTasVE07vtHqsxa2pHjL1oqQ+TFnOR4jc/0n1/xeRQtYqRQxTAeObCfJpuzOuLvfgI1cwrl5WtLVXB6QjiPFDp8fHBsm4nuUlKAY8zShqIe5irS7qsf6AKKLhllf4XY/hN4K/dHeeLRoEV2KIpgLzHf3QUxjk/S9/7R+2BysivdSU5WFtasALPpRErF/Vg3yPAppw0RS+hiocnH+iwRitt7oh4Rr+uyF2XmGwlmvZQ9fdbVMnxE53l/J5xe7jwYY2xbZZG4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 25, 2023 at 10:15=E2=80=AFAM David Howells wrote: > > It doesn't seem I can add it to mm.h as an inline function. What? We already have that pattern inside is_longterm_pinnable_page(), so that's really strange. But regardless, please don't duplicate that odd conditional for no reason, and don't scream. So regardless of where it is, make that "is_zero_folio()" just do "is_zero_page(&folio->page)" rather than repeat the question. I also wonder whether we shouldn't just use the "transparent union" argument thing more aggressively. Something like typedef union { struct page *page; struct folio *folio; } page_or_folio_t __attribute__ ((__transparent_union__)); and then you should be able to do something like this: static inline bool is_zero_page(const page_or_folio_t arg) { return is_zero_pfn(page_to_pfn(arg.page)); } and we don't have to keep generating the two versions over and over and over again. Linus