From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8710DC4332F for ; Sun, 11 Dec 2022 18:28:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DCD788E0003; Sun, 11 Dec 2022 13:28:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D56168E0002; Sun, 11 Dec 2022 13:28:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCFA78E0003; Sun, 11 Dec 2022 13:28:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A7D718E0002 for ; Sun, 11 Dec 2022 13:28:19 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 63F3080419 for ; Sun, 11 Dec 2022 18:28:19 +0000 (UTC) X-FDA: 80230860318.11.A4B7119 Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) by imf11.hostedemail.com (Postfix) with ESMTP id 4143240006 for ; Sun, 11 Dec 2022 18:28:17 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=MGBmNEXQ; spf=pass (imf11.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.219.50 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670783297; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VcIjNZvmXhwLlIH4qzTb3os7YT1CTCX89zz+g7s11S8=; b=W7cB19mybenZV+uYNsrzH79zwfXAUJciP+QN5tFDrA3g7QBm90DQXSpQpVXVh+vgEE+bgl osY/TWbBt1y8QvkG5W0ycDs2zdqPaodBjiGqMb30UMdDcICtBgXFopOD0Gqu8No6bKkr+K ew0rsfhBGGtswHDKRBerzcsoQO20l2w= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=MGBmNEXQ; spf=pass (imf11.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.219.50 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670783297; a=rsa-sha256; cv=none; b=yKtEXAKJ6a31/Mq07dpvhEXRWF+khCDDnUn5UMtTNimhkcmQ9Yh2AhFUlwlUxaUj/ywUXF H1m+8YoAvXnO1C8S6j1hrgnz46vLyekOQEToJPPui4moJe4AMohuUNnxsEzcv1gOqMhglM 25Sfn8FkRxYlNGxsxKl65cJ7tgdLgLU= Received: by mail-qv1-f50.google.com with SMTP id d13so6845558qvj.8 for ; Sun, 11 Dec 2022 10:28:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VcIjNZvmXhwLlIH4qzTb3os7YT1CTCX89zz+g7s11S8=; b=MGBmNEXQ9KDFHMWkhfA16f3WXE9+n6bQWGbQ/WBcrwvvD7XGUxNJ4lULAQ4bF52hyX I45Gmp4HDqpBwWuXX3l+4nvpELR0hLZgp15u/sM1JcfxMioNWKmTXOmZ3q/OnbB9HyzY NTeZGgpA0T0hHbjbfhGwL2uIoepMHlEZ6wf+E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VcIjNZvmXhwLlIH4qzTb3os7YT1CTCX89zz+g7s11S8=; b=VYN8W0WJ3VG/UMrQmRDdWal+ub1ZU7g4GMGiIpEppICvnyNWH5QD98VwEDZOy8YQBn Gm4Ikf5QabSFJeBioCaS1DxfbdXnHIVJkOEW57GTfq3xbqtqU2iMTyXaAkGHuiRhlGS1 JumZZ37Smm0HotC7Ee1ttjGpQ/NddZOHGf9tAQf+SDitLj7N0kILQwDykG9MaAToaFcT kmwFn7ey2n4xK9RBSly32Ijn1yNXgmncOvP4/6nrFDo/KpzjGPrQ139/s2RvalRuvlrU 0j8fp8AVy9O4nSHbUsosGrsqAlvMz14VR0UzbffdAmDgEc4lS1+4GLcdjbRSiM9O2Y6f T44Q== X-Gm-Message-State: ANoB5ploasOzY1/tgQtcoxTQeuWNBObqh4j9rmHn/PFex19fZtR/GHlm RIWpZ4+piRnxVTW3MYdaBNaGFTY62JP+z+1V X-Google-Smtp-Source: AA0mqf4TmqqFw/TyYAEehsNxlC7DK5mGNx5KG9ajqWNiLBQErC5r4+QKTDMRBPcKJzfDI5RRaCloYg== X-Received: by 2002:a0c:f6cb:0:b0:4c7:b66:ea01 with SMTP id d11-20020a0cf6cb000000b004c70b66ea01mr16892920qvo.30.1670783295857; Sun, 11 Dec 2022 10:28:15 -0800 (PST) Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com. [209.85.219.45]) by smtp.gmail.com with ESMTPSA id o10-20020a05620a2a0a00b006fb9bbb071fsm4428964qkp.29.2022.12.11.10.28.15 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 11 Dec 2022 10:28:15 -0800 (PST) Received: by mail-qv1-f45.google.com with SMTP id h10so6848887qvq.7 for ; Sun, 11 Dec 2022 10:28:15 -0800 (PST) X-Received: by 2002:ad4:4101:0:b0:4b1:856b:4277 with SMTP id i1-20020ad44101000000b004b1856b4277mr70224982qvp.129.1670783284766; Sun, 11 Dec 2022 10:28:04 -0800 (PST) MIME-Version: 1.0 References: <202212112131.994277de-oliver.sang@intel.com> In-Reply-To: <202212112131.994277de-oliver.sang@intel.com> From: Linus Torvalds Date: Sun, 11 Dec 2022 10:27:48 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [ammarfaizi2-block:dhowells/linux-fs/fscache-fixes] [mm, netfs, fscache] 6919cda8e0: canonical_address#:#[##] To: kernel test robot Cc: David Howells , oe-lkp@lists.linux.dev, lkp@intel.com, Rohith Surabattula , Matthew Wilcox , Steve French , Shyam Prasad N , Dave Wysochanski , Dominique Martinet , Ilya Dryomov , Ammar Faizi , "GNU/Weeb Mailing List" , v9fs-developer@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-cachefs@redhat.com, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4143240006 X-Stat-Signature: gwc4wmh5qw575ihujgps39nmtwrqt8gs X-HE-Tag: 1670783297-542568 X-HE-Meta: U2FsdGVkX1+zwH4/Ds3I9D7xpsHCffHjL7uSHWqWTJKHVgoAhsHnE5wxFUNBmcNPN/JhathuDyxXvEgsMD8F8DaSj/ZFW5fcEIct8VmbR812ARax/QKC324nG6n11cceA/LFMunmVsPf+fniO2Idxw1fPew9pc5khACt0AHmYf74tQ4ELB562n5Iku+8oFRdOFAGVaR8v7ynKwsVcUD7ipBVBvpZu9+A/XOhqcpT6JdgZi9nkUuA4UxfzgKac0KT5PlyIH88P7nBH0jKp6IlfZT3wBFwsMz2xVrqW+iFXZun06vgHh1qLVP0ibKN/oqMSfANJZyqLfiMJRa85Q61evMvFNzcKDn84enINVMMcodTNPAN0odThI2jpsdzr6Rj/C/QMFC/mxQKz3XdloV00WIAfb0j8FC/XXFMa6cJhD/k06wKahavWi126GXE4a+SPLuj+2BNZSv2TbsmgvGGs+4MK5O5Yi+m9WSaW7laN1EOAKNZEHk+V/MPn/oqim9qL4XjX7iGf0Qtqnc76yWc8YIhE3YuWug0QIqpnvEbJ3O7K8GGLl3dQoWBYedg+Fh5SVWevb1CLzcswAW8ZnWCIGvIoOMUNEdinwfmb2YNAlhhkRQEDokej6t76DzcqNLk1opUd2kC2WOqGBOPaqeSlgAccGTne4UnEq02XcsgwSf0dVHnkjdJDMtsidtjabWKzrC5tHYtxKdm5uw3c6VTnOBv54vhT7AStxbLYpQbxFPExB5M93UYLTPwzaaQufnsLpEthoAg/K0Gecn30iEcAMxZDGxY9Ww7F4KRV8DHPvpTKQoo26wphZt0MxXD1akVI1XATn8NvAPveJz586QKbwZ26M9KKHiioRaqPWvzEF4kb8UsUk2ZfwFAan4q17NtdHY62TnZESck6cWMs4EeEieY4S/K1lOa6/eo603TBGMV+y7oWAyNWjpLQzPYnXIKtY6OKSL0w15A0qXRaXk MJ43J2LG 4pXrWM28GlNfITCmNljscHaJp+Q5KHTnYcbgd9iTCICpTZBrip9rMT0FPczJ1eaAeC+QMo9KeooX6wylSLqV4S5mpbf1Hgxdg5oXuDjsJQnZufaQ8c9k1U3mOm7rwTjzYc6ScKLdb0HWcheXFiTACnERUuWjExAoYU11bSOU1eGWG+IXiNJUQqBbMaWNrNhgPpMOyY3nwp8We5QnZPkNL5a3ANNYfULZ0MJOmckMZAHwM3UdGiB1eiyhPpEeEuugczPU2Cr6EdiXBuecjoTtMjvDiR5vMnlx5SYmRcrP+vT+XVSCzYoU1fVKubbKQONedW7tlGx72JSNNPKwMzzuJIJvOx/WpgO/h+wj3skr3m8tAzvwhHPtuoZ/vc00SUDSphcZqWL1PvjkaMSld8TNeh5SO1A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The disassembly isn't great, because the test robot doesn't try to find where the instructions start, but before that > 4: 48 8b 57 18 mov 0x18(%rdi),%rdx instruction we also had a mov (%rdi),%rax and it looks like this is the very top of 'filemap_release_folio()', so '%rdi' contains the folio pointer coming into this. End result: On Sun, Dec 11, 2022 at 6:27 AM kernel test robot wrote: > > 4: 48 8b 57 18 mov 0x18(%rdi),%rdx > 8: 83 e0 01 and $0x1,%eax > b: 74 59 je 0x66 The and $0x1,%eax je 0x66 above is the test for BUG_ON(!folio_test_locked(folio)); where it's jumping out to the 'ud2' in case the lock bit (bit #0) isn't set. Then we have this: > d: 48 f7 07 00 60 00 00 testq $0x6000,(%rdi) > 14: 74 22 je 0x38 Which is testing PG_private | PG_private2, and jumping out (which we also don't do) if neither is set. And then we have: > 16: 48 8b 07 mov (%rdi),%rax > 19: f6 c4 80 test $0x80,%ah > 1c: 75 32 jne 0x50 Which is checking for PG_writeback. So then we get to if (mapping && mapping->a_ops->release_folio) return mapping->a_ops->release_folio(folio, gfp); which is this: > 1e: 48 85 d2 test %rdx,%rdx > 21: 74 34 je 0x57 This %rdx value is the early load from the top of the function, it's checking 'mapping' for NULL. It's not NULL, but it's some odd value according to the oops report: RDX: ffff889f03987f71 which doesn't look like it's valid (well, it's a valid kernel pointer, but it's not aligned like a 'mapping' pointer should be. So now when we're going to load 'a_ops' from there, we load another garbage value: > 23: 48 8b 82 90 00 00 00 mov 0x90(%rdx),%rax and we now have RAX: b000000000000000 and then the 'a_ops->release_folio' access will trap: > 2a:* 48 8b 40 48 mov 0x48(%rax),%rax <-- trapping instruction > 2e: 48 85 c0 test %rax,%rax > 31: 74 24 je 0x57 The above is the "load a_ops->release_folio and test it for NULL", but the load took a page fault because RAX was garbage. But RAX was garbage because we already had a bogus "mapping" pointer earlier. Now, why 'mapping' was bogus, I don't know. Maybe that page wasn't a page cache page at all? The mapping field is in a union and can contain other things. So I have no explanation for the oops, but I thought I'd just post the decoding of the instruction stream in case that helps somebody else to figure it out. Linus