From: Linus Torvalds <torvalds@linux-foundation.org>
To: Ming Lin <mlin@kernel.org>
Cc: Hugh Dickins <hughd@google.com>, Simon Ser <contact@emersion.fr>,
Linux-MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] mm: adds NOSIGBUS extension for out-of-band shmem read
Date: Tue, 1 Jun 2021 14:16:08 -1000 [thread overview]
Message-ID: <CAHk-=wip5urjbGkPsoATGRbFoXSf5bq1qMwNAWEz5OpeanE+DA@mail.gmail.com> (raw)
In-Reply-To: <1622589753-9206-3-git-send-email-mlin@kernel.org>
This series passes my "looks fine, is simple and straightforward" test.
One nit:
On Tue, Jun 1, 2021 at 1:22 PM Ming Lin <mlin@kernel.org> wrote:
>
> + error = vm_insert_page(vma, (unsigned long)vmf->address,
> + ZERO_PAGE(0));
On architectures where this matters - bad virtual caches - it would be
better to use ZERO_PAGE(vmf->address).
It doesn't make a difference on any sane architecture, but it's the
RightThing(tm) to do.
Linus
next prev parent reply other threads:[~2021-06-02 0:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 23:22 [PATCH 0/2] mm: adds MAP_NOSIGBUS extension for " Ming Lin
2021-06-01 23:22 ` [PATCH 1/2] mm: make "vm_flags" be an u64 Ming Lin
2021-06-02 1:58 ` kernel test robot
2021-06-02 2:06 ` kernel test robot
2021-06-01 23:22 ` [PATCH 2/2] mm: adds NOSIGBUS extension for out-of-band shmem read Ming Lin
2021-06-02 0:16 ` Linus Torvalds [this message]
2021-06-02 1:06 ` Ming Lin
2021-06-02 2:13 ` Hugh Dickins
2021-06-02 2:02 ` kernel test robot
2021-06-02 3:49 ` Hugh Dickins
2021-06-03 0:05 ` Ming Lin
2021-06-03 0:46 ` Hugh Dickins
2021-06-03 18:25 ` Linus Torvalds
2021-06-03 19:07 ` Hugh Dickins
2021-06-03 19:12 ` Linus Torvalds
2021-06-03 19:15 ` Linus Torvalds
2021-06-03 19:24 ` Andy Lutomirski
2021-06-03 19:35 ` Simon Ser
2021-06-03 19:57 ` Ming Lin
2021-06-02 9:30 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wip5urjbGkPsoATGRbFoXSf5bq1qMwNAWEz5OpeanE+DA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=contact@emersion.fr \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mlin@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox