From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A714AC4332F for ; Wed, 16 Nov 2022 17:45:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE1C76B0072; Wed, 16 Nov 2022 12:45:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D91996B0073; Wed, 16 Nov 2022 12:45:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C58E56B0074; Wed, 16 Nov 2022 12:45:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B52A96B0072 for ; Wed, 16 Nov 2022 12:45:23 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7FAAEAB07E for ; Wed, 16 Nov 2022 17:45:23 +0000 (UTC) X-FDA: 80140032126.04.2936F9E Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) by imf22.hostedemail.com (Postfix) with ESMTP id 0A168C0010 for ; Wed, 16 Nov 2022 17:45:22 +0000 (UTC) Received: by mail-qk1-f178.google.com with SMTP id k2so12146803qkk.7 for ; Wed, 16 Nov 2022 09:45:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5GiK3SgiI9CKL6CbV/SHRk4GJHwDooVfogzt8LPWN3o=; b=TqeYel93n9lNXLImI0rYMMKitTxHGoo/8D+RKHflcgvzNACmHDu6Eb9di/e7V/YbE8 JSJRp318JWElgMvnZtF2Sfh/DzdgvepAY2rDh1s1dTzV9kR37AskjrOctkn0OTHyoRkt uA55JflOEh28Mq/hdA83+W+8Zqe5ZMbDkRHAw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5GiK3SgiI9CKL6CbV/SHRk4GJHwDooVfogzt8LPWN3o=; b=LhwVbpR4+KSkywRrzGfWSvQZ1VTPbDW7SOnnjQAoXxvpHx+dcH2ztbfnqom7IzClJB +TKwHmxdAUrysgR2n9uV0hpte7OqmcpOlfeVtTSsfigfKJCrRPabwZgYk5LqtyJot62u 0ZoC5J9yDTDVG4jENE/I516934zlPkAnKeD8L8jLuPXpX3CjIomqpb5IX41pDjrcvoF7 nN5ZgL8leHfBhcUyLXItxktpAo3lChmwe3oUPnWonbXPPAmgal91fu7OHkCieATjiKbZ 22/vn/Khcioc8ZQwjYhKLVgTTckOa5ismHOhd0IrvcSEnobOZrfWwTP16d/OUArI/sSy OO+g== X-Gm-Message-State: ANoB5pn9q2+eHEBkyyAosrhyzVBLF66A5Q6EZTrrdiMQtnSNwMw29Ys9 uSuH/jKuAaVJwuwnXpHB6wxkP938EF7LRw== X-Google-Smtp-Source: AA0mqf6gSLz8TU/vO/+UaJA0/OYqblyDBYbOUyhRd8iyDJHfGCe67kE8Ya9HvyQlH0d/Brhnp1DJBA== X-Received: by 2002:a05:620a:12a3:b0:6f9:ddaa:ef95 with SMTP id x3-20020a05620a12a300b006f9ddaaef95mr19961200qki.27.1668620721693; Wed, 16 Nov 2022 09:45:21 -0800 (PST) Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com. [209.85.160.176]) by smtp.gmail.com with ESMTPSA id bz25-20020a05622a1e9900b003a51e6b6c95sm9043530qtb.14.2022.11.16.09.45.20 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Nov 2022 09:45:20 -0800 (PST) Received: by mail-qt1-f176.google.com with SMTP id l15so11163472qtv.4 for ; Wed, 16 Nov 2022 09:45:20 -0800 (PST) X-Received: by 2002:a05:622a:22a7:b0:3a5:1ba7:717d with SMTP id ay39-20020a05622a22a700b003a51ba7717dmr21964368qtb.678.1668620720230; Wed, 16 Nov 2022 09:45:20 -0800 (PST) MIME-Version: 1.0 References: <20221109203051.1835763-1-torvalds@linux-foundation.org> <20221109203051.1835763-4-torvalds@linux-foundation.org> In-Reply-To: From: Linus Torvalds Date: Wed, 16 Nov 2022 09:45:04 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: mm: mmu_gather: do not expose delayed_rmap flag To: Alexander Gordeev Cc: Hugh Dickins , Johannes Weiner , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Nadav Amit , Will Deacon , Aneesh Kumar , Nick Piggin , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Peter Zijlstra , Gerald Schaefer Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668620723; a=rsa-sha256; cv=none; b=WVorxFmKmHGRmaMRrtSLqwmbCLImFgTqINfH7LhnqGoejcL/chkWKv+MgfxSPQXh8vso6a 0rOQyhsgzhDmbCl/FDvpgqdbfLfwsXzYCq7QfPmIvzKefW5lXJ9i1+wXziHvHFOqfKPJb2 8ybRHa8UuUH6o45Actn5F/RsaS4/LcE= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=TqeYel93; dmarc=none; spf=pass (imf22.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.222.178 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668620723; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5GiK3SgiI9CKL6CbV/SHRk4GJHwDooVfogzt8LPWN3o=; b=2AsisJkUwnBLe+7Dj9wQJ9sVQ00EiDcTV4k42inDyvWkB0mFO3hVGqSsN+g7A1ifFRMn40 WmfDXJnd3IfGuNfQcxKZtR8uFlRJDbs/sKzLydSWXhlwXG1ZWGyXbc/IXT4BfnN85GkvgY efzR43tTjz9AY9eCO5IZ4njC47ZBheo= Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=TqeYel93; dmarc=none; spf=pass (imf22.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.222.178 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org X-Rspam-User: X-Stat-Signature: uc89ux6o5gzaowr6mk54dgxmtxrambpu X-Rspamd-Queue-Id: 0A168C0010 X-Rspamd-Server: rspam11 X-HE-Tag: 1668620722-335893 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 15, 2022 at 11:49 PM Alexander Gordeev wrote: > > Flag delayed_rmap of 'struct mmu_gather' is rather > a private member, but it is still accessed directly. > Instead, let the TLB gather code access the flag. Now, I set it up so that if you don't use delayed_rmap, the tlb_flush_rmaps() function ends up being an empty inline function, and as such the compiler should already have done this for you - including optimizing out the test that then doesn't even matter. But this patch shouldn't *matter*, but it also isn't wrong, so.. Acked-by: Linus Torvalds Thanks, Linus