From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23EE4C77B7A for ; Fri, 26 May 2023 02:29:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 856B26B0074; Thu, 25 May 2023 22:29:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 80734280001; Thu, 25 May 2023 22:29:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CDE0900002; Thu, 25 May 2023 22:29:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5DE166B0074 for ; Thu, 25 May 2023 22:29:44 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 318D01A0C63 for ; Fri, 26 May 2023 02:29:44 +0000 (UTC) X-FDA: 80830825488.23.FB118DB Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by imf07.hostedemail.com (Postfix) with ESMTP id 1CE9040012 for ; Fri, 26 May 2023 02:29:41 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=Ieid42mO; dmarc=none; spf=pass (imf07.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.44 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685068182; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eFUluCk6Yg3CJh7zCYAWn34AyV3ksw1s+RmFmqdT4VM=; b=jrUeBOPbBjraRwiiJ+E02NvOu1UHaLs07RlDUiKX4yQ8LKnSuvPx9KtlCFYbmSfjegxmq/ CsMbb/wd1krjuaroQ/9hCYt1oqIImkeCmfcVYQiivySVEVDPW1A8W/n2ylphn1SCdCeIPI D2DuhT6YB/M/VIA8gYxS1WyeZUk05N0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=Ieid42mO; dmarc=none; spf=pass (imf07.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.44 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685068182; a=rsa-sha256; cv=none; b=UxR9HB63lLYA2XI1D6YmZHUYUwiaNmzn8qTg7lUKzLU64xY/sP/EF1qzRmwgidXRSDeY2t 4zJPQxj5lWwzDaI2Y/cKLol4hngbOt08evup5yNbi6fFSSVwMWfK5eUp3NbkpuVYq/4CT1 0IoiaOXhkaaqqkMy7XSResms8oznmPU= Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-510db954476so259065a12.0 for ; Thu, 25 May 2023 19:29:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1685068180; x=1687660180; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eFUluCk6Yg3CJh7zCYAWn34AyV3ksw1s+RmFmqdT4VM=; b=Ieid42mOXUdzZxbIYNgLrrStagH1yaiUL7RqhGGSGjoaOffdI4Bu3y4Jfpd6Kvjam+ k/1nt52NIiItCsyE8kAKdpy33LEz7/+zVLLtipntGfqUOUAy7D9POjHN1WUf0D3nnwhC IRaJSV57B3gxXp5hxEwcUEqwi3M+0nVRjAaQw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685068180; x=1687660180; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eFUluCk6Yg3CJh7zCYAWn34AyV3ksw1s+RmFmqdT4VM=; b=X4RQKWsyal8doyHgsEthvkIxpwR7i9dXuITBHXWk+On4BiIkrQV4M0perotfB/HL73 hMOtrJALARD+dUoxNvJqBmWoxEo8DZNwPGxa284Dey9lZsf2p0gRcsgTg8KTwld6V7Xj GpLm5sDcnbQg8s8YB5ZsPTUFK3IS67yqUzaJWJdbsFouVX0mFcgzcUpFF8tFEQ+itv3z T6kvOaf/kk2+fs7o2dJagiW3ka/FbnANgxBjfehZVeQ3reqrtbtwljIP+EKCb+QlpbTG wyTvQaNRbrjZJ3rmHHsRoUwK9ig1pJ6Txp+O/MqkVUPz4HkRYsQITaOUTkZeV1CC7jPh +03Q== X-Gm-Message-State: AC+VfDxjy1DSWCjnHDrdHvmX5Cd3kwjtH/wb4BRCY/VSGmIXS86uFLG4 Thm5aov6JjfKiIKK72DzyupdVMGlnAugAke38io/mhaR X-Google-Smtp-Source: ACHHUZ7op1iqHP89jAL2xFHgtiiqkeRjqFxXxGFd/kmHuZm12xvOagv4mV877fWENU0+XbysfnfaYA== X-Received: by 2002:a17:906:ef06:b0:973:92d4:9f4e with SMTP id f6-20020a170906ef0600b0097392d49f4emr592409ejs.53.1685068180338; Thu, 25 May 2023 19:29:40 -0700 (PDT) Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com. [209.85.208.44]) by smtp.gmail.com with ESMTPSA id g19-20020aa7d1d3000000b0051056dc47e0sm1097740edp.8.2023.05.25.19.29.39 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 May 2023 19:29:40 -0700 (PDT) Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-51440706e59so234313a12.3 for ; Thu, 25 May 2023 19:29:39 -0700 (PDT) X-Received: by 2002:a17:907:d10:b0:96f:d345:d100 with SMTP id gn16-20020a1709070d1000b0096fd345d100mr533983ejc.59.1685068179297; Thu, 25 May 2023 19:29:39 -0700 (PDT) MIME-Version: 1.0 References: <20230525223953.225496-1-dhowells@redhat.com> <20230525223953.225496-3-dhowells@redhat.com> In-Reply-To: <20230525223953.225496-3-dhowells@redhat.com> From: Linus Torvalds Date: Thu, 25 May 2023 19:29:21 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH v2 2/3] mm: Provide a function to get an additional pin on a page To: David Howells Cc: Christoph Hellwig , David Hildenbrand , Jens Axboe , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 1CE9040012 X-Stat-Signature: ctyopdhfdqsz5m7i4hz6wan7yg3drdw4 X-HE-Tag: 1685068181-693835 X-HE-Meta: U2FsdGVkX1814Jh1z7eGw8xqBlBCuO/BgLsLFeQdepu+5hCpgX9K/Ito6+MAOx2Y2k5yKO3XB09/H7qlBfsJul9stGBNU4haItORR6NmPZsNkflgOLJYpd0DCL1zRUpD4v1leroXtxY0pk2Yh2Fw0BkaJAu7xhL8eqZhN/4W4vRNkegSRyQpvlIIrGfxloXRfrJ7Kq0VGhWivTuEXO9wU7gCDbaD3kjjZIjf6MSc4cZc4/ixiyLAcV2/3JlFOoId5irjAmCPavxuGAhs9twAm/qjZbL1snpDizxm7tG8ew0rqG05/f/IqGg32JAqjAJaacHsmmLTLJ27AnmTsgux+mCZU3yw6CXFPhHTHTPkG472+KbpbINIhpWjLv+lsE70BPk3oYaGfQzUTtLxedZTb2e6FzfLvKdruU90Q1KQpA0WVhqUb0gLgMUp1scO4482N7fvfIWUHDebDZBSTAjeNpEJ73fG4tczFINGILB0MmFKE93DB0UJWJ4TLqzQPLZxYYXSfY7e5r9Ucgf56Ww/XLzmo0C08vkTh9Rw8lxnfal88NM1dBa+0TGYg2ZrifR58Md4dT9YAihEfX5sHsFUICmVROer1eeyhnHMEXLGE6L3pWBJpvOwN/7zL1mEXBjqbCE0hlRsABr3egnLv3hhsrUA+TVppIWcb3VjsrRvSmL+ZfCe+v9uwbHvbs2f7JznaaGq/+VqHUoN00YSpsmqWA7Zqahrh36KRaWh/39CxyitbZSiAksIgTlsU7XwtPn0meSnNk857dP2HRfe+NDSWDnIaVGrBRfzw5Wi8DmJ41LQK1CLGgK6igV5gyG39Rkftgb3KhWtw1sAEc1otf7iPzC16ZYOxA93BHbumYmJalMur5Hemmv6snaBpkWFusIEH8pnO7qUePMp+m1qLBTeIhstN55zXU30kNW8UsOc6O5IB+RyvTCIy8WYnL3nYZg95D8TmB+ZxOdlavFg9QF QzLHbh6G FxMZo8GB0LlNtvb7ClATqI1raHnhS1m7KSK5hYpBb4OGGSA/f7IRmMGXPEGbjcNLY4sg7SbEjQU4w1rqLtkt45bFIPTgcccuAHnJg0KAaVuudAuCyOo4VGb0q+j1hKMkJhGuXpf6VauXlUEszwlebLmczaaaIm/n3/LOq2oTJVvk/84aHmPiTyVREFIyKw0ZgHBeufZp1OZmXhh6QDZod+qG/rz7k7MATb6QNdoJpGGnJPyXkrH3RkdALExgK/BAcxaukSYgDGKu638qnmJb2wrauF5Z2PDChhH+rG+o+QwiX1G+2hrRFDFddRsapLtLDLa4LtN7n0I+emCLvcjOqDaQkK+wASz/hrowVglyiZNzf/lbm7e99MfLGXUJUlcF83e5ciBQqbAnD82m0pU5lWPICjVIdK3GPTeqR5GblJ5V19GKOTbe15aG3OqFq0Irzz4RwpF2DPIfnCZBMoIrRQsfOvaii9oBMPEpJ26RunAZQO11PTFuQTYTbfNRl4xF1s3nJxdpLa4I5rikvbodrgJuMmnXnt2tU40M81X9I3IT04YuTF91Y28vKRh+f4f1bQnnY8aRvxPL9KaHP0H3xHrilYQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 25, 2023 at 3:40=E2=80=AFPM David Howells = wrote: > > +void page_get_additional_pin(struct page *page) > +{ > + struct folio *folio =3D page_folio(page); > + > + if (page =3D=3D ZERO_PAGE(0)) > + return; You added that nice "is_zero_folio()", and then you did the above anyway.. Linus