From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94DD9C46CD4 for ; Thu, 28 Dec 2023 00:36:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A55196B006E; Wed, 27 Dec 2023 19:36:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A052B6B0075; Wed, 27 Dec 2023 19:36:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F38E6B0078; Wed, 27 Dec 2023 19:36:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8236E6B006E for ; Wed, 27 Dec 2023 19:36:38 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 54A821A02A6 for ; Thu, 28 Dec 2023 00:36:38 +0000 (UTC) X-FDA: 81614361276.19.0C9522B Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by imf11.hostedemail.com (Postfix) with ESMTP id 52C9340014 for ; Thu, 28 Dec 2023 00:36:36 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b="W/LC6i1K"; dmarc=none; spf=pass (imf11.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.128.46 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703723796; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZuhB8VHwVQmrv2O2PykI3H6Y0tt0rKki08G/rfRh77c=; b=gsHG0EOcV/Efn92qE0JvXvBRekQPQx4eHMEqBDDEHQuXybpCFOXAMqKuiyZWonQRZPfRTh ds9gK9UshhoyJPwaLqtKRVOL1M8/exUffo6BdvGulR5ZzPrXLdnHp6qWW2VZeY+eokh+f1 KP5WW0emmy35Oro0C1hQWKshff8aWe0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b="W/LC6i1K"; dmarc=none; spf=pass (imf11.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.128.46 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703723796; a=rsa-sha256; cv=none; b=aIaCOAP/X72QHpIlVS5NltbNy8hP3w+2HgeQTCi9GEYKUGafJfO9m2Lq9meG9egiKm1eiI nGvhms0oAXtWGf3RFLcoB41DB2SOmh22s+CMKfUj7Qvd+My2T2REddgJzQclAYPm7Kblx9 F5jwORnvZYwvC6ZbKjKZ+WG8IA4Y4jY= Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-40d3c4bfe45so61317105e9.1 for ; Wed, 27 Dec 2023 16:36:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1703723795; x=1704328595; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ZuhB8VHwVQmrv2O2PykI3H6Y0tt0rKki08G/rfRh77c=; b=W/LC6i1KSFlYW1ZzbmXR0LHUiNi47sa6add4sYj1blrC0EAUy2wVi07BUuKI3oBU4X UpWs3aBxmHZbT9euHxSwZCOpx9pzZbxTEI6A2kpCeRUlRUrdxp2SNfe1l0I6UX+PufmJ Aml/ywlz0cN78pz7h80q8Fq8iWyuisJdyqdPM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703723795; x=1704328595; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZuhB8VHwVQmrv2O2PykI3H6Y0tt0rKki08G/rfRh77c=; b=f8DkFvLZM5N+gA4MOqm1OLl0y2Uv6dIlL21pQ8oJC6OE6Tl9563MuvQ4zHez+g9C9a /zRPahPE52wCeP3DUwEWvIf30puRycpZZEWcnvXTTNMbTrTMUzCFOYhoZB7USFqxW+9v Sv9KApLueEX3CeIaUuPYtbPtXYL4J6qtr9MDvMbwp5wyMIvVk1vtAkSUDAMsJ12bT5Cr HJcMEJRnDKngFNGHz4l02egIE/F9uZCY00BHO5hxSXT97em8EfUikXiZLlljKuKsd8LE DGWbMx2LR0Ao1HPxLjFKU+abuY6OtJkCcca0h556YGGjE+qyHCoqUQElUASWxO+BIvYl +Z6A== X-Gm-Message-State: AOJu0YwTNgPB4SpgEPYzjYFaKYaX1UPdBlDAqOoawusFPgMB/wTFNFpI /lishTXw0DFlSZMdsU0UcHsHJxUMVYPLmojVXZu8v8wN71PXPQ== X-Google-Smtp-Source: AGHT+IHP/BibJUV65OLsRJxVyi91h2W+0p5jxFltzJLjjm1NCU0mdL8FHP9vWC7721UIKkRHrNqZMA== X-Received: by 2002:a05:600c:1f10:b0:40d:312f:c444 with SMTP id bd16-20020a05600c1f1000b0040d312fc444mr2512185wmb.348.1703723794627; Wed, 27 Dec 2023 16:36:34 -0800 (PST) Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com. [209.85.218.51]) by smtp.gmail.com with ESMTPSA id n2-20020a170906164200b00a269e651abesm7147954ejd.176.2023.12.27.16.36.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Dec 2023 16:36:33 -0800 (PST) Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a2331e7058aso678138866b.2 for ; Wed, 27 Dec 2023 16:36:33 -0800 (PST) X-Received: by 2002:a17:906:254e:b0:a27:2f11:2928 with SMTP id j14-20020a170906254e00b00a272f112928mr781979ejb.271.1703723793333; Wed, 27 Dec 2023 16:36:33 -0800 (PST) MIME-Version: 1.0 References: <20231227150354.9437b5c792000b8eb22758e9@linux-foundation.org> In-Reply-To: <20231227150354.9437b5c792000b8eb22758e9@linux-foundation.org> From: Linus Torvalds Date: Wed, 27 Dec 2023 16:36:16 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] hotfixes for 6.7 To: Andrew Morton Cc: mm-commits@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 52C9340014 X-Stat-Signature: s7fnpqyeks6ttc5y8fez3uctthzunyje X-Rspam-User: X-HE-Tag: 1703723796-759206 X-HE-Meta: U2FsdGVkX1+FyCuCQSXiByVX7utfAeDN6xLgBuIXCi3CUtGaCbjyAvZFOgeQJe2z8sOtt99g+vds5/ZwvsFudPIpgMWwH+h9PI/ok+waghqebkZPIPh375GcGj7wlXX/xdn8HsoUKU6GcUfcQ2l70zf/xFIUUrg6f+Ks4dX/VziP8Tk36NZ29h3fVMBPSzyCSYMlGtAFHBb/adenOTQD7mXtN84W7QlmKvfX3sEum4L3quA9cYzGXYHnWzH12R3OtPFiw7PpV4/h+RNxxOTABZNsK2jEOZI2koR11cwCX3n1RamPsqfkO5eQIx3+0BR7AheLiHv6P2rAI2eyOOiCoWsDSzN7P3hvifAz2OPVJtkfN78ZJ/rYN6NfgiTICPq3Mx7jeOLitpHUmfwOAcFvwtDoyXrmqGEyePlZobiCmKG4fhpu4qfQseV3n3vXLSla1+xwnUmqJe3QiYwVHTdxsHmW2KDrBl7VVqmcVgnHks+6fi9AzFBKMfwj/33xxg1CJLl1L24QSP4+x5tw/2HruF4SOmXyKTAyaBraW3iGGHOwrbCXncflH83+m0LhwuFFCrIlbL40rd5YMmFj6YUWJoArq8diZ+m7aruPQOp+5khhjGvt7/6xo6HbGNoVqUY0AQAlp4zZEq+mEqIlyNlLzUKFeYzM6Pdpv/TZEK6vvukrKtIln8Z6ZWYg8Zd61+pBYr+lkxvaS77MtzlCrN6CpFLgePSMxxkfBe/+9t2wOf1swzKGzy9Va/WjIRUzF7LFehgo8O96uM7E7HNmK6fiFMbKBUcZin6z3PiEeklP+8s1gNCfP3/Ma/C20FP3TJh1qLPjz3UUton+fInPKThuwwe4/OYjCo6om4+7pdpGYwL0L+oNDuYq2eKTnhBxAy+PwmcmL685V3KE06nOAdZOEZjhoZ0VgbTNOm4DCm3FRty81YS+zAxFKtGykcdEmeSZCTEvH4D+M0csbRsFwej PyIMe3MC IaVCkt9vC1cledNsxo8kQCu9bA2yDSxm+t0yuJDX5aukTGB1MLLlPxoj/c9Nt1obhVLyg30fRDjylSbEs1IwTpJg1+IiVIpGjQcPz8yF4qzooSdRES7i7+B9PXQVSj9HDa4D1zW+nf/i824LPmGtvzVOStJScG/5pV5/2P+ZMNODm8x9k8bjKDVDq3w4AOunxFYwBGj9gJl73OmGhMDyw7tJflPLKB1SGibUC29wizfYaqi0Tp9TWyjaVxMZE+8tpYod3Mp5recEdtS4EnRsrlEClQfos3/eRawSjJAEazdZkZEXJdwsGUsGRhe2Qrclsoyrbbey1czDoyK6oX7hN5QcYua7SAh5vTn+cHnHoOi5SsUaQtdKW6G0v994dkZt1GFPauCJ3yXTkcv0Fsr6RSgaKGPYL8Pje0Xsq+gNHbeLIUMl7kQAodykxF2mnnmnGtSbh6TSb5EVuSh/whzuY3N0wL7zSqyWGlwDEjL2B3qt6fB0DtpKsXBI8kOIfZ6M45xBi7uMJXpFlmPpvHMn/Z30dLkBfJtV6aKWD3+Q1lgfp1GA0qKSy0wYjKb8v8EcY/YySRGcxuE0kBiHWtjyIM9BelTopM5qcQNKY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 27 Dec 2023 at 15:03, Andrew Morton wrote: > > Baokun Li (1): > mm/filemap: avoid buffered read/write race to read inconsistent data Hmm. I wonder if we should have made the i_size_read/write helpers be smp_load_acquire/store_release()? The existing smp_wmb() are almost accidental, and aren't primarily about the inode size, but about the page/folio uptodate bit. I guess they work, but it's all a bit messy. Which might *also* be better off with acquire/release, but we don't have those bitops, I guess. Oh well. Linus