From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84E68C4338F for ; Tue, 24 Aug 2021 19:25:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 33E176138B for ; Tue, 24 Aug 2021 19:25:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 33E176138B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id A6AEB6B006C; Tue, 24 Aug 2021 15:25:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A1B7B6B0071; Tue, 24 Aug 2021 15:25:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E36A8D0001; Tue, 24 Aug 2021 15:25:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0140.hostedemail.com [216.40.44.140]) by kanga.kvack.org (Postfix) with ESMTP id 703F66B006C for ; Tue, 24 Aug 2021 15:25:34 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 253F118132D08 for ; Tue, 24 Aug 2021 19:25:34 +0000 (UTC) X-FDA: 78510953388.40.04BD8FD Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf15.hostedemail.com (Postfix) with ESMTP id D7C36D0000A7 for ; Tue, 24 Aug 2021 19:25:33 +0000 (UTC) Received: by mail-lf1-f54.google.com with SMTP id r9so47796314lfn.3 for ; Tue, 24 Aug 2021 12:25:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UZJyYVORrCiAyJfqjWHoPU9PIFZ88DitsmtYgIA7rQ4=; b=KtXnGitBkvxfOgqJRNuwi+8709mbnBLpqTuREEhVvpbMPwWaovy2KY9NAyJLvsfAEZ 1V1wAe8ouRjxf9LTndxeO7Z+UHxlIm0NFECFKbrxrI2kT1jgXK9GwPGvsFC73in9KpWb 1oiPXuvWItsl7evaUnfeF/dDHy6N+uJbuNkFQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UZJyYVORrCiAyJfqjWHoPU9PIFZ88DitsmtYgIA7rQ4=; b=MJJQcBcZHXhTKQmZn5sPkc3XsaN0hIGUdJBroJmUiou8ofM9Y/W6LjJ1RfNzj54psO pdEb8/YTnGOOfVDmZCfBMIzlFRm2ygo/z6u/xfp6I50GDRg4FvH+Yc69CRB/s5fZA1Pe KyOyMdjFIGoBCvlBXXjSUFBRYHQQyIVzrQT+0wHbLjgzR7MhKbtAm/IfWBH2x0oZvnZf dNRwQbheLOhhBxarzV96Bz9OnFEm5/IaAkEkepv/z1JGEY7yokieWNWCQm/+r84TNGz5 T2FdLWEu/TEBOAtPrW7zF1oK4rg+3jI3HJdaIrhhrXzLx/QtEkJ0K3ILM2VxRO2chI8j Dewg== X-Gm-Message-State: AOAM533GF5v9PwiEy3eNCuMYHge3xDI/4imvZmtgzInd6EW4hs3LeK/S lHGI/wmYNg0eAGz4u1Wj0ZZ4+xHNQDHOFVDw X-Google-Smtp-Source: ABdhPJwXe+AbDip2jpQiDBz4lTezoT0q6O3e53i3BjvOo7r9gcjvKVuWGI++fYOY9FGKAN33pweWwQ== X-Received: by 2002:a05:6512:3d91:: with SMTP id k17mr29991653lfv.166.1629833132199; Tue, 24 Aug 2021 12:25:32 -0700 (PDT) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com. [209.85.167.54]) by smtp.gmail.com with ESMTPSA id u24sm658324ljg.64.2021.08.24.12.25.31 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Aug 2021 12:25:31 -0700 (PDT) Received: by mail-lf1-f54.google.com with SMTP id r9so47796226lfn.3 for ; Tue, 24 Aug 2021 12:25:31 -0700 (PDT) X-Received: by 2002:ac2:4da5:: with SMTP id h5mr16581349lfe.40.1629833131285; Tue, 24 Aug 2021 12:25:31 -0700 (PDT) MIME-Version: 1.0 References: <1957060.1629820467@warthog.procyon.org.uk> <1966106.1629832273@warthog.procyon.org.uk> In-Reply-To: <1966106.1629832273@warthog.procyon.org.uk> From: Linus Torvalds Date: Tue, 24 Aug 2021 12:25:15 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] Memory folios for v5.15 To: David Howells Cc: Matthew Wilcox , Johannes Weiner , Linux-MM , linux-fsdevel , Linux Kernel Mailing List , Andrew Morton Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=KtXnGitB; dmarc=none; spf=pass (imf15.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.54 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D7C36D0000A7 X-Stat-Signature: 4p9oj6x18mkjukkoroeyptb7f31rjipr X-HE-Tag: 1629833133-628256 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 24, 2021 at 12:11 PM David Howells wrote: > > "page_group"? I would suggest "pgroup", but that's already taken. Maybe > "page_set" with "pset" as a shorthand pointer name. Or "struct pset/pgset"? Please don't do the "shorthand" thing. Names like "pset" and "pgroup" are pure and utter garbage, and make no sense and describe nothing at all. If you want a pointer name and don't need a descriptive name because there is no ambiguity, you might as well just use 'p'. And if you want to make it clear that it's a collection of pages, you might as well use "pages". Variable naming is one thing, and tere's nothing wrong with variable names like 'i', 'p' and 'pages'. The variable name should come from the context, and 'a' and 'b' can make perfect sense (and 'new' and 'old' can be very good names that clarify what the usage is - C++ people can go pound sand, they mis-designed the language keywords). But the *type* name should describe the type, and it sure shouldn't be anything like pset/pgroup. Something like "page_group" or "pageset" sound reasonable to me as type names. Linus