From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02120C43467 for ; Thu, 15 Oct 2020 02:48:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 471CB22257 for ; Thu, 15 Oct 2020 02:48:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="H7wKZzmk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 471CB22257 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BBB076B0062; Wed, 14 Oct 2020 22:48:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B69E36B0068; Wed, 14 Oct 2020 22:48:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A599A6B006E; Wed, 14 Oct 2020 22:48:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0238.hostedemail.com [216.40.44.238]) by kanga.kvack.org (Postfix) with ESMTP id 7B1DE6B0062 for ; Wed, 14 Oct 2020 22:48:47 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 065EB180AD811 for ; Thu, 15 Oct 2020 02:48:47 +0000 (UTC) X-FDA: 77372627094.10.shock91_3b01f4527211 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id D66D616A07E for ; Thu, 15 Oct 2020 02:48:46 +0000 (UTC) X-HE-Tag: shock91_3b01f4527211 X-Filterd-Recvd-Size: 3952 Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Thu, 15 Oct 2020 02:48:46 +0000 (UTC) Received: by mail-lf1-f66.google.com with SMTP id l28so1741684lfp.10 for ; Wed, 14 Oct 2020 19:48:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sPmN39XMdhH/ZRzEWbdWRJa4YGst6YX4ITt4ggC9sgk=; b=H7wKZzmknLGSwJX8VVMAlFL2hjitpKjoF2M0l3LGbtFcQhq6fmjQGIu0Mb77YCa8qb bpr2OddXeAy1ASmwtlmu8twK2w5a/a1VchvtD/FmunIJolvudip8ACBxLYa7jJ06ix40 ZpAiCTTlJ3OI59TEjqTICKyQyumqI82mBPYIU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sPmN39XMdhH/ZRzEWbdWRJa4YGst6YX4ITt4ggC9sgk=; b=iaH2uXO2ejQY9WQOmeZ+8+7m+VFjSexWWit3X3Qqdp4nreOyJspw6HHJoCEUMwOoXl gjkPkQIbcGjI43UZX1iMq5vg+9tpNHttfap4+rncOmyBmNa9ee1WlIXlyFircGXY2Ghr kSEdT5vnxhx5TOMWx9XRyhUp+iRLQcam5LUP0B784vyChgdIXYVS46NMvDrrS0/4gKMz SkM6SdG57i/wn/264ADMJwJwVClf0bMukT+tBpYdUWGYMV69oS3V7UXVHnGhphVpDQMS /OdUwXJFmr1eh3+D82mQD+wXBSG+2vPFyQo7DAMR4b+Dbk5ibonb7KHvVUtYd/8N5clu 866Q== X-Gm-Message-State: AOAM5325/vkRIcrcUAZmn4KwU3OPdIkEsIQIT+4lEPORw5ZUnGXWRvmS jbwrhHk87HlY/TKdhC72u9msb6/JFwPVVQ== X-Google-Smtp-Source: ABdhPJxIgry18UTnHWHpOo7bI2iOtW6va7UqTHZK2sQ9ubzIjn5/HJOsGYPTAKwV+elsQSuKMNVNXg== X-Received: by 2002:a19:4c05:: with SMTP id z5mr111258lfa.506.1602730124509; Wed, 14 Oct 2020 19:48:44 -0700 (PDT) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com. [209.85.167.41]) by smtp.gmail.com with ESMTPSA id s1sm463528lfs.66.2020.10.14.19.48.42 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Oct 2020 19:48:42 -0700 (PDT) Received: by mail-lf1-f41.google.com with SMTP id z2so1808475lfr.1 for ; Wed, 14 Oct 2020 19:48:42 -0700 (PDT) X-Received: by 2002:a19:4815:: with SMTP id v21mr336886lfa.603.1602730121761; Wed, 14 Oct 2020 19:48:41 -0700 (PDT) MIME-Version: 1.0 References: <160272187483.913987.4254237066433242737.stgit@magnolia> In-Reply-To: <160272187483.913987.4254237066433242737.stgit@magnolia> From: Linus Torvalds Date: Wed, 14 Oct 2020 19:48:25 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/2] vfs: move the clone/dedupe/remap helpers to a single file To: "Darrick J. Wong" Cc: Andrew Morton , Al Viro , Linux-MM , Linux Kernel Mailing List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 14, 2020 at 5:31 PM Darrick J. Wong wrote: > > So, I have a few questions, particularly for Al, Andrew, and Linus: > > (1) Do you find this reorganizing acceptable? I don't see a problem. > (3) Can I just grab the copyrights from mm/filemap.c? Or fs/read_write.c? > Or something entirely different? Heh. Those copyright notices look pretty old, and I'm not sure how much - if anything - I had to do with the remap helpers. I suspect just a // SPDX-License-Identifier: GPL-2.0-only is fine, with no need to try to drag along any other copyright notice history from those two files. Linus