From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E44DEB64D9 for ; Thu, 29 Jun 2023 16:42:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 14B528D0002; Thu, 29 Jun 2023 12:42:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D4CF8D0001; Thu, 29 Jun 2023 12:42:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E91808D0002; Thu, 29 Jun 2023 12:42:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D5DCB8D0001 for ; Thu, 29 Jun 2023 12:42:35 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AE97C80496 for ; Thu, 29 Jun 2023 16:42:35 +0000 (UTC) X-FDA: 80956353870.12.9A81E77 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf16.hostedemail.com (Postfix) with ESMTP id 94F3018001A for ; Thu, 29 Jun 2023 16:42:33 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=KLEnhdgt; dmarc=none; spf=pass (imf16.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.42 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688056953; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5w9ol53Pbytsh9JJtWN5s3IG7GIlT/ijcbnJWBLshdM=; b=AzTLn9JJtVoexsMq929j/jtkhzLZW63klvYDlY+vH85U6tr9QRKNUxBqXmzE4mL+bFwLlo hcD+45epVhi6KOi5q0VR3YRH+Utf4yBkAsxjb8gaOQ6dCTiM4Zwuxo/VeIjH82lWXVis35 9bNTqSdC5RUWXebVjx8bXrSmpBE0C4o= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=KLEnhdgt; dmarc=none; spf=pass (imf16.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.42 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688056953; a=rsa-sha256; cv=none; b=6TQn8KB2YwOhYT366/kTzBTBHcl1QjwPCXvvXXqHhX5x0od3brarO39NJfPhynb992E1Y8 3u8STgwsbxtN10xo6PcnlS/sPhKjMeySZGj2jDhWqKRAH+FKTnk84mKiaO1llHG7H9xk+0 uYP7MVITMvDysHl6khs0dRhPc1FGrL8= Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-51a52a7d859so1538648a12.0 for ; Thu, 29 Jun 2023 09:42:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1688056951; x=1690648951; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5w9ol53Pbytsh9JJtWN5s3IG7GIlT/ijcbnJWBLshdM=; b=KLEnhdgtu1c8kM62lKXQjj5JgvBYesh4er2kkookEOPNPvUhB+y6XBGIpsThY4Oz7c RqoxMNfBA/d6bI/EI60+uuUD06gTkpYEAI5h5V8fB0cCJJXD/2n7qzNNP/cDrK/lWzxu qg3NX0vGeSu/SOth9o5WfCH+j1hi/gtxz9+Jg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688056951; x=1690648951; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5w9ol53Pbytsh9JJtWN5s3IG7GIlT/ijcbnJWBLshdM=; b=dBs27EXTcAQxdyAApUGNG3c+jOPHzNT7IyaozXecSI4PXcYpLttKnnmppm77EJ/YOT CNW2Twqo/RyLXqvfceERD9raiv/aztH6dxKnUiMHIc2HnawXlLjHWAin5jJqxTd8s9Tk vtcbTd9eHdqS3PCTZRaU8WzaxXE1o5+lDiE6jqAD6y2VZWz1b0eRjCRPb+kWsUuSfmDW k2gZplPROPhzPZxCWWIJNO30lIZyiky0eqC+ByMItKwxogfIPWWRCQ1F/Xqa0lYUvCYm 3D6pvFKNyBAHPwiFrCGDcXfJOB0XRmBp3Jjs3Zs4n8MujhZt90gx6cy92o17JdzKADbD 4X3w== X-Gm-Message-State: AC+VfDxQRcOAFtbcS1UzxXfoENoCp5DkXID5vTBdswuiEio3xCQTq2r7 qTj0AfMC5kIPJPDkTgR4/zeG1X63yy1nYjv265xfcrWm X-Google-Smtp-Source: ACHHUZ794ArMZGS5sSpctEYzRrgtNYg/BxUtVvwRy/ySEfyOjBLM94p0Jndva55b8OzUogOvHx4kqQ== X-Received: by 2002:a17:907:3eaa:b0:989:6749:d61 with SMTP id hs42-20020a1709073eaa00b0098967490d61mr5044905ejc.19.1688056951687; Thu, 29 Jun 2023 09:42:31 -0700 (PDT) Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com. [209.85.208.47]) by smtp.gmail.com with ESMTPSA id lh22-20020a170906f8d600b0098282bb8effsm7032352ejb.196.2023.06.29.09.42.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jun 2023 09:42:30 -0700 (PDT) Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-51dd0205b2cso1516616a12.1 for ; Thu, 29 Jun 2023 09:42:30 -0700 (PDT) X-Received: by 2002:aa7:d94f:0:b0:51d:a2d9:85a3 with SMTP id l15-20020aa7d94f000000b0051da2d985a3mr478016eds.8.1688056949878; Thu, 29 Jun 2023 09:42:29 -0700 (PDT) MIME-Version: 1.0 References: <20230607053135.2087354-1-stevensd@google.com> <8ef3ee-ba41-8e9e-4453-73736ff27783@google.com> In-Reply-To: From: Linus Torvalds Date: Thu, 29 Jun 2023 09:42:13 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH hotfix] mm/khugepaged: fix regression in collapse_file() To: Hugh Dickins Cc: Andrew Morton , Matthew Wilcox , David Stevens , Peter Xu , "Kirill A . Shutemov" , Yang Shi , David Hildenbrand , Jiaqi Yan , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 94F3018001A X-Stat-Signature: 6xqbaymx9cpm5yqyki8d6squcr6pgw3z X-HE-Tag: 1688056953-716234 X-HE-Meta: U2FsdGVkX1+M71J0boHKkpZkZ9ItK+gm/Y/55hylBoSMSCLBe3/PO2e6rEyf+gJQAvnjGWo5luCS661LEICvgiqoMb3qGJjvJORYg2SaKybdk9BomMuubq/Kj9sMxViXi0g5VWTgjRYKBM0jq+cAMSBkVAnJnzQzMoiLDd7uqCZ7jR65u1sez6fMFnm58ASr77QNcLzB/Eml/oXUtdO6gjmzPdV4Si97s300K/P0wbOidZqhdD0LtZqrWnj+NWNW5ZnIZLnc/a4Z59q2IlEaLdEF2eBbNdACDoZqwwUp3cNiq6F+gy7OAI6xjTUPxW0lZP3qwsqw15z0kLzF6yUDbqaOkXZoQmyFZGR7HeqvC4bnjwKoZuj1AWhgaFS3YDyoYsYsWWGHtvD6+RH1WlZhpbJhy9DG3nIlqlE88RFqwSLD73n4rnt/YzzShNStgE/HzFSVAi3GYYJWCKdaWNVhDqwGcTKF2+kjR5jSznsU1eK0x+cH+p42nhpqCb0OLFw/ildINbKG+YUVJB/q2QNuZ6WKQh84xUMhCwIi7jjgj0smDkvkvLuK3dkXCz7BnT5xt3k4FFpqZb7pco7UoytdsYhmn8pxT4IW8490n17j/pK12E2yobl0LwzygbSyokyB17XXryIKRMvNTVNgBHAwSMKABhRBNfJUa/4wuc6SoPfylp/7YCT5KG1KHSrcfZTjJnsbNqbje+ooVkJcZjq2qICv5VM4FyF40jxIAxvgTaGQNT77W0UYKmuoIrjG7/EuWwFCBPQnzdhjSLgLwUUoWHYIAVqxOgUeJc72989TVZm6zd+9uxDCq+AWlv3keiXALK4nPtPk8HUdsJM4QATIE0CLFsM/pMb3L6Z6g/w9Khsk14zaxR1EH4GHbRUt7y6v0zAaTgihPrLScI0ugukjgRiNYSUnyH1ijOcJdbpvaJU18BaF/pmiMvIzyYAxWyJ017MzJ3QZNcuv1WkigVC C/JJPfKy DeVrCd5mIzvld6LRWHJnsz9dThKnTmaU6Qd4Cuy+tfSP87u9s3fkgoSoh0he4B4SJza1mV9fzQMDurzEq3ZN0C3gmH/B3jhC5fGI/7HcuFe7tEaa7M6tfF3yQVr+AYIg2WX7dHO3ELRi1uuz+hB5U4wGLmwagEX7nxtYKwdbPpMjsXWOhyJj1JyWVmb0Ixd3dXIANSgx9EXUkOxNNzCMGtt6so2NobT2uViZvMxouqww4H0Sdyh7nhHiMPDSUqylBE+ztG+QS4U0+i+7Zh6orQR93tZBF4E4LmU6I+XDfGvK76e5ZIb/XxfcQr2ey+Es1ZhSoDHv3MyRfaLoqg/8ZQSfkqZhZU33vN6BZFm2gv+77VybxZCadBDE+XN/frYBFXovCpxXTTnI1vrBZB3wUOvojnK84VoKrSql4hpULpwPnhgWGI1rRaDIKhCbqIJ/t51QHD8DrCVqxVO4c5FKLi+x4yGsTXqGpS3/NBBz2Q40m2Z2IwTOTsnnRQaheTh6o2LJLtkYm0iDh/6hKREAMt7qjSd7XCSd/9thIypAAhFpN17xYK1fzs763TXwxcdHY8HZHhpP6jJ+P7o0S0ztC5I5NHA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 28 Jun 2023 at 21:31, Hugh Dickins wrote: > > There is no xas_pause(&xas) in collapse_file()'s main loop, at the points > where it does xas_unlock_irq(&xas) and then continues. Thanks for reminding me. Now applied, Linus