From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9D23C28B2F for ; Sat, 15 Mar 2025 19:06:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B3F4280004; Sat, 15 Mar 2025 15:06:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 36341280002; Sat, 15 Mar 2025 15:06:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 204F8280004; Sat, 15 Mar 2025 15:06:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0262A280002 for ; Sat, 15 Mar 2025 15:06:48 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BCA508010A for ; Sat, 15 Mar 2025 19:06:48 +0000 (UTC) X-FDA: 83224717296.03.D317690 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by imf25.hostedemail.com (Postfix) with ESMTP id 875A6A0011 for ; Sat, 15 Mar 2025 19:06:46 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=cbqRKcJj; dmarc=none; spf=pass (imf25.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.42 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742065606; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t7QSyiK4gltAHsc9Nc3s5gKYE4gQQxsJ4Lx8cwiVysg=; b=g4nhNz8ZZjWTfoTJKT3lJt/hrQ7GEeZvbX7q6xVfqxYWtEGZvmzzIajFIoGOwpKlEPSYKz rn8YIbm01T+cYdwrgu5e8fwiTAX9KsqoiqWhzYBrWrB6RVoa7WbqBLIH3h0rxfcsjt2Ply tC2ohI3Gj/l8aCaG0vuhrPt2PYCHlZY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742065606; a=rsa-sha256; cv=none; b=ybH2XmJNTIZD56Bk3rizNv/mMOI5Wy41UBGWlvT4rA8CeEyMDAWThSO+thD5JkeUh0rFHA eZElhLBky7qseyfLR6WVVq/dTr2KaYh4OLs+lTztqYf8pPFr42f/15thygE5GhonoAMcY0 6Ap0fg13lfjSmUuUyzWWgRs8aSEavWI= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=cbqRKcJj; dmarc=none; spf=pass (imf25.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.42 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-ac2a9a74d9cso648840466b.1 for ; Sat, 15 Mar 2025 12:06:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1742065605; x=1742670405; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=t7QSyiK4gltAHsc9Nc3s5gKYE4gQQxsJ4Lx8cwiVysg=; b=cbqRKcJjDBfS15CsqjIEb8dBri7x/p1am+BJaL9XpbJksAjydBvGb/K7v+8nwB1pct gBis/J7Vg1C738e+yUo0XceDXGv4wTmr42nXyxLJv23TPgUy2TS/SP5YbvBselIfovnZ Gxb/zeRRcabX9gjQFkhqd595pitHk6tI+cJsw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742065605; x=1742670405; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=t7QSyiK4gltAHsc9Nc3s5gKYE4gQQxsJ4Lx8cwiVysg=; b=Q1xPk0gS9HuSpWQEXuNGpS5ah4H40eoRvHfzhTs9QIvf+SLHOLzigqoIingpSqTxNZ N1Y3yx+ACVB2YdcDsr30LuuiQyQJPM4JdBDRoBQghuxcmRvw+7nnhviRXyDzd2p3xT0Q MNCV5HxZCUK2Wkpkt2g5wuOP2IiVpugdZNRo/mpwChhszEfq1DO+qb1MimVZB26ZewzX tz9irGWxRMCPReg3eqFwp4joyoFbDPFkPWpSOjog74hHUhwrDuYceCWdu7WpLyNe104i EBBjhrA3jyRzaUgx5IriYwP4CAbgc7lr7FG3C0MhQXPSKh/x6OjmTyHxqW8YwJGz2o14 UIcw== X-Forwarded-Encrypted: i=1; AJvYcCXnZHjHVP5bOXI3+6xlb8yYWzZpryMFOsJBq41TPtnqgj9tf7Ho/kdxU3aFy2/K8AIjHke7NY8g+w==@kvack.org X-Gm-Message-State: AOJu0YxIUTAY0fdCo8mFMyz1Jw+gkBxT+P/JydTnrrQuIB5uuhfrrGe8 xfl9qsRpwGvEDBsdO/O0+uq6GlAebUew+WTJsoyxH1UHQ6xS1cBbcaZe2WMoAduM3fUrL4/jfIe VRG8= X-Gm-Gg: ASbGncuGgAEuZXPIvKiSZtihfZZY7Awy2xGGYAcBzg4yJPx4ZcmS3+1ZM0UanUGZlPL UZT0XZpaOq7xSCazOx4LgDgQAQ57gbjfVunFfzBvXDvj6UqnzfNL0rbFNCvJShfRWDfWxwcFmxr e54m9wATrIKdi2ZOggItB5+QtytsS0mg+N2029/fTMfRFoh462usKQC1avKYjlqwm0zLW18Pf8A 7rCcEO+NMjBFY8156z3ws3vH1m2RlxkyrHOdhNyDT6n48C0w5ftl0pr2TWPK+G1UEjYx8YBdJcy /AK4oHBg9HJsPkUYkxtVMhXiwJcUxIEaKP6VwWSqkJcZiwfpz/QOZCaew2W2MDB5ItcF0MZ01CM 278MGQVZOURZ0pGOt6dM= X-Google-Smtp-Source: AGHT+IEdSx8ASltPKetN5e1afMy5Jn0czLc+M8UCvsuYm7awURkKdsHqGJui9A04s0FAVr5uL5aPag== X-Received: by 2002:a17:907:d92:b0:abf:8f56:fe76 with SMTP id a640c23a62f3a-ac3301e8dc2mr743282966b.25.1742065604592; Sat, 15 Mar 2025 12:06:44 -0700 (PDT) Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com. [209.85.208.42]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac3149cf219sm403064766b.88.2025.03.15.12.06.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 Mar 2025 12:06:43 -0700 (PDT) Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5e6167d0536so5860405a12.1 for ; Sat, 15 Mar 2025 12:06:43 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCW0lRYS1ZS4ABk2PVU92ZTUjW9HyRZMN+JGsXQj2DZSd57x2i3k5wcY8UOR+vDhdYB60RC/P2zDBQ==@kvack.org X-Received: by 2002:a05:6402:51cb:b0:5e5:35d1:87d with SMTP id 4fb4d7f45d1cf-5e8a012db0emr7263232a12.20.1742065603164; Sat, 15 Mar 2025 12:06:43 -0700 (PDT) MIME-Version: 1.0 References: <20250315025852.it.568-kees@kernel.org> <20250315031550.473587-2-kees@kernel.org> <202503151141.786736B85B@keescook> In-Reply-To: <202503151141.786736B85B@keescook> From: Linus Torvalds Date: Sat, 15 Mar 2025 09:06:32 -1000 X-Gmail-Original-Message-ID: X-Gm-Features: AQ5f1JozV0P0lbN4BwuSspsfnfrTvM8C1limqKntuHe_ynuRti3Jh4PmTFRofj8 Message-ID: Subject: Re: [PATCH v4 2/2] slab: Introduce kmalloc_obj() and family To: Kees Cook Cc: Vlastimil Babka , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Gustavo A . R . Silva" , Bill Wendling , Justin Stitt , Jann Horn , Przemek Kitszel , Marco Elver , Greg Kroah-Hartman , Sasha Levin , linux-mm@kvack.org, Miguel Ojeda , Nathan Chancellor , Peter Zijlstra , Nick Desaulniers , Jonathan Corbet , Jakub Kicinski , Yafang Shao , Tony Ambardar , Alexander Lobakin , Jan Hendrik Farr , Alexander Potapenko Content-Type: multipart/alternative; boundary="00000000000073e254063066413c" X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 875A6A0011 X-Stat-Signature: xun5podbrefq777n5x1te5oy71746kd7 X-HE-Tag: 1742065606-859187 X-HE-Meta: U2FsdGVkX1+0XtsQls255cQAb+/l7YkblmeMEglmBqtE4DpBBZI4TN7arTDFU839uudRtii5Z6toOX7XPI5ZcK1lzEBH0Z8dMs3dOq/Ynjy/8Nf2hlbMTZKFUSaBa6O4Qzu3hEcTxe7v5xFgh5KbnZQx2O/MaAR48ClPwucJq73BpVdz/9CRnF6Z3ZZBKw1RVtauiwhBxpyrbYbGAQ13IT0I7ohNuzUsQ/e/jzGjBHRFfJVsXc80xXmn9QRLYUb8ng/XlaDO+2kkhEp8IUcWjpAUWZRsFIuEYbmygixKWx6RmlDIAt/t69n9hBmBR/5USkSHwuKtQMsTExSpM4ou8iCx5I+XX5QZC1dzJkaPa0sV/9GOxm0MUcDUkoQuy4l2Y+1xubHw9h1Cyp3/jBZ6KKauhxRbuDQR/nTt2XN2CiQlxQr29ywU7d2MK/fA7MTeSYRrUN8JiPS99NUGmzk5Y7h1M5u5/WnR9kqL8f3kNyDi3zmidXHoYt/OKjftsNydsPwe0/BtypzjAMsxXO5ezSOTOJIG9OMLHEfQkdnmMXN4aZipM8Sxsm2/foWmx8bLTyZGVISurFFCtAvB+CcpP5SRXeT3SiiOgyymIhqREFzry2JWov0JxyyzGC9j9oKcBLfB9wYYrrDQmynv4Guk18obtKYnX6sHS7CVL22wT5UmY6mVwRjgV4Q4lI57Kar+QK3IRnymcS6z8Ua63cbKEmGX6nuslwIJcUmTxrsRiiPVImpOHJAZuWN3m5tLIGCwsyLkZw2lqKqiLvKdzokgbzwRAAhvN1tO0bxezMAbSUG5CxihppSoJ+AFN9NV3fjttnfWe8zxvm4XJwhdPwKk8gsatD7qqBjDmnpJoVQODO1vtB5bRrL2ACCN4Fj2qmYC4URVwlKCU0deX3zO0ma5vXdT44nUyeTuOovNkjSQLOVwhgLQabKXKy0+HJ0HiCWiDxDdwGBveCxn3LOR93D OZCuyCYU iIapi3GSDyDjPKjKvVMFHPolnCmk1iofnxTFqtMC4vX/XhcZwni9innnyMg11JQUrGUSBaXsnDuVvn3kdlI05orIzK9wOFQ+BalI2A+gzWSXqpTnMyeZC9FbKVES4OyAZW6RJML1NygqHb1NsWhhKpJsHkyxY4Sp/aPm1VxC0oAbm6pu4tJ48GWjjC4pvHI8YiVeeBOWEIfNhYlQb2++7b7TZ+QNPIv9RuFAELt+/uVxeVlnXFir0GO91Vtip2EKJh4Tv6f15+FHvgxMLjv6qcD4dOmr/Qkejx4B9esL0TYh0As8VpRsMOCEy3TaXyAvsw+gIgPmxT408utYBWhGaM+1+yfBLYJLKyn4rERHp0U2V3h3Sva23VJ0V0abcj5g+4IvCvKUP1ALhcee+tqe/BZWeQH4RhsA3skCsQB2kgz9nLXNDq3wXIrN3PDhwY0uQNxqqJLu1wBDfsN3dkv44/AMMpcu+/h0jqTPGxhLS/JHL/e2zVjGlYXWAjKTYBTsa02VucVdr4i4Q7M25zQ8b1e7kGHxm0WuslOH85qms0irpJpj5zGyrsw9O9ONEx5hd6WB5Tc0FJD2zHbY9dTcerAXDjLbF1Ilj29c6V4q9qrhG9AWx6jWqIDMhADQv54Cex0k2/SpPgUzLcpTFFKj751kf4qx243L7Vc4iUIh/+cPnBtMjOCdikdlqGEjpVv/PfG6pZvUruRcPrmieoiXV8dhGrD9z1Hh8T3HWx/UOyErcjggNeSxngTwKZkrZJr0KshJ2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --00000000000073e254063066413c Content-Type: text/plain; charset="UTF-8" [ Sorry, on mobile now, so html crud and no lists ] On Sat, Mar 15, 2025, 08:56 Kees Cook wrote: > > What about making the redundant information the type/var itself instead > of just the size info of the existing API? For example: > > ptr = kmalloc_obj(ptr, GFP_KERNEL); > Yes, using "sizeof" and "typeof" on that first argument (for the malloc and then the final cast, respectively) sounds like a fine interface, and it's still obviously visually an assignment. I think we already have some interfaces like this, I have no objections to that pattern. Linus --00000000000073e254063066413c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
[ Sorry, on mobile now, so html crud and no lists ]<= br>
On Sat, Mar 15, 2025, 08:56 Kees Cook <kees@kernel.org> wrote:

What about making the redundant information the type/var itself instead
of just the size info of the existing API? For example:

=C2=A0 =C2=A0 =C2=A0 =C2=A0 ptr =3D kmalloc_obj(ptr, GFP_KERNEL);


=
Yes, using "sizeof" and "typeof" on t= hat first argument (for the malloc and then the final cast, respectively) s= ounds like a fine interface, and it's still obviously visually an assig= nment.

I think we alread= y have some interfaces like this, I have no objections to that pattern.=C2= =A0

=C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0Linus
--00000000000073e254063066413c--