From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E9EDC433F5 for ; Mon, 25 Apr 2022 21:42:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3D2B6B0078; Mon, 25 Apr 2022 17:42:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9ED176B007E; Mon, 25 Apr 2022 17:42:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B56A6B0080; Mon, 25 Apr 2022 17:42:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 7C6B56B0078 for ; Mon, 25 Apr 2022 17:42:54 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 556F881D02 for ; Mon, 25 Apr 2022 21:42:54 +0000 (UTC) X-FDA: 79396726668.21.C95C7D1 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by imf07.hostedemail.com (Postfix) with ESMTP id 2213540041 for ; Mon, 25 Apr 2022 21:42:51 +0000 (UTC) Received: by mail-lj1-f175.google.com with SMTP id 16so4397692lju.13 for ; Mon, 25 Apr 2022 14:42:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=J0ON/l2oodv3sNlP+eHVo6ZPpiqCxnVVyYN++iumNjA=; b=Fbz20CF4Jj2RaIdFgpKFZNrAzaKTxj2Uv1lUdUtavR82B8XjNHdJlqKRYFj8J5sYnH 2a+cy65W/7lJaACwuKUGno6crPpRa3JpDQ/3evU6c5XeZIM8JF/489oyyF9AR5CR/faW UkPxO4Xj9bmhWF8R8j+SJ7JRENzCLryJSbSxQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=J0ON/l2oodv3sNlP+eHVo6ZPpiqCxnVVyYN++iumNjA=; b=hIj+4HMWuz9FENUDGssAQdRpgSJl79PGUThQIvu5VMdSiqgW6VmJX3CFwLwUWavoRt NEwYbSXASgmKnZh/P+x9VDZSZm7h/CyP3XDvqjHB2lQmu3Gvj3d9+ivGhgr4GZbPhyCO qWLr7x9cmOuuE5U1BhnNyqx5sHfSBBnsohFiYlqzJcEaC04tOw8gakrSdvx+PhoC+6/A tgUJd6DF0BjZLHbJAxdL+bIWFjLRQEFDaCTJIATZcIhF0dxSbNJC3gbaTe2aF3aqJWRs ILS9y6IsxElFrEUvIT03onL+2UF8c/eYhjvK9WeI0wasB78uZOa7lymk9VxBd+amhTkm Or5A== X-Gm-Message-State: AOAM531ZZ9aNSTfkkngMgvWigKRk5yVE37bryVKlrHw2qUbKOTVqOHdI R9z1+FgIFAFy/o/HU+5lzvHaZ/JSuPsFC2SH X-Google-Smtp-Source: ABdhPJzNcvm8VxqtcUC3Z1IMbrvu/LAFGjqMj2i5LOM8IRiyqlH/elwXJCIBSlYMLZfFyumD0XFfOQ== X-Received: by 2002:a2e:165c:0:b0:24f:8c7:d235 with SMTP id 28-20020a2e165c000000b0024f08c7d235mr7461968ljw.449.1650922971917; Mon, 25 Apr 2022 14:42:51 -0700 (PDT) Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com. [209.85.208.176]) by smtp.gmail.com with ESMTPSA id t25-20020a2e9c59000000b0024af7b8fac2sm1322409ljj.6.2022.04.25.14.42.50 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Apr 2022 14:42:51 -0700 (PDT) Received: by mail-lj1-f176.google.com with SMTP id q185so10345535ljb.5 for ; Mon, 25 Apr 2022 14:42:50 -0700 (PDT) X-Received: by 2002:a2e:8245:0:b0:24b:48b1:a1ab with SMTP id j5-20020a2e8245000000b0024b48b1a1abmr12172414ljh.152.1650922970684; Mon, 25 Apr 2022 14:42:50 -0700 (PDT) MIME-Version: 1.0 References: <20220425142706.23e6bea1d5bfdd944e33bc96@linux-foundation.org> In-Reply-To: <20220425142706.23e6bea1d5bfdd944e33bc96@linux-foundation.org> From: Linus Torvalds Date: Mon, 25 Apr 2022 14:42:34 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Linux 5.18-rc4 To: Andrew Morton Cc: Sudip Mukherjee , Linux Kernel Mailing List , Linux-MM , Song Liu Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 2213540041 X-Stat-Signature: xc6j7984y7by75rds97tzbekzxqxazdj X-Rspam-User: Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=Fbz20CF4; spf=pass (imf07.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.175 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-HE-Tag: 1650922971-876065 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 25, 2022 at 2:27 PM Andrew Morton wrote: > > From: Andrew Morton > Subject: mm/nommu.c: provide vmalloc_huge() for CONFIG_MMU=n Note, should already be fixed differently (with an alias) by https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0fc74d820a012550be006ba82dd8f1e3fe6fa9f7 although when I looked at the random collection of vmalloc things it did make me go "hmm". It might be a better long-term idea to only implement the very generic low-level function in mm/vmalloc.c and mm/nommu.c (ie the __vmalloc_node_range() function) and then move all the random wrapper functions into mm/util.c. Because right now we effectively duplicate all those wrapper functions, which is kind of ugly. Linus