From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38B3BC001DE for ; Thu, 10 Aug 2023 18:32:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 351946B0071; Thu, 10 Aug 2023 14:32:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3018C6B0072; Thu, 10 Aug 2023 14:32:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A2E96B0075; Thu, 10 Aug 2023 14:32:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 07E776B0071 for ; Thu, 10 Aug 2023 14:32:17 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BA8D8140A3B for ; Thu, 10 Aug 2023 18:32:16 +0000 (UTC) X-FDA: 81109039872.21.B775D54 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf27.hostedemail.com (Postfix) with ESMTP id 9D0B540022 for ; Thu, 10 Aug 2023 18:32:14 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=HasoqfXS; dmarc=none; spf=pass (imf27.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.53 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691692334; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y4G1eMy9+CFptENlm/g/netej2ahnFST4juFiDvm5E8=; b=vnHCqR3wE5hQ54o6oNlh11+0wfMxc8ZPkjdhvcRd0CknIfmRkWyYE41y2W/2GeRkitEOdD VRug3zQ+Cka73NbRE1b4Y+lHgQYxWWs2q7B+BEGTNhnLGJocK9coZkcvrVgV//B8B9OQzM Fb+O3vUY8ohRoEBrKn36MY5UtsSlkyg= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=HasoqfXS; dmarc=none; spf=pass (imf27.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.53 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691692334; a=rsa-sha256; cv=none; b=oVQH4sLZoFCgTY3zFtLTMJsEavE3Mt3awOxc35oS+nHv3mgu4tZVoHICL2z4+Bd2gxq0so xuCY0vWG7alOsF798G6bcSofwZwR8wNxrzE3kH56qPF6oycP7FOznObw4FmBsBClatamtl caW00K2gshelAStVfUtx9w5UlMuuXiE= Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-99c1d03e124so166577766b.2 for ; Thu, 10 Aug 2023 11:32:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1691692332; x=1692297132; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=y4G1eMy9+CFptENlm/g/netej2ahnFST4juFiDvm5E8=; b=HasoqfXSMgtR8tD6+JaFDvR+gpFlNaiS6Tkor8LkYrQmDATil/aXEZVw2xxKFZCwhb +g+waewt4gbP29TWkrBfrkEOBYawg+VK2TRcwIllXuM0Emc+itUSVtFCDVJr474JrnU9 ZYiieiOq9S/3XVhuDkPynjSaLum6NcdmkZGs0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691692332; x=1692297132; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=y4G1eMy9+CFptENlm/g/netej2ahnFST4juFiDvm5E8=; b=Ek3j03BBULheDJvTjFvn2bsYClebF0NoNnr0FdMBtlM3XhAJgsgzDxNAvIPPaHiy/w 7p6US1D2lU/b24E7EtwRhG9zKzkGwXGKoOiHXRqi+JGaLfNp14URHNBVQpHREovd+0w5 GrnktqU7hKDakXmW5dqqqBzesLc2fWA9luNU46e/PZDoHIX0ZIGG9JbeAOFJ3Y4voyRQ JV+NbKtBXTH5Uu+8y4T5oTY1ZosCH4BWCiz8pRIgs95fNP5G0MowSRgRG/GSdPYhoPIb DDIrechEsze68WgYJYZ+NUgB1wIyCEL65T/UlM0M1D/MOA42Zm3PSIyUIrzaXOFc9QdY z9sA== X-Gm-Message-State: AOJu0Yw5n4tJO0GA7G1i4q6PvojRWENLKPx7eTYqoTaatm6SsS5t3gBw MFmi2ZILaH1i86utwLIe9JvKTZ8ye9lvsmN337Cjkrps X-Google-Smtp-Source: AGHT+IH85pdoox4hMu0hZNUIsrXp+XDmi7ZwE0fGjEeppBZlb1V8clB3d5q6KdBELpmBOyvl6Pid+Q== X-Received: by 2002:a17:907:a0c7:b0:99c:b0c9:4ec8 with SMTP id hw7-20020a170907a0c700b0099cb0c94ec8mr2393370ejc.17.1691692332559; Thu, 10 Aug 2023 11:32:12 -0700 (PDT) Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com. [209.85.208.43]) by smtp.gmail.com with ESMTPSA id c22-20020a170906171600b00991d54db2acsm1264758eje.44.2023.08.10.11.32.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Aug 2023 11:32:11 -0700 (PDT) Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-51d95aed33aso1479783a12.3 for ; Thu, 10 Aug 2023 11:32:11 -0700 (PDT) X-Received: by 2002:aa7:d408:0:b0:523:f91:fcce with SMTP id z8-20020aa7d408000000b005230f91fccemr2755596edq.13.1691692331501; Thu, 10 Aug 2023 11:32:11 -0700 (PDT) MIME-Version: 1.0 References: <20230810103332.3062143-1-ryan.roberts@arm.com> <20230810103332.3062143-4-ryan.roberts@arm.com> In-Reply-To: From: Linus Torvalds Date: Thu, 10 Aug 2023 11:31:54 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 3/4] mm/mmu_gather: Remove encoded_page infrastructure To: Yu Zhao Cc: Ryan Roberts , Hugh Dickins , Johannes Weiner , Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Christian Borntraeger , Sven Schnelle , Arnd Bergmann , "Matthew Wilcox (Oracle)" , David Hildenbrand , "Kirill A. Shutemov" , Yin Fengwei , Yang Shi , "Huang, Ying" , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 9D0B540022 X-Stat-Signature: 79nqakfzgw7bdzxhstakazwwm6x9b9ej X-HE-Tag: 1691692334-234500 X-HE-Meta: U2FsdGVkX18EP6sbFEMNXqFdTodGLvnGC11C+01qDExmnqbQlh8ATiKoca0w6eOiUaOQwfAS0eo7/pBAoGb41h3fjrFlH8iGdVTmdzXRrt0CJ1xURsJk73oLFQkGsJsDFwgl4PKPi/j+d/jHjwmxDuYNAiHzxnYaa8LCwtqqErVpdj4yktYzElRUfvt1QNfVjQchCTC6ij69QL6aiF3u+FuYi3SKjRbiF7db5e5vvQfXSszK0txjycL2MRopN4PazZZ2P7Sg1gxcALzEddVVJdiMegIifTlYg1ZKR1uSJnsCMZsSh44tXrkXBYSejIUcrraOtWwNc8JaGfTErlckSnlxY2kiEGnQeqpEBFnLq6FPVyNz+rE9S8fsjYbk6eJTXObtmfWMhldAzRz8wGYKH3P4Jcwvx/UHCNFHiBaeLbOCVxtq0JhlxrG9N78mPwUx3gR1rrDgJjiGR8UUK3qWkZ1KYaqCggDfpJJ2CUr/yDoq8KrYu/ebvQXUdCxZSrdlpcJmlUJYlmyzLt2+ckPo1Qb5haUqcypwXor3n/RGEA9OWBXKGMM1St2dspDhz9ehTTGLMj4KrkoDmCk5K9U/HnYY0xAmiln1MJkUbUwSKRvbZ9+l0gXK2M+ygWHN9IbehWhBsG7t4cDiQMHanC2YgtTVT8MO5D5ZmiaEePzlFjDOaliLnA9uGztYCRYI3JJn2kHERZZlkk6j1H0n5Wh41a41bXAkOW1eRHaKwkeetN0SBtfmedlyufDwDcg9nFMyEMsE+WPwuiJZYl7OzXUvB5rdOBgNEdUxP9djDHqJBj5GMTHJWw4NJViUZAi4oc5vH4li2SsUe9jGQ/LFuVOcBbkKiOvgmOfiMXkF53FOoC63bKBPuk0Gdw8V7LRGKGlg61tyPpkI6eBbSZXEsbiiIAWO5YArOu65p2wsjDBuaZy6nGPknoEqXOE8cj6zRFk3cHF5BvA6ghaITvIyXPb pr9ApEk5 Jl+SGgRUzrkBIdFSdO5bw0qE4IFtv6DMTxLr3633Pa0J/k1Ij18MyYV9Q04W3culDep5QqfI+wuY0eyXFDWtWBQJpFkbS9PA6OKp32VrGtbaFHrq196QgGvihvYpLOrDatPHSny4b+D2FY90CUxJRJeDGs6unACbW/AdkNjFZwIeb0CF7qaoQ0X/B8eOymV8J3hhwQMuhiZBCOv9vgL2ABvEXZA4Pgmd5gTeM4H+iZlkE7TJx1+Zz3rjUs3FcPhzRJ1ypulsFuA8VgJvzKstHVdCBVu68QLn9HxoWjWwthU9uD78b6k+SnyPjR1MOHjXqzEyIRBh6FGJbX9sXpbXtP7pwbfFwehQ8jgCkV7Iqj3Xrit3wnGCJ2NpRIKz08h3c054iW/t0F5un34GWJ96RmTtasiIaSVy3pALU1XNz/Hj6T+1IxsSdbD6VVZLgDBXqbqb8t2lSINKMNFn/ihwzjfLKQPNzJ2cvS7NZEDph9uvxcHC1s6UlNAzTRRTNuiPGX4lCT1/Eo9X3+Tq/xow3Cx8Y1LvhhJ4MdY22m+mqCUGxuL36V8zDUDa+nAb5WuFcOXcC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 10 Aug 2023 at 10:35, Yu Zhao wrote: > > Adding the original author and reviewers... They might want (need) to > take a look at this series. It looks fine to me. The important part is that the rmap removal has to be done after the TLB flush, but before the page table lock is released. That used to be a special thing for anonymous pages and thus needed that special flag. But if it's done for *all* pages the need to flag pages goes away. I see no issues with this, although obviously I might have missed something. Linus