From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37967C4345F for ; Mon, 15 Apr 2024 18:21:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 94A8C6B008A; Mon, 15 Apr 2024 14:21:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FB096B0092; Mon, 15 Apr 2024 14:21:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C2486B0093; Mon, 15 Apr 2024 14:21:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5D5646B008A for ; Mon, 15 Apr 2024 14:21:35 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EC2FDA111E for ; Mon, 15 Apr 2024 18:21:34 +0000 (UTC) X-FDA: 82012584108.07.82821C5 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf03.hostedemail.com (Postfix) with ESMTP id E669F20026 for ; Mon, 15 Apr 2024 18:21:31 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=bVQoXgMV; spf=pass (imf03.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.50 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713205292; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yXQXQf6BkxnxREYjP8+VxnnUlawTjdMp0f5jlbh5Zh4=; b=rL94285CDTYosqLj2Uuk6tLCOYdY7QKlBl2Wr9y6mshxc8nslvSjiUiyjlWbr1wGqyIHeR 2JQnUIprFcYNLd2AW+Ui0zwBGjOcLqkb8dunSHX6U59PcX9l/pWZu+jFGJ1MANREzwWSgY vbzEfjnEVvrrOnXRjpXHc69CgWQgKKc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=bVQoXgMV; spf=pass (imf03.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.50 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713205292; a=rsa-sha256; cv=none; b=Rx0Yrw9AURZgiPjs3b9x7Hg+ZB0efobqzevg2siKanw4QqZ/vzHOHejmrQg+/TQO1WewbN YKS/p3VShHGyxqvmcbAQYOXEA2VPNQViLSmmAetm6oXevsbx51WXra2v/1p2du8xOnHeS/ n5jrvxU6kz+lCsopPQvUIPROuPA7ksE= Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a52aa665747so146580266b.2 for ; Mon, 15 Apr 2024 11:21:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1713205290; x=1713810090; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=yXQXQf6BkxnxREYjP8+VxnnUlawTjdMp0f5jlbh5Zh4=; b=bVQoXgMVSseJYBposkEjdFeS9XdnXduTLfmb0mjaVBUMxgTKQPyTtK2z6Pn3BWoS/M FlcG7vi+T1WbAvOZ12nr4Z7EPZvoMa/HkjvkTd6fO8hbZHkf1KxPKpz6WvuR3H8hsH2w DseyC//GOCLvma6HESA31L3K2moGTMvQSLzoU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713205290; x=1713810090; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yXQXQf6BkxnxREYjP8+VxnnUlawTjdMp0f5jlbh5Zh4=; b=J7Pfn2mA+7PMGjh7LYV1qt1at/KW+AzOwgSIWI3vSFJUEHvJ8PMBivXjsMIYnXjJaH EbfIJWJc3WhKcc+7ztUwzD+C88LMwCKqKJPw/XWMMTwiCDSXWxU0vupcJnC7gwHsevQA v24xoP55ZPwSLwsybV20hwvCVekuxuY8pNJ+NPE4qFn6rtOCYumJzzYK7rxfLaK345ae krVPOkt6QDI7MOXKLyVsL9YHVbuz6lu8DPpBf/x6YabPsdrYuYyIo3o9ldUxHW1Ykfyx dImrrYb5eYyrs84Z9//ZN1LUWvehXRhVDhSnKiFbHNLnSDnbeycOk0mXaUQLVlcVcDn2 thsQ== X-Forwarded-Encrypted: i=1; AJvYcCVQqaoSmIT0exctXPQpDr6NHq7cEwz4rZmBS41A5KwicrQTU4x4beR2EBjyVfT0BY9KK6JFCAVmXG93A7L+rhkgm+0= X-Gm-Message-State: AOJu0YzmkHv9UKAKJCVqVRCvD9qSBn2FAAlKYgLisAe0k0K5Yf/vaWEs x3rU8eyNgyfYnSc4FdAV+FKbtsZka8P5CnDdtoWOl2Lt5t4HCjIWLKmTkvNOA1Mr32P/SA0QjDe O8rwrGQ== X-Google-Smtp-Source: AGHT+IG7wOEipItFSfVyK5CkYov7YEyHAFYRWi6EYqpOz/dktGPvG8rO7F48TmDlWoiHmQ3R/NPzXg== X-Received: by 2002:a17:906:560f:b0:a52:362f:be1a with SMTP id f15-20020a170906560f00b00a52362fbe1amr5314127ejq.18.1713205290078; Mon, 15 Apr 2024 11:21:30 -0700 (PDT) Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com. [209.85.218.47]) by smtp.gmail.com with ESMTPSA id g5-20020a170906c18500b00a522f6fea95sm4913651ejz.223.2024.04.15.11.21.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Apr 2024 11:21:29 -0700 (PDT) Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a450bedffdfso439996866b.3 for ; Mon, 15 Apr 2024 11:21:29 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXBrWf0GvY48bYEoBQY6b+dGpdqc67rtcwnhmgR+Mx8Vl0ngKH86Hcp6PjuQ1xht94GDY0nX2ysy1O+NP27CZ6g16o= X-Received: by 2002:a17:906:110e:b0:a52:320a:6320 with SMTP id h14-20020a170906110e00b00a52320a6320mr6421452eja.51.1713205289339; Mon, 15 Apr 2024 11:21:29 -0700 (PDT) MIME-Version: 1.0 References: <20240415163527.626541-1-jeffxu@chromium.org> <20240415163527.626541-2-jeffxu@chromium.org> In-Reply-To: From: Linus Torvalds Date: Mon, 15 Apr 2024 11:21:13 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v10 1/5] mseal: Wire up mseal syscall To: Muhammad Usama Anjum Cc: jeffxu@chromium.org, akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, sroettger@google.com, willy@infradead.org, gregkh@linuxfoundation.org, corbet@lwn.net, Liam.Howlett@oracle.com, surenb@google.com, merimus@google.com, rdunlap@infradead.org, jeffxu@google.com, jorgelo@chromium.org, groeck@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, pedro.falcato@gmail.com, dave.hansen@intel.com, linux-hardening@vger.kernel.org, deraadt@openbsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: E669F20026 X-Rspam-User: X-Stat-Signature: 3t8zkjqordyrr7rxb6usctw7jcnn9unh X-Rspamd-Server: rspam01 X-HE-Tag: 1713205291-600580 X-HE-Meta: U2FsdGVkX18vx18jgFZ0pTu4cnAk9E4OcrW64RYIgMiDbTW4oX4+iPa62xpWxDUucX7bJKFlLGCZh4jLg7V/Kiis/ME/jSFkqBwkaMEiWd9fgNkZWelLCT98lrERrQxLxA9JVUP2QTvtnjknmtj45sHjGB24p8xuYG85S/ZgWx73Wc6wswBHOovfSH+tkYqiTBF5grRCK+ozfBA0KsfQQ6wr0K0KsESFhLTeaPvKMN7pLfE2unjqZdpMitkx1OREt4LCJ7R2w9IyIsGBRx74e/ivRxZOu4aWfdKj7Ime6ZYxuEGw1ZlyJEZMADixXUR5bZJ9tn1RDB5i0Pk1GOIaeVF6YcydCiy2ksx/5tHmuhKwgazt2jo9QXvE7p9cvoIWhQ+98nn1mbwQCZ84f0NNUT2+cD5Wgl7Cl9mAuNxBJ2Hp9mZRGy4/3/nhTwSssDDk0rXy0+FnLj/xqh/w6vPRCRHnRCje+rK8gIWs7qQYNdVNZmb95iUvNuOB/DfENp6EFQgSX1uBspXn/CkIAYq/Mr+xRuGfPf/IB0R2qiU5ZCKLT7NVY+n7cQSW5rZ7BmirXgAcmPZ6J33Ia6TyepPPU0cy3TZE8BVOQKjqsE9Qev9Abf5KW3O18ozY78RpEYSw2SorJireFjGcoKG4/hKJCJeW+ai1kDoACKRI1r9SP8gclvRRPlvXbV0N2btQHTJUoYbDpJwbDh7X06A/Ky0oquSzwp9SiDSYHPP0NvZKR+khAXO6r8egxcle6QiwYjNKMXAtisHEcSueOu4u0W6UUmbV0JGOSqWrYlFMV2SN978f1vx7L0Xf2WJHsZtgIKe8bHfFSo4GojTQ9bVdI10KCJas0j6qHSO+pao5OzfeDv0mrcTaysMpOGdHUMjraPb6B1kaNOy+L/Oxtf1bBnOSw9qv6a78C+/xEhnLjzRWjh4PNRk8IEDQ/Hbohi9OOXtc4yZIjZqRWR/qvVqGVvS CisCL40b OBsFvlMv5tWrHWwPu8ddDNBO5eLVdEQ0mqxgywxG00LGQvOKojOlo+vrW7tuxbUoI3WexX4aOe3T3rflsNLHkPZZGZjeTQFOwzrwmW74UikOTQBBztVrcjWsyjGTneChQWXkKI6zUrnt5RSq/X6EiFWlh208Nzi2DR1sVjJcyKN0viVBvzrTit+FcU6KSi2ouAw0LhUc3dRD3HHrn2SQhMeaWKf0JdNnxB+gDh/anqpsiEEw/tL3z+rEhNl+Fb8XCL0RdRBnRrzxCbGJ1yk0fUdvwEHjZcjlHEge0q0AWFkaLDGfBxfDTvwRrSYuxZpN6lW2Zry+D4hQHrLAQTYpkT/TonpHL7dNY5k1q/Y4LLss3GSBXoiBGFXQ1qM+fU2I/Q7hRFk7PP/4CtmrFvYxFVeToEx25Omaug8PjE7092cQCS+GeSBf5VBYSuh0eYTuJ8kRhZasDBylH2EsH7DzeUJVIsDgXqd2r/nwFkzJRz5hhEduDRMvI8fa3CTXThxLcXT/jFPr7yRlJwVxpodT9kQ7KKMr+Hnf0S/pBCPJ41r7/8hflSEp8rTYji3r4fnygIXoB57PkE+mmKNtxqm9FAMKY90QUIppEqgV22MzE7ozIpFY6pFrxdbJHx5eracGDDqSm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 15 Apr 2024 at 11:11, Muhammad Usama Anjum wrote: > > It isn't logical to wire up something which isn't present Actually, with system calls, the rules end up being almost opposite. There's no point in adding the code if it's not reachable. So adding the system call code before adding the wiring makes no sense. So you have two cases: add the stubs first, or add the code first. Neither does anything without the other. So then you go "add both in the same commit" option, which ends up being horrible from a "review the code" standpoint. The two parts are entirely different and mixing them up makes the patch very unclear (and has very different target audiences for reviewing it - the MM people really shouldn't have to look at the architecture wiring parts). End result: there are no "this is the logical ordering" cases. But the "wire up system calls" part actually has some reasons to be first: - it reserves the system call number - it adds the "when system call isn't enabled, return -ENOSYS" conditional system call logic so I actually tend prefer this ordering when it comes to system calls. Linus