From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F6FDC7618E for ; Wed, 26 Apr 2023 17:04:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D46D86B00FE; Wed, 26 Apr 2023 13:04:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF5C46B0106; Wed, 26 Apr 2023 13:04:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBDB86B0107; Wed, 26 Apr 2023 13:04:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AC0CD6B00FE for ; Wed, 26 Apr 2023 13:04:00 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6F905C035C for ; Wed, 26 Apr 2023 17:04:00 +0000 (UTC) X-FDA: 80724164640.12.AD24BE3 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf06.hostedemail.com (Postfix) with ESMTP id 42538180011 for ; Wed, 26 Apr 2023 17:03:57 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=S5KwTyJb; spf=pass (imf06.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.45 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682528637; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rojE/Cf5Vc/Os78fxzdIb/ZWKVxlH85NFon6s3+eQhg=; b=WX0hJqsP+uE7VrUZXRw2N0KmnGy4aRnMWgB/OaIzgHGtNOAKSt34+AU7JCkiF0+XZDSTz1 hhCGjqH8YUA2DoDill+2xZsmbXhaM5ovrx50FDXSopdXkTBarCoIxGk7wgpwc/NXSsY1aN 8/MPwD43pbIqbDQpCVvk7XbVThqF2uw= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=S5KwTyJb; spf=pass (imf06.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.45 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682528637; a=rsa-sha256; cv=none; b=ftT3ISAq6LoCyDwhIVKWA99ZEfQX8pFCo+53jOVUkL6wwz4Nm3050TzGjL83KJaP1PRBmT ldGIQiS5w8FZdsHI1ZY/QiDCtzDoF+7FBUoTuLyFUmPCJPY+BiY59G78IW/ibrLdCcHVpd Jnn/nsjB9Ckv/XCHeiuhuttZwlNH5Jw= Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5051abd03a7so10958119a12.2 for ; Wed, 26 Apr 2023 10:03:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1682528635; x=1685120635; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rojE/Cf5Vc/Os78fxzdIb/ZWKVxlH85NFon6s3+eQhg=; b=S5KwTyJbCrYSpRgabEwuFA9OPMgLGr3CoGSMLx3UJiaoG2llzimB8Na4uKpzikb5dN lA4MX5tUTY8epkXLYywHGwvQr9jl5GYMn+WEKJSqFejCBbhejce4rUWv7ekF/5wBxznp HPKFT+B9iQy9OetVh8YE6V4kpo/qxT9I5bef0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682528635; x=1685120635; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rojE/Cf5Vc/Os78fxzdIb/ZWKVxlH85NFon6s3+eQhg=; b=MuqCHvsVCFSs6mUnBPojmGw6OQF97hvXnKMnlreEGB0KkiViIqtqzvoOCZwdhamgkE k9kDLNUxCBxrn4UbWYLoMj3uV1j2rKEguln2NCZe/jOu9wSAyxDBxfv2GzzDOcs699yW YeRVeAvq8CNcolfrAlVRkp/Wt4/w8c87dUr76mXXq9jTGmU9RbLWXWCWlEaeHPefzdKd yjiC9TCbBDQb8Y878Y2QAp/b6Y/bWatZC+RmltHHzWiwb6WIwfHhXwLL4564HArLgkGl iumOJBBQWippFsE8swED+YyGx7MNGFQBpFpd0x8TF926xDLlxYDajoa+6UPgyc+OJyt1 Yn8g== X-Gm-Message-State: AAQBX9cCW/VcFz3Legd0kvZPb4nfj90P2plr/+PixguMpxCfYe+LdIi9 xWnhiugvnGjeeRbKQYoPNNbwgEHge2V4U8/BW4kFDQ== X-Google-Smtp-Source: AKy350YWLp30JLdJabcX77q8wIbsfQBK4Xy9sggfDrh1Eggt2JpNYTHeAdgf3nr1rhVvs6eAR6F9nA== X-Received: by 2002:a50:ed96:0:b0:502:52dc:b9d4 with SMTP id h22-20020a50ed96000000b0050252dcb9d4mr22323750edr.10.1682528635200; Wed, 26 Apr 2023 10:03:55 -0700 (PDT) Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com. [209.85.218.53]) by smtp.gmail.com with ESMTPSA id x20-20020aa7d394000000b00504803f4071sm6961919edq.44.2023.04.26.10.03.54 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Apr 2023 10:03:54 -0700 (PDT) Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-953343581a4so1121007266b.3 for ; Wed, 26 Apr 2023 10:03:54 -0700 (PDT) X-Received: by 2002:a17:907:7e9c:b0:957:28b2:560a with SMTP id qb28-20020a1709077e9c00b0095728b2560amr18417571ejc.46.1682528634167; Wed, 26 Apr 2023 10:03:54 -0700 (PDT) MIME-Version: 1.0 References: <20230425041838.GA150312@mit.edu> In-Reply-To: <20230425041838.GA150312@mit.edu> From: Linus Torvalds Date: Wed, 26 Apr 2023 10:03:37 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] ext4 changes for the 6.4 merge window To: "Theodore Ts'o" , Nathan Chancellor , Nick Desaulniers Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: j3aa6ideij1upbgo8kpwxbw1hhcc38qh X-Rspam-User: X-Rspamd-Queue-Id: 42538180011 X-Rspamd-Server: rspam06 X-HE-Tag: 1682528637-436255 X-HE-Meta: U2FsdGVkX19a+ipZ1QjBioq2QZjj4NRi/5AL5O47e8eUmLHSKlm3gHTqJZV6BHGbIgkz9h2j8MuifO5ePay3dn8QwJdxjiurfsru3Sdq8GeBOgeaDcdiESKZMM6c8uUIljJDz0/rsOenUOFxV7SpRaHjc7O7oKG19F8eEZHD3RFPO7xJIVUjRIOn8xquVB944Y9urffycvYxtVA56WW4DYuteUUrJbW/1sVjU1a5YFbzubQikg7DUEnnyUzidtPhNg1X6a9htsqxtKzAaGAJu9gErqM+jl+kQuTaPGfQZCihJwEypv9ZjYqbYnzUpTl+mPRbuQhSnTtEveQK6t8nDL5tL3saiK+wraUF6WPpndYZWTuxFdCtSuG41GKe0YyGPkDzDVSOh5dQiKi5x5NuYldJ3xdCD/D3u5lsgjG8spIzaE+j2l4XDtIBI2o5mioj2D5r3aQnSKZb7VttwBr2RJ4zkEx1/IPBYNY5JcrQqPdVUG/85BOUVCK3rMtT6ecU9+NnK28hhoVBvidxIJJkAoLvB2SmS98pkH+rMlIhAhC6xQTE3kYJP/K1vgv+3vpTWU3x4c0V1NpWQxYsiiB38XehzFLvbEHvLUqWpnGV4invEK8U5qyHWbJKvi8NKxjw0ZGX9PEQKJPLXTrzPWPPNoZoQ/2hlfICA+EY+mAjqKRWM1upFLf8O0XPHulv4Nx1a4egFSEK/mK+KMiHK1JYMAFnb4CMwKetahcfhycJRER2NL7iPd6lfvgeJLmsjK5TGeZF5Q4yc9fvigfJwEuJq2fgu68CbvoUl2NQBHM6pm2vi5J09hY/3isU/DW5xqSErzjVMLEbWS3iEKo1BIBNzt4eQn26H3+gADqTAa5a91khBUS5tiYwq6RVq2GKcmKWeGj6YF660CHVBPulX2YCbk3Y5kwhTussVb/VoSh4cI+JCRnPKSNTvvLJnVsJQr087DOjU9aKuWiFhECWHUH SLZy2Zv0 PvmKZ9EUsRAnZ17TQsCrmEjj3/10u0SA3pr9eeXt6sLS5i5keMpWZsGecJmiJZalJDQjclg9j7W1M9uDlIGQJYRJSL84F3oyopt1L+5R+VlM9cWFVVrAdde/3ir0TxlwBEefdA8aFoiTMQkf7lajJw2yP5tHaLsEdTgzvYmBQu1tP8Dy1QcgvHp245QXfNkIZ42NL85TOt6lCWiZvjZIWu1V1l3/wVIXieDTPTffnKFwAzAAWsfXh8GDhkTGryqT5JCiYfFDvXFBsRBJVJ0K+9ol69Uk1X5qRswpGfquVxxspU1cSSK0r2jYbrdKhVtxvRmBIIB9g/MKbE5e1+2402gA7WDjb+K69GSkbP34ztq95SWJMT6IGo8cBcInKVmstM6x8Fnh+ztSsYfoVc5IwHzLJdRyIWuC36eLPbDkpoB8I3CPPmN7ieNiHfjfhQKdbvZC3q+KUxCHRql5VlGdNbIO0viXyB1NhGtz88Sq2OxgFiv6KM/AsLA6Ki/4f5lMGVk0iMdY1dUtj8db7haurrB+jQ7X/akWy7BcHHxOrWRkRewSChoGLJrp8Q56pLJHEuzGhnbKy1KtM4lAiZR8W3aqTrIVTPFPYUASD73EbXW4Ov1A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 24, 2023 at 9:18=E2=80=AFPM Theodore Ts'o wrote= : > > Please note that after merging the mm and ext4 trees you will need to > apply the patch found here[1]. > > [1] https://lore.kernel.org/r/20230419120923.3152939-1-willy@infradead.or= g > > This is due to a patch in the mm tree, "mm: return an ERR_PTR from > __filemap_get_folio" changing that function to returning an ERR_PTR > instead of returning NULL on an error. Side note, itr would be wonderful if we could mark the places that return an error pointer as returning "nonnull", and catch things like this automatically at build time where people compare an error pointer to NULL. Howeder, it sadly turns out that compilers have gotten this completely wron= g. gcc apparently completely screwed things up, and "nonnull" is not a warning aid, it's a "you can remove tests against NULL silently". And clang does seem to have taken the same approach with "returns_nonnull", which is really really sad, considering that apparently they got it right for "_Nonnull" for function arguments (where it's documented to cause a warning if you pass in a NULL argument, rather than cause the compiler to generate sh*t buggy code) Compiler people who think that "undefined behavior is a good way to implement optimizations" are a menace, and should be shunned. They are paste-eaters of the worst kind. Is there any chance that somebody could hit compiler people with a big clue-bat, and say "undefined behavior is not a feature, it's a bug", and try to make them grow up? Adding some clang people to the participants, since they at least seem to have *almost* gotten it right. Linus