From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E2A6C00140 for ; Fri, 5 Aug 2022 23:32:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C90E76B0071; Fri, 5 Aug 2022 19:32:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C3FDC6B0072; Fri, 5 Aug 2022 19:32:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B07DE8E0001; Fri, 5 Aug 2022 19:32:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A21686B0071 for ; Fri, 5 Aug 2022 19:32:53 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6A8CB1618F0 for ; Fri, 5 Aug 2022 23:32:53 +0000 (UTC) X-FDA: 79767141426.07.2947ACF Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by imf06.hostedemail.com (Postfix) with ESMTP id DD561180006 for ; Fri, 5 Aug 2022 23:32:52 +0000 (UTC) Received: by mail-ed1-f54.google.com with SMTP id x21so5133403edd.3 for ; Fri, 05 Aug 2022 16:32:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=oX5dixeC5cISzlmeE16lJbqJDGD4u5Eew52IH1AkIug=; b=OGweQEBV6PwoBvKXWW7hNFk0oy34DwHtq9zVl/wNvm42Kggg7c0oJ/FBOOo1oQaG3b vBKqmHIuluGFEQKNy3P/KT7LWjqca78MHWczUx6TQysIZkKyAE927djCJSimDev2kNRi Bq1V6hnmwcqPo/6RS8mi1/QjimKryQFOdsZ3I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=oX5dixeC5cISzlmeE16lJbqJDGD4u5Eew52IH1AkIug=; b=bCCt/CsnJ2HEJAWlqBf7Q4akA9D7DYpWV6cq2UWIgco2eFO0qJLOkQEH5p6CVz+sJt II1+fiyZWreOewhUa/NuZ0LFmypmH2OsGMRNix1CzhinJN7ahbwpRhrJiFlLpKzOcJtB aqLpm1XCoPunJMtEuX9l4ek7X7AC9ahiwwylK/32MJmlMHBIl97BkZj6wJFsAOn747V2 2tQSPKDrvsks1ZCsqEwDForm7tAg37alvETmjmECW8OnldIpKjWa037PIHLJMrtnRrC8 99MY6l87Xmwa4rGWJSDiGsrUZO4fy6a8x8xtj5f7Xr7Cfway2NSAJTC18R2tOWr4pJAx FwFA== X-Gm-Message-State: ACgBeo3FTM6Dn63R0eh3KQLoDscpluLIKC1YE8kmOpHe/ro6DSFkdp93 O8oi45S2FpiyGtZKg5SUl2ci43Ej1J4GI5/E X-Google-Smtp-Source: AA6agR5PyA3fOFgyfOAxhgJs4XJkSVcTY6PahZ3fQ2oKpEAEmXx++NU6RsDcbXdZCc0NTXDfzOPNXg== X-Received: by 2002:aa7:cac4:0:b0:43b:ddac:aa79 with SMTP id l4-20020aa7cac4000000b0043bddacaa79mr8611900edt.202.1659742371413; Fri, 05 Aug 2022 16:32:51 -0700 (PDT) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com. [209.85.221.42]) by smtp.gmail.com with ESMTPSA id ep11-20020a1709069b4b00b0073087f7dfe2sm2081858ejc.125.2022.08.05.16.32.50 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Aug 2022 16:32:50 -0700 (PDT) Received: by mail-wr1-f42.google.com with SMTP id q30so4722142wra.11 for ; Fri, 05 Aug 2022 16:32:50 -0700 (PDT) X-Received: by 2002:a5d:638b:0:b0:220:6e1a:8794 with SMTP id p11-20020a5d638b000000b002206e1a8794mr5558868wru.193.1659742370294; Fri, 05 Aug 2022 16:32:50 -0700 (PDT) MIME-Version: 1.0 References: <20220803133541.18b82ec9344ed0e8b975fe5b@linux-foundation.org> In-Reply-To: <20220803133541.18b82ec9344ed0e8b975fe5b@linux-foundation.org> From: Linus Torvalds Date: Fri, 5 Aug 2022 16:32:34 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] MM updates for 5.20-rc1 To: Andrew Morton , Roman Gushchin , Kent Overstreet Cc: mm-commits@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659742373; a=rsa-sha256; cv=none; b=Gvx5Z6CETLwKCHm+WhbabteYq6Wx4pJG8jcD+ozZLhAYzFxaXAHRuBvfiIPL+N+g8ozkO6 1f7pbrjb/CVgTp1RfIx4h/293hSWvePneAHfAEIf4lP/VdLqXV4UkA+1VBcPI4N/aVCvEK 1Fw5NJ8EFsJKp8YV7xkJR3SQ687wG7o= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=OGweQEBV; spf=pass (imf06.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.54 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659742373; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oX5dixeC5cISzlmeE16lJbqJDGD4u5Eew52IH1AkIug=; b=MfcI55mbyMbScf5vQsuTnPeWP2tHLgJz8EKV8K5bQjv2jvhc2Slxacru9Yh15a94naFEIc 4TOszwgPJhgKcwlej+ZDE8VrXiCacA8RBLyk2T099XdvTUORsf4nyE14G4Se7MzMscaoK4 8x9bbThswsnzNh8GtSysHo3s77qhOzs= X-Stat-Signature: u64fhk18agzkpgparicjxgq4651zjdqh X-Rspamd-Queue-Id: DD561180006 Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=OGweQEBV; spf=pass (imf06.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.54 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1659742372-164218 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 3, 2022 at 1:35 PM Andrew Morton wrote: > > - memcg debug/visibility work from Roman Gushchin Well, not just memcg. There's that new CONFIG_SHRINKER_DEBUG too. Which looks like yet another "people add Kconfig options incorrectly". We don't make new features "default y" unless there's some truly pressing reason for it (ie "99.9% of all people will want this" or "we used to always compile this in, now it's optional"). And shouldn't that thing be under the DEBUG_VM heading anyway? I removed the completely bogus and inappropriate "default y". People, please stop doing that 'default y' thing. I realize that everybody always thinks their own code is *sooo* important that it should be enabled everywhere, but if we've gone 30 years without it in the past, maybe it's not so critical after all, and maybe people shouldn't randomly enable it unless they WANT it. Ok? The main reasons for 'default y' tend to be literally - this used to be unconditional, now we have a config variable for it, so let's make it 'default y' so that people don't suddenly lose functionality - this feature truly does cure cancer - this isn't actually a feature, but is a gating question to other features that you may want to just shut up That last case is mainly used by the network driver subsystem, where it asks 'Do you want to see drivers by vendor Xyzzy?', and it defaults to indeed show those options. But admittedly that network driver case is also _partly_ guided by that first case, ie it has often been something where a group of drivers were moved to be under a "do you care about this vendor" situation. Linus