From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00768C433E0 for ; Mon, 18 Jan 2021 20:34:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 81B9522573 for ; Mon, 18 Jan 2021 20:34:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81B9522573 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A4B588D0027; Mon, 18 Jan 2021 15:34:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9FAE28D0017; Mon, 18 Jan 2021 15:34:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E99A8D0027; Mon, 18 Jan 2021 15:34:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0057.hostedemail.com [216.40.44.57]) by kanga.kvack.org (Postfix) with ESMTP id 74B6E8D0017 for ; Mon, 18 Jan 2021 15:34:50 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 381AC181AF5C3 for ; Mon, 18 Jan 2021 20:34:50 +0000 (UTC) X-FDA: 77720049540.17.order77_3c040842754c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 1ABC9180CF5E3 for ; Mon, 18 Jan 2021 20:34:50 +0000 (UTC) X-HE-Tag: order77_3c040842754c X-Filterd-Recvd-Size: 4183 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Mon, 18 Jan 2021 20:34:49 +0000 (UTC) Received: by mail-lj1-f177.google.com with SMTP id y22so19549276ljn.9 for ; Mon, 18 Jan 2021 12:34:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=s/gRDfD8YrbS3XwFv+1aIqhbdQ3uhWKzz+1gnqOggXc=; b=bt+FYJOGP9ZQRnSTHuwQLcEHZRbKmiPtmHbNsgK244Ouf8inj+gEKeqwbkLMxBsORz 9XqHiL4j09NQl2Hbu7Zqohe8R4Mcab9BZ0x5QNfz6nqunlYqEM100bLwpChO1ztnC/8t YuMK5vRxoxly7Ufn/H5ahy9EptvTtBt/Xd6mM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=s/gRDfD8YrbS3XwFv+1aIqhbdQ3uhWKzz+1gnqOggXc=; b=OnBvZA3W6A0IqjFItxlFI0vkzn9vjDIwOolGqCaYsgpyTcwEwmeaaMpOvRF90ln0k6 TC9Da229QyFO86MhxlEtqXNSAbmOnxrXl1CSc6MKNj0rGnDIN/5JufZH2osYOBi7/IIj K5g83PD9uQsb66Ixh930qzVy5yy3sg9tudLDPA+XZOHYaoSRxC+WZDJ6iC6b4g+PCpY5 5uOqoj8cr8VowAsl9cEdIDdjNOW/dLB4PZ5WXAsVJSON7cm7HAmqg62fSBWzAevt93S5 B1qzplejzkSUuVfkmk8/mmpoKzUNRok6gDpKPWq29H7WPwU9HaM6dM2YY00G/39wOl/w nKIw== X-Gm-Message-State: AOAM533Np2eUmRJrl4FoUIp8Qfu3ujPVh/dhrxwuqrWXuUKRX8iXdEVx E95KMpOQNGRI04aSfidKrlD4DPQ1efv0gg== X-Google-Smtp-Source: ABdhPJyo2BsB8WJVmkOyLOFSBzglX6Xa/jMGSRlBWOp+KVMmicsFLAZk5DKy3b/hKzpuFd7Mrw5K1w== X-Received: by 2002:a2e:1648:: with SMTP id 8mr572403ljw.70.1611002087391; Mon, 18 Jan 2021 12:34:47 -0800 (PST) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com. [209.85.167.45]) by smtp.gmail.com with ESMTPSA id l15sm2004958lfc.244.2021.01.18.12.34.46 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Jan 2021 12:34:46 -0800 (PST) Received: by mail-lf1-f45.google.com with SMTP id h205so25879537lfd.5 for ; Mon, 18 Jan 2021 12:34:46 -0800 (PST) X-Received: by 2002:a19:8557:: with SMTP id h84mr336671lfd.201.1611002085703; Mon, 18 Jan 2021 12:34:45 -0800 (PST) MIME-Version: 1.0 References: <116c7669744404364651e3b380db2d82bb23f983.1610722473.git.gladkov.alexey@gmail.com> <20210118194551.h2hrwof7b3q5vgoi@example.org> In-Reply-To: <20210118194551.h2hrwof7b3q5vgoi@example.org> From: Linus Torvalds Date: Mon, 18 Jan 2021 12:34:29 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH v3 1/8] Use refcount_t for ucounts reference counting To: Alexey Gladkov Cc: LKML , io-uring , Kernel Hardening , Linux Containers , Linux-MM , Andrew Morton , Christian Brauner , "Eric W . Biederman" , Jann Horn , Jens Axboe , Kees Cook , Oleg Nesterov Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 18, 2021 at 11:46 AM Alexey Gladkov wrote: > > Sorry about that. I thought that this code is not needed when switching > from int to refcount_t. I was wrong. Well, you _may_ be right. I personally didn't check how the return value is used. I only reacted to "it certainly _may_ be used, and there is absolutely no comment anywhere about why it wouldn't matter". Linus