From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89322C83F17 for ; Thu, 10 Jul 2025 21:58:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F05EE6B0093; Thu, 10 Jul 2025 17:58:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EDD486B009A; Thu, 10 Jul 2025 17:58:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1ACE6B00A0; Thu, 10 Jul 2025 17:58:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D27B06B0093 for ; Thu, 10 Jul 2025 17:58:45 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9D6EC1A03B8 for ; Thu, 10 Jul 2025 21:58:45 +0000 (UTC) X-FDA: 83649720210.05.9998A20 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by imf17.hostedemail.com (Postfix) with ESMTP id 7F4C240008 for ; Thu, 10 Jul 2025 21:58:43 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=LzL9OBqZ; dmarc=none; spf=pass (imf17.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.47 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752184723; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NOhvg1l0t2LaUB8HzcyN7Tq+OVNAbmeCuPM6bN+kiYw=; b=bGsO7NN21i1SbUefzaWoZ6x3hfnxePiApsVZE/ae+SY2f2tYceYTdfAD1Yub7+FxqI9VtR fizFxPbANtmu8iRxBM5jAZgZXupJDxw+JOeL1LOgUHvjWnum5UMvwk+eXXGSVcKUXrszVF o37UNlmvrZdgbjIvlskhPMHV3I9aKp0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752184723; a=rsa-sha256; cv=none; b=xgCXh6wLTfhV2w5ii+xDfIGHyWljVzSLAzTMsoIdfZZhemRsoL9TM94Ay8ydLfPegbifz5 ux5A5YWfW59gQLMaOKE4Ehx3fQvyTqLQgfGSSZhePV4Aw81ongzUNvkWafkvy1JJUls7s6 gEuGQG79SRIhOJmDxtnC216KSC+E4wU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=LzL9OBqZ; dmarc=none; spf=pass (imf17.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.47 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-ae3ec622d2fso256733966b.1 for ; Thu, 10 Jul 2025 14:58:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1752184722; x=1752789522; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=NOhvg1l0t2LaUB8HzcyN7Tq+OVNAbmeCuPM6bN+kiYw=; b=LzL9OBqZcGp5rC1+njR6Fpm/jAoL9MG9neniEyWmFtU5y2sTc/U/Qz8hBjVx9H4pgb aKpSbL69+rMCN09Iv8hBdkZG63VOXWc+HhqjtrgkQUvYjf2HHimNrnCi/MsQITky/M1F 3u8it4vSbSzGfQCcwN3AW+5JUcq4SLwTQRAms= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752184722; x=1752789522; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NOhvg1l0t2LaUB8HzcyN7Tq+OVNAbmeCuPM6bN+kiYw=; b=Zhn4dE5o9/9xA+izXLyrXpMjxcFmr6uXmOpXmlH7ogjCtxUcCZf+5zFgXwgxEI/AwT CUXorWnFjjKaFkVivEAxFZVcBn4dgmBmHNHOwoKktrhy0XLpzNFbfyUtTKRccYz7nj4R 00fSL5P6fVkGz4F7Xc5cHNZsb+MChMAtFkCIIQlq5/KdLlmeUE5HoK+c0uoaPx41Vxu5 oUZDbw1Hk+m8T81pcR2fmtyyHqhTw8wXfFeLrzqIxbaY0JneC/+/xbSyrOvw8/w7wYKt AuotJOQlm28AFg3HKV0FPG0WOcYwBa73J+B8tlE/jxrzYwUUc+17rW9CW1V4WbBXmNRF ecaA== X-Gm-Message-State: AOJu0Yywew9E0MMNa378vN/oiGhx0NwCTm+U9R4YXx1YSUNJo23nW95W ky8DvBw47Uw3P/lvKP4GmaiNx4CTz0NWbRfiUfuWHSmY3qKEnxM8elwpr4I2V4ymP7lCJbFglAS QW3YqHXs= X-Gm-Gg: ASbGnctDY24XbgMi7BwIfUWbHglcijNSTOSVSAz81YKJXjCqR5L1ZYus4k5mgbI4kAm MfkzHujr/1aBDS2tAin8iQMZPe8swGCHgop2YCh1GtQUnAXOQXyXYd4J4NoIgvRlLq1FEXrXOlv m3PM+Jin0Ccociqz58uhMSOJL70K7K41cGww7s1HUbewPshj18jcmhXZQ5q5oqf0xxhP6mn1GyT zFn2PDHeny6yQ104Kq0XnAimivhuXs8z9Lz7/nftzD8kukpKzs9juKW9BSyX0vpw2ItKz6XnEuS trCwUEFrbSDQQdYx9YqkFaa/NE8yxqKXR2RHvNGbVzPVAyo0ELMBiuve5T7lhgeJ9kFDSkvWKs9 7WhvSvyht1QZ/YEeib5ThkncTTAs4ETmKJXfzbHeAQBvWg0ETY+o5Kd+cOAa5OJc5gR/e0Z41 X-Google-Smtp-Source: AGHT+IExu4UbDLGeyCVz2jr53CWSQj3FWfSkoT0Hw5NrAclb1/CFWB9M9Y/97ayj3SIEdtK151zB4Q== X-Received: by 2002:a17:907:9612:b0:add:ed0d:a581 with SMTP id a640c23a62f3a-ae6fbfa7d26mr80788066b.17.1752184721705; Thu, 10 Jul 2025 14:58:41 -0700 (PDT) Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com. [209.85.208.49]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e7e91dd3sm192882766b.28.2025.07.10.14.58.41 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Jul 2025 14:58:41 -0700 (PDT) Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-60dffae17f3so2156941a12.1 for ; Thu, 10 Jul 2025 14:58:41 -0700 (PDT) X-Received: by 2002:a05:6402:289c:b0:607:206f:a19 with SMTP id 4fb4d7f45d1cf-611e84a9aa4mr389972a12.25.1752184721009; Thu, 10 Jul 2025 14:58:41 -0700 (PDT) MIME-Version: 1.0 References: <04c1e026a67f1609167e834471d0f2fe977d9cb0.1752182685.git.alx@kernel.org> In-Reply-To: <04c1e026a67f1609167e834471d0f2fe977d9cb0.1752182685.git.alx@kernel.org> From: Linus Torvalds Date: Thu, 10 Jul 2025 14:58:24 -0700 X-Gmail-Original-Message-ID: X-Gm-Features: Ac12FXwFBMXaxRHdcUswF9pkpuvbALmMtsHBeK-c4iMg5ugUB_Hn2l67aUaOXFU Message-ID: Subject: Re: [RFC v5 6/7] sprintf: Add [v]sprintf_array() To: Alejandro Colomar Cc: linux-mm@kvack.org, linux-hardening@vger.kernel.org, Kees Cook , Christopher Bazley , shadow <~hallyn/shadow@lists.sr.ht>, linux-kernel@vger.kernel.org, Andrew Morton , kasan-dev@googlegroups.com, Dmitry Vyukov , Alexander Potapenko , Marco Elver , Christoph Lameter , David Rientjes , Vlastimil Babka , Roman Gushchin , Harry Yoo , Andrew Clayton , Rasmus Villemoes , Michal Hocko , Al Viro , Martin Uecker , Sam James , Andrew Pinski Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: 7F4C240008 X-Rspamd-Server: rspam03 X-Stat-Signature: qhm7ogcueg4844ugtp95ez4ryo14cotu X-HE-Tag: 1752184723-737138 X-HE-Meta: U2FsdGVkX1/cRMEbfFSzXeuW1f41csjwE9S+puUa9uxivtv8mjc1AakF4lNdvBjYN4NBYs1ONQ4FVMWvkwRpWvD2dgYDwBle4wnF1BKJEoaH7dJFixXOLbKKgB4zqHSJXYkpbZzDTgYIBe0a8fo5sMV8itKajy8OI14Ic+5Fk1kf3gWNZHtoZtopZg3FPGEsAFz/ZkVDaxKs31bCvd/ea/N0xpxHm2eZtjpS4IQ+ln1jjA6T+TT3Fd7N7RzfXfBnBVrWi3rLx/zE9ks1lQRXNKX34f00j26ypXHcMP6bmteiAwu4x0ERLuUuydfeOvYVPUqKAXEU+NZ5rgJaAETS2YF9JGVGDYA8Bun1/RPQ+xJdstDxK54i2rSU0gRZjJFU/+NS/ORao2km1U5+ml/3MN5XypzvLGR4WuF92HgGwJhN192Qnm4t8pwhJ3TAy0WlaN2utXbscXCereib+hTt5dDKUBxqQPrObHN8vpwW3vXwfgNC/quixPcjqO8nCU+/Ls9BqpD6aqVEMKzKnR9DIpdHG0sWjO0zKGGEQq1/QFLujUASlJRQG6LOEhj0Nk3CkczPBwHEpsllCGNJesxs6+CFrLQqgXYBuZ+VPYAq9Fy9i4IRgdqjzl6GNsEpBNqFoy75rJeAqhgHR4hXr+U3g1NKzH8bt0+eTuL9NyI9F/XmugNzZJDFfn/CyGVvpyXGTJK7ryqDOEdGBCVFYrYnCvjkVMYRP3epbbEUybxf5bM/B+W4Pvov7E1drV+KTjeASo/QDI7nkpODLG8PowhX2tlJS+Df4bydZ8hA8xF4QxsDot0n6OpXaS0gVQZSHc6VjdqoQCoAuDCYSeAlnfGd3Fu6UIyscyUl3oAEl7+afDCqZKJjCObmQVxzxUw/IPQR5AitB85z3oTOJ9tdHxXkOMLt7Bt4vlS+mGpHjDPUNWfq9TgqKloBRe86TknTKyg56eazH9I2aO3OXsGw05H 4WGQd2he EL//eBOVafe7OLMuqIDYt9vTAAeWPYGFPQRgaM4chSuwC8sq+HfW9b2h3IKmjS/19pRrZizluBH5xccDe7qFUMj4Xx3HngeiVLIhcfefA7SQvTGTPGRjhNm6mnjl18wMdR4cRLzx8jNEwq7zBI/MarxXe1QQ/UJp5G37/ScNIuWsi5LTT+xtJ3xu3g+3A93sJHe9QHuBUVH0yZCY3ZF/epcKgDrR/PndEzu9ODoNNyuGEcBhuDDyNiPZOr/N7ZYYmQnqW2yzR+AkRAsGtORt5/8vDIn6VqAWx7YRcGcEzOl82AxRzIlPsIYQ0ZVcSM+vkisyhYH2tk3g7Qq/sV6Ndt8OuHXXVXdF0wFzpUvawRWCTVLJxHsmQDhuZKW3yBJ34JL/2gP+wTQ+QSfvZccGRK6J814WyLiEIRu08HKvh93mOkCF7WzvRMfws5T5D5YzpwpmfMqOCzfZiNWJZGH0YqBI1DMuJ/cYQmZb/k3IhwEqf3qrMusVz4arEa/yuc2WFlPCIEsa/W9bQiYewxgFbQ9tx9syeOyJz5UYvp4oq1FcXKOLHytbZ/ZLjFMBaJY55VXw9dF/B3ogeJcmC78QqF0GOLII16d8DyVFNrKJ95ew7WG/AsrDGf80xpt+0IZ62Akgn5Tblh39edi0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 10 Jul 2025 at 14:31, Alejandro Colomar wrote: > > These macros are essentially the same as the 2-argument version of > strscpy(), but with a formatted string, and returning a pointer to the > terminating '\0' (or NULL, on error). No. Stop this garbage. You took my suggestion, and then you messed it up. Your version of sprintf_array() is broken. It evaluates 'a' twice. Because unlike ARRAY_SIZE(), your broken ENDOF() macro evaluates the argument. And you did it for no reason I can see. You said that you wanted to return the end of the resulting string, but the fact is, not a single user seems to care, and honestly, I think it would be wrong to care. The size of the result is likely the more useful thing, or you could even make these 'void' or something. But instead you made the macro be dangerous to use. This kind of churn is WRONG. It _looks_ like a cleanup that doesn't change anything, but then it has subtle bugs that will come and bite us later because you did things wrong. I'm NAK'ing all of this. This is BAD. Cleanup patches had better be fundamentally correct, not introduce broken "helpers" that will make for really subtle bugs. Maybe nobody ever ends up having that first argument with a side effect. MAYBE. It's still very very wrong. Linus