From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07BDDC61DA4 for ; Sat, 4 Feb 2023 19:51:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 003366B0072; Sat, 4 Feb 2023 14:51:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ECD746B0073; Sat, 4 Feb 2023 14:51:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBC9C6B0074; Sat, 4 Feb 2023 14:51:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CC9B06B0072 for ; Sat, 4 Feb 2023 14:51:01 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 651701201AF for ; Sat, 4 Feb 2023 19:51:01 +0000 (UTC) X-FDA: 80430652722.29.C3D2147 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf07.hostedemail.com (Postfix) with ESMTP id 39F5640005 for ; Sat, 4 Feb 2023 19:50:57 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b="e/U0/7Zm"; spf=pass (imf07.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.53 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675540258; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XXqZLuT6IJKVYT0/2ie4j2Zj0I5vvT2fCkqKaBFLuZs=; b=v5WSUF5cBem/kkRGVQwTGsxhKqcwjZxV7wQ1PHt8Njz2AGQNb+PF1eNHEfsBcn6Fjmwnbc jkG5YJsTn77hSFd7F7iB7gZJ9G+g0U/ImcqWyGWbHRGSAT7UqsBh9oTXX0J3NhnVDiPpUl M1V2A6mi+VC+TXJ1x10TtfQdVM1nTAw= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b="e/U0/7Zm"; spf=pass (imf07.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.53 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675540258; a=rsa-sha256; cv=none; b=1ZF9ShytYeL6t8pJoo5DwArMs7BbMpkbdbyw5e6jl+/s7MCJuuzfiphvB0SIFAlQETv3qP O4ddVGkTS1WDezfo+1ou0kR8b6lBpPva1/MhZ14vUmljqLNF2xdqXWE6AX1cTMc/9klUYs 4HpGbNRl51giCIXELWwUoV+1EqhZoRY= Received: by mail-ej1-f53.google.com with SMTP id hx15so23962283ejc.11 for ; Sat, 04 Feb 2023 11:50:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=XXqZLuT6IJKVYT0/2ie4j2Zj0I5vvT2fCkqKaBFLuZs=; b=e/U0/7ZmC3xl9Mx8ivBzxUUiJoNPiTw7CcE1qyUL+o08ualvm7R/rOVGNxEZohscQ4 btwKjuvQcYKD5I/lF0RWaexripdHlek4KX4ln95igIklMOWBlxrQ48cEbqD4x1c6nhbD ih9n9XtXaEauMUFvIg8hoePSW505GE5HB688A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XXqZLuT6IJKVYT0/2ie4j2Zj0I5vvT2fCkqKaBFLuZs=; b=xWJ6LQ8psR2sbDz2QJN93kYV+p1goA9FVlpTwCs2Zm6iT0Gs7c+SvXfklxKVlWR7Ez Feq7Hl8DZ0HhoGLdnov5kgdIWuNvRW0obCJ5R7RPjcSgyWgRwy6gDvyCFaHeBFFWxII4 pH0kNB0Om5+43Ids9L69HWgtVNK4jZ3RdfVJauDULXbo2/j1kA9jLpF5gsbF5/vAgwC2 xq64SkBua6dNKCzQ93iLLEgChUJM93X1sUn5X9z9lWiYYqnaAGEuwyUfPTaG4H1wf21v lXdIrOwBiSCEqyZtiusnAVbS92zk3ivd9egnIRB2oOvZL6uf96owfec8qw7d7MnXrLxj eqEg== X-Gm-Message-State: AO0yUKWehLKK4gfDMv6x5a5HOgK+Q4Xh3PakqTmW7EWe2e4h3oOXwTs+ 4A1kbRuN4aegbZcXWExl+L1PeZZr9KjJmKQpROc= X-Google-Smtp-Source: AK7set+itldKvCvhsjasNGvEwKbFlHA3PlLCimS4o+m64EYA61H0vGc+kZBM6tTGPTPYVNlK8rmnaQ== X-Received: by 2002:a17:906:4fd5:b0:88a:292d:be8c with SMTP id i21-20020a1709064fd500b0088a292dbe8cmr8109205ejw.22.1675540256355; Sat, 04 Feb 2023 11:50:56 -0800 (PST) Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com. [209.85.208.50]) by smtp.gmail.com with ESMTPSA id s7-20020a1709064d8700b0087221268e49sm3175963eju.186.2023.02.04.11.50.55 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Feb 2023 11:50:55 -0800 (PST) Received: by mail-ed1-f50.google.com with SMTP id v10so8140569edi.8 for ; Sat, 04 Feb 2023 11:50:55 -0800 (PST) X-Received: by 2002:a50:d0da:0:b0:4aa:9bd9:d81b with SMTP id g26-20020a50d0da000000b004aa9bd9d81bmr820436edf.70.1675540255245; Sat, 04 Feb 2023 11:50:55 -0800 (PST) MIME-Version: 1.0 References: <20230203-get_kernel_pages-v2-0-f1dc4af273f1@intel.com> In-Reply-To: <20230203-get_kernel_pages-v2-0-f1dc4af273f1@intel.com> From: Linus Torvalds Date: Sat, 4 Feb 2023 11:50:38 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 0/4] Remove get_kernel_pages() To: Ira Weiny Cc: Sumit Garg , Andrew Morton , Al Viro , Christoph Hellwig , linux-kernel@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-mm@kvack.org, Jens Wiklander , "Fabio M. De Francesco" , John Hubbard , Matthew Wilcox , Thomas Gleixner , Mel Gorman Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 39F5640005 X-Stat-Signature: aogozc4hj4bj5u3wae4uy9z9exf3j68n X-HE-Tag: 1675540257-962159 X-HE-Meta: U2FsdGVkX1+C4IXzg/aOHUs17VNMU7kroeGjWqBRg6CpcLP7SJTPJFlVGi0gorzdqMrrOfe7cI/zrTKqiSCC9np35G6ltO7rukAR7oPC4fkDmoEBB0on38cBSmbR8V+ryGALvCiwSov/nRv6GyM6adWZ7NHU4iEsqWvPvOEyM4VgevDw5jrZji4mJDbRdbDnwqUIoodpXf5TVAWGiSTr9Z5oVTlkF6AOCCqHTzUyCzBr3KbL/03iTUMB1XLngtSmO3ncCfwTrQY9P/7ibrUoILig+Ml8rbxfcsj7UniiPxzGA5KgMnXJlJFhLca58sBvv6TcPqGiOTcx9ElivyTJo64EuquGIp8ZlhlXs9VXJOcZJjGSUmeOecEkq6/acHgyffrV2gNiuX2llyLMMw7Ik4SFX4mHxO6uks4p/2mhlusZFHMGM8i/e++n1Hed5Ie31L6kOIE0yo4dfUi0kze/X9cfSYu55CByxYy2syS9P9vh+OmoC7R0yu8NuO1zNsxE/XqPu0d2AmuQ13vkGgTEB0xti0VShspaYp8EtVGEZM14ZwCpxzPQ3oFDMu+9hrrzlH5MJV+rJvHHOCF63g41rwpkNONaFjwdej+HVQZUvDrJIS6bwmV/HkjoIuwvtRyFNr/jqmip5bKt2wmF4iBJiUwSDsDrBKghfoiz6U2XRjiBwEIQQ8aw/R0D3WLOihV6oe+TOrdjwqlcHcFJZCePLnhJL3CknAxAYYmB2nvKekGdKJ+apPQJ/dHGDoOsZO3S2BFtrlatJGfMLTI3u+CKxFEaWETn8XW7oeeBVPh0eCEKmtwFt0mQLdQwnqCz2dD+k0ZRLugnNBLRDIDvsNXKjyxHtgXOSsbY/U0wiDyyICsRvMn1Iod9ksOT2+NJQkzVQaavvSafaxcifKd3ESu4/KVhfUpS2R8cNR2hfhFpUiFOdSzxvu5dKoFbWhWTe/H2Kbl3Bk46XzlhhNO0qaM RczPJZHg Dkx9LXeDewVxROCBOkKErQnRLAWJDvEV1oS3NrRgKx4F3HcUyHfPDl2mdc1j1YT17k0f0kgRhIj97DDxG1JDbIqVDcTucuk3Q+FNIwJAt9Zy44mhy8n4UBQS01ddSWwziSINsEjcleUR6N7bHa+CkWs89O+Bvw8kVIDZES43JjjrswimwJH21mHuM0pl7xTrAqAvmeWF+wKFq6NeDqt5fmQCHcmyxNkdKq0Ogdx67OXko6DeN7LWrHpnsL0UIg+vM2AiBgF4mClA4pcZPCtEjwHaNjXOSiIZOY/iOjjOE05IUIJ+R7XGokK+3oCrH5lcmZRCAsy08szwpj0M+mm+4A53b+a0ic4MzCGCgmWeQPhGOFZ+QuNBHqmMZ7IhSkSxW3yjhLC2XgXHBOGtWuV51aZPu/1OLmJXLXlIH+oWp9Wu7FZlGD8APcgxEEEHhTnWaoi8bKtERvV+La5hKNEOCzkIS8qR1BF4pBITRuM3OeqJfK+ULa7DrJePmUsu9CvzlX0Ahgyezf18J+re8ziWQoTtF+i5sLBMGvbW0SC4FQQgyrvQtXOaFKkGge0JSGK9JL2mZyhNXP4LB/FcgLRrABFpN9w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 3, 2023 at 8:06 PM Ira Weiny wrote: > > This series also fixes is_kmap_addr() and uses it to ensure no kmap addresses > slip in later. Ack. Please make it so. That said... I wasn't cc'd on all the patches, but checked them on the mailing list, and that first is_kmap_addr() patch makes me a bit unhappy. Right now that 'is_kmap_addr()' is only used for user copy addresses, for debugging purposes, and I'm not exactly thrilled about extending it this way. I get the feeling that we should just have a name for that "kmap _or_ kmap_local" range instead of making it two ranges. But admittedly I can't come up with anything better, and it looks like different architectures may do different things. I just don't like it. Linus