From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5F04D597C1 for ; Wed, 13 Nov 2024 00:58:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED2CB6B0082; Tue, 12 Nov 2024 19:58:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E831D6B00AB; Tue, 12 Nov 2024 19:58:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D05E76B00AC; Tue, 12 Nov 2024 19:58:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B1D006B0082 for ; Tue, 12 Nov 2024 19:58:30 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5657AC06A7 for ; Wed, 13 Nov 2024 00:58:30 +0000 (UTC) X-FDA: 82779259962.12.42188FF Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf27.hostedemail.com (Postfix) with ESMTP id 0502840003 for ; Wed, 13 Nov 2024 00:57:44 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=I5sWnFfJ; dmarc=none; spf=pass (imf27.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.47 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731459445; a=rsa-sha256; cv=none; b=l7WSymG6tYkKy78XnwMIuQ89WWJpSAgYs5+tM26oQc3hmGcO//sdx9fGTeJb8OwNDC/2HD iBbypB11enZB3vbFZCvAuysPtw/s7LLbwR0s/m3wIDhH5uVR5D8oWRAzhbsR2u5YtjNjbn 7lHq/3f8ZOJSpvyzsclxldal8G6UAjo= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=I5sWnFfJ; dmarc=none; spf=pass (imf27.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.47 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731459445; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5tJ813zBq+G2Ew0iXW8JEVhQMVvtnrBGzEzzKoVgMoc=; b=OgnNsCKpqnkRXsI06bI9tAQfDtK962rpJH09YO9goG3fQVTVOHNsCINKt0Uc1j6A1RrPX7 kI4vj5GbTHR+mCgxOPNQg7o1igVPdDBmReCrk86R92jL+JLXQCVBaUDmRL6lABjlToyjdr Q4k5wze93RZSyOBRPLPnKBCyzw5e8Zo= Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5cb6ca2a776so9546696a12.0 for ; Tue, 12 Nov 2024 16:58:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1731459506; x=1732064306; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5tJ813zBq+G2Ew0iXW8JEVhQMVvtnrBGzEzzKoVgMoc=; b=I5sWnFfJzjLcEQCbDbjsrNwihs4Jd8V2un/oW+p/zC/Q5JrIakKsYOVfy57S7KCiNs m8mx/PbAAcGMvJs94GMlavgjKByb+OkyE3hwChTHmmJklhaxxP5Iry/RavENE5V7fto2 BYoee/n7GzTxm/667lnheTSnzIVTD5RUsChVk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731459506; x=1732064306; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5tJ813zBq+G2Ew0iXW8JEVhQMVvtnrBGzEzzKoVgMoc=; b=QhAUhq+hfqMbEzlsICHJk2IbAUy3mDrHIk2q6bI7q5KxYYvh3cwHtrgdln9IP88OTv zVGPwymhB6KJRkavYnRBsKfyiKgDBBvrLmvPtjuJi8SXSJnVc2ng+2vUhPKERXWgOeAX MKOg3n1vdA6xFeznKkimBMWE24ko4yPom5mEBL1hObUzzqduHd+SUgy+yRAbZK+o+rlm vQXSUACONjMyfcA/4LXlzz+FFkV4UJ1jAkC8Vxe2Lza+qPJOgWXLyHo5a3oxYfqjDeGo Y0F8T7MD86gFAteXNkrIzVrQvjAeyJnJtnFeAwZRlL8Npe3N7Acey0940r5atNJCz+VM JePA== X-Forwarded-Encrypted: i=1; AJvYcCVs7kjxWeMwDchNMGFSP8q4zM+nVbvl4nShcah7UU02es0VIp+kMFIF4UjjBrU5xP8/AsATkNRBwQ==@kvack.org X-Gm-Message-State: AOJu0YwAbek0KaS2+xV78Kh3KuGh2AFYrxhSIRwyyHqcmHmVkQvTnwWT 50LKZZ0xRKExMnsJFOPWkh+yyGJkbWQIb5g15ct/nP1+ElKk7yzNxmyctZZWiGBHjvmoVIZw4I2 dFBMFLg== X-Google-Smtp-Source: AGHT+IEzUj6m6LahamjkeGOmhq8mQw/e6VzNcnlT9ML+hD7fYTJrdUGCSZLdwZwT4xeQrfqGlpFXig== X-Received: by 2002:a05:6402:278c:b0:5ce:dfbc:7fa5 with SMTP id 4fb4d7f45d1cf-5cf4f3b22c4mr4246224a12.25.1731459506390; Tue, 12 Nov 2024 16:58:26 -0800 (PST) Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com. [209.85.208.48]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5cf03b5dbf0sm6561235a12.15.2024.11.12.16.58.22 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Nov 2024 16:58:23 -0800 (PST) Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5cec93719ccso8173068a12.2 for ; Tue, 12 Nov 2024 16:58:22 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXYV4K9LF5/d+gEOMQi1AQETYkEHw8Jta6QNt+Ta+TEskEeNKDVOoprfpNAVr65kcCPTc9KFeBo+g==@kvack.org X-Received: by 2002:a17:907:1c11:b0:a9e:b08e:3de1 with SMTP id a640c23a62f3a-aa1b10a9779mr425956266b.36.1731459502310; Tue, 12 Nov 2024 16:58:22 -0800 (PST) MIME-Version: 1.0 References: <60a2309da948dc81e4c66b9e5fe3f1e2faa2010e.1731433903.git.josef@toxicpanda.com> In-Reply-To: From: Linus Torvalds Date: Tue, 12 Nov 2024 16:58:06 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 07/18] fsnotify: generate pre-content permission event on open To: Amir Goldstein Cc: Josef Bacik , kernel-team@fb.com, linux-fsdevel@vger.kernel.org, jack@suse.cz, brauner@kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: 0502840003 X-Rspamd-Server: rspam01 X-Stat-Signature: q84tup84crhh8zxug1kst8c396456kax X-HE-Tag: 1731459464-900274 X-HE-Meta: U2FsdGVkX19mtkx9FEC86B2zljPSUne3n0mGz2nUnn6KbN47Sy855+iBRy5PDCj8Mp2kE/Q2eKDvSlFsn+IYPritd8HsjK+OGGj26TrywFP1LmT9uaaA1TsnaqJpi4uQ3VreOeK2FuXt/mdSsxx2GgSZxbaB9leJh/XtRi7PAwYSHAmfJGA2e140aQBkFIKAYi+2Pa0d+y+V+k4OsCoHhNssaEcsFhRk75JNG6NuIBveA65mr0zm3btUIGCPnpdsOzGbDQfh5fTescfhaHtU1EdkeNF8xwKGPD1Kyv9QmLPkBk8pTeMVARqX3jBe6MCVn+TiDSXHPtIDcrTlubP9DxQICdOZwG3q8n40N3QdF/VzdvUalxX2phyI6Xu9P1K6s8sBEIHK1pFbGdBlRoqx6fUKTvjujWJuI2oTQzHJpB6nTu/kbn4ch5OqxZGnJot0dXu8e2I/3ZjW7uBsH9MKbqKzzVgijPm1PHbhdi8IwTjt8UB8Ly1WwRmxsqwjtijFQchS8ks4R9E+HnModn7Kg2Y1aWC6pXSZTSMD1As+/YpOu+sUokYTdnH4HE9x+lNTcFJlD3KByVq0RqrbkYU8k/o8UzNaEHA+mSBPR53T37Q1/XtEew9HQCpEGhF64rDkw7sJHB93DRaknl/Sq9hHltM/q4ZUl9y3CILVRo5YZPp1SMzg9PEOgmz+zhZaEVNk7lWHZJTfNNQbPU4axQXvahgktOUTrylShJeztkAGdGvPHV+vgcdhULCChXDnZqefhZAP57yAURJ2/3BFQ1SkQM8l7IqOgiX0vgPC0Ee0pd/GnOpqBs2fQQzxu5Sx2/y+saOWHew5DfvLf7l6/zNcpDZFGb9NusnGuUoplxPHvuTpbVrWd5I0ZNHoBFYKqyTOuGFrWYZpUhlNh5PrcXsL8rjm5O/kXh61E5jg8FvNVdveDgeom9WNk/C0sXlx3z7Rs4L6dUWNKccfR2eSAol cTcPHk2T J5DqE6dM4/EQTOOs4PZDuzKrM13LU9qSIVPWVa1yRAgPtCIbc/0LwrQf1pi8uK88XNoEGM+7JOlUtrG/hrIf4Gha8pHpHiV00Gdm/sU6B80H1RGemESKI6U36E4MF0h3Jo4AjBSOjUy7+DNrtzEPjknryAzX8/Jmp7aMzWlH8QXz1cJ0Pj/3PqDe+VkpYrKdFs7WnHrwgjUkKh866n9+HlxcC1+DbtqEv5pJch+yDnmzU5oKfKebDDNZfRn23A/lgZvJFOkEy/8f/r5icZ+RAcYKrNYY86hiKaRHJTQ7O7Ak3xDxxSBYd6oL3N/J98l2uZy2pNgaVCIsP3O42KvJAVZXBj5PUYvWwU1looluZpUJ69dbyGIJY8tu9RHb+DoypfVXOKkOHNnNlvurrMPwjiGcHMtIPADVExrYR82JgDf0rkRd2FT2bYJ+VRFLk2+YbATuCT9lF5ElSfpoPLpWpc2bkRgMWvLC5kodq9stlzFBMfFB+SzU1kB1lxw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 12 Nov 2024 at 15:41, Amir Goldstein wrote: > > You wrote it should be called "in the open path" - that is ambiguous. > pre-content hook must be called without sb_writers held, so current > (in linux-next) location of fsnotify_open_perm() is not good in case of > O_CREATE flag, so I am not sure where a good location is. > Easier is to drop this patch. Dropping that patch obviously removes my objection. But since none of the whole "return errors" is valid with a truncate or a new file creation anyway, isn't the whole thing kind of moot? I guess do_open() could do it, but only inside a if (!error && !do_truncate && !(file->f_mode & FMODE_CREATED)) error = fsnotify_opened_old(file); kind of thing. With a big comment about how this is a pre-read hook, and not relevant for a new file or a truncate event since then it's always empty anyway. But hey, if you don't absolutely need it in the first place, not having it is *MUCH* preferable. It sounds like the whole point was to catch reads - not opens. So then you should catch it at read() time, not at open() time. Linus