linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: syzbot <syzbot+75639e6a0331cd61d3e2@syzkaller.appspotmail.com>,
	 Andrew Morton <akpm@linux-foundation.org>,
	jordy@jordyzomer.github.io,  jordy@pwning.systems,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux-MM <linux-mm@kvack.org>,
	 syzkaller-bugs <syzkaller-bugs@googlegroups.com>
Subject: Re: [syzbot] WARNING: refcount bug in memfd_secret
Date: Mon, 25 Oct 2021 10:00:22 -0700	[thread overview]
Message-ID: <CAHk-=wiJRdV-7NYvh+8mzDtuPvTg6PHHUedeVXjY92+gxhYJbw@mail.gmail.com> (raw)
In-Reply-To: <YXW9lmQVx1PLX9aj@casper.infradead.org>

On Sun, Oct 24, 2021 at 1:10 PM Matthew Wilcox <willy@infradead.org> wrote:
>
> I agree with you and suggested that if anybody really cares (I mean,
> you need a multi-TB machine to produce this problem) that we simply do
> what we did with the page refcount:

Ack. That looks like the right thing to do.

> +       if (atomic_read(&secretmem_users) < 0)
> +               return -ENFILE;

If somebody sends me a proper patch with a sign-off etc, I'll happily
apply that two-liner. Hint hint.

              Linus


      parent reply	other threads:[~2021-10-25 17:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-23 19:35 syzbot
2021-10-24 19:54 ` Linus Torvalds
2021-10-24 20:09   ` Matthew Wilcox
2021-10-25  6:37     ` Dmitry Vyukov
2021-10-25 17:00     ` Linus Torvalds [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wiJRdV-7NYvh+8mzDtuPvTg6PHHUedeVXjY92+gxhYJbw@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=jordy@jordyzomer.github.io \
    --cc=jordy@pwning.systems \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=syzbot+75639e6a0331cd61d3e2@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox