From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 770BFC433FE for ; Wed, 9 Nov 2022 21:04:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B7EB06B007B; Wed, 9 Nov 2022 16:04:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B2EAA6B007D; Wed, 9 Nov 2022 16:04:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F6058E0002; Wed, 9 Nov 2022 16:04:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8B7876B007B for ; Wed, 9 Nov 2022 16:04:29 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4E0A71203C0 for ; Wed, 9 Nov 2022 21:04:29 +0000 (UTC) X-FDA: 80115132258.18.10A0635 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) by imf13.hostedemail.com (Postfix) with ESMTP id BB5D820009 for ; Wed, 9 Nov 2022 21:04:28 +0000 (UTC) Received: by mail-qk1-f181.google.com with SMTP id v8so11725801qkg.12 for ; Wed, 09 Nov 2022 13:04:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=XpdFWP2UvcAbMGbUYPrSMtfLikuC8rkjFeQL5hAciEA=; b=KdE1Y7fAhltwN53hSoHGDBlfPvPeRlvmLCaw+KCDc1dgnDMy9H9uLEGV037MQ0FqfD 3jZ3GqySXl6FuE9sMkaeHxI/FeCXjw9BIDb8HnG+G4ne79A53gyDug1ySQnIjLw7vakB nWaiifZbt81yMI6xYRyWLd5CJDeRZcuejE4mM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XpdFWP2UvcAbMGbUYPrSMtfLikuC8rkjFeQL5hAciEA=; b=F2gp/AsSX87keSDlaP/M3kBAwGYi4Bc9pmZcWtxecbxZMh9g45oJ6m4uSXwKn5ncfN G7kdcUlzP4OgsENtyxXJmaPSbpjbhuRvv8rBBJqGuXCw4FXW3wx2yu3+rNUNBN7uAxmi M8SduKqOdi3plBzzez58Z6C7bzG1B9gtF6nDf2AUIo0o584sShCCX89hpSJE4qJRXSvl KuIxshDpunyj8osk/vkTiSMKxmspXYrdb+FLeaUHgZhNK1fTHMKkmly/36Hn6fx/94/s P1uTlKxFi/qdgAjzupnlfemPgTbZJzXn6qrm8rf7xaXPdoQtRR3Gfro/ykcnxH3OEDOO b9Zw== X-Gm-Message-State: ACrzQf3EJ+iShzVvznJgfZ7N/+9vtKlGDBqsp1E5vjBe5gsQjdbni6DL t9HH0uzAPouZ0xDlu0zZ5L+Px+Uat5MbUw== X-Google-Smtp-Source: AMsMyM67I9OEGJInpJEC7exf7RfIE2q13iHqqlHoIJHCJFGKZHq4hznX3KzxIunhpsEAtCEnnxkGlw== X-Received: by 2002:a37:5e41:0:b0:6ce:79e2:68af with SMTP id s62-20020a375e41000000b006ce79e268afmr44956941qkb.239.1668027867811; Wed, 09 Nov 2022 13:04:27 -0800 (PST) Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com. [209.85.219.174]) by smtp.gmail.com with ESMTPSA id c8-20020a05620a134800b006ecb9dfdd15sm11380614qkl.92.2022.11.09.13.04.23 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Nov 2022 13:04:24 -0800 (PST) Received: by mail-yb1-f174.google.com with SMTP id n85so184298yba.1 for ; Wed, 09 Nov 2022 13:04:23 -0800 (PST) X-Received: by 2002:a25:bd7:0:b0:6d7:7464:4859 with SMTP id 206-20020a250bd7000000b006d774644859mr14656214ybl.362.1668027863307; Wed, 09 Nov 2022 13:04:23 -0800 (PST) MIME-Version: 1.0 References: <20221109203051.1835763-1-torvalds@linux-foundation.org> <20221109203051.1835763-4-torvalds@linux-foundation.org> In-Reply-To: From: Linus Torvalds Date: Wed, 9 Nov 2022 13:04:07 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/4] mm: delay page_remove_rmap() until after the TLB has been flushed To: Hugh Dickins , Johannes Weiner , Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Nadav Amit , Will Deacon , Aneesh Kumar , Nick Piggin , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Peter Zijlstra , Gerald Schaefer Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668027868; a=rsa-sha256; cv=none; b=ZBg5wMCK3NCNilTGiERnTFjglipYGI74RggnDZr+IOq3+6XKteRYnlgwfyRw0scb0sMx2G wxmV9vEau3o84qKmRrkALixngaitu1wULtvQuVUJSTN2Snio8OmDZqb96UjqGOPFb91cnV 13/F8VhMMok1mF0MJs1x6CzDgFcU80U= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=KdE1Y7fA; dmarc=none; spf=pass (imf13.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.222.181 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668027868; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XpdFWP2UvcAbMGbUYPrSMtfLikuC8rkjFeQL5hAciEA=; b=hqA0QSYF1vHOXJD1U9oFKh4ZOz4N4oLS1N/1xrLtVKvXUur99m5k00Z3VToD0kUn43kSHw rsCza7vMPcw3IpECPANtKLJk7RA2M6KyyHsRiSoJYYJ5rEmJe0B6AanF99S9IFErbBzLVi nPj/iDzbUN8zmMty68oYYmRC2vlEa44= X-Rspamd-Queue-Id: BB5D820009 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=KdE1Y7fA; dmarc=none; spf=pass (imf13.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.222.181 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org X-Rspam-User: X-Rspamd-Server: rspam01 X-Stat-Signature: o7psbqg7b58cozg6qk58ftr9dhs7t6fd X-HE-Tag: 1668027868-820709 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 9, 2022 at 12:48 PM Linus Torvalds wrote: > > I'm sure I messed something up in the process [...] I hate being right. The UP build requires a #ifdef CONFIG_SMP .. #endif around the tlb_flush_rmaps() implementation in mm/mmu_gather.c, since the UP case now shares the empty "no nothing" implementation with s390. I'm not going to re-send the series for that trivial fix, since nobody is likely to actually care about UP anyway, but since I noticed it (after sending things out, sorrt), I'll just mention it here. And I was so happy about sharing the s390 and UP case, and avoiding any code being specific to s390. Which is what introduced this thing. Oh well. Easy fix. Just egg on my face. Again. Linus