From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DB19C02199 for ; Sat, 8 Feb 2025 01:01:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D8992280004; Fri, 7 Feb 2025 20:01:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D12B8280001; Fri, 7 Feb 2025 20:01:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8BC5280004; Fri, 7 Feb 2025 20:01:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 97E64280001 for ; Fri, 7 Feb 2025 20:01:22 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 11A58C1112 for ; Sat, 8 Feb 2025 01:01:22 +0000 (UTC) X-FDA: 83094974004.06.5CBBE66 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by imf23.hostedemail.com (Postfix) with ESMTP id CDFCD14000A for ; Sat, 8 Feb 2025 01:01:19 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=EecsFKRS; spf=pass (imf23.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.43 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738976480; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CAsidQK6MMFyKHMlWJZB5X6jfUBH59IMYB84m4rpH7I=; b=zcc7sUKsq7sdCQdJD3tuii7fqk6++3ocf6MxqJZKUOryz+yIlh9zTyZjptAjoyviQRy+Ny Vb475sWDzHUTK9brpUZrqJFYRkKuQ5ztl3GEaX7hYstAGR+3EMPSigWzc/fsx7/2GYziMz yVB51cSKWLWLvWDrX0ZYDIWF69TWkRo= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=EecsFKRS; spf=pass (imf23.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.43 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738976480; a=rsa-sha256; cv=none; b=oMJhawPH8B4EDnsJeBRCi72/OFlUWFcU1PJQvEH64LNPAXaWdmDtVDTDRgdHBz+aRPcKZU JX3Epyf0zwW70tttJEAe6mY4kDCFJyfjutuyScwoKDcsgwfiM4AI8r/N/w7nN6hawFZdTK XA3LKSYiBHebL1Ho4Mo3N23lE7aovLE= Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-aaf900cc7fbso458991366b.3 for ; Fri, 07 Feb 2025 17:01:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1738976478; x=1739581278; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=CAsidQK6MMFyKHMlWJZB5X6jfUBH59IMYB84m4rpH7I=; b=EecsFKRS6AJHHn4GWroizD+yVUlKp2Htnq6QjX96nv5ZqbyrBU9AAjI/1DRYHSilGK VYG7p/sN3MoYHZJMXeBI+NHcnJQ8UB0AYAVOUUsmx7sLyoFLQe4EsYLLiBIoj9NEfFzS bqEKUs5S40kiNoTvvVbTIluIeassyFZv5duRI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738976478; x=1739581278; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CAsidQK6MMFyKHMlWJZB5X6jfUBH59IMYB84m4rpH7I=; b=Momfdz0ERy+YxbRudcqy2lixhJMJGEJpr5LmOBW2BG/0dRhkF7NeVbXkoEC3Md4yUG m4RjKIdiOd1o4wrSJdS3fYP9sefwX0yLufpl6fm1UYF8FcPpKNDs+9YA11UYHf6ApLt6 DZHKvmw7azWr99EPevwd0NSfHxVnTtrbMIjezodx6Eyh8u59HLNyDGn3sX2uI3sLNSQb LrBL151bdgwxZuwRC4PuhYx80ZHjp8ZR1kpuhCl/UsJiMBBmL2HOdv2eEEdMxPj678l+ G2sWJLoU8yYot3nEaxQ4ZpC8KGOzOHMq3if++a93xfQAWd+/v8/jN9THST99a6ptFj4g Rc0g== X-Forwarded-Encrypted: i=1; AJvYcCUARgCLqQGkx1IzmwO8QfJ8GSRiyktuW03Wo27ZCsnDo/z8+UZIGc+QITsL1A3JBLMAdVWSPbj9XQ==@kvack.org X-Gm-Message-State: AOJu0Yw9/4zsRdTrp9NtsOt7mTrJGcMnYbto+AgVENXWR1mYti8OukgV GNe64zZg3aRAQRWt4RMTBbdFi1ErNGpuTvYbQqpHegIwqSyf6v3TNTgTbxOs5h1cLPkJ6zJQc5v GBq8= X-Gm-Gg: ASbGncuZxi+1FBuLup7voWr2XqTbj52sAvqWU/RR1PIpL03JuzzSKOg/EHZAf2KQ8m2 68spkwqZREb3tLFTs19/BX3amJEAGz4kgaa4Mri8oYwzxA39AaXKx4Q9TRn8Mo5SS93++PZdJeY LhR12JrdgqFwFwong3y7Ax9v8MZyRCddHrZ3+5M3Ktzd+SvDHhUZU3t7iFV50j6Kdp8DT9JORRn gY1KzxSPsoyQmpbtPvO4mt2hOx/NXLutGo21cOtujW8Vh3Q/agwdM4BpwDkuz0DUXiznCx2Pjd5 /MxoZ5yv19Ggy5W1+CEZUbXasjY4P3xN/V+o97lDA3KWcniY02q+FmtUfpdXOkMbvA== X-Google-Smtp-Source: AGHT+IHpM6aE63j6plSolWqN10Ac4LLsq3dB5LcdKERPNc1tEq6eED4M25XsuCROD/8c0tR7ECE1cw== X-Received: by 2002:a17:907:9719:b0:aaf:8f8e:6bf4 with SMTP id a640c23a62f3a-ab789aeacc1mr514801866b.26.1738976478128; Fri, 07 Feb 2025 17:01:18 -0800 (PST) Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com. [209.85.208.48]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab77dcb9336sm307417766b.27.2025.02.07.17.01.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Feb 2025 17:01:17 -0800 (PST) Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5de4c7720bcso1785104a12.0 for ; Fri, 07 Feb 2025 17:01:17 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUQqw5ODZvjHlOuTpzq7cP/0JHX1ouQHy7k9Ff2aE/LdSxIeKwXsiSmZSSIivl4O8hkkQEE5MhD2g==@kvack.org X-Received: by 2002:a05:6402:4608:b0:5dc:7538:3b6 with SMTP id 4fb4d7f45d1cf-5de44feb687mr5666498a12.1.1738976476819; Fri, 07 Feb 2025 17:01:16 -0800 (PST) MIME-Version: 1.0 References: <20250131191231.1370466-1-bvanassche@acm.org> <20250207164926.6daeac77@kernel.org> In-Reply-To: <20250207164926.6daeac77@kernel.org> From: Linus Torvalds Date: Fri, 7 Feb 2025 17:01:00 -0800 X-Gmail-Original-Message-ID: X-Gm-Features: AWEUYZkeg0wYXjpzfi5m_V4Uuw8xs1LDtPDCNnBHSdgnGiVKcI8LF5ufDujgWGU Message-ID: Subject: Re: [PATCH] mm: Fix clang W=1 compiler warnings To: Jakub Kicinski Cc: Andrew Morton , Bart Van Assche , linux-mm@kvack.org, Ivan Shapovalov , Vlastimil Babka , David Laight , Nathan Chancellor , Pasha Tatashin , David Rientjes , David Hildenbrand , Kaiyang Zhao , Joel Granados , Sourav Panda , Johannes Weiner Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: CDFCD14000A X-Stat-Signature: 1sabmswkrmkz1iz345198x8p4qptmofs X-HE-Tag: 1738976479-380583 X-HE-Meta: U2FsdGVkX1+iPcdqWigrBEEIPAm1zA+PAmqJDiovb2lxOmRMHOiauJxbv3ioY2OqIMWH7aYUgrhKepgs/n7oNUzBG+QIF4V7erXXgdRilMuLVOHzlWLM8U0OFNPvqyjCtqmlAGozS00pBvLiqeOPjlE07sBzcPRmQccYsohtMMdg6SOLDGK+kFUG3bNmCW8+5Xr/nYyqXVi2tQVxmXlLRFiL/ge8kPCdHuVN737LTRx8wWvM75Ggg+TP1Ubf9GU7tCpNtJ0PAQmZKYpBKeoiua6Aao4/rje+uB18P3BUYwTjcmJmy9xYGpn5SPD173k3yaQHgXpo7LCsPpX7cRYpyt43K0USe+VoToSMRG5Zn+vQNgXjgu2ffUoT1xMNvvi4FwWQ8kX9pkdRui0nAV6e0S/7XOQs3qLv2DSxIEAtDl30TZyKO80Fwlc4KZrBQbzmQWBrJNamvtCDJIIuqsUzt/jF57mews+rd4bUolfXSVvkFgQkXIkMSWnujO/+07yUov5HDpX8p+jt2b1szFQYXqcbVFX9jes6f5LN8V5Ma19C8ql3E5k6Rn0cmDShvym9ZjFIfZt9x7LYUVkNDLT+PjdDWMa8JkXQVlr+nRm3+4TfUOLXUCtZM1/dk/dE7g0MC/H6qkhlDGI86m3VhJ9o7xlYHI62Cw6t0lXmctAlmG+D8MCIJ15QL6HjDPTj8kTdiRFu9F1fPlB04fST5UnGCTRyG+7mgB43EWlpm99yV3yEL5R04qLBLKHbB5UJsPKKNEtueRG2byZy+tgV0aUry35LJF2mOV05ijhoIgWwwx+vm+bmdVnTxRRjZx/iVwEmIg6Zm190L5bU35Oqmua5v0fQr9msCSDmQRJeCEyhtrFsuAAwj8RYXnQRTx1dxlpV1ZHuozCs/JW1ieyWgLmGla/4TngnqO5NxQa5rkdRIq/OZ47MfpeUqbtfdf28GuYqcZra5n/FH6lFHs9jUQf bdLm14Bu nvQsdV0Re8ob3i5F+p7rFUkd0evm0/69tRqAtN0QOs7eOX5rp+FQucSJt6plEvsyVJ+VYNic7rzf7Keckvkg2sgjpnGOIzF5IV0yQoC/KXPYn0x2gZxOUaF6ckqthIwNo/HOZSM2VNAAk4HCu6pTgvkVupDoZtaZSdfmwAMY54z0AjJA83QDmebBvZlAmvkv1mZd7/GeMARLDLzIeR8rRUSvNekxcJHoAvfbxYxP0FIvOp3fnkw2fH20jv7V/qM0N9NHT5SlLvtY7mi4KZu5BGYEaHW/JFE37EfZJqL3NFE7e665pzJJ0vgPTC+mH3sAVX0cJiEj7xMWt/3aKhdcDm+rbc90nOHsjqpg/dzSC3LxXbirDTD56rR5jK+1bwcmTdrjtvEDJWX5z2Zh8G75dL3HCqQzQTQTZsX7zsZN4B2Q62TbNEzf3hHGhImReUQLam5fM2DAYMqH06FRnRmLOL0CjhJa1SteXy2nQBF+6PJou7LU97mxoBZhAcd9ygHhnph31/XBpll/LPBeKNeXimiG4lw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 7 Feb 2025 at 16:49, Jakub Kicinski wrote: > > Could we possibly please still consider taking this in for 6.14? :( > Since the warning comes from vmstat.h pretty much every object file > generates this warning. clang 19 is getting more widely used now, > its making it hard to see new warnings. So: - I build the kernel with clang, but I don't have clang-19, so it's kind of pointless sending patches that DO NOT EVEN EXPLAIN WHAT THE WARNINGS ARE. - and even if you explain *WHAT* the warnings are, please also explain *WHY* they are valid and should be cared about. Because honestly, W=1 is literally meant for "warnings that aren't necessarily valid". That's why they aren't on by default. So no, I'm certainly not applying unexplained random patches that don't bother to explain the what or the why. Not for 6.14, not ever. Fix the patch. Explain the problem. And possibly just disable the warning. Linus