From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B712C433EF for ; Tue, 8 Mar 2022 21:22:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B4E268D0002; Tue, 8 Mar 2022 16:22:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AFDB78D0001; Tue, 8 Mar 2022 16:22:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C50A8D0002; Tue, 8 Mar 2022 16:22:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0180.hostedemail.com [216.40.44.180]) by kanga.kvack.org (Postfix) with ESMTP id 8F2648D0001 for ; Tue, 8 Mar 2022 16:22:41 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 54844A9448 for ; Tue, 8 Mar 2022 21:22:41 +0000 (UTC) X-FDA: 79222493322.18.DA02209 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by imf01.hostedemail.com (Postfix) with ESMTP id 9E9B44000B for ; Tue, 8 Mar 2022 21:22:40 +0000 (UTC) Received: by mail-lf1-f51.google.com with SMTP id bu29so376867lfb.0 for ; Tue, 08 Mar 2022 13:22:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ITqWpEZwrmmJzxal3MypORnmA0mDOzhlH8+XcvCxIyo=; b=HBj/d6ypv10UMkfaM2OS15pVbsLfF4xN6WVmpOfhU/y5gJzN5IFBq1T04eDhff8+n3 G2fSh+r/zEea/7VW6snxkdVJFPV846h0LVdPFFmKUFSATqCBw+wjJGQDAqaDfbX2/4WM 6s5tfRAAowQx5Php/TTtIUA6tereJtP6Hwk5E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ITqWpEZwrmmJzxal3MypORnmA0mDOzhlH8+XcvCxIyo=; b=y27pr+eiQiNrbFWPXOD09s0V3utc3+qXcP7XJDYkdAP5DrdCiP98qyBLIOJFJPAyj1 k58xpJcS1PBmI91ZazxzzafEp4/rPi5Y/oIcqmTZAE/Sv76TTl3FGX01sLcnD6Yourdu OSpn+8OoV6V81StPDkOZCHLXcUDIyVtRmEhtRRxBO7J3y9vckH9LmE1fyXIAj8MwXY8n +qSbyPX6YfyrRMMM1SH31tceCfUfwqRCeoHCRspbhdNyP26eprxh0TIzRAibc95IS6PN tdmlfF3VnDMtlfcuecZdiLkIyaYMf8cLcplkZfHk5SmVyTVhgBcCwizUC9bktA+iqVy3 4XnA== X-Gm-Message-State: AOAM532a7wupCVv1/pysys6YIHWMYjqwnPjxd6c7M/6txb4No62Dmnqq oiUz8dsGCd8rxdRlXNwIzCdX/HDC7TEv4AR0g3A= X-Google-Smtp-Source: ABdhPJzTTyRQb2lsYqVVU3KGT4V/aKt+IgzI5ShObQ4oyiARcMKrodXrb7N5o78jA//GrA08Rtmlsw== X-Received: by 2002:a05:6512:1093:b0:443:3d8d:84af with SMTP id j19-20020a056512109300b004433d8d84afmr12470858lfg.334.1646774558560; Tue, 08 Mar 2022 13:22:38 -0800 (PST) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com. [209.85.167.54]) by smtp.gmail.com with ESMTPSA id n13-20020ac242cd000000b004433b7e218dsm3683111lfl.109.2022.03.08.13.22.38 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Mar 2022 13:22:38 -0800 (PST) Received: by mail-lf1-f54.google.com with SMTP id l20so233797lfg.12 for ; Tue, 08 Mar 2022 13:22:38 -0800 (PST) X-Received: by 2002:a2e:6f17:0:b0:248:124:9c08 with SMTP id k23-20020a2e6f17000000b0024801249c08mr334510ljc.506.1646774547965; Tue, 08 Mar 2022 13:22:27 -0800 (PST) MIME-Version: 1.0 References: <20220308141437.144919-1-david@redhat.com> In-Reply-To: <20220308141437.144919-1-david@redhat.com> From: Linus Torvalds Date: Tue, 8 Mar 2022 13:22:11 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 00/15] mm: COW fixes part 2: reliable GUP pins of anonymous pages To: David Hildenbrand Cc: Linux Kernel Mailing List , Andrew Morton , Hugh Dickins , David Rientjes , Shakeel Butt , John Hubbard , Jason Gunthorpe , Mike Kravetz , Mike Rapoport , Yang Shi , "Kirill A . Shutemov" , Matthew Wilcox , Vlastimil Babka , Jann Horn , Michal Hocko , Nadav Amit , Rik van Riel , Roman Gushchin , Andrea Arcangeli , Peter Xu , Donald Dutile , Christoph Hellwig , Oleg Nesterov , Jan Kara , Liang Zhang , Pedro Gomes , Oded Gabbay , Linux-MM , Khalid Aziz Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 9E9B44000B X-Stat-Signature: 1pcuurdq11md9e319mse5go9hdgquret X-Rspam-User: Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b="HBj/d6yp"; spf=pass (imf01.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.51 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-Rspamd-Server: rspam07 X-HE-Tag: 1646774560-264818 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 8, 2022 at 6:14 AM David Hildenbrand wrote: > > This series fixes memory corruptions when a GUP pin (FOLL_PIN) was taken > on an anonymous page and COW logic fails to detect exclusivity of the page > to then replacing the anonymous page by a copy in the page table [...] >From a cursory scan of the patches, this looks sane. I'm not sure what the next step should be, but I really would like the people who do a lot of pinning stuff to give it a good shake-down. Including both looking at the patches, but very much actually running it on whatever test-cases etc you people have. Please? Linus