From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83813D3C92D for ; Sun, 20 Oct 2024 18:46:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D02D86B007B; Sun, 20 Oct 2024 14:46:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB27E6B0082; Sun, 20 Oct 2024 14:46:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B79BB6B0083; Sun, 20 Oct 2024 14:46:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 98B016B007B for ; Sun, 20 Oct 2024 14:46:34 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 818E1C13B4 for ; Sun, 20 Oct 2024 18:46:18 +0000 (UTC) X-FDA: 82694861340.29.7096DD2 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf01.hostedemail.com (Postfix) with ESMTP id B3E5540011 for ; Sun, 20 Oct 2024 18:46:20 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=EFdb98Ck; spf=pass (imf01.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.54 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729449942; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0PLJqukBfD4fHf2ztQUKQIxZkUV+Rj9iZfPkEtdHboU=; b=5LBeRDyYTd1PBCsUxia5i3Mwhm25A7gZ7+JDE8Kjj4HvcXqwhN6Y6gP0KdL6ec+sd/dDE2 bcea7k2pgmEU32yrvtUWxujTCqUXehGKo++F7vVbGAUq2Z4diNUHpUCh3Bmqw/g50EIsu8 +mJRk7W626TxSGRXJfVEL3lx1wggaLk= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=EFdb98Ck; spf=pass (imf01.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.54 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729449942; a=rsa-sha256; cv=none; b=VJTX86wln3JOEj1i51CAhIHpvu2pvAVzV+jh3kLTnPGwrhvKJDwhTYMs/CJIt5USBbQars vwg5XfKySrJcPai2VIHsPB8N630G6ex+GUs9zmDMKkVHL3RPjNtLxjMOpaTR0n0+Q5AgVa PLerbwq0XQ2pdOuQygoTMrtJXiH1730= Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-a7aa086b077so419479966b.0 for ; Sun, 20 Oct 2024 11:46:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1729449990; x=1730054790; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0PLJqukBfD4fHf2ztQUKQIxZkUV+Rj9iZfPkEtdHboU=; b=EFdb98Ck77WseiSmzK2ZGQKoCkT8aVd+VKLOr+R8LYaPsv5/eTMXcnK0WON6uQFzsH XC3Cea6gyaJuB22+hXRXRZ44d8ET+wce08+zWal6R2cizUvdopy/rHINphtYAufVyPID sGVxn+VrQdEXInrHtqNB8j5RQNjXrLNrIbzyo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729449990; x=1730054790; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0PLJqukBfD4fHf2ztQUKQIxZkUV+Rj9iZfPkEtdHboU=; b=qDKDwQsEzecdENY9/Pl+Oz8euWXq8AppEbaS6vIcEMioPDLmgLzdsd8MwjkSzIxs7d NqbqnKBJnAg2Vo37BJIjsKp+BM58kQDu2zENxeLRQEV0cqULLqVEv9lu3T1Esu+BrhF0 W2OxTjotQRBlV2GdzNwoiR6GjmXyEZUGi1rr9lopdjCIsTyZabt42JGMoH66Ft4gKizA p0dAVBue4f7jGSdwXJp9GOvJyClbTAQFL9JNmAEIjlHVu6719R3x+WcNQ92AiejXmLVa h3D4ggt0U2XQQvBQmBYRrjlF8DcMm2enhwgeENP7fkc/8lWFqAwNqdFRqDC8oHOBPCPq G1Kw== X-Forwarded-Encrypted: i=1; AJvYcCWtPa/cKrDD2hQUK9WbVRgUPtElK0mSW22ZFozDaQRwRZFr2YL0KeXKL35az9aF6gOy3po7CxYb8g==@kvack.org X-Gm-Message-State: AOJu0YxFwgL1XcmXZMxrFOFmppbaY0Tcd8NaGybNtio7Y0aZcbY9gZim SBqkdEjb2bnwfruZ0KrtafcErBDQBDMWi7vJXNiIVqEpx6O+YYNjeuYiSJZ19kgp/hKrXJhLeAH SHz4hVQ== X-Google-Smtp-Source: AGHT+IG0gTv/UifkiXDM971/ouTktIMgL18BMM8oApRpTj1eVMI8s93gCnzRalmdPKdy2kNcMB7hng== X-Received: by 2002:a17:907:944e:b0:a9a:6314:40e7 with SMTP id a640c23a62f3a-a9a69a786b0mr863314866b.17.1729449989819; Sun, 20 Oct 2024 11:46:29 -0700 (PDT) Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com. [209.85.218.45]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9a912f7c32sm117109466b.90.2024.10.20.11.46.28 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Oct 2024 11:46:28 -0700 (PDT) Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a99f646ff1bso463169066b.2 for ; Sun, 20 Oct 2024 11:46:28 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCU4xL6QPlPUqtCMj11+/HcwO+VfJWC155B/3cGmDW5cccMB+0QCP1Iaml1EGb8YHpoDj+o+7eyYIQ==@kvack.org X-Received: by 2002:a17:907:2d86:b0:a9a:29a9:70bb with SMTP id a640c23a62f3a-a9a69a7866amr846780366b.14.1729449988270; Sun, 20 Oct 2024 11:46:28 -0700 (PDT) MIME-Version: 1.0 References: <20241019210037.146825-1-kent.overstreet@linux.dev> <90bc0794-4cab-415f-a442-4af85a32eed8@lucifer.local> In-Reply-To: From: Linus Torvalds Date: Sun, 20 Oct 2024 11:46:11 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mm: Drop INT_MAX limit from kvmalloc() To: Kent Overstreet Cc: Lorenzo Stoakes , linux-bcachefs@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka , Andrew Morton , Uladzislau Rezki , Christoph Hellwig Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Stat-Signature: cu6w97ug8ecpuie9j64ozqaup76cszeu X-Rspamd-Queue-Id: B3E5540011 X-Rspamd-Server: rspam11 X-HE-Tag: 1729449980-413861 X-HE-Meta: U2FsdGVkX19+g1N+g4NRXcOO9ZsUWrrIxQvQtRPRQM74fRQRR2PIAR+R+r3a8tkFtIX7kSxrllU9mPYZzfFWrDvpExet9LoxskbKPgmRS5GxGiJFjgjBvtc3oAIiHqvY7dFZ4KNbylDDSU9C8AvF0IPX2VFQOw2V0eKi3cswbfULLlr4RUj0joWRzzzHCzGgbNCI/lr119X1LsT7DK63YQJsQm3bXrCrKetnBS0A/19o/lwI/7GcdIf2vMQ4B0vVQCU92n7RmAcc+YPICpEKcyFX2ZQxQfGTzvuy0lrp5vPmMTC7l9FNF3RgPwZSUSP6qTqo8DFd1G5d6/4mMBhaG3jF9MJ2X3mpV5YC/OAndiUD3CD22y6RXspcBGrWx7KqaRanj8E/sYC2WngvVK75GjVrT/Z8wKdrAN/HfCcWhSc668zVlgR9Mf9GdX3vxFTq2S+5rDCyOm6bgcFxGwBHrIWOd+CHT7WgsPfDTz7n5cly3x9/sV6oUA2eIA9x5xy42YKyVXbsTRjVDNAQL1wCsmrwB+J7+bs4Ua6fHJqIJHFriveCChPmFM26LvlUZDQ5wg6v58IYOAgsDTW0HBR/TWfcCgEB6YoxfaNXwstmLDbfHHiStv8TBakWqW+s6sX6QFh2y/aOQGYJbzTcwtwoXdN4noXzjZTSZUNkQf/CVQfV7VgvEwFqnlvswa9tnwI8V27dQDwZjX9nh3hSHoLdRQTz2lcqHGzdmKJsfpFjGhdyYpNcGaXVQH4HoNKHE92kIIrxjMgLWN9MRw4PBsYadieN36OOCUuTKkM1Sq5Cfm16qZcFgmGj9gdBwnWmjIn9kNNPMkSNzTDSp1uf24Zgwu9JJHGT8WoaEGXwDmTsRdoTnN+nSIT60q+gUxC7c40kKCTGFTOwZ1mpUMvFG47VF7WFxAcUgcmp5nZBKQRFJ5yjmDicCk1ds5PG3B4CFYez7gEGjsJks0oekS0LBJh YtDJrCr6 tfVUcM8clEp9l4prMcPwhR8O7fSCpmBzWHO4VaP5MAY5dE8rXnzBzv4EtCqnZ0t1oCiWdeR2G15AUNaDeDrnpk7FD3vaMbsmncmRq5dwGIgumaUhMdrMSzeK6fcOmsnaVw18l0e5e9pWBgG8SFJrjMOnwmzxuuDriPROerUcbvObb70p8nvO/U31DxVSvdNPmGMJwWAJdYPQyy0BarcMylgcBVfGj8OjP+bwjoZBx4Cio7MRUKnCJALYaLDKTokCGgydJ5lDEvJb0Larjnvg9HQZOY8BmVadXhydvabf0LUtgk7ICPCQTfzklNOYI0swh2bkMm52jZh2DLEsxmI0eg3TO+czR/BbY6/uJboUDXYu4Qw8tlLoDXa93yq/bJ2oBRHBsTLgjscv9DXuMsWJi891f7gXvrhWmlyMSJPtymc2kSTcnY3aBQyUVlgF+Eh3PLy70rum2rkdwFkT9EM9jYSWdS+gWLAK0fH5xoUBj6SYQ+pZxZYAFLACtItRqdgTZ/KZ5wgYZf9hyggt6PUMe8bzII1RdnWO3aQCnkVFVSmb59so= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 20 Oct 2024 at 10:04, Kent Overstreet wrote: > > But given that vmalloc() already supports > INT_MAX requests, and memory > sizes keep growing so 2GB is getting pretty small - I think it's time, > this is going to come up in other places sooner or later. No. If you need 2GB+ memory for filesystem operations, you fix your code. 2GB is more than you *can* allocate on 32-bit platforms, and even on 64-bit ones it is often quite a lot. So even aside from the *fact* of integer overflows, that check isn't going away. Linus