From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4465C433EF for ; Mon, 25 Apr 2022 08:18:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C54B8D001C; Mon, 25 Apr 2022 04:18:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 675E08D0006; Mon, 25 Apr 2022 04:18:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 58C448D001C; Mon, 25 Apr 2022 04:18:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 4B6F28D0006 for ; Mon, 25 Apr 2022 04:18:18 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 273FF28731 for ; Mon, 25 Apr 2022 08:18:18 +0000 (UTC) X-FDA: 79394699076.20.A755B74 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by imf15.hostedemail.com (Postfix) with ESMTP id A6407A0039 for ; Mon, 25 Apr 2022 08:18:13 +0000 (UTC) Received: by mail-lj1-f170.google.com with SMTP id q185so7660976ljb.5 for ; Mon, 25 Apr 2022 01:18:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Gf4qna+chgdqKRpP/Wa5zsGXxEnC9UfbtEiM/gls+m0=; b=Aml0zD/fxPnfqRhWfiNo69LwKx2/KRsDrIss9R5tS0Ba7quxETTRhXIyWpj4qhK09T Gt2fpu8LSyw0qXIyi384DNEtzxsABGGLhu4D3ZrRWYZkwVDzZaz5+/BzVYa3S302X1yY yYRDLXxGnGeSi1OfZ5tLmVptCJpEd526sjy/c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Gf4qna+chgdqKRpP/Wa5zsGXxEnC9UfbtEiM/gls+m0=; b=qqNxe98TZFwu9kTA7V9q76LSp1XHqGdG3ubfsXkNbTUQ3jFWCtw1sDk7YCYB5Qutma MwP0niICUjkIKVkqyO5RifBEVFgIU5auGGGf+IOhcqK7MN0FsGcm+F3Js1MYQLVRiPLX xNcoT0Hr/JoAlAy6FsGatTEMNoL9Nn0LQsJ3S4j7cXuJIFPSbncWb70vLP1EBTlsCYqF ZXCHJqJAGnri0c9JgBl4tyS1HQvqF3588hh9j2D1pY+toI3xQmpEA15dc+iJuZaEwNLi 61D+EWgxLhW9I7gI0PDO97ALafcjsG+d67G8GQp6fju8WatXv93U4UvHkL+HPL7uOKww y62Q== X-Gm-Message-State: AOAM532YWlsR8uyQvcmp/xIuHiUr1OvLKal+T/laUoKSQ0StPczWV8xY sLMOpx5haj31huF10mK8NI2b233TIl2islwruPc= X-Google-Smtp-Source: ABdhPJzoouvkfVhvJJsR8PYPrEBe19bwksGhCU1Lp7kOyre9k75HQmLy9npH04/Xx+y+TnarDDaeVw== X-Received: by 2002:a2e:a445:0:b0:24a:c1ba:b62f with SMTP id v5-20020a2ea445000000b0024ac1bab62fmr10486691ljn.81.1650874695642; Mon, 25 Apr 2022 01:18:15 -0700 (PDT) Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com. [209.85.208.171]) by smtp.gmail.com with ESMTPSA id r18-20020a19da12000000b0047022f82509sm1333045lfg.238.2022.04.25.01.18.13 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Apr 2022 01:18:14 -0700 (PDT) Received: by mail-lj1-f171.google.com with SMTP id c15so16825449ljr.9 for ; Mon, 25 Apr 2022 01:18:13 -0700 (PDT) X-Received: by 2002:a2e:934b:0:b0:24f:cce:5501 with SMTP id m11-20020a2e934b000000b0024f0cce5501mr4447272ljh.443.1650874693427; Mon, 25 Apr 2022 01:18:13 -0700 (PDT) MIME-Version: 1.0 References: <20220415164413.2727220-1-song@kernel.org> <20220415164413.2727220-3-song@kernel.org> <5e5e4759efef83250f9511d4ab0e1ba34f987ce5.camel@fb.com> In-Reply-To: From: Linus Torvalds Date: Mon, 25 Apr 2022 01:17:57 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 bpf 2/4] page_alloc: use vmalloc_huge for large system hash To: Geert Uytterhoeven Cc: "song@kernel.org" , "linux-mm@kvack.org" , Rik van Riel , "linux-kernel@vger.kernel.org" , "bpf@vger.kernel.org" , "rick.p.edgecombe@intel.com" , "hch@lst.de" , "akpm@linux-foundation.org" , "daniel@iogearbox.net" , "hch@infradead.org" , "mcgrof@kernel.org" , "ast@kernel.org" , Kernel Team , "imbrenda@linux.ibm.com" Content-Type: multipart/mixed; boundary="000000000000abeec805dd7637e2" X-Rspamd-Queue-Id: A6407A0039 X-Stat-Signature: 4q6ns3857hcnzpcqzxsedicoj64cc1mi X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b="Aml0zD/f"; spf=pass (imf15.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.170 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-Rspamd-Server: rspam09 X-HE-Tag: 1650874693-760267 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --000000000000abeec805dd7637e2 Content-Type: text/plain; charset="UTF-8" On Mon, Apr 25, 2022 at 12:07 AM Geert Uytterhoeven wrote: > > vmalloc_huge() is provided by mm/vmalloc.c, which is not > compiled if CONFIG_MMU=n. Well, that's annoying. Does this trivial patch fix it for you? I get this feeling that this could be done better with a weak alias to __vmalloc(), and that could take care of the "arch doesn't support VMAP_HUGE" case too, but the attached is the stupid and straightforward version. Linus --000000000000abeec805dd7637e2 Content-Type: text/x-patch; charset="US-ASCII"; name="patch.diff" Content-Disposition: attachment; filename="patch.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l2efx5810 IG1tL25vbW11LmMgfCA1ICsrKysrCiAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspCgpk aWZmIC0tZ2l0IGEvbW0vbm9tbXUuYyBiL21tL25vbW11LmMKaW5kZXggNTVhOWU0OGE3YTAyLi4y YTY1NWVkNTY2NDQgMTAwNjQ0Ci0tLSBhL21tL25vbW11LmMKKysrIGIvbW0vbm9tbXUuYwpAQCAt MjI2LDYgKzIyNiwxMSBAQCB2b2lkICp2bWFsbG9jKHVuc2lnbmVkIGxvbmcgc2l6ZSkKIH0KIEVY UE9SVF9TWU1CT0wodm1hbGxvYyk7CiAKK3ZvaWQgKnZtYWxsb2NfaHVnZSh1bnNpZ25lZCBsb25n IHNpemUsIGdmcF90IGdmcF9tYXNrKQoreworCXJldHVybiBfX3ZtYWxsb2Moc2l6ZSwgZ2ZwX21h c2spOworfQorCiAvKgogICoJdnphbGxvYyAtIGFsbG9jYXRlIHZpcnR1YWxseSBjb250aWd1b3Vz IG1lbW9yeSB3aXRoIHplcm8gZmlsbAogICoK --000000000000abeec805dd7637e2--