From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6F02D3E2A0 for ; Mon, 28 Oct 2024 18:51:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4CE156B009E; Mon, 28 Oct 2024 14:51:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 47DB76B009F; Mon, 28 Oct 2024 14:51:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3462C6B00A0; Mon, 28 Oct 2024 14:51:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 178A96B009E for ; Mon, 28 Oct 2024 14:51:16 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 07EF2ABDC2 for ; Mon, 28 Oct 2024 18:51:15 +0000 (UTC) X-FDA: 82723902618.08.3C2EFC7 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by imf19.hostedemail.com (Postfix) with ESMTP id 624D81A000F for ; Mon, 28 Oct 2024 18:50:43 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=Dei7bwsZ; spf=pass (imf19.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.51 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730141393; a=rsa-sha256; cv=none; b=s12tI9ukIvuQIu3mhba6c1AKlpxkyTdFgqddTfHeeR94EJtL9enhtkcRjxpUKMod+mOaU9 okvVVjsStDhqfi4DBKHgxpsDgLixcCdYUQ+pOlHVVrw5eflI1kQr9iLoZB0E9NbDtspKES 6QSpJNJNt+M5YCNn8jOM1Zxk//o/vZI= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=Dei7bwsZ; spf=pass (imf19.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.51 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730141392; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kIxdURF54ugS0I9GsxO6vUsWqiwPODNyGYtyXOv/jbs=; b=klP9WLnTCm5cpJKzt7XdfdT5VewpB14rkR/3ZLbk//+gtqWmuhKhA6nIdFWBEBZR65Joou PViUaLXC9urc6luZ84lvLgZCPdi46tVTB8L/UC6oV5fsnbnxRV7K0utcO/X3WQlorz83JY v/yqtRpY5gwtEK9++AmQI3zfAZwArwU= Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5c9634c9160so5355092a12.2 for ; Mon, 28 Oct 2024 11:51:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1730141471; x=1730746271; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kIxdURF54ugS0I9GsxO6vUsWqiwPODNyGYtyXOv/jbs=; b=Dei7bwsZkQYjymIprUtvAKFmyvGexk1DxBXELBSF3Wh9xfTpjTQw65mbNH1y3rgtRq jrsmYZuO48Paj0Gq/eALh4g1M/vtNYH6LAW/8JXKKSEdx84oso9+By3nXbAAmN/ZzY5t uPNbseRRx/DcbwdksNdfdp0POWt0mBeFCWKOQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730141471; x=1730746271; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kIxdURF54ugS0I9GsxO6vUsWqiwPODNyGYtyXOv/jbs=; b=RosO9rTtm4B0rGeu7VLQBAQqbg5dRbrVzgoibAwmWNN32tvUw0NyOYcjv+DT6Cip7H ULmtaQyF+Cl3NXAHnCHcM8TvuQt4sMDjMCmQGIor2rxWRvRhmlSPDKJrI1LCTTaQ2n4Z qdpjthJsQW8KgH3Ia91qJ+DNggNM7PrPYhVhPjQIojhfVlgFAlDVBFbFThI0H69pqjf6 3hnvkzdl0Bs3JbTbWzWFljPpqJKq3Mbo5KH1NZYuS+ckcwO1uK5oedvTd4VJsrhKUB+I AzIzADLn9Rat5T2mEA1dy63xuyjZbgHtb+PQ0FmPRQil7a2EFVQSFhvs0idBK0SApVmU bKiQ== X-Forwarded-Encrypted: i=1; AJvYcCU2W+yq3ngt0YUWGltiFcaFXD1DjF2PcRUhrAIrJ0vnNmpr09CuGeGJRwIBJMkrrLWBRbFGxcc4Aw==@kvack.org X-Gm-Message-State: AOJu0YzXvlL5cmBCKOpbqg4Nf9YCOsXxhlmoLRC6wkksF3cpuUTT1t7J AZfoVpi7hbIO89Nv6/PPXzgFskIarkP/TV8kQhuES81zchY4GcOzOXeRhqtnsSxETOJfSoqyfIB iBJ4= X-Google-Smtp-Source: AGHT+IE1OJp8BK+XNR+8YY30SqbYaMmaVffOJIYibrIPSUXFGfYdLLZDB5YA0GbWpL7eCVuZfb+TwA== X-Received: by 2002:a05:6402:34d4:b0:5c9:8a06:3420 with SMTP id 4fb4d7f45d1cf-5cbbf94eba0mr7593518a12.35.1730141471130; Mon, 28 Oct 2024 11:51:11 -0700 (PDT) Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com. [209.85.218.41]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5cbb62c4547sm3367110a12.53.2024.10.28.11.51.09 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Oct 2024 11:51:10 -0700 (PDT) Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a9a6acac4c3so728381766b.0 for ; Mon, 28 Oct 2024 11:51:09 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUfyhioYItqQkDWic43Q0Lv4O4tfOlDGmmCMylkoXqoWgROuWH12wHmvrl3LUPLPYILwixmUBayEQ==@kvack.org X-Received: by 2002:a17:907:7e9e:b0:a99:61f7:8413 with SMTP id a640c23a62f3a-a9de5ed3f62mr706790166b.23.1730141469413; Mon, 28 Oct 2024 11:51:09 -0700 (PDT) MIME-Version: 1.0 References: <874j4w4o1f.ffs@tglx> In-Reply-To: <874j4w4o1f.ffs@tglx> From: Linus Torvalds Date: Mon, 28 Oct 2024 08:50:52 -1000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] iov_iter: fix copy_page_from_iter_atomic() if KMAP_LOCAL_FORCE_MAP To: Thomas Gleixner Cc: Hugh Dickins , Alexander Viro , Andrew Morton , Christian Brauner , Matthew Wilcox , Christoph Hellwig , Kent Overstreet , "Darrick J. Wong" , Peter Zijlstra , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: xtx7uphtswqpb8h5s1973mizytgpjj9c X-Rspamd-Queue-Id: 624D81A000F X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1730141443-603968 X-HE-Meta: U2FsdGVkX19A/WD/itaTZ1LRQjvaAxtB2Crxt+tYL1zfd2SRAyq6FvnS5uIoEf0OP8mGXEpwrxqHFsvxLRTBKo6Lkami46f4DyggTYqd5vDM/UsjODMfVmNN4vukB72CG8dSbrJBEjZI+LbJ5ivI5iTUjkosryiq4vF+0GnyG0+46nfoSk1VjFwG36RvK6Moavk4kq3t1DYO7bBx41mJCEEsDxxQFWJ0ef3jw19M7m/CAvUhIB58PfSVviRtVlxlKUQtI+bqTss5ptxXDgUcqR8QYedRD54cP/qSk5tlvjxs5HnH0hO2qLbpxa1ebHt2SZ2I1HKAgcUh++t06tTG+gQ1QVsGNucpIQR8FeEY/gt9+U4oLYGna+Z51UIKGu3U693LXCcYT7Ili75CXqmYpffGIvwC/WidQKYa9RlR4wTaZv/ES8PSNtkgkFiy4KWXeF7MxNGXCEwTUIyXsyjTRTi9yMsaYU5TEetbJTxHdx6dckaxwPm1juRUphnrsHzy/Ux+LPI2gH8sNgigltaINtvekHENu1XfGyBCV8wqRTKILee9ID4/Rr3TxFP2OGFj2ZPaTYDtCQ2tFUDu3nOPH8XUw1RE9xAO8gCMKemrMWU2mmZYpLkUcqvANjh8ya01YcFO0w/O4W78IL3uLOVh+PeyTraVR+BD+8TpQEhEEkRsro7yyxM+bgDB1DbEc1Rgcd1JdvyAsY8ErEVzwKdybGF603qjBJrdYbQ99IK/ZS6pfyHW+hNEO5cPhubP9LMby+SWbgAuUV8sxw79p8QQCHU149Q29vvQtXQJWJeVQ/ZPxIWphSyd4JWYm7SR5po9pubYBVfVV5Bf6uFRDSMTczMMaXN/NDdnG9DA3uvkGPrR+RZn9NNL/qVKQrIGrQo8HIx2SA/fbiaRr4ZXlfsxZFbsOkQSyPjINhnDJicDOKrsLjOmykpG8uRO1rM1/DUiMeZATzwaT1OUGUqzw+I exbhiWTI AE7jsD9IT6tFN6Th0qNzmSvw3xjeoU0X7Kbkr09IMujTFQOkrY6dTQbARcWqwH23vI17scW/wotD7mN67xCckNBj2Aaq4mbfC/vSTSt/q7viQ8xUo2wfZ5Lb1WBaorkACDnLF7ftIPjItpu27a6zZs5itHOZDWSF/+R3G67rE/Yc1j08n8VdmEGo26s51nsCjih3FFuIKvPcFYgwIb6nbvCA1UB1JzZ5QUY9MZEc8ZErBrz+kWoT2j0LGb4Uix6OFop/SWtQ4yRV4jVTACLGsL3qthX5F9yfWsT17l9/vzvVQ9iqTVyJUnCwYAQfmtVh4Ovok4QjCVy1npldtvmktYhrZ90c9wiUuiuk8M5hzPs/FIDQGW11Sx/VC5Ib+PcsWgsFZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 27 Oct 2024 at 22:41, Thomas Gleixner wrote: > > It has caught real problems and as long as we have highmem support, it > should stay IMO to provide test coverage. Yeah. I'd love to get rid of highmem support entirely, and that day *will* come. Old 32-bit architectures that do stupid things can just deal with old kernels, we need to leave that braindamage behind some day. But as long as we support it, we should at least also have the debug support for it on sane hardware. Of course, maybe we should just make PageHighMem() always return true for CONFIG_DEBUG_KMAP_LOCAL_FORCE_MAP, but I suspect that would cause more pain than is worth it. But yeah, I do think we should seriously start thinking about just getting rid of HIGHMEM. Linus