From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B43C6C433FE for ; Tue, 1 Nov 2022 17:42:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DDCB6B0071; Tue, 1 Nov 2022 13:42:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 38DC66B0073; Tue, 1 Nov 2022 13:42:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27D366B0074; Tue, 1 Nov 2022 13:42:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1A06E6B0071 for ; Tue, 1 Nov 2022 13:42:30 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DC793120A7B for ; Tue, 1 Nov 2022 17:42:29 +0000 (UTC) X-FDA: 80085592818.29.4B57732 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) by imf20.hostedemail.com (Postfix) with ESMTP id 872F51C000D for ; Tue, 1 Nov 2022 17:42:29 +0000 (UTC) Received: by mail-qv1-f52.google.com with SMTP id c8so10788658qvn.10 for ; Tue, 01 Nov 2022 10:42:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VEycd8RlbAJ5XnCuKjnbIdJtCVqg8RDC/hCEwO7a6NQ=; b=YjRU+tsSmurMeVwzySzhPqI0t2VCknNkLnbOVIawDPOo1+GGY8Qoo5+fEXX3SaLP4S JLvN8q0IqPpqSC+bLu4zmaBYcCLAE4irKcs7j9Ox+/u0vFrKHctEBON7yKgVUju63ucv kDSte0QhaHpSgnfmPEpESzeoM157FKlvf+lLs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VEycd8RlbAJ5XnCuKjnbIdJtCVqg8RDC/hCEwO7a6NQ=; b=BtH9Bu/nP8O9UuEqDv5nK/PY9xuswsPJQJLeKY2tUlc1vwNvb9Mly/b5maN87+dwbC /rx3gwnc+RueFOKyt+9JmzYxR8oItKh9YY++XMrzPuEKGxuUWPT+l0t2eWHUNwriJ9K0 bnxCetjWT8SidZLq7BinVaJkfgkF7J/ktsGgz6dtVcjrHWgSSu0PqT1hsmEiu1E6RHzl HaSzWAbWxWC95r2600CgBsKaStlj0AE9mJV9LNnLy8QrjOLTNeGanuJXoTNVMSzJEkg2 5sd6/FEqFwZmRxfN6N4gP3M+4xeNM58ns98HhCVAY4/75d7r9wPF1r1j3e2WzsKBI3Dr OyZw== X-Gm-Message-State: ACrzQf0vSkLl9/I8ghtnOIgCGNxvFDgpKMoY6+WsrCcX0/RZCYJooBRJ /QO1OLcmYSinuYMqDzhnZmxc5YTd8tee9g== X-Google-Smtp-Source: AMsMyM4KyPOvNYDJk0iltaaSIQRQdBuh9MWfVOeG5WJHqVOlASz8ttDjbOqNTVxnbPYGBC5wu/Nw+A== X-Received: by 2002:ad4:5de9:0:b0:4bb:83a6:10bf with SMTP id jn9-20020ad45de9000000b004bb83a610bfmr17035153qvb.49.1667324548377; Tue, 01 Nov 2022 10:42:28 -0700 (PDT) Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com. [209.85.219.171]) by smtp.gmail.com with ESMTPSA id bp6-20020a05620a458600b006cf9084f7d0sm6922944qkb.4.2022.11.01.10.42.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Nov 2022 10:42:27 -0700 (PDT) Received: by mail-yb1-f171.google.com with SMTP id 63so18189619ybq.4 for ; Tue, 01 Nov 2022 10:42:27 -0700 (PDT) X-Received: by 2002:a25:bb02:0:b0:6ca:9345:b2ee with SMTP id z2-20020a25bb02000000b006ca9345b2eemr7234903ybg.362.1667324547146; Tue, 01 Nov 2022 10:42:27 -0700 (PDT) MIME-Version: 1.0 References: <20221022111403.531902164@infradead.org> <20221022114424.711181252@infradead.org> In-Reply-To: From: Linus Torvalds Date: Tue, 1 Nov 2022 10:42:11 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 04/13] mm: Fix pmd_read_atomic() To: Peter Zijlstra Cc: x86@kernel.org, willy@infradead.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, aarcange@redhat.com, kirill.shutemov@linux.intel.com, jroedel@suse.de, ubizjak@gmail.com Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667324549; a=rsa-sha256; cv=none; b=n6dv556o2bDKfSbhxEuLylSZBv/6gqdiHfh3/Gy6sMYMeWzTSVvEL0eDGEtibDQaRgkc7O dnXPGOG+odZmQszERymnkKE1c1fEDwsYKxKmo/GnRO2kwYSlgaD6wPOTq1vu0xnTrg4jMC /yf/BY2jShlcmWGQ2AZ17ggsio7PX5Y= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=YjRU+tsS; dmarc=none; spf=pass (imf20.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.219.52 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667324549; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VEycd8RlbAJ5XnCuKjnbIdJtCVqg8RDC/hCEwO7a6NQ=; b=BHS9Wxt695y7DXjyAeuGmsTua/njAhbUXYSlQW8KOSOZL2Q20ctBbqg7iY1YOjgQE1VXK+ iPX9ES/Chmo+uGD3KLpmH7E2WPmfBAInn8Gs1pnYXuCJQtkeiUKD8i7wNcyCd3p22/tF/5 nBPEN6TGrAArovl/40yQuLLP92o3CIM= X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 872F51C000D X-Rspam-User: Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=YjRU+tsS; dmarc=none; spf=pass (imf20.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.219.52 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org X-Stat-Signature: t5xn7zz4yjiyw81r9qka8dpz97whmmdq X-HE-Tag: 1667324549-329267 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 1, 2022 at 5:42 AM Peter Zijlstra wrote: > > So I've stuck the below on. There's a *TON* more to convert and I'm not > going to be doing that just now (seems like a clever enough script > should be able to), but this gets rid of the new one I introduced. Thanks. And no, I don't think the churn of converting old cases is worth it. I just want to discourage *more* of this. Using the same name really helps when you do a "git grep" for a symbol, the whole '#ifndef' patterns for alternate architecture definitions shows up really clearly. So that - together with not having the possibility of mixing up names - is the main reason I don't like the ARCH_HAS_XYZ pattern, and much prefer just using the name of whichever function gets an architecture override. Linus PS. I'd love to get an ack/nak on the "mm: delay rmap removal until after TLB flush" thing.