From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 844A6C433F5 for ; Tue, 8 Mar 2022 20:03:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C978B8D0002; Tue, 8 Mar 2022 15:03:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C47358D0001; Tue, 8 Mar 2022 15:03:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE7B58D0002; Tue, 8 Mar 2022 15:03:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 9FC148D0001 for ; Tue, 8 Mar 2022 15:03:28 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 64D5124998 for ; Tue, 8 Mar 2022 20:03:28 +0000 (UTC) X-FDA: 79222293696.14.BC5E903 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by imf10.hostedemail.com (Postfix) with ESMTP id E8239C000D for ; Tue, 8 Mar 2022 20:03:27 +0000 (UTC) Received: by mail-lf1-f45.google.com with SMTP id r4so8552850lfr.1 for ; Tue, 08 Mar 2022 12:03:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=czsRGOkOn3Lgpr63tuiW4SCDSW01owb7EuPhkTzECmM=; b=bOcSUSaffQIuHF2CSU04hVbpPCejg/SdphJ6c1+LuWKBJjlLZbbCI4HeWDmKQqotw6 Z+FhPUs0dHXmbekhhf5T8yXt+lsbxU+tYj01K3m3MHIYZXN4QXKRxMhMJnW0d8+S2sd3 3/4ljensKECXT+zaZ2BHQJbn0bZRqLGy0/n0Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=czsRGOkOn3Lgpr63tuiW4SCDSW01owb7EuPhkTzECmM=; b=j7XhgmzvEgYyPeTYRtAmEGFaCEsQOYj/jVlLFb8SOWXZG1NT+D9ixaxvLJkKhcZBYY 8F8aFz+wY296vG7f5OwRYC+k4xBOIA8Q0KdUyBXvm2YhLMTHdHNJ8k7HSh15tq+j0a9B TAQ6XD1iEiAw2oxK9NhDt1BW3loJJaCj778kLsWV9FawmwbLxkMKM7nXzfpDmhx0783i IpIMsI3hwHG+E4g7kQBl8domW0l9Ds/753uN21LLT+wp1XCXVysXrGT3HfII0mI9cw5+ asxbnZOUmqNDQ6unfQGjRF4OlIJcsNXE3+bqT+IthDpvDlLla+jrdLt26HVo90ZD1VOn 7oug== X-Gm-Message-State: AOAM531ru1OR8H3s46MVdxz1EqN6uPOcQjsX3w2TwT/x6555pDEb26vF eWRic2Q6zI40imbaa7V6vGdpueYjSH/OhE/ppds= X-Google-Smtp-Source: ABdhPJy6BYJGC0I6RXW6sMqDVLvqjmHQB+fYciwIL6jMNeRj86kCochsmZE64ZPyyySfc/Y8ePEo+w== X-Received: by 2002:a05:6512:16a0:b0:443:3c9c:3d3e with SMTP id bu32-20020a05651216a000b004433c9c3d3emr11832858lfb.383.1646769806012; Tue, 08 Mar 2022 12:03:26 -0800 (PST) Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com. [209.85.167.52]) by smtp.gmail.com with ESMTPSA id h8-20020a2e5308000000b002432295576fsm4040715ljb.49.2022.03.08.12.03.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Mar 2022 12:03:25 -0800 (PST) Received: by mail-lf1-f52.google.com with SMTP id s25so73206lfs.10 for ; Tue, 08 Mar 2022 12:03:24 -0800 (PST) X-Received: by 2002:ac2:44a4:0:b0:445:8fc5:a12a with SMTP id c4-20020ac244a4000000b004458fc5a12amr11949016lfm.27.1646769804575; Tue, 08 Mar 2022 12:03:24 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Tue, 8 Mar 2022 12:03:08 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Buffered I/O broken on s390x with page faults disabled (gfs2) To: David Hildenbrand Cc: Andreas Gruenbacher , Alexander Viro , linux-s390 , Linux-MM , linux-fsdevel , linux-btrfs Content-Type: multipart/mixed; boundary="0000000000003abc5505d9ba794e" X-Rspamd-Queue-Id: E8239C000D X-Stat-Signature: dmpw6e8nkdnyc7rr9stnssp6buqthowb Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=bOcSUSaf; spf=pass (imf10.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.45 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1646769807-132713 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --0000000000003abc5505d9ba794e Content-Type: text/plain; charset="UTF-8" On Tue, Mar 8, 2022 at 11:27 AM Linus Torvalds wrote: > > So I think the fix for this all might be something like the attached > (TOTALLY UNTESTED)! Still entirely untested, but I wrote a commit message for it in the hopes that this actually works and Andreas can verify that it fixes the issue. Same exact patch, it's just now in my local experimental tree as a commit. Linus --0000000000003abc5505d9ba794e Content-Type: text/x-patch; charset="US-ASCII"; name="0001-mm-gup-make-fault_in_safe_writeable-use-fixup_user_f.patch" Content-Disposition: attachment; filename="0001-mm-gup-make-fault_in_safe_writeable-use-fixup_user_f.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l0ik6w7o0 RnJvbSBkOGMyZTBhODEyNzRkNjdlZGZmZjM3NjljNGMzN2UzNjRiYThkNmY4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaW51cyBUb3J2YWxkcyA8dG9ydmFsZHNAbGludXgtZm91bmRh dGlvbi5vcmc+CkRhdGU6IFR1ZSwgOCBNYXIgMjAyMiAxMTo1NTo0OCAtMDgwMApTdWJqZWN0OiBb UEFUQ0hdIG1tOiBndXA6IG1ha2UgZmF1bHRfaW5fc2FmZV93cml0ZWFibGUoKSB1c2UKIGZpeHVw X3VzZXJfZmF1bHQoKQoKSW5zdGVkYWQgb2YgdXNpbmcgR1VQLCBtYWtlIGZhdWx0X2luX3NhZmVf d3JpdGVhYmxlKCkgYWN0dWFsbHkgZm9yY2UgYQonaGFuZGxlX21tX2ZhdWx0KCknIHVzaW5nIHRo ZSBzYW1lIGZpeHVwX3VzZXJfZmF1bHQoKSBtYWNoaW5lcnkgdGhhdApmdXRleGVzIGFscmVhZHkg dXNlLgoKVXNpbmcgdGhlIEdVUCBtYWNoaW5lcnkgbWVhbnQgdGhhdCBmYXVsdF9pbl9zYWZlX3dy aXRlYWJsZSgpIGRpZCBub3QgZG8KZXZlcnl0aGluZyB0aGF0IGEgcmVhbCBmYXVsdCB3b3VsZCBk bywgcmFuZ2luZyBmcm9tIG5vdCBhdXRvLWV4cGFuZGluZwp0aGUgc3RhY2sgc2VnbWVudCwgdG8g bm90IHVwZGF0aW5nIGFjY2Vzc2VkIG9yIGRpcnR5IGZsYWdzIGluIHRoZSBwYWdlCnRhYmxlcyAo R1VQIHNldHMgdGhvc2UgZmxhZ3Mgb24gdGhlIHBhZ2VzIHRoZW1zZWx2ZXMpLgoKVGhlIGxhdHRl ciBjYXVzZXMgcHJvYmxlbXMgb24gYXJjaGl0ZWN0dXJlcyAobGlrZSBzMzkwKSB0aGF0IGRvIGFj Y2Vzc2VkCmJpdCBoYW5kbGluZyBpbiBzb2Z0d2FyZSwgd2hpY2ggbWVhbnQgdGhhdCBmYXVsdF9p bl9zYWZlX3dyaXRlYWJsZSgpCmRpZG4ndCBhY3R1YWxseSBkbyBhbGwgdGhlIGZhdWx0IGhhbmRs aW5nIGl0IG5lZWRlZCB0by4KClJlcG9ydGVkLWJ5OiBBbmRyZWFzIEdydWVuYmFjaGVyIDxhZ3J1 ZW5iYUByZWRoYXQuY29tPgpMaW5rOiBodHRwczovL2xvcmUua2VybmVsLm9yZy9hbGwvQ0FIYzZG VTVuUCtuemlOR0cwSkFGMUZVeC1HVjdrS0Z2TTdhWnVVX1hEMl8xdjR2bnZnQG1haWwuZ21haWwu Y29tLwpDYzogRGF2aWQgSGlsZGVuYnJhbmQgPGRhdmlkQHJlZGhhdC5jb20+ClNpZ25lZC1vZmYt Ynk6IGludXMgVG9ydmFsZHMgPHRvcnZhbGRzQGxpbnV4LWZvdW5kYXRpb24ub3JnPgotLS0KIG1t L2d1cC5jIHwgNDAgKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogMSBm aWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDI4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL21tL2d1cC5jIGIvbW0vZ3VwLmMKaW5kZXggYTlkNGQ3MjRhZWY3Li45ZTA4NWU3YjljMjgg MTAwNjQ0Ci0tLSBhL21tL2d1cC5jCisrKyBiL21tL2d1cC5jCkBAIC0xNzQ1LDQ0ICsxNzQ1LDI4 IEBAIEVYUE9SVF9TWU1CT0woZmF1bHRfaW5fd3JpdGVhYmxlKTsKIHNpemVfdCBmYXVsdF9pbl9z YWZlX3dyaXRlYWJsZShjb25zdCBjaGFyIF9fdXNlciAqdWFkZHIsIHNpemVfdCBzaXplKQogewog CXVuc2lnbmVkIGxvbmcgc3RhcnQgPSAodW5zaWduZWQgbG9uZyl1bnRhZ2dlZF9hZGRyKHVhZGRy KTsKLQl1bnNpZ25lZCBsb25nIGVuZCwgbnN0YXJ0LCBuZW5kOworCXVuc2lnbmVkIGxvbmcgZW5k LCBuc3RhcnQ7CiAJc3RydWN0IG1tX3N0cnVjdCAqbW0gPSBjdXJyZW50LT5tbTsKLQlzdHJ1Y3Qg dm1fYXJlYV9zdHJ1Y3QgKnZtYSA9IE5VTEw7Ci0JaW50IGxvY2tlZCA9IDA7CisJY29uc3QgdW5z aWduZWQgaW50IGZhdWx0X2ZsYWdzID0gRkFVTFRfRkxBR19XUklURSB8IEZBVUxUX0ZMQUdfS0lM TEFCTEU7CisJY29uc3Qgc2l6ZV90IG1heF9zaXplID0gNCAqIFBBR0VfU0laRTsKIAogCW5zdGFy dCA9IHN0YXJ0ICYgUEFHRV9NQVNLOwotCWVuZCA9IFBBR0VfQUxJR04oc3RhcnQgKyBzaXplKTsK KwllbmQgPSBQQUdFX0FMSUdOKHN0YXJ0ICsgbWluKHNpemUsIG1heF9zaXplKSk7CiAJaWYgKGVu ZCA8IG5zdGFydCkKIAkJZW5kID0gMDsKLQlmb3IgKDsgbnN0YXJ0ICE9IGVuZDsgbnN0YXJ0ID0g bmVuZCkgewotCQl1bnNpZ25lZCBsb25nIG5yX3BhZ2VzOwotCQlsb25nIHJldDsKIAotCQlpZiAo IWxvY2tlZCkgewotCQkJbG9ja2VkID0gMTsKLQkJCW1tYXBfcmVhZF9sb2NrKG1tKTsKLQkJCXZt YSA9IGZpbmRfdm1hKG1tLCBuc3RhcnQpOwotCQl9IGVsc2UgaWYgKG5zdGFydCA+PSB2bWEtPnZt X2VuZCkKLQkJCXZtYSA9IHZtYS0+dm1fbmV4dDsKLQkJaWYgKCF2bWEgfHwgdm1hLT52bV9zdGFy dCA+PSBlbmQpCi0JCQlicmVhazsKLQkJbmVuZCA9IGVuZCA/IG1pbihlbmQsIHZtYS0+dm1fZW5k KSA6IHZtYS0+dm1fZW5kOwotCQlpZiAodm1hLT52bV9mbGFncyAmIChWTV9JTyB8IFZNX1BGTk1B UCkpCi0JCQljb250aW51ZTsKLQkJaWYgKG5zdGFydCA8IHZtYS0+dm1fc3RhcnQpCi0JCQluc3Rh cnQgPSB2bWEtPnZtX3N0YXJ0OwotCQlucl9wYWdlcyA9IChuZW5kIC0gbnN0YXJ0KSAvIFBBR0Vf U0laRTsKLQkJcmV0ID0gX19nZXRfdXNlcl9wYWdlc19sb2NrZWQobW0sIG5zdGFydCwgbnJfcGFn ZXMsCi0JCQkJCSAgICAgIE5VTEwsIE5VTEwsICZsb2NrZWQsCi0JCQkJCSAgICAgIEZPTExfVE9V Q0ggfCBGT0xMX1dSSVRFKTsKLQkJaWYgKHJldCA8PSAwKQorCW1tYXBfcmVhZF9sb2NrKG1tKTsK Kwlmb3IgKDsgbnN0YXJ0ICE9IGVuZDsgbnN0YXJ0ICs9IFBBR0VfU0laRSkgeworCQlpZiAoZml4 dXBfdXNlcl9mYXVsdChtbSwgbnN0YXJ0LCBmYXVsdF9mbGFncywgTlVMTCkpCiAJCQlicmVhazsK LQkJbmVuZCA9IG5zdGFydCArIHJldCAqIFBBR0VfU0laRTsKIAl9Ci0JaWYgKGxvY2tlZCkKLQkJ bW1hcF9yZWFkX3VubG9jayhtbSk7CisJbW1hcF9yZWFkX3VubG9jayhtbSk7CisKKwkvKiBJZiB3 ZSBnb3QgYWxsIG9mIG91ciAodHJ1bmNhdGVkKSBmYXVsdC1pbiwgd2UgY2xhaW0gd2UgZ290IGl0 IGFsbCAqLwogCWlmIChuc3RhcnQgPT0gZW5kKQogCQlyZXR1cm4gMDsKKworCS8qIC4uIG90aGVy d2lzZSB3ZSdsbCB1c2UgdGhlIG9yaWdpbmFsIHVudHJ1bmNhdGVkIHNpemUgKi8KIAlyZXR1cm4g c2l6ZSAtIG1pbl90KHNpemVfdCwgbnN0YXJ0IC0gc3RhcnQsIHNpemUpOwogfQogRVhQT1JUX1NZ TUJPTChmYXVsdF9pbl9zYWZlX3dyaXRlYWJsZSk7Ci0tIAoyLjM1LjEuMzU2LmdlNjYzMGY1N2Nm LmRpcnR5Cgo= --0000000000003abc5505d9ba794e--