From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFF35C4167D for ; Tue, 19 Apr 2022 16:42:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 45F568D0086; Tue, 19 Apr 2022 12:42:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 40EE28D0047; Tue, 19 Apr 2022 12:42:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2AD968D0086; Tue, 19 Apr 2022 12:42:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0058.hostedemail.com [216.40.44.58]) by kanga.kvack.org (Postfix) with ESMTP id 17D228D0047 for ; Tue, 19 Apr 2022 12:42:04 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B94E118337A18 for ; Tue, 19 Apr 2022 16:42:03 +0000 (UTC) X-FDA: 79374195726.27.E81D271 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf24.hostedemail.com (Postfix) with ESMTP id 3330B180021 for ; Tue, 19 Apr 2022 16:42:02 +0000 (UTC) Received: by mail-lf1-f49.google.com with SMTP id bq30so30427304lfb.3 for ; Tue, 19 Apr 2022 09:42:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6P1qWvF3V5GecgjWCwMHmxXvgO8LhvNSrvaeOrIx0no=; b=bOi7JrsKqW6RMlRYZ9yUMtpdFOoida/a9exETF7P4zUXYy8YfeeMmKRQoxSP+cBkH6 o6mLBuE//QNcdO3jlJqz53BsfpGwllgT4Tgv3ikKYQ6nO5XfIxIcZHWoBpkfZxheIysG An/Fl3+TnkBLB8svtmOlHuNDaqXA1rMz+XTXE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6P1qWvF3V5GecgjWCwMHmxXvgO8LhvNSrvaeOrIx0no=; b=K+Ta0M04Cyc6DJURuKe7wxbvfewNNmKjTLZzrabwgxMLNgFiEwL7I4QNEhR29epbWW bW1BF0CJcYTrioSGZMLCnUhyIaxv7x5ybOcCMU9atwKK5FNMFtqFb5cdNkmAEB8adeRA BLLzI+YN6lGz0wKpkC2fI889GKt259K/BJajfBsPoSpYcHyBG6RrfscXvFpzHzg4aM9e m6/A/Ju1DYLBR5/FE+ceZDbKrYy/ojXQ2ecySGRDoUQzfrm3uSHToT6Sp3uEl7cOtpg/ mym1tshwB9b5WKEA+Ent3ugN9Zg7ZpvJC113bEfEl4K1UEbGzAJ6S+zlrwcS2/3chwY5 R/Xw== X-Gm-Message-State: AOAM531Q7hJN1/RArG2N6eFlchTbM/3ibsv2Mm8w1nX87QdJwCTftrjs 0MMX6gLNTO+sCTxOmKXU5gJy79gcL4timhLMEQM= X-Google-Smtp-Source: ABdhPJxAikvdycuKgJbJsMBbgyhGqjRLPwusmMv8hMcIbSs0szUtWlKlw6VbEYBDU1Nqn5JxKY9K1g== X-Received: by 2002:a05:6512:3f92:b0:447:769c:1b2c with SMTP id x18-20020a0565123f9200b00447769c1b2cmr11927195lfa.387.1650386521287; Tue, 19 Apr 2022 09:42:01 -0700 (PDT) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com. [209.85.167.46]) by smtp.gmail.com with ESMTPSA id r1-20020a194401000000b0046bb09b8e47sm1559056lfa.272.2022.04.19.09.41.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Apr 2022 09:41:59 -0700 (PDT) Received: by mail-lf1-f46.google.com with SMTP id x17so30400847lfa.10 for ; Tue, 19 Apr 2022 09:41:59 -0700 (PDT) X-Received: by 2002:ac2:4203:0:b0:448:8053:d402 with SMTP id y3-20020ac24203000000b004488053d402mr11323216lfh.687.1650386519338; Tue, 19 Apr 2022 09:41:59 -0700 (PDT) MIME-Version: 1.0 References: <29b9ef95-1226-73b4-b4d1-6e8d164fb17d@gmail.com> In-Reply-To: From: Linus Torvalds Date: Tue, 19 Apr 2022 09:41:42 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 02/14] tmpfs: fix regressions from wider use of ZERO_PAGE To: Borislav Petkov Cc: Mark Hemment , Andrew Morton , "the arch/x86 maintainers" , Peter Zijlstra , patrice.chotard@foss.st.com, Mikulas Patocka , Lukas Czerner , Christoph Hellwig , "Darrick J. Wong" , Chuck Lever , Hugh Dickins , patches@lists.linux.dev, Linux-MM , mm-commits@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 3330B180021 X-Stat-Signature: tq7m8o9xbhaphnx95jxmwjae8zy1sho7 Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=bOi7JrsK; spf=pass (imf24.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.49 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-Rspam-User: X-HE-Tag: 1650386522-277397 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 19, 2022 at 2:17 AM Borislav Petkov wrote: > > Yap, and I reused your text and expanded it. You made me look at that > crazy DEFINE_EXTABLE_TYPE_REG macro finally so that I know what it does > in detail. > > So I have the below now, it boots in the guest so it must be perfect. This looks fine to me. Although honestly, I'd be even happier without those fancy exception table tricks. I actually think things would be more legible if we had explicit error return points that did the err8: shrq $3,%rcx addq %rax,%rcx err1: xorl %eax,%eax RET things explicitly. That's perhaps especially true since this whole thing now added a new - and even more complex - error case with that _ASM_EXTABLE_TYPE_REG. But I'm ok with the complex version too, I guess. Linus