From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE0E0C001DE for ; Fri, 11 Aug 2023 16:39:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 701B46B0078; Fri, 11 Aug 2023 12:39:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B1986B007B; Fri, 11 Aug 2023 12:39:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 579506B007D; Fri, 11 Aug 2023 12:39:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4B33E6B0078 for ; Fri, 11 Aug 2023 12:39:11 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2696616087D for ; Fri, 11 Aug 2023 16:39:11 +0000 (UTC) X-FDA: 81112383702.30.6FACBB5 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by imf29.hostedemail.com (Postfix) with ESMTP id 226D1120008 for ; Fri, 11 Aug 2023 16:39:08 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=HKHeGXsC; spf=pass (imf29.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.179 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691771949; a=rsa-sha256; cv=none; b=Hs1bpU3L0QBA2TO5DJ0kwh+X0pPFLt+iXZQm+bumAVT4oyiI/YY9q/AKe5W6ERvpwYZsc3 xEcYwL7fO/AZGhGqnH//eMsDQWHTz370evl4ZXblrC6pgmNaQB49LaHCJA8RhqCuN6lpyj Qu2IR/YhKonqGwuVIKqgSwwAYuLQk80= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=HKHeGXsC; spf=pass (imf29.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.179 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691771949; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZIHlgRVD4zuIsPHrllchsXgEvRrrKBDJPCXSLRIlRrE=; b=rgwjA9COar9Re2KB0jNxdokd9mDazEO1dE/zIpydJRHv8ckCwoLNab4P853uHZzxiUpNQ/ mDajNHNZYIHx7iZkAmqoJr66ZriLtH1okEDz5MV92WRpoQmMUel5BXLqbU1TIlDvK9DOLm LoDmBJGst9+blGZKJo9kFanplBjAhKw= Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2b9bf52cd08so32605691fa.2 for ; Fri, 11 Aug 2023 09:39:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1691771947; x=1692376747; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ZIHlgRVD4zuIsPHrllchsXgEvRrrKBDJPCXSLRIlRrE=; b=HKHeGXsCsnFAgm5g19pTrZh7wlETPzz6bibBKIHF7dFVtlcbrZfdZx/5fo+bjGFGKR JlmyttburRrNMleVRL7az+QY06Z99EU/gQdrtZiZtFMDu9QYak1AQGY/CfVzd8BSx0FQ YYXV9UECSnsSqdxDAaAJ2Pm0riRPcsoqhgyK8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691771947; x=1692376747; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZIHlgRVD4zuIsPHrllchsXgEvRrrKBDJPCXSLRIlRrE=; b=E/plFyQxEd84yDacveh40ZlxGszLK7S0QbhNIbrmbJG9VZ5w1xnh+/SvelaP/gIOb0 Y27G/LlRQtR883gsjy1G+E2dAMPuN6z+FZBN0Ja3gSR99V1KkWakIxc0noegil++q6iy zzMsm8fX7Y9vGCuBtbD+9/SdJA/+9E5ABJO9HpiHBnim7Z5xVmjSZQMXOBZT3KzsEEym 8vxU/iscWLJDIDO3IDY9SYyFMsxxHdz20EZuKTjccy+c2MhvyshIjXcatAxJdOnByNKH B9qnPvPofEuQXsJbMl4DEhx605pz+i7R7e/nU5QX0NUDVhhj3wKKTdeSb7WFITe8/+gB rkAg== X-Gm-Message-State: AOJu0YwBVnySsqXoIdJS91MIPAdZJVXVUdHmSdt9Vc18nV48z1U2i0sA mkvrTk4fbWiP2Sg50sql8xHySrJ+jraDt6WDLcqfQvHt X-Google-Smtp-Source: AGHT+IFI/HrruSD91xDYp0yVQHoryDesjiCP1edH+ACd6ly59BUWMIjPKmB0nes/XdqeqYOc3Rjk6g== X-Received: by 2002:a05:6512:159e:b0:4f8:7772:3dfd with SMTP id bp30-20020a056512159e00b004f877723dfdmr2332310lfb.11.1691771946848; Fri, 11 Aug 2023 09:39:06 -0700 (PDT) Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com. [209.85.208.43]) by smtp.gmail.com with ESMTPSA id g15-20020aa7c58f000000b00522b7c5d53esm2249450edq.54.2023.08.11.09.39.04 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Aug 2023 09:39:04 -0700 (PDT) Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5236c9ff275so2897251a12.1 for ; Fri, 11 Aug 2023 09:39:04 -0700 (PDT) X-Received: by 2002:a05:6402:184c:b0:522:ae79:3ee8 with SMTP id v12-20020a056402184c00b00522ae793ee8mr2037905edy.5.1691771944135; Fri, 11 Aug 2023 09:39:04 -0700 (PDT) MIME-Version: 1.0 References: <3710261.1691764329@warthog.procyon.org.uk> In-Reply-To: <3710261.1691764329@warthog.procyon.org.uk> From: Linus Torvalds Date: Fri, 11 Aug 2023 09:38:46 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH] iov_iter: Convert iterate*() to inline funcs To: David Howells Cc: Alexander Viro , Jens Axboe , Christoph Hellwig , Christian Brauner , Matthew Wilcox , jlayton@kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 226D1120008 X-Stat-Signature: gbxa9inbgfmjw6y94q6c8ups4jxjmf9u X-Rspam-User: X-HE-Tag: 1691771948-582936 X-HE-Meta: U2FsdGVkX1/92UaN8FGnNHdCLLqHx/pJ5HnGUMuW2lWh7O3XEx2AeYmTvH0DtrT+luLqTHRdTHkKOE9KnBg/qSBiF5WyIL+gugnKAQAxsRgyb8IREPDiydx7DtpPmCZ2gLe1gnZiZZ+vaP53QUpos+WO+kUaMHflGYJbUuE6tjA93WCOzLaVs+rQIMgJkLHRAIxJpLOzqp6Xt3pBHRq2JkNn1MV8SxPOwMuaGzlWjYCa667dKaaojNfThTaSag4kA7s/uUN3zBcoT2qCB0bW5+oMwUCqgmqaKyyLZij6+LK3dKZmE1XttC+9XCv8GlSoSxLT/9Glpbgz3KmVUqQossb3rcIpIHoJYqllEWH43KJjVUA0MRLFBYeaEupuRV/y/CCsEdmg423ZOITwmT44rx/wuOx3ZTH6N2Tp6modbx+yI+s0GaUQFRVLfThJmI1xv1C3GtUSg8jyFEVwajbDM9ZUz/fEkv0Ubd74LRNzCi50N8YS7rs20d8b29JGVlZRMylfL4p8JyDMG92sE0bnv72n651B+nuhiVwxy9TKJ3ccIvODYyMDfZK9AafXdFHI3AFUcmdS1RFQmOUmQvGmB/9bqCvOB/YwMNYeAFiJG3Bb8EEb9NnIUy3gWqUH2WZoyJw5lYXjD+HZfu9VV6Qdx4/lTukPod1aqPGQudrwctTvDaMmczOj2CdOsPiVEVhqZTpbMqYgAT9VSKqcwSk4ekYJvgzIDyQTR9Zukmx/ZSj5DPdTQrWiH1VFVEpa5WmVQaTcy3iy4Kgvj8URAQzPc+LLRm2hjjfK4l9DKpUzhxx1aEi3zLLjYDOMYpoSVvsrCWCD3PFsEp1MjG9RqGLUjKesR0D2DOlWv49pWD+CAe2NmKMlqPxnmVP4VEiMkb2EdxX9Af7I37uNBTqGfYJDDDLXIfndBnFlskNdgBPIXEIZfBJo+tF/TvO8zkNwlw06aCwbcVFGC0SbxLoIvbS 09zK/6kl jGZtlVzARBtqTcEqn+g1UqEB6niViNPG3gR0qGwx614o56nTUmeyvcv6o1rV2wNEFYBZhlwFwmN5kd9OfJGt5UzXhFv4Z2az00MlQwVJuyJlg2uF533Q2OzZ6S6VoooxCDbXa/Cjdn8zH073GpmgWNjxucCa4bLVH9aRz/EqaMz7nAeU1WDUoIvQWYqMGr6jWpUMlu15hcy7TpTlHgSYPdfy3v0gMoK2Kv4sylCl5/vydxU93ZOyMA04tkpTL2L8ChQwH1wxYzYLn/KmXAJUc2LhZUYsiQ9mNA7JZb/hCWhEW/5yyM+e3wF9ntVyGRl7re1twyMqHSzgOzHWuEsPAOyYBqPB4/N7q+ZXPu6cDRRRuwgJN66uMvXO4T0Nr8AaQHOW1xO2WXh/EZWxm+ewYjL28BaY7FEgAnva+R4W0AdJ3aPb96gTGpkUiWEcZzuIeYjILIQugFGSHEHMZAmtUEbrBj31J75omh+qfDKJLhwLhiIXdZIxcVXPP30uk/gatUGDZnVEDpLxsGBWtq5nQXsjb+mO4bZFiZvwLfglQ0SeJg4VUSnvUuIOpuZoqdvANQ5c3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 11 Aug 2023 at 07:40, David Howells wrote: > > Convert the iov_iter iteration macros to inline functions to make the code > easier to follow. I like this generally, the code generation deprovement worries me a bit, but from a quick look on a test-branch it didn't really look all that bad (but the changes are too big to usefully show up as asm diffs) I do note that maybe you should just also mark copy_to/from/page_user_iter as being always-inlines. clang actually seems to do that without prompting, gcc apparently not. Or at *least* do the memcpy_to/from_iter functions, which are only wrappers around memcpy and are just completely noise. I'm surprised gcc didn't already inline that. Strange. Linus