From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 803F9C49EA1 for ; Tue, 6 Aug 2024 14:46:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 185BD6B0083; Tue, 6 Aug 2024 10:46:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 135B36B0085; Tue, 6 Aug 2024 10:46:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3ECB6B0093; Tue, 6 Aug 2024 10:46:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D75306B0083 for ; Tue, 6 Aug 2024 10:46:31 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 744571202AC for ; Tue, 6 Aug 2024 14:46:30 +0000 (UTC) X-FDA: 82422096540.03.B4E259A Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf07.hostedemail.com (Postfix) with ESMTP id 5538D4001F for ; Tue, 6 Aug 2024 14:46:28 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=F4cyaUvw; spf=pass (imf07.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.49 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722955580; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MWWrNlqBqyxE+pa3MBe3r8meejGqG07YEY2OhAnz4Do=; b=AQqM6BXRJ2PISjAmyQYIbYZ5PzfzswUMzJtdZt1QjE9PT9ywfoOS11Pkgaq7KgFKg4i+MF BKjn+2lStGTnYnT3o5OhgcGwV3kb8ggqKf+X4CU8GEvpTsq0F4+cN63ZQkm9hXT79X2CP3 Wa7PFrsR/0E5qqT+Sekm91xOxkR9MjU= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=F4cyaUvw; spf=pass (imf07.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.49 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722955580; a=rsa-sha256; cv=none; b=gZ5zbktfSJo8+wtuZ08Jc5tdlfSImeO7YSzzoVztv3MdpuvTv60qaoOtis6CREZG7yIKXK IAykDDEj/N5twfd1yguTT/PejvmsQPjI/7CdBdL1xOE+cXjsQodyPVGAkF9mnEPU9UIdVU fIcuKW1pBFlYquzmyTPVOEek44rQw5g= Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-52efd855adbso1139881e87.2 for ; Tue, 06 Aug 2024 07:46:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1722955586; x=1723560386; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=MWWrNlqBqyxE+pa3MBe3r8meejGqG07YEY2OhAnz4Do=; b=F4cyaUvwhOuc3+24Umbw/dkHhRtDIbIYTVLDvGAoiWJtLE+DtC6PfTvdFUswTcn0r4 SAxbWgCjgbMY4veN7tl4crx/tyrTh/0By+q4IUOAReJj6izjfvueyQcDQWpXIGIXZLTV w1NoHFzwOPiB0vZcOMnqbLlJWhKWmo4CGn760= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722955586; x=1723560386; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MWWrNlqBqyxE+pa3MBe3r8meejGqG07YEY2OhAnz4Do=; b=eww02i3sn9U0pyIh9dMNx3Mca0LX08RqN3cqwt/S0q4d8JXn9iH7ha4Ly7OXcHmbN6 kkPFJx01AqjB23Hl93K1NxcKgXrvFfOUm8CB6NxLVoHvx/yc+jTW50RaFvKadJVuKSrj aVyzk3pzmHlAyCtX/Aut6e5VZm4afNMUgkCpI3ZtauOXr9AqbEB599pBq/4/94idbGK3 l833ScZ9b3oSirTfWz9Hq/S7WZelEHOMTFA8yuDOfrRHskehkYSklAReN2gEUNguPn+w s0FCsoGAs/PXUzH8eLz4tE01WDv/mO+GTMJIfmgSeCnj5vJeai2PvlkF+pamcSOq2khi hT5g== X-Forwarded-Encrypted: i=1; AJvYcCWFPk4jgI9zrdsKpuLxrCHvD3i1XCnpNhPQKgw2ZBfPJqlqi3MwfdAZjFRfmzO8DLaI3GeYlp1agADSo/3rShf32mU= X-Gm-Message-State: AOJu0YxfGEAloH06dq5XcuyVgbR2PxDPbfSlofQrj10tuVjBQzxNXpFq qIRkfw7I1nJtIstZ+zuTHH7h57Oze3Mw8FV+AZKDRr1JVh8IW7229iYnSY+tR/gsSM2a0x7kqZ5 262OwmQ== X-Google-Smtp-Source: AGHT+IH8I7j3NiwX+YumrJvhS3nbT1gV+Cif7+0TimMwhu7pYB1/C+3761/5PzQKvtdnq03JYpaK4g== X-Received: by 2002:a05:6512:3092:b0:530:b804:df26 with SMTP id 2adb3069b0e04-530bb38120amr9579252e87.30.1722955586288; Tue, 06 Aug 2024 07:46:26 -0700 (PDT) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com. [209.85.128.49]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5b83c22db71sm5918703a12.94.2024.08.06.07.46.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Aug 2024 07:46:26 -0700 (PDT) Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-428085a3ad1so5736675e9.1 for ; Tue, 06 Aug 2024 07:46:25 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCU6uoPwx13SOqvUaUUkZdwKSKOP6CCg1Xbj9sNRXP/G4FGJIvgaLyhCYiKr3wkXiLNHqhQjxa0F2W8A27Rnx7t291U= X-Received: by 2002:a05:6402:22b2:b0:5b8:1035:214 with SMTP id 4fb4d7f45d1cf-5b810350411mr8834214a12.33.1722955106581; Tue, 06 Aug 2024 07:38:26 -0700 (PDT) MIME-Version: 1.0 References: <202408041602.caa0372-oliver.sang@intel.com> In-Reply-To: From: Linus Torvalds Date: Tue, 6 Aug 2024 07:38:09 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linus:master] [mseal] 8be7258aad: stress-ng.pagemove.page_remaps_per_sec -4.4% regression To: Oliver Sang Cc: Jeff Xu , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Pedro Falcato , Jeff Xu , oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Andrew Morton , Kees Cook , "Liam R. Howlett" , Dave Hansen , Greg Kroah-Hartman , Guenter Roeck , Jann Horn , Jonathan Corbet , Jorge Lucangeli Obes , Matthew Wilcox , Muhammad Usama Anjum , =?UTF-8?Q?Stephen_R=C3=B6ttger?= , Suren Baghdasaryan , Amer Al Shanawany , Javier Carrasco , Shuah Khan , linux-api@vger.kernel.org, linux-mm@kvack.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Stat-Signature: h1ezuzf91awpptqmzdhqgp1brcmq78co X-Rspamd-Queue-Id: 5538D4001F X-Rspamd-Server: rspam11 X-HE-Tag: 1722955588-496250 X-HE-Meta: U2FsdGVkX18l8vgBpb+K+p9fpVORCaoPWZaH6B0a7QJzwa5zuT3gC5Q4RMud8HzP4eOAKRvzI2YDML33ccdIpn6q7UnueEZu8duc3kNiMEMGMDXynHk6JgHdRfVVm++IEgwho0BXyATrv92I6e3TF5Gtf26Z23A7UAkxIeyNmk5ohd6UZfJ0cvFWPkjgsd09SbMaNZ7dlx6pH2BXHUv7qkpWvEAEmQVbgh0yMUJ5gb2BCly63zxEuJtk0QmmK5xXAkC4ld0ZLllanT7gmSY+FbCSfmm+5NAr2aeSXoqN0VHOrb8kLQ5CUk87Cor5j7gYvbe6eQnKRiuND/zh7D5/gT0APm/hXASrINTyRTgyXOn1slI6Y9lCLKpWy9PYt1Xv/C0bnXIhdwMyt3Q2E5q0sK20GypEFPuGWsEU8nX+ZN2GTwXUdikN0zwS8rSiQO0B++L+1o878PYIiOGW5XybEEPAgd/MX35n/QCAtC0ctTNwKhKeBIHS/uTjQLBPGhizTTvLBrL0hQd0XYNew9Q6RVdR1SSBSumEcTMis53Y05MiqLtT6BsCC4ML7hNxJabi6WsF2TuVUlonKQ8Vyf9wKu6/T1/aZX5WEDqAWI2RDZQ0B/r9tOyQZMy+dzXTISSM50lhZU9ir79a48oE5x9PzoLgGZlfayMWnLu0DIu0TClbf2syKQvhc7wtvjCen/yeLiavC8jIgrZLa2Z3nHt1NL52aCCCq2BCPeyQnSSmxvBgQKqd1hI6pcjKtN1g9u7z/HqiARvyFxU6reChw+K4C09ps0WQwMMDq2oNZ/hVCi//UyxoZibAEnpv3X+Q7IqYv7cRRlnEkqD/EMpobrLCTZCAK8du+sg4fKaWpUfmDf/jVxV1uG8o3boPl+QI6g5CesHMcn7YOC2U9vQr9/K5TuNYpI7TWoI9vsfSSYOo1OiIDsUlZQhyB663RvJ3B0M/LTUUiXo4Rb93EevNvip /uFBKKJe ZYy8Sye0EyMc096biHis2PUjiSl0ToYqyNVZTUHSexD34/NEZe41O7GGLhHCMsS5vZdXRpoH1+dr/gjXxfyl5oOKxDf5+cgjXiC5llzF0Oetwy63UC4k5PXlfyV6c6xDTJqUy2Ru52yH1qS/bObnOVx1p/4T+GW8pYIcd8h6Fk7rbUbqavNUFyZXd2v+ijTKk0VXpXLsYKJDYiJBQaIksdarcsxyZ2U6uAV4ZjjdAH3PVAYvyWV9ScHbqndvtV2z3fCvl0+lfESY1pnCt0HQcRLeYVZO0eLUP80Zy7ttckMjVh17Zcbxxi+Z/t8rAJd9iyMJ3nHjoH+2UDcx7C11+QZAi+ALYycuNHrUmCTTk+KYOaQ04ZGV+oyNzhiYmcobSTzJirGn8tQ5QFNVjU5mjWpbTgKw0uYtv2Peat0uIz887FGKS+dNEf0xflQfG7KmEEN6ub+H9o9XB80Ss0ByUcrOdBxA9x22jAbx5BqmE/BKT6wJ+hqIXV5U8Ar3dn/0SLWOMgA1DQ0oPseGn/eh+ObD0N2qxxzq6i9ioMq8JCK8ELI2Tcn/Bpem4xO7pZxwznXYQJqU4b5ETYjRDUov4eUqXw1zxj1UP62u0jU4Pk8Wv8mHlKTMIPQpQ2A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 5 Aug 2024 at 23:05, Oliver Sang wrote: > > > New version - still untested, but now I've read through it one more > > time - attached. > > we tested this version by applying it directly upon 8be7258aad, but seems it > have little impact to performance. still similar regression if comparing to > ff388fe5c4. Note that that patch (and Michael's fixes for ppc on top) in itself doesn't fix any performance issue. But getting rid of arch_unmap() means that now the can_modify_mm() in do_vmi_munmap() is right above the "vma_find()" (and can in fact be moved below it and into do_vmi_align_munmap), and that means that at least the unmap paths don't need the vma lookup of can_modify_mm() at all, because they've done their own. IOW, the "arch_unmap()" removal was purely preparatory and did nothing on its own, it's only preparatory to get rid of some of the can_modify_mm() costs. The call to can_modify_mm() in mremap_to() is a bit harder to get rid of. Unless we just say "mremap will unmap the destination even if the mremap source is sealed". Linus