From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E386C3DA64 for ; Wed, 31 Jul 2024 15:38:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 29FA26B0089; Wed, 31 Jul 2024 11:38:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 250686B008A; Wed, 31 Jul 2024 11:38:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 117486B008C; Wed, 31 Jul 2024 11:38:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E53B46B0089 for ; Wed, 31 Jul 2024 11:38:44 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5A5CB80379 for ; Wed, 31 Jul 2024 15:38:44 +0000 (UTC) X-FDA: 82400455368.04.8FA7DF7 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by imf09.hostedemail.com (Postfix) with ESMTP id 35FCC140017 for ; Wed, 31 Jul 2024 15:38:40 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=ErIhYTAy; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf09.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.44 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722440280; a=rsa-sha256; cv=none; b=rVdrBlXhyc3gc9zswyYhUwz8Q00V1+nFY4oxOrRqT1Hh42R9bGf+jHUVZX1/i43+AD9F8K oM+lL8MtLy0qaSOpfgHFDKNivqpY2bX7Is+X/TypoZhHB/GT4V+5/aFhGuwseIH2zr7h9B sLKGyeOGqHXGZ6hOSYPb8dZS+gv+ApE= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=ErIhYTAy; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf09.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.44 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722440280; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nqxYY02XSCW5aR/b6Hv6+wQ/epmOGp5dhlBbrSTUONA=; b=t6U3thUTqHLssS9F0Dq6ONJuqKAxz559qKYEebJzxV9sNrhTYbdirIFw+lQbFVL67opi8p eGfFBqbK2HDmUGBGX/OWcog2f4bdQP01gmG3gEUiYQg6NQiET6CGRfbP5cMtfpCxblNBmg gHUVUUYLuLQkh5BuHQ7bqBVq/I7d0UY= Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5a167b9df7eso9445810a12.3 for ; Wed, 31 Jul 2024 08:38:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1722440319; x=1723045119; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nqxYY02XSCW5aR/b6Hv6+wQ/epmOGp5dhlBbrSTUONA=; b=ErIhYTAyDkQZgbt8AelLYLGNwghTB61Wsd4eIAzMBZ0kv/7TtBM+NRxl1LQx9qsROs EAXQPvWQ1D+DR0guZR/Ov2/D8f4ByZRbDbOGIvD5RTRD04skZdsSz/aq52JSM1Emh753 8nEoLNvQHrM6eSRUhQ58+/boqXe5ZyJfUDyBY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722440319; x=1723045119; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nqxYY02XSCW5aR/b6Hv6+wQ/epmOGp5dhlBbrSTUONA=; b=TIL0NMAA8wCK+CmWMySXS/vrnXyZNwrFkPNe2607GQt5nCFi3g+3mWybWLgMh7phbZ LxexeqOBVg3u8Dio2FNfyo/FrooCaRidjzDPGpGJVORuytjKK/Q/VqhQ3+51NiVVPW5S uexMd/3hNvwGH6Gval5cPObCZKtjS23h75UJPVWGweEyartvCALBGt3mSD+3yU4Awkck z+pe2dCekWdDJJYN8Lsluz5CrdtFl1UmMc215GSHQ9l9ZY73i6KLTqGbqRgP8QNE7H4d 8vgTB/GKc4aW2TgChVjxweGvwyOxa+/kVOPnm3F3hrbCdBQ9Y6FDZl6v0qMKjcDIBSrU 1/tA== X-Forwarded-Encrypted: i=1; AJvYcCUbXzBvaH4pt2V8Q9oSPA9n28DHaEb2S0qaaEXwNsKTSnkU0cFVxfDjwdknN2pODxlijnWz6jzEnKIez/1YdDudbHc= X-Gm-Message-State: AOJu0YwmZKMkGIEMbhIIL180/jINkSIgphaXwps19uscbZk/VSa9Vr9x O84RiNBWHnuDpiPSMfT1JRfk0wuvqMsYg/lUkUcpLJUHkzQuhxC2rIWBgCgAFNBOuu2jhjHP5sT 2VAzl+g== X-Google-Smtp-Source: AGHT+IFmnUR8rzVy/UEIAwiEBJ0twTNnaxT9HCbR5HvMg97J9H5B4yoO2Npq0yPU2eG4CX+yOYYCYA== X-Received: by 2002:a05:6402:34d2:b0:58c:eee0:4913 with SMTP id 4fb4d7f45d1cf-5b021d22aa6mr10060652a12.27.1722440319286; Wed, 31 Jul 2024 08:38:39 -0700 (PDT) Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com. [209.85.208.51]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5ac63590aa3sm8842014a12.31.2024.07.31.08.38.37 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Jul 2024 08:38:38 -0700 (PDT) Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5b214865fecso4417696a12.1 for ; Wed, 31 Jul 2024 08:38:37 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXwNnV2Ghqf2w+blVba+rV29pn26iYADyaDAB9OmXla/H1LHiA6g32X6glRHugLYvKDODSy6pI3vJTx4P+dX3mhdaY= X-Received: by 2002:a05:6402:35d6:b0:59e:686b:1874 with SMTP id 4fb4d7f45d1cf-5b02000c768mr11557176a12.6.1722440317614; Wed, 31 Jul 2024 08:38:37 -0700 (PDT) MIME-Version: 1.0 References: <402c3c617c29465c898b1af55e3c6095@AcuMS.aculab.com> <5cd3e11780df40b0b771da5548966ebd@AcuMS.aculab.com> <8111159a-c571-4c71-b731-184af56b5cb1@app.fastmail.com> <73d65e2553e543069f9969ccec4ea9b3@AcuMS.aculab.com> <0549691a6a3d4f7a9e77003b70fcf6fe@AcuMS.aculab.com> In-Reply-To: <0549691a6a3d4f7a9e77003b70fcf6fe@AcuMS.aculab.com> From: Linus Torvalds Date: Wed, 31 Jul 2024 08:38:20 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/8] minmax: Put all the clamp() definitions together To: David Laight Cc: Arnd Bergmann , "linux-kernel@vger.kernel.org" , Jens Axboe , Matthew Wilcox , Christoph Hellwig , Andrew Morton , Andy Shevchenko , Dan Carpenter , "Jason A . Donenfeld" , "pedro.falcato@gmail.com" , Mateusz Guzik , "linux-mm@kvack.org" , Lorenzo Stoakes Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 35FCC140017 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: z5ip885pnhadzpbbazigf5mqzaazd5wh X-HE-Tag: 1722440320-222793 X-HE-Meta: U2FsdGVkX18uYFsM/zwh9pyfGXetHQA2h56hJejnTe4ChAxT+G41If74a+Vgo4p064RBQFYoGStWVZ2gNkGEHYFXvF98Dwq4/piBdpXiPj78CPFuaiszCwUBP2/GPhhlbwF9CzAk4yanMiiDUh96JXPZRWFKHbUD2jj/sGsmJJlPS1ZAOQp2aQ1jUqA4Ey7jS0Y3ODNAViRK6GGS6k9+lKZ0ZpgHtb0RZ6UUNhztBAQvfDa2mh+IvSYdr4zZQgVmsMrSEW3Y8MxsxEum6M1PjerMcgsybvJUy+MnXqvYQ7DdHG4tC0qhLSqaSFqxi5j1vy9K+UVdxlbVuipLYPURN6uDi0nDvu2axgnfN4t35E9ROZP5M/RpeBdBMN+Zo/Z87aR86Ow7RODzXQ40OlMNYUTZ/JiGTnElKZg0q9Hr1f4Rh9I3jwccT0UiPhTO5rTOlQrG5/IWjHnuI8pGuqpnP6nJVgfr1f02c7vNwNH+4ouJ3l61s0hzQjwTEl7EQOks4lC/PFR8xYjVhD2qMobalLT1xWPZxYiohl0I6pTb92oiXD3CB/8hPCxETtkboMjhSO8NdXPOQ3alfbysHHDAM0Z11myX+jCqfdPU/hntUh7pE2cVP+S4W1xy/j7QMglmQfvt33t28VcLEHKV8UCZwUqPgo75CVGUcqsL+ysMnVATlgASqy+ilIZ5rnReYg0MACi5HUl1ZwnP9JUu7jFk/+dCLJ61tHBTWESrXaZCiWeA8gXLDjo0Vwub4fHC5vNW+DZM9IvxpeDz4XZd2lFokn9OPYvu3wIXKaWDeR4z143k+HBYrBhHBPsq7SenlmZhGgk7VzK79P8cfXIjfUHkjcD/0O/PeebTb1b5L0FoUP0+0g9SZdMJmL6xVKgK8HPqAUiYuw/WJWjejlMjKfXTH6E/J13Cc8+cGqH1kQiOUXLE0S0WEhVY2tPRp+kbUxR2H7kKZz7Ik7oib/h+pXt JWyeDI+e 08dPtsbLhojb6uQSQOmZs9+GB5/EgL7aOaEmCrZjjN8F1GQt2jWLr3L/J267HjzsT1NDLp5OeovL1FJahS1Dyugo63T7ZxQ9yBIs1KVvgxifjUExJZjyxqiJmYLU1jS7rYJ0yZ00NvgyDHI5uE8iD0uukv6UopbB/7Xt0cDpyEaha1GBm8xykPgTsmo84tKjsOOWzhNxylCDf6l2ivNeUD8C+u8QtSXYVI+e24UpMQqbd22GkIgIqoeE4mg0220/4YFn0HTzkpj+0YIkMwIjFZjC+rihqBQWgCQLAQOR0+maMpqLmCkHhcHqPE6qYE0AvogNAnfrAwULTl7AePSC+71L/qo3uBRtcvKtmYjFSmpgfnvx0j6catfpnqdTePLKNPXc+1KVWVbwD1lI72qDkEE2By6AABPY5OXMZWPblCNvf4oa5p+1LpZSVjwgidJITecssEuiroemGmrYSkn6Kt8sHLFmOT5+TqdclGnPGHuabwG4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 31 Jul 2024 at 01:10, David Laight wrote: > > The __UNIQUE_ID_() define just seemed excessive - especially > since all compiler versions support __COUNTER__. Yes, we could probably just simplify it. The thing is, "all compiler versions support __COUNTER__" wasn't historically true. We used to have this: /* Not-quite-unique ID. */ #ifndef __UNIQUE_ID # define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __LINE__) #endif because __COUNTER__ is such a new-fangled thing and only got introduced in gcc-4 or something like that. So that "prefix" literally exists because it literally wasn't unique enough without it. And the "__UNIQUE_ID_" thing is probably because that way it was clearer what was going on when something went wrong. But together they really end up being a somewhat unreadable mess. That said, I did end up liking the "prefix" part when looking at expansions, because it helps show "which" expansion it is (ie "x_123" and "y_124" were clearer than just some pure counter value that doesn't have any relationship to the origin at all in the name). But I did change it to "x_" from "__x", because that way it was minimal, yet clearly separate from the counter number (ie "x_123" was better than "__x123"). It was the repeated useless "__UNIQUE_ID_" part of the expansion that ended up annoying. Not quite annoying enough to change it to just "___" or something, but I was close. Linus