From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F011C77B73 for ; Fri, 28 Apr 2023 02:54:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 879B66B0074; Thu, 27 Apr 2023 22:54:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 829B36B0075; Thu, 27 Apr 2023 22:54:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 717E86B0078; Thu, 27 Apr 2023 22:54:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 660086B0074 for ; Thu, 27 Apr 2023 22:54:11 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 270FE40194 for ; Fri, 28 Apr 2023 02:54:11 +0000 (UTC) X-FDA: 80729280702.28.9361017 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf02.hostedemail.com (Postfix) with ESMTP id 1734F8001B for ; Fri, 28 Apr 2023 02:54:08 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=gVr7G68n; spf=pass (imf02.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.48 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682650449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/9mxxPAl4POq2fq0d8t6aqpR8L52uoUsixYLH2L9aFc=; b=MSS/nTY60LAfXMtuw1IjHwC/3ZTFypW/fmTfLHFP2DFDA4yX+BDZWS2+pITJKYUTAa0zYg qSHVzLmCkTOjWOfnctVTn/x9Zo4BsKYSHVkVO+WRtQnZYItefWkcouC+M2+F3AsgNWdug/ 5LOJGnWbZ2+TEhfUEoZlVqW9PnIg1CU= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=gVr7G68n; spf=pass (imf02.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.48 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682650449; a=rsa-sha256; cv=none; b=Kz+WCwvuPCv5ZTv52CicChhzvy2AhhW+laDz8+Ja43pvoiftZg9c3BxB+WEknaoFE77wSc ZdD6D42Wiogt/F5ADJvOot+zsogDbdMYJw7MOr9H49teyyOSVO8664n9tIZrGjoq1FtuYW SwVJnzKjQpwWQZxFAaj68sRzM3IB3xs= Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-95369921f8eso1519392866b.0 for ; Thu, 27 Apr 2023 19:54:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1682650447; x=1685242447; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/9mxxPAl4POq2fq0d8t6aqpR8L52uoUsixYLH2L9aFc=; b=gVr7G68nDrSh0Mm8XFg00vgUBfCAEBsm+kBDZ6P2d/L3Go4V19Aec1suNiJ2VDMl4a NC//cawahRxIQyl707Nwom4+1A1RhV2GpO/XSsIxz5nFODPCXoF0mxYmWyNW/oJNrQUG lEX7cDfl2BDYrMP3hbQsVenPmN2vzJMOvESpw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682650447; x=1685242447; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/9mxxPAl4POq2fq0d8t6aqpR8L52uoUsixYLH2L9aFc=; b=jUzEdqAmkmn+rLzSa2dQEannEzhCywjhNsl0zS3z/qr6yW0K6GCj4WsyMEcDGqp/kk QPHQDeu5Wi5RNjEoQhbl8ECo0F/lgAOlemb8gA8KcgbPbP+cnPA4pn8pBfSzVZKj8OH1 wRwnviNzDfBwso08i2ITitbJbgWEG4bLhJ70nPA1B0vog0Ns039KY3WYUTPx+/FQwkCg Ia+mB3B4Oc1DLEX3+WOnQ/lf4nbxoN3UasxEVswTdIc+R6QHh/6qOVXybA6wbrp4yuNx s6ZcfgGpflejaXu37UFLFOpcms3rwr2XwO2ItT2RmoxtNMICnOAEecBEtpvfNs3n+qHl U2QA== X-Gm-Message-State: AC+VfDx2WqrNHaZKA0af2lQkPqJxNwqBNKalFC25IEXnXPOp1vsEi60a /GAByKUhM9tPnNq9DPHRjUpXLb1cQjfx4JElKGLspg== X-Google-Smtp-Source: ACHHUZ49yJV5sPmxMXQZtVpjYoMT2kvL7rsGoKMcPGhroVTdy9EibSN2piZScVfvMv1GAJardFIA+A== X-Received: by 2002:a17:906:58ca:b0:94f:3804:5cd6 with SMTP id e10-20020a17090658ca00b0094f38045cd6mr3530215ejs.66.1682650447218; Thu, 27 Apr 2023 19:54:07 -0700 (PDT) Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com. [209.85.208.50]) by smtp.gmail.com with ESMTPSA id fp31-20020a1709069e1f00b0095251a3d66fsm10395431ejc.119.2023.04.27.19.54.05 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Apr 2023 19:54:05 -0700 (PDT) Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-50847469a7fso13502374a12.0 for ; Thu, 27 Apr 2023 19:54:05 -0700 (PDT) X-Received: by 2002:a17:906:da8d:b0:94e:4586:f135 with SMTP id xh13-20020a170906da8d00b0094e4586f135mr3520975ejb.6.1682650445056; Thu, 27 Apr 2023 19:54:05 -0700 (PDT) MIME-Version: 1.0 References: <20230427140959.27655-1-vbabka@suse.cz> <2023042719-stratus-pavestone-505e@gregkh> <3cc6e10c-f054-a30a-bf87-966098ccb7bf@suse.cz> In-Reply-To: From: Linus Torvalds Date: Thu, 27 Apr 2023 19:53:48 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH for v6.3 regression] mm/mremap: fix vm_pgoff in vma_merge() case 3 To: Vlastimil Babka Cc: Greg KH , Andrew Morton , "Liam R. Howlett" , lstoakes@gmail.com, regressions@lists.linux.dev, linux-mm@kvack.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, Jiri Slaby , Fabian Vogt , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 1734F8001B X-Stat-Signature: 1rqq46qi5agameqzfqbf8ptkmggdnp6c X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1682650448-564604 X-HE-Meta: U2FsdGVkX19a0Nf42arHu4BFT9Xv3aAk4HBwpqFzOHxHbd20udQa8nxStUEaVExfGBYkLxkGWD4tssit+bgOesXquh9ysnPkMNFYIKvriBxGTSGefEpR3jdI/C7JWxct2JVf0xNEbXu1GLVy2tidvnUvAWWECUQp73Vdcs2sqKmS1GfO1QNQWHh6b0r03rEucSJ3Jzd8xLIvZP/PZyutBjrTmKTEgn0RmfXYrP9z81+oYu0u5vhJWA+yKH1+G3MeIMUIgBzkHQSQHE6i0y8acV8mUefntdW0XvoX5X+0YXcn+8Lo3Cm7qrkoKvSi3Hr5c+P9kThY7ny8euRwOXpqo8iaWKLoo41gglN28VXsW/aAt6Sz3xlImHHd5b5ycmnrPc/FLXUOdq+N8/JfWOsUrsMQ1iddQKTw1LIAqMhXfp42cGAhyoD08fW+tU0nUTmsno19a0PcMWKSgA2zUnIjXPqdDPYfCCxMQTjMcXNGASq6XdqZFQfFL3KbRkwpYGKL9wV8wzbTt2JYyUHf6mMTYBVL/61pHKayCUv7zlCirtI9Kw0CfuSNPisK0b6vqaxgc1vx8Y+K6r4hoTZ42izhjRJqHst61ILp7/1XiKqlfXdEb2Yd69WBOCic250DAmJGp5KxKuhRcaCRercZzy4X1bDDj+vD4eMpxrEEBrZcdbRb+pR2ruZ1rAvlUZrMeAT4jSsMz/B9foPb5jo2rALm0Wg/zlht8j5bYkjrgpu47VOXHwCvF0Zg4cXiECWL1Vjp2bpGJ8gSOZp1Yd837RzBg4Iabo0LZPJOn57wS7qajDs6bpHod2qIfD++kvYEWXX/bR3vtkjBzIXZK+bLFKgrByEpCOdkZSd7FnWix/zBPrChtQsfOcHGgmTKT4nFf7SNNEmnnTV5xs9o7WBwAW+dJBqNw/TGoMC+RzCpm5dD1tLOL2lZDVsfjx+C7fqRasVZfU7TAwXbrnNxlSbkyIf AwkWrWpW h46KeYK5NweR+nsIKvup0qgqFwOfhh3DVt7gFlGYjezphXN850uTHEst58DEVKd3LKPQ34MLAgoSUZI7qRZibgWt5zMSP4kOVWZD3UmU6oBwAKeLB4lESgmrkpAE7iZlt2CZIoyaf9aPznSxFTl1cKixec3rDnkMaHa2JoX6h+uPjS6zJIDEjY6Uj/cmj+wLvHrfi+4DtgUgRVB+U2jYlgPuFRdA5xTimQtA2iy4GZD/yVHW93F+ad4IVQFZ/wBdL1BM0hYfxbTbhAtGzo9Bb81tMxr/ZRLwXs0ciAReobM1qmM37R8Rk+aFnIqa5QlJ3iC0QgQJAzcbvu8xl5GM5fihN/81F3GywfavMAT9C/EpWnXuSRlwVcmHp8V9nIzg4Lv2J5qnr6523x7vAilnEViMMZLVhoDGnMzBU1uo3IG9QCCCcDUyyl5fp7gdXFI0uAVvmp4JsO54E+TFNgguOiezPklnKWaZnSTK/WTjXjlk6txnMk35Y1Y0NUyNDoY2q7Up50Z9ScsBU/vfA27i+4RLLxaU36rqXqyvBZgCf9/N5X0OYqEqdfOMtuKyIfNMzkQ+lzZqUykqXxMMwuoF/XWdfu0Mfh4MLjgS1MVO1JY/3FjE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Vlastimil, On Thu, Apr 27, 2023 at 8:12=E2=80=AFAM Linus Torvalds wrote: > > Ack. It's in my tree as commit 7e7757876f25 right now (not pushed out > yet, will do the usual build tests and look around for other things > pending). Gaah. I just merged Andrew's MM tree, and while it had a lot of small conflicts (and the ext4 ones were annoying semantic ones), the only one that was in *confusing* code was the one introduced by this one-liner fix. I'm pretty sure I did the right thing, particularly given your other patch for the mm tree, but please humor me and take a look at it? That 'vma_merge()' function is the function from hell. I haven't pushed out yet because it's still going through my build tests, but it should be out soon. Linus