From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DA1BC3DA64 for ; Wed, 31 Jul 2024 16:04:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 264FA6B0085; Wed, 31 Jul 2024 12:04:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2151F6B0088; Wed, 31 Jul 2024 12:04:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B6256B0089; Wed, 31 Jul 2024 12:04:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DFC1E6B0085 for ; Wed, 31 Jul 2024 12:04:47 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7FF51803DF for ; Wed, 31 Jul 2024 16:04:47 +0000 (UTC) X-FDA: 82400521014.19.692107B Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by imf26.hostedemail.com (Postfix) with ESMTP id 3D7E3140026 for ; Wed, 31 Jul 2024 16:04:43 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=ZaqDkBiw; spf=pass (imf26.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.48 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722441840; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+yaKOV8TmQ0VNaMsLmwJtsrXt1HeOlVVbSAymsrtRf0=; b=Ca1bzHxBsu0l+pSUpPCmh1PaV66FiprSdnI4z8pLkuexMXV5dJ3IZJgaioYCLauJ+RXAwh v0InQM+4QtLlwdltfHC4qxrEoVNMulZ+tVYZIwvD4jxh1pMvIOfPC0WIMMTgXlDuCn43It uEtPCUXkzM8J9SwSiimkKuxeMkZzgZE= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=ZaqDkBiw; spf=pass (imf26.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.48 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722441840; a=rsa-sha256; cv=none; b=OGoUCGzzwcAejYRFPDDxy1FgaOEujPajosrJmrnCG3S8ZdRQVtUfy6JAkn9+g+0VNUfaIi 3aKXXBntYu9DLCu/noNGsbpvf74hu9waFmzQtRgQRm+daSCLZymebjYvvoStSx0Dy54Z/q gFmozk3OfeHzHf6H3sjqZP4+g0vQr3M= Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-59589a9be92so8834688a12.2 for ; Wed, 31 Jul 2024 09:04:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1722441882; x=1723046682; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+yaKOV8TmQ0VNaMsLmwJtsrXt1HeOlVVbSAymsrtRf0=; b=ZaqDkBiwKtc5XdWo50ZFyNhOTREORIkOx7zeAIln9S3pg3Y8R07BXuvQbR/FNbIZRB 77/GWhi1OVHLacaGMG1fn0N+CN5p+ZJ3S6OSMdLNCG9fStQdbQ3doJjo4q8CnFBRWc4x WJEGKZqi9WOyjRnbUh05gf8uWxcn1OWWUy4oo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722441882; x=1723046682; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+yaKOV8TmQ0VNaMsLmwJtsrXt1HeOlVVbSAymsrtRf0=; b=CfGq3PDucpoE25PX8jUOCniAN3beM/kCUjnm+3ENPR43M2uv96FmIqWWdfpKrGTuK9 RTKfKLZuoZOmf+yiFiSpo3/06yr7ubHb3+qZrPwvE5otFeheGTglHY/Mwk4BHhnpoCZX 2T1UhOh23yCm3megCyUxvKOm4dQfCaq+v74DBJMbC7+ROyj7h8cOKIRsWxv2SJdQigz+ dibfJ/n2CgWLjAThCzG59KiZKe0e8RfsDauR3PhdAduO35IbW/qcAVphVX4YbndGRQq2 nfVmF1jGwwLzW7ov6qqir6HjESDqSgX1E/qKwa0Mi9L/AkP/hqr8phQUCIvHEqqv69EZ r7pg== X-Forwarded-Encrypted: i=1; AJvYcCVDGR49S5PLZFb2V9g6NclVubR3yQ7M4fbVp2TqXhVaNd4z0Pyttc1cf9D++4RPuFFoSkYp14iBUv7T5Xhscyf3t3c= X-Gm-Message-State: AOJu0YzaspCfsKzBvjZLqaeV2aIKaIQB/utfZe6eI0HJDpShJx83LQvI becrmyJQt5ToMhLwthNDl3ANC0RmrR1d+vXNLp7akhOEe4feNWo6an00Swx8Ks+jRoWDO7X4zI6 JeC5kSA== X-Google-Smtp-Source: AGHT+IHhpmlm6W1hfzTa1BdMHzZXFxaGRd8WD7ooSRWuSDRb8zGnVe3b/cQPgKPdSSMt4WbkMtKIoQ== X-Received: by 2002:a50:cd48:0:b0:57c:8027:534d with SMTP id 4fb4d7f45d1cf-5b021f0d957mr9229027a12.27.1722441882337; Wed, 31 Jul 2024 09:04:42 -0700 (PDT) Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com. [209.85.208.44]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5ac64eb3591sm8817858a12.67.2024.07.31.09.04.41 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Jul 2024 09:04:41 -0700 (PDT) Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-59589a9be92so8834630a12.2 for ; Wed, 31 Jul 2024 09:04:41 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCW+GsMAaCh6o+aW1fLIR6YYOFfrTcgRQDrRAuOQVIGh7/xmoUII8BuX2eto5R4R7rOzdJh6vw63KNLvstbwrZD60Ms= X-Received: by 2002:a05:6402:34cc:b0:5a0:e61c:edfd with SMTP id 4fb4d7f45d1cf-5b0207cb548mr11807179a12.14.1722441880993; Wed, 31 Jul 2024 09:04:40 -0700 (PDT) MIME-Version: 1.0 References: <402c3c617c29465c898b1af55e3c6095@AcuMS.aculab.com> <5cd3e11780df40b0b771da5548966ebd@AcuMS.aculab.com> <8111159a-c571-4c71-b731-184af56b5cb1@app.fastmail.com> <73d65e2553e543069f9969ccec4ea9b3@AcuMS.aculab.com> <0549691a6a3d4f7a9e77003b70fcf6fe@AcuMS.aculab.com> In-Reply-To: From: Linus Torvalds Date: Wed, 31 Jul 2024 09:04:24 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/8] minmax: Put all the clamp() definitions together To: David Laight Cc: Arnd Bergmann , "linux-kernel@vger.kernel.org" , Jens Axboe , Matthew Wilcox , Christoph Hellwig , Andrew Morton , Andy Shevchenko , Dan Carpenter , "Jason A . Donenfeld" , "pedro.falcato@gmail.com" , Mateusz Guzik , "linux-mm@kvack.org" , Lorenzo Stoakes Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: jeifrfcpf6w51mdz77d7onqaix5fw1ij X-Rspam-User: X-Rspamd-Queue-Id: 3D7E3140026 X-Rspamd-Server: rspam02 X-HE-Tag: 1722441883-526101 X-HE-Meta: U2FsdGVkX19pOHX3EiHfMkfoJoi1Q9IRgy0O/VNJT/amF+8ZBOIfrNfFLHBVN9Kx2dMW85mF1BztuDe7NKn1RMGIw93ZFL/Y1c82pLNfBIfJijfDmDvDSAG9tExlHDU+2RvBvr5Q20KQh8fd9I+KazMuY/9ZetxSJ58JQq5ihiuSxLvUjkz/3QrSO4GOg+LtleFPiuDHENvM2dfb3Efwy2Nji2kR15fE4axnRB6hqwfK82UuAQWZD0nq68RtYbdkXzTPYa1hNq6wh5Gi2hjpBrg3TSSw9I7X+NXVjIyBkwIHX/h7rkF2kZC3C3PeNjp/oF3f17j7ry7NjqHygUmuJ0rE3A44dFkghvatCh9UV/PGcc5qhJaQtGlFNVDWDDeNjvMMIGyHa+LKtyqD3mntrMB1Ilwu6gm8mL4O5ZZLVijAgQciR3OrO6j0IAIdgSZywHHTk9gtanwXoO3fXcYaV0doypKdzvtA9NyiL83RWz2C6F6tBaoYlKjiQNn2Jn49+SzlclFuCyLLzgD4Unyn9C5Ed5Ti6jWxw/2yJWOZjXlIl5rp82vQ1faQEfOOXLTiqoI3Y8c5EWdZLlQZUya1o3CLceYrmEB4BmDSHaNkkgtgCCcww3yEcbDwgAhT1Vqtz+VdFj2hi/MmeVVLRMZjbR/CrL++QS62oeI/dOImesPuR058u0lw43KW3SO2YPF8FaXIyg6qOT2OLCMZs+ydZaLuCHn5ZcmwsiymPP3UefQGoRaXn7DcxER/v78ht7BaWdlGpj9CwEDqbg2f1xN8zHq8deUn4yJI0qApR5vT0DpLbVaXgrdSbi8Fcw3/qMPww9nPGRK6hcJ/N4yPN5e777dGqM80vwoTa65gAd2biclnxZ9sMgoIDKAV5G8GktF+W3imk3+GWyy+4rMJaNFXmsFCpuCXYLjBbwh7c8uWGIb5/etAWVGap9qKXaxZdnCRkm3y9R7JCOk4pbXi6fJ VANDXBHm MsOJ+d1YM3Kh92sC5UGPHqVEpH2SSUjn3jSLd4j0k3rBIi2Ri/tOAzC9K9MHat7VE5HHxVFkBZBQhXMJj5gYxpwjc7rUG0o5+UDbNPwNS78Z4gt7b7XUNwbYCsWh2U48OShdcK7WgFJEiu4+EMv6eTLxUR5h2BSaXFoWGdNo3YrlBujuVdl5+d38ipHb2BjKyv9JcLeO5a1Qq/KbuG78igWJb1Qo2a9WIfVTjEN521xkdeX6IuH1QpLaxkU5/PKYM3vSWzngtI2MXsCMDfxKAHad7zQrjvUIVKQ7Qa2pQ7A6U2739ij7xtklPa17tIe0rQQDdjqtAV55Ajz8QA8zGyyN2qAvNwFL1V0dQgV+OZO4BrjMGiTJxGltsRylJDudCp7oQfsrd0UCxlHfWnPG3BuM3XVVhhSeJPERmxgRq4V3jr2b9DWOjPjt1oHwhKaPIR2/gs6ZdHwUk88FPxOO4hn7epLIlzvRR49AGQtjmZKQ0htM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 31 Jul 2024 at 08:57, David Laight wrote: > > Perhaps something like: > #define do_foo(x, uniq) ({ \ > __auto_type _x_##uniq = z; \ I like it. Not quite enough to do it now, though. But I did commit my min3/max3 patch, because when I looked at it a bit more, I realized that the old min3/max3 implementation was actually completely and fundamentally broken, and has been for a decade since it was rewritten in 2014. I don't think anybody has actually hit the bug in practice (it will cast away significant bits if you use it with just the right types), but when I looked at it again I was like "Really? We've had that horror for a decade?" Linus