From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CCA3C35247 for ; Tue, 4 Feb 2020 02:45:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4DCE720732 for ; Tue, 4 Feb 2020 02:45:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="LcV/G6E7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DCE720732 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D1E656B026B; Mon, 3 Feb 2020 21:45:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CCEA66B026F; Mon, 3 Feb 2020 21:45:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBD6A6B0270; Mon, 3 Feb 2020 21:45:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0058.hostedemail.com [216.40.44.58]) by kanga.kvack.org (Postfix) with ESMTP id A00D86B026B for ; Mon, 3 Feb 2020 21:45:29 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 4D4E02DFA for ; Tue, 4 Feb 2020 02:45:29 +0000 (UTC) X-FDA: 76450903578.06.mask83_2fce85bb6bd21 X-HE-Tag: mask83_2fce85bb6bd21 X-Filterd-Recvd-Size: 5458 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Tue, 4 Feb 2020 02:45:28 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id x14so16801564ljd.13 for ; Mon, 03 Feb 2020 18:45:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=itatGqV9ZdZCCEBn5U6ljfzsA3HoNXxjauowsvmG2DI=; b=LcV/G6E7ISHEI8sUyl8m+6ZcyRXQ3yHv5nUd6RARg0n5TMRiJrYlQlshSVdAp3i+yQ o25nDdXc/qQvvROY1pQHVEejOilO3yB/SzUtfPOfhaKA1pYRMu7oheJ7X2A2MYs8I2eh UeqTvkpJKv31zn5PNIW3OTiQevFBNLu08wuPA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=itatGqV9ZdZCCEBn5U6ljfzsA3HoNXxjauowsvmG2DI=; b=ZU/Y2w9gJvo6JNNRx6gFWLbM83e3YFuBpZR9aGJcb0hReB+YvwOu97338ZmzOuZ0En tnUJ5Hp0kKaIRt+RpnUyxAN/PgUF3/pwkZ0wN771OLL/EO1RGEMCah28rxX+t9qM3vTw n9xRMUhG260zKDizSZgTRZCC3UmtOIf9cgy/WKJUjpQXNjCO6O86yZZI7MggT6366yrE 3alODj5v9BUglOj7Ds41t8Dg2ZXanlLVKnOh9byXZhusMq1EOkCJHFwf030VxmKZTAvn 041Cy8fskYmpMlARmmKgDxjgsd3ILfv074l3hfHauMai7nYIP1toKQtQYurVwlDmJb6T X+iw== X-Gm-Message-State: APjAAAU9SXu1EQXLS2Eu2MsKccFDxGM+/HI7WIW7MbO4kppKHiDTaBsF pyQSazHV+ZgxAxLhBvEhnEuh3AE9OwV4CQ== X-Google-Smtp-Source: APXvYqzvn7u4CTPjVwolsZFI8aF1g+4QShkzR9GFauZ1OdVh7eSAYEg2aEfilLKMwMxUHrpqgzu/Kg== X-Received: by 2002:a2e:9050:: with SMTP id n16mr15447147ljg.49.1580784326404; Mon, 03 Feb 2020 18:45:26 -0800 (PST) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com. [209.85.167.41]) by smtp.gmail.com with ESMTPSA id v7sm10580476ljd.12.2020.02.03.18.45.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Feb 2020 18:45:25 -0800 (PST) Received: by mail-lf1-f41.google.com with SMTP id t23so11139687lfk.6 for ; Mon, 03 Feb 2020 18:45:24 -0800 (PST) X-Received: by 2002:ac2:43a7:: with SMTP id t7mr13663336lfl.125.1580784324550; Mon, 03 Feb 2020 18:45:24 -0800 (PST) MIME-Version: 1.0 References: <20200203173311.6269a8be06a05e5a4aa08a93@linux-foundation.org> <20200204013359.YjZ6CpL86%akpm@linux-foundation.org> In-Reply-To: <20200204013359.YjZ6CpL86%akpm@linux-foundation.org> From: Linus Torvalds Date: Tue, 4 Feb 2020 02:45:08 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 05/67] mm/page_alloc: fix and rework pfn handling in memmap_init_zone() To: Andrew Morton Cc: Alexander Duyck , Baoquan He , Dan Williams , David Hildenbrand , "Kirill A . Shutemov" , "Kirill A . Shutemov" , Linux-MM , Mel Gorman , Michal Hocko , Michal Hocko , mm-commits@vger.kernel.org, osalvador@suse.de, Pavel Tatashin , Vlastimil Babka , zhi.jin@intel.com Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Anxdrew, this whole patch-series seems to be corrupt. Not only was the "incoming" cover emal missing the base to apply it to, but the patches themselves are broken too. See for example this one: On Tue, Feb 4, 2020 at 1:34 AM Andrew Morton wrote: > > From: David Hildenbrand > Subject: mm/page_alloc: fix and rework pfn handling in memmap_init_zone() > > Let's update the pfn manually whenever we continue the loop. This makes > the code easier to read but also less error prone (and we can directly fix > one issue). > > When overlap_memmap_init() returns true, pfn is updated to > "memblock_region_memory_end_pfn(r)". So it already points at the *next* > pfn to process. Incrementing the pfn another time is wrong, we might > leave one uninitialized. I spotted this by inspecting the code, so I have > no idea if this is relevant in practise (with kernelcore=3Dmirror). Note that "=3D". That's some MIME stuff that you haven't decoded, and then sent out as an email as-is. > Link: http://lkml.kernel.org/r/20200113144035.10848-2-david@redhat.com > Fixes: a9a9e77fbf27 ("mm: move mirrored memory specific code outside of m= > emmap_init_zone") Same here. That "=\n" shouldn't be in the email, it comes from some original MIME data that wasn't ever properly decoded. The *patch* itself seems fine, and the "=" signs are not mime: > - for (pfn = start_pfn; pfn < end_pfn; pfn++) { > + for (pfn = start_pfn; pfn < end_pfn; ) { so it seems that only the actual explanations have gotten corrupted somehow. Cut-and-paste from some MIME source in a MUA that doesn't know mime? Or directly from some mbox file without any MIME decoding? Linus