From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4723C433F5 for ; Wed, 15 Sep 2021 01:21:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 381CE61166 for ; Wed, 15 Sep 2021 01:21:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 381CE61166 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C58B66B0071; Tue, 14 Sep 2021 21:21:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C084F6B0072; Tue, 14 Sep 2021 21:21:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF69B6B0073; Tue, 14 Sep 2021 21:21:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0150.hostedemail.com [216.40.44.150]) by kanga.kvack.org (Postfix) with ESMTP id 9E5C46B0071 for ; Tue, 14 Sep 2021 21:21:29 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4E32D39BA1 for ; Wed, 15 Sep 2021 01:21:29 +0000 (UTC) X-FDA: 78588055098.30.8AB0D37 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by imf22.hostedemail.com (Postfix) with ESMTP id 0EA221900 for ; Wed, 15 Sep 2021 01:21:28 +0000 (UTC) Received: by mail-lj1-f177.google.com with SMTP id f2so2233994ljn.1 for ; Tue, 14 Sep 2021 18:21:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=x4VkY+TFyFo+mcrDLvn05mZKNpL11A9T/wyZkbRLEvw=; b=WcSzoKReTJLTL2aZ/b+qFuar86cyA8X1UAHLQP5uOOMjaIPKEImNq42IAR+dpDOOyO b2fhmZ3E1rr9/xaCbXjtkUBcrmjRjo5zePtYdy1BkHdF5OnKcF84F/1upMw1YJrS8vfP aHrPsZdWJg6FbF9WGF47DU2Wl6OlaBC6f3jpM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x4VkY+TFyFo+mcrDLvn05mZKNpL11A9T/wyZkbRLEvw=; b=TdGoj4w9PupB/JSrp5RYnhRPEQ7MoIV9qVOVVcBYd9Pvd1vaZvsM8obMvzAIEJAI4z ECPJgBVZAqbozrdpqI/N3FZ4gKUtdwWjK0WlT8ySoPPJvM0NB7iTphwlf6gaA+52H0IN l1d9Y1CNvlqS0nBYkWujnK1HJO33dkS6Z5AEfclrEpCbSVoWNTJSD/4GGwNR6QeGEC4M pLBrEdnucpWA50Hk9p+phnRPkGCD+x5h1IGBQKFClBUkU9H6lZBcRj3IYZetvFBlkvXQ ouAt9OeDWBc78e3/YZ9Z3EgDptmFedZW/BYbmkoWtd2DL1WaWFVooWUzXBJjHHDXrWBs oJCA== X-Gm-Message-State: AOAM530JkC9PJHlEeqs9ibdMD1uMxu5iTV4b7qxnKo6/Hp0OgkZarQV0 fePOuthJ60q6xTswgSFqhdhckxnraQ9Th50aCno= X-Google-Smtp-Source: ABdhPJy8m/OSK0b1sMbwOqhbCsip08owehwJSfQEbIwsegyDMl6TvNaufjFFwvjvRF1C+fIeE5xAlw== X-Received: by 2002:a05:651c:110f:: with SMTP id d15mr17461101ljo.99.1631668886714; Tue, 14 Sep 2021 18:21:26 -0700 (PDT) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com. [209.85.167.54]) by smtp.gmail.com with ESMTPSA id i12sm1252028lfb.301.2021.09.14.18.21.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Sep 2021 18:21:26 -0700 (PDT) Received: by mail-lf1-f54.google.com with SMTP id g1so2414848lfj.12 for ; Tue, 14 Sep 2021 18:21:25 -0700 (PDT) X-Received: by 2002:a05:6512:114c:: with SMTP id m12mr15709190lfg.150.1631668885502; Tue, 14 Sep 2021 18:21:25 -0700 (PDT) MIME-Version: 1.0 References: <163166717752.510331.12843735095061762373.stgit@devnote2> <163166721835.510331.4931010992364519157.stgit@devnote2> In-Reply-To: <163166721835.510331.4931010992364519157.stgit@devnote2> From: Linus Torvalds Date: Tue, 14 Sep 2021 18:21:09 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 5/5] tools/bootconfig: Define memblock_free_ptr() to fix build error To: Masami Hiramatsu Cc: Steven Rostedt , Mike Rapoport , Andrew Morton , LKML , Ingo Molnar , Linux-MM , Vlastimil Babka Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 0EA221900 Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=WcSzoKRe; dmarc=none; spf=pass (imf22.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.177 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org X-Stat-Signature: 3xc864fp3txdqmqmcibruyp6w1jrqys3 X-HE-Tag: 1631668888-66415 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 14, 2021 at 5:53 PM Masami Hiramatsu wrote: > > Since commit 77e02cf57b6c ("memblock: introduce saner > 'memblock_free_ptr()' interface") introduced memblock_free_ptr() > to lib/bootconfig.c, bootconfig tool also has to define > memblock_free_ptr() wrapper, and remove unused __pa() and > memblock_free(). Christ. I grepped for this, and couldn't find any use of that memblock_free function in the tools directory, so I ignored it. It seems like the code in lib/bootconfig.c is compiled both into the kernel and into that tool. This is a nightmare. We've explicitly tried to avoid this for the tooling headers exactly because of issues like this. Linus