From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D21A0C4332F for ; Fri, 18 Nov 2022 22:15:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5CEE58E0001; Fri, 18 Nov 2022 17:15:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 57ED76B0075; Fri, 18 Nov 2022 17:15:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 447258E0001; Fri, 18 Nov 2022 17:15:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 366C76B0074 for ; Fri, 18 Nov 2022 17:15:45 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 083A7808B1 for ; Fri, 18 Nov 2022 22:15:45 +0000 (UTC) X-FDA: 80147971050.01.53F6493 Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) by imf18.hostedemail.com (Postfix) with ESMTP id A23EB1C000A for ; Fri, 18 Nov 2022 22:15:44 +0000 (UTC) Received: by mail-qv1-f42.google.com with SMTP id k2so3106763qvo.1 for ; Fri, 18 Nov 2022 14:15:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=pojgnIa3yng2KeOHm7wwCrEJ0fgeI0WPAxB+/uOvwqM=; b=BwyNh1+rdJu96LlHA3PC1MOZUU6OGfAEg0/tTi+QC3LJoTPhce1Ta4CvWzjrgf4+Sf DTwyzA6fhfEAh6di13kUKXRKwBstF0zE2/NNYalqp+WdAU1IJmbCGLK0ZIGaiaqa2xUm civ9S76Llz+rTYBme/YQ+goRH+/X0k8/EanB8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pojgnIa3yng2KeOHm7wwCrEJ0fgeI0WPAxB+/uOvwqM=; b=N9rN64wxvuf0ngf4TNiEf1qNKSBFoANBW1wwNE/MP8OkO6oFsZkHoXsm53UZ/CxUWk F/fD3jdp08Owy+p+Ahzqh5WORZjkUFYV5P1v0CbdXxemNy+79bRdQfyrctANVI2a0cTG 5NwWxUy26I5y4cjbCe04jxx5H+Se8FjYGnK+PO973pa+YPFsi61/+ZufzHpfNt30/NSH DV0Wv9OVBPc3qat2Tmzt64bX3Oaxycaxqzn12MWjV+ykyJW7l3A2BfprqgE01AO90HzZ Zh5rwLJPCIFNFhUW3QftCXVbGLIjsV1ZjnjBCIobN7EhlYyhxjm7GdWnjhM+IQRG9TVB VCXw== X-Gm-Message-State: ANoB5ple97+CVZcdXfr/YgFCDVPX19lE0y8FmeN6VcA2Hjx7KBfyIVSB F20vj+3rf8G2F6EqmWNiMH5Zx9iTEC6K2Q== X-Google-Smtp-Source: AA0mqf4hxzGbYBRwTTUxhvXPe3KOZ9UVSKa1jP98zp4Q7Q3zroVsctSL0pL4x1mEOEbcqaXETREktg== X-Received: by 2002:a05:6214:acc:b0:4bb:e3f4:6ee0 with SMTP id g12-20020a0562140acc00b004bbe3f46ee0mr8638878qvi.54.1668809743636; Fri, 18 Nov 2022 14:15:43 -0800 (PST) Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com. [209.85.222.175]) by smtp.gmail.com with ESMTPSA id r8-20020ae9d608000000b006ee7e223bb8sm3165056qkk.39.2022.11.18.14.15.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Nov 2022 14:15:43 -0800 (PST) Received: by mail-qk1-f175.google.com with SMTP id k2so4425820qkk.7 for ; Fri, 18 Nov 2022 14:15:43 -0800 (PST) X-Received: by 2002:a05:620a:1fa:b0:6ee:24d5:b8fc with SMTP id x26-20020a05620a01fa00b006ee24d5b8fcmr7692107qkn.336.1668809271549; Fri, 18 Nov 2022 14:07:51 -0800 (PST) MIME-Version: 1.0 References: <5f52de70-975-e94f-f141-543765736181@google.com> <93fa81ae-d848-58c2-9f70-27446bf9baa8@google.com> <20221118140346.b9026301b4ba03e43e15aeca@linux-foundation.org> In-Reply-To: <20221118140346.b9026301b4ba03e43e15aeca@linux-foundation.org> From: Linus Torvalds Date: Fri, 18 Nov 2022 14:07:35 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/3] mm,thp,rmap: rework the use of subpages_mapcount To: Andrew Morton Cc: Hugh Dickins , Johannes Weiner , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Vlastimil Babka , Peter Xu , Yang Shi , John Hubbard , Mike Kravetz , Sidhartha Kumar , Muchun Song , Miaohe Lin , Naoya Horiguchi , Mina Almasry , James Houghton , "Zach O'Keefe" , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668809744; a=rsa-sha256; cv=none; b=ACDxtriMZitCSD9E4CozaTtNnnB9hH77PqExam0Qho9jy87+LpHGgWC6KOqfCo8w16+6A5 eeaJWe07ETIKG90N4fwUL9pbSMlpxH6vm37GOpPk81SC20PDbIwPnTKd05UWj/SkbiRlwz vll+m59qB144EEIVKperhxu2uBqXYuc= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=BwyNh1+r; dmarc=none; spf=pass (imf18.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.219.42 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668809744; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pojgnIa3yng2KeOHm7wwCrEJ0fgeI0WPAxB+/uOvwqM=; b=FCBk3cN+Mk4KaudbdVXMUpv0xf9+756NNAz8MyjcwfH3N03qHFqGMbBC/PqzSzpoZ6jEmO QquZfhTuICO7+IGo3OvbgAanZrsvnuko1ySfC+0fGWWKZz5RybIFiSkpi9b4fC6H94DLiD umy7lZkqaOa2bl4ILx9mhjuQlKrte7A= Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=BwyNh1+r; dmarc=none; spf=pass (imf18.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.219.42 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org X-Rspam-User: X-Stat-Signature: 9x3jhpe5rectr3ooihqnwk3q4fksabkk X-Rspamd-Queue-Id: A23EB1C000A X-Rspamd-Server: rspam11 X-HE-Tag: 1668809744-378329 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 18, 2022 at 2:03 PM Andrew Morton wrote: > > I'd prefer that approach. The "that approach" is a bit ambiguous here, particularly considering how you quoted things. But I think from the context you meant "keep them as two separate series, even if the second undoes part of the first and does it differently". And that's fine. Even if it's maybe a bit odd to introduce that locking that then goes away, I can't argue with "the first series was already reviewed and has gone through a fair amount of testing". Linus