From: Linus Torvalds <torvalds@linux-foundation.org>
To: Andrew Morton <akpm@linux-foundation.org>,
Kent Overstreet <kent.overstreet@linux.dev>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
mm-commits@vger.kernel.org
Subject: Re: [GIT PULL] non-MM updates for 6.11-rc1
Date: Sun, 21 Jul 2024 18:12:37 -0700 [thread overview]
Message-ID: <CAHk-=whqXizOqcpcrqvRJ88Twi4+o=G1Y=5qsLBs5R-8uHjs+Q@mail.gmail.com> (raw)
In-Reply-To: <20240721151013.b9b331ce79f5f60c54c69636@linux-foundation.org>
On Sun, 21 Jul 2024 at 15:10, Andrew Morton <akpm@linux-foundation.org> wrote:
>
> - In the series "treewide: Refactor heap related implementation",
> Kuan-Wei Chiu has significantly reworked the min_heap library code and
> has taught bcachefs to use the new more generic implementation.
Bah. I think the users should probably have been converted in their
own trees, instead of having this thing that caused a somewhat nasty
conflict.
I think I sorted it out correctly, but I'm not seeing why the bcachefs
conversion was done outside the bcachefs tree.
(Ok, it's not like the conflict was all that nasty, really. It's more
that conflicts in this _kind_ of code is a bit nasty).
As it is, I do see the Ack from Kent, but I'm going to ask him to also
double-check my merge.
I see what happened in linux-next, but that state also seems different
from my tree (at a minimum, Kent also moved the tiemr_lock around a
bit too).
Anyway.. The conflict resolution looks sane to me and doesn't seem
fundamentally complex, but (a) mistakes happen and (b) it does seem
like this whole heap conversion could have happened in the bcachefs
tree.
Kent, mind checking that I didn't do something horribly horribly bad?
Linus
next prev parent reply other threads:[~2024-07-22 1:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-21 22:10 Andrew Morton
2024-07-22 1:12 ` Linus Torvalds [this message]
2024-07-22 3:35 ` Kent Overstreet
2024-07-22 1:15 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=whqXizOqcpcrqvRJ88Twi4+o=G1Y=5qsLBs5R-8uHjs+Q@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=kent.overstreet@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox