From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D519C46CD2 for ; Wed, 24 Jan 2024 17:27:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B64616B0089; Wed, 24 Jan 2024 12:27:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B13FD6B008A; Wed, 24 Jan 2024 12:27:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0E426B008C; Wed, 24 Jan 2024 12:27:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8F5146B0089 for ; Wed, 24 Jan 2024 12:27:57 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5214B1C179E for ; Wed, 24 Jan 2024 17:27:55 +0000 (UTC) X-FDA: 81714887310.19.E93CA3E Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by imf19.hostedemail.com (Postfix) with ESMTP id 3B69E1A0020 for ; Wed, 24 Jan 2024 17:27:52 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=Lv6klvku; dmarc=none; spf=pass (imf19.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.49 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706117273; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zTlbGsImqxn7RX+/XBkYgj6lDq/Avh2rTF8zOkCv5JM=; b=Ov5tQGXMoumyh7HUG7TbbJ3Kjb2YdHSXFzzgNFKbecpeSGNWdWJt3P5IynW+XnbPaMw1Bx nL8Mt7W00TzbRKWXt6oiZh3/PsF6CUGQDAYLL3pDEwUgBdS8jNzJFSHY2jQsUjLzzjOSLf 7N0yQeg2ty/h6/owH18/kAtmQFowmTc= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=Lv6klvku; dmarc=none; spf=pass (imf19.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.49 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706117273; a=rsa-sha256; cv=none; b=erBqC11nl43Pa+GvzrFgY/0ZgrSBvKNqUvrtFnXizVBpbf9bRkT746f6S/lwUx3N9TboJy ibPw7yrL5Col1uQhv9FxgISoMWAsX7g7GRXncQYHdX0xLjfLh8Da+4rUhVcTZWnzCqmyno /cnmDdcExMJDEahJobdl7JeE60fcr8k= Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-55783b7b47aso6489313a12.0 for ; Wed, 24 Jan 2024 09:27:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1706117271; x=1706722071; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=zTlbGsImqxn7RX+/XBkYgj6lDq/Avh2rTF8zOkCv5JM=; b=Lv6klvkunF95NQt0cYA+7z1kSyueAnTkFvhWHHJjGtUE8Bfhwzwy3iW6LcD8CsYQGW 3HaktAfKvsvm6+sf9XUyASYacgCkcBiTA7iaHxdJCxAKAlL5LA0l3Ff8rUt74qyMZ6B5 0tsFvgv2auYGVe/ryxJIR8X2Ypcm5ZUvdTiPc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706117271; x=1706722071; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zTlbGsImqxn7RX+/XBkYgj6lDq/Avh2rTF8zOkCv5JM=; b=DS8PqjMoEsjoqIPGEuKawBRzyCMBxlpuoU3IsXoT2LPMPBxU5EmY2AjpH29J9lXYkw nhaMHv6vzTh7sZJscIxcTtUV0iVRU/GXlsST6HS8ZefRGoaln7kjO+Lqg9PpjtVaRIfD HBSfKTvUuXdn2mPK+sbu5FX5QX//cYoRAqOhsaVWhkH3JctaV88BWnVsBz3FOrxbXU+x WA+RdE19y4Z8FukfSWYl9Fasdsm+kYBMug3odkPEFbRs8Zy4PaK0w8LdRx/cwN5YWZm6 7ww2bs2a4mZV6V2Eokc9acXPKPxSXyFLaX4Yikkp3MoxaaRIbZ0L3YC4X00SadROjly1 Il5A== X-Gm-Message-State: AOJu0YwL/vVjHahrOCYRmtfqwX2Fo6WlP+xoSZNYcSaL4G1lnGNfLcGW peu20BFbYKFwr+PRHwG30dFzJDhCWwskGtvWCRCDAiZu20witQiGMPFfGqpMa6wHf6nGe+QY1va 9dK981g== X-Google-Smtp-Source: AGHT+IGYsg4QYfFLsgNDXDEkIqcTw1WVGhxCUOGX0bLhPwq36ctQhc1WcE9SUQvHqgIY9v+yAzDD5w== X-Received: by 2002:aa7:cb4d:0:b0:55a:6546:71e7 with SMTP id w13-20020aa7cb4d000000b0055a654671e7mr1796072edt.82.1706117271535; Wed, 24 Jan 2024 09:27:51 -0800 (PST) Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com. [209.85.208.43]) by smtp.gmail.com with ESMTPSA id l16-20020a056402125000b0055c4ab8122esm3318620edw.38.2024.01.24.09.27.50 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jan 2024 09:27:50 -0800 (PST) Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-55a685e6299so6124531a12.2 for ; Wed, 24 Jan 2024 09:27:50 -0800 (PST) X-Received: by 2002:a05:6402:34d4:b0:55c:7444:153f with SMTP id w20-20020a05640234d400b0055c7444153fmr2637292edc.60.1706117270433; Wed, 24 Jan 2024 09:27:50 -0800 (PST) MIME-Version: 1.0 References: <202401240832.02940B1A@keescook> <202401240916.044E6A6A7A@keescook> In-Reply-To: <202401240916.044E6A6A7A@keescook> From: Linus Torvalds Date: Wed, 24 Jan 2024 09:27:34 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [6.8-rc1 Regression] Unable to exec apparmor_parser from virt-aa-helper To: Kees Cook Cc: Kevin Locke , John Johansen , Josh Triplett , Mateusz Guzik , Al Viro , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3B69E1A0020 X-Stat-Signature: j3zf8sxm1pnztbp5e556c9pkdcdzoszg X-Rspam-User: X-HE-Tag: 1706117272-534157 X-HE-Meta: U2FsdGVkX1+aSNaBavHF6nG+pVxswe+j9EqyG+xCWA48ePHT7iXAgiENVrPDALAcpbzUP5DG6AEXfzH0TR9mDcbWy3w9eVAequQC4C5h0ZzBM4pUONLNd/67O0A6eXlNXi6xuTwYPpl2nMlfJzvqNyDmq6ElB6ZxvfuAuzwRgD3si01fcshdXLNzvbulpFg7TLwjVw+2uCfLiuMzJ5lbw+Dipkqk9Sho8H5q4w8EXw8d9pemxALkePLTn9f4uq5aQ25XS7Q4YXGILtripxirm1PcxqevUPGTgkcNqhB8Q1c+O1Oly/6pZrHEsi5q0Lg+BEO0JEaKPiLQgEPVRvwJRnFn+Z2/X3114TXqTvmsjyARPOEXLoHJBtcWdo93a1+UfPEEBr6TOszSdFdxOiCXxL2rcOCX8Q06fMSDamv4Fj1xzO2QEf4sWB+91vBAtfUZnSBy/48lxZp90UJlXkn1zwr5NUZAb0e/gMl37GDbpaNlZCuyYCs8HCH4Fs6/5K2vvN0UqQhLo7Fs6Hd+/ryerS5t/zK/JNdstz4xQPCaXZdxeLUF2K27lQjjWwIA917iVXBpp/k4azYKwh926vyW4ydqVxDcF21zpOzIU8M1MNAVXA7fabEFFCbg1yvPOa4L+uYhpPIYpkOraLKG+Ycr7LjXiTh/D++8cdqB1FsB0KoLrPP4NyNfnWnN3IvQzPQKrpfAJn1fqjY4BETIxywO+Buks439oPvABegQeWsOllfraIMZPo/488HPh2aNBphKRaTX8E15HY/Uu8J49fzy0bNallSlSnEdcqMsIGPiR7PlaFw/NkH4D4eGmxhbB1MBAHfGHR/gPcBUq2kO+c7deSMjxfH44gnL+M/Hl+5T7Yggp10K7ciCHz7qEct2oMUbBN6koFeh2J/IO2dYvCZbwsbYxI/tqrCaYJ+ubdNcNkagtVBGLzFD9wYeLPA0QKP/68w8kg6nzqykr1dEAbz 8/I5ioZO aS9fWIq/UYYxb445FejMJm6SrHqi+AAzoZel/thqO3q2fRMw4kgwOHrKodq+PfV/cq6LWTg6ajJAx/V/F0FJF1JB4Ud7JHY1eU5RbD2mM+qZ7W+ADPGa0q1z/IEEe56hhUqGnipMYEjGgbveQvLJac4EbAk0huLedIRxZ26h2ysQr4ROY+RduVKpJD2JVw55EnGGUdmT/GqeT/rCF9x4Nlww5UJFPHENytvQKnB96i2N25FZABSdFsutDb9vhVsJmHeFSOfDPvASE7/AjH9AYaNBhP/M7+2u/hLEFzSH7UdxA0CfUXc9wigTqIEiSRddHtJlFSAfuipHJBA/y12q5NLoPq3rsK3TIhf/dHZv4xOlak+fG/Gyr8gml/Kd0nbsQFsOBzAncfVgJaq9J3d7ZWoUOBAm4U3JoH8S5yWmD0YAJBuoDKo78PE6Ck8Rq3Fp4pwAQTm8G3gCaTU84VoPWOoGB1xzeY4nsT0625IfHhuZzpt6USpzEni2R1ES+8OJs9jJphw2E4a7u1dUdZnP8yUU/g2zUmlJyjdW9XZUdiO8+VuDZbRwLhex58rdU6hgW75y5IkAy3UcKuneBwpfkLL+20Wa+UwEB8pab X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 24 Jan 2024 at 09:21, Kees Cook wrote: > > I opted to tie "current->in_execve" lifetime to bprm lifetime just to > have a clean boundary (i.e. strictly in alloc/free_bprm()). Honestly, the less uinnecessary churn that horrible flag causes, the better. IOW, I think the goal here should be "minimal fix" followed by "remove that horrendous thing". Linus