From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F4EAD5B146 for ; Mon, 28 Oct 2024 20:22:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E4806B00A2; Mon, 28 Oct 2024 16:22:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 893C56B00A3; Mon, 28 Oct 2024 16:22:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75B656B00A4; Mon, 28 Oct 2024 16:22:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 592E56B00A2 for ; Mon, 28 Oct 2024 16:22:55 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0AF9712011A for ; Mon, 28 Oct 2024 20:22:55 +0000 (UTC) X-FDA: 82724133954.10.DFE078B Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf09.hostedemail.com (Postfix) with ESMTP id 3FD85140006 for ; Mon, 28 Oct 2024 20:22:35 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=brtkQE08; dmarc=none; spf=pass (imf09.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.41 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730146844; a=rsa-sha256; cv=none; b=7ESuyIKqmANeacMgteF8y/AjzSIcf52h/5KHNFtMoZyMLl164GLn+0V645kt+8ig0NeEJg JDgB10zyzJKeQ8RpGPmVgIQxrQiOMpgBytNobbG/ekEJIQaefcyjWB/xEyBA1L4wjijugZ 6bd33PZK7Rs4mB9i/ynDUrlVlxqp2iE= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=brtkQE08; dmarc=none; spf=pass (imf09.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.41 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730146844; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e6nAUNbudPdSaY4ohe22hR7sOvXwfvaldH6jIn/jf/c=; b=1/xsLMY+jYiGv53LubFPkEnceXP4/2WnwLsP3XIxVjqCRLbqOye6g2v568GHUi4i6W5K/F KjQjBn0nX48EYudOvTlJMxU09VRTMTxcXf6+064QdwiRdPASZgyQv1rvsbexZkTi1a3yhF DQsZoJ8NUm7melByB8QcNUpN4ZWh5fA= Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a99cc265e0aso730153366b.3 for ; Mon, 28 Oct 2024 13:22:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1730146971; x=1730751771; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=e6nAUNbudPdSaY4ohe22hR7sOvXwfvaldH6jIn/jf/c=; b=brtkQE08eBim2jMrAPw/8e8Ozo37x2NN2xI1Mhwpb6rXOC74T/XNgLMvNOFcQaDiE/ gZMzxGcRKl8XjEe9hr6Av3SsBkabkjkNhgfq4W0sRmbRPQQXec+dP7Q19bYqFa0AJ9b8 KGucRhb52UsyxvI0a9XtkBDf0thVTBMGG8YMs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730146971; x=1730751771; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=e6nAUNbudPdSaY4ohe22hR7sOvXwfvaldH6jIn/jf/c=; b=ltA9M8593X2EihqtDP4Pln1/gOGinNRK3kOa9YTIVe8n2LslWKNIx40ilAgrnCrslz K4POLAAlNsmVnPCm4LQyaJlgTXTeoG7vcmDyDWNbU+IHBWdTvjfoLpyJ2Rjh3CKfvew9 3YXXWKI+fj0DQCD0R58Og/8XF8t0U71iXnF8D/y5gUKqDCPFsilOu6SwrQO4GHCD4mSF D5SOYAQTtjyxZeyxg0IHcBy7WpAry//pGpU55FgdS8Cg32Lhar4VPwb84cbDP0kLWhEZ V2zkXhLkOWoEmxxXtWsjeOArLg3zfy3wiHbI31TD/LWhZRQLSrqh5A7W9hWIb4as3Nx1 W8XQ== X-Forwarded-Encrypted: i=1; AJvYcCUpNhixsnij2natsT+8djj8ALvmEMoItyt7LWSunyc+GIRhzWWMOJwHdbnAaVeUcJtgJ6d+ZuEH8g==@kvack.org X-Gm-Message-State: AOJu0YxF8oH9zfhDwAD2B7CQ4ENYCuHcwZRsWtiV+MaRgU7xwk+9SSIp rxcevvWNuePLn1XGQD3CoaGf//0aPxXlC19/Yd6L/WjEQGFhEylS3oZs5q0a00ooLg2nMyuFrLm ooBxWiA== X-Google-Smtp-Source: AGHT+IF2s+sI9EjOBr1Bqi7FfmUGxyVtxp6lbEL6+1VoI7mCYHciNUNWx8fe1bzjeILyLkuJtHcqMA== X-Received: by 2002:a17:907:3d8b:b0:a9a:e2b:1711 with SMTP id a640c23a62f3a-a9de5a34aecmr873942466b.0.1730146970981; Mon, 28 Oct 2024 13:22:50 -0700 (PDT) Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com. [209.85.218.46]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9b3a086f6dsm403604266b.214.2024.10.28.13.22.49 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Oct 2024 13:22:49 -0700 (PDT) Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a9a156513a1so737658466b.0 for ; Mon, 28 Oct 2024 13:22:49 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCV+quuZzPrtH009g7MTO5TmU4WCCrSl7OqA5J0JPxMkkfnQfpZzYACmLOXVLELqOwaZZjY5cepDFQ==@kvack.org X-Received: by 2002:a17:907:3fa7:b0:a9a:8ee:5951 with SMTP id a640c23a62f3a-a9de5f4ac2amr729925566b.25.1730146969268; Mon, 28 Oct 2024 13:22:49 -0700 (PDT) MIME-Version: 1.0 References: <6e8deda970b982e1e8ffd876e3cef342c292fbb5.1729715266.git.lorenzo.stoakes@oracle.com> <61461dcc-e455-450d-9c01-5465003fc31c@sirena.org.uk> <438f50c5-8b8c-444f-ae85-10e5151f3f24@lucifer.local> <57mgmdx7wgfwci3yo3ggkmcnm3ujamgkwcccm77ypvmer5tegn@opiq3ceh2uvy> In-Reply-To: From: Linus Torvalds Date: Mon, 28 Oct 2024 10:22:32 -1000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH hotfix 6.12 v2 4/8] mm: resolve faulty mmap_region() error path behaviour To: Lorenzo Stoakes Cc: "Liam R. Howlett" , Mark Brown , Andrew Morton , Vlastimil Babka , Jann Horn , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Peter Xu , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Aishwarya TCV Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3FD85140006 X-Stat-Signature: uwtw4uxx58sryuyudk6o7ci3pcoqbfai X-Rspam-User: X-HE-Tag: 1730146955-34446 X-HE-Meta: U2FsdGVkX189oWCEvh5DJTpbDgR9rWqzq7ceNjSlYQu30m3zUxfhuBPJO4jkd4Dnm6BZcW4P7QHGUY0E6Ptlnzmn5T0mInlhgvG5lWhq2heDsEYHIn3FHx7WKqAijn0LlYQCKQR3NyhdfIvc/0jNFreC16tJlSyhtk7AcxTR0BYlJnaPGmc6IOLMRC3S3FEQg6tN1w3Rdl7vx+sjoARJeOuONVEHvIm3YO6WIsMlfIMM8PCL7+KFnLLa8Wy3i5WU+VXhI+0LWWIyYeLsKBFUPebqYPt8sL4t1uHcTQuA/Xf8zv9kwMucwIj94o9TMeZQDJW6yMadsZo/+N45m6weYRJiX2GlD8OxT6maLu9D0vFnwNUoViv/WV3f7dlmP17a9NHuapKRJ2CaHNwYxLY0oB3L8keSiFIDvv0Zt4A4qI2+AkhrDvhSJ9j3kqcglK+RDYen0skRMe+G6FrMNkdNdRndEd+D10LcPs5Sc+ExotYjnfRO5rX+np8uRvDwE/4uUOezqEUodOzJCmOSKFdGM3F9qFeZd6MnGbzPWPjNzbVfleWvEdrIGluLoQY6G8mg6sSqcmX0rfS5ZL4Q9ALLJuYw/xQ1Z11TxEz2mnQCZsVWYnvz9FO4hqBY6CJuiq3J+KITs+Ld5keIiE67nnLCQnKpLIjaA+bp7N8PGXseDBoYD5CW3N9QJy/lP6ZyY93vgtVT+4khMnPpib9Uip8dHc8O1P1QYF8ZjJQSV1+A0sk8x3uxL286RGvZwidWmeKhOyk+f6QLyguAByULC7DUKT9VOB7P+K4/n5pn3xVMX3zjf++ytbZgVQs0Rp/8GAwuEipuh4yH8YY+YV2hLpnD1ACu+4M+B2LBXEG8TXhby7ndpgicXKvf3Kh4X4aVo7dbsEzZvNtxrpsq3iTkLx/nIA6UgNUx3dgGeKByHad/jm9WEkojCEGaC5I6lhot8e+xY8Ag2nrBhx/AZx4L8pI oh/x4K3D mTjn5luor4Q30fI06zIWZ1Tja8qDILE8abJoU8xu+iXiuHrtgkkQGdlB9OHeJwDgoXROL2BujX8EUkJ/6QW5xqVsA6ePmUJhxz1LgKB2O30Ioq3Eec0Jh5awQR/uE/Bj+LdynmZ1p56cIxLJFnlhYIh5SnOjXICQduwFF1S6W5oumxUOIsF5zubWgTcq6JaM7ADrMIRfFYLxw17Asr1mpedYTexeX+lkuz71Qi8fY3eXsikPmWSlNyqgK/JhLT6gp/Lru8JhL51PLRL0zRSPxmE2vApar4DsTuUcXYAb9dQrCklBh/jBibOdGTZDiNrR5saVnwwjz+eug9I/GuroTSgdcf8iy6nMc5N8CjFGxLnM6ZIR4m93hVuCHGNtmgKzHRlPGalc1TCdjkc6Yh5BxKYkAa/T1g4yXcTHrNamYBN9iVinmaG7RtZSDI5ltbJUAl+pXQoy+fDb2ymmTbvawM0IqRfN80Gsu+Vj3swOfulA6K0oeba//zt5zSO9IAJ4zCL6gzpjQMAW1Vmt+axVVADtFP21u4/l0x5+IJabhs06dIV7oHFfdPNNVVpwIE5wOdHtf82eRI+rQ0MI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 28 Oct 2024 at 10:18, Lorenzo Stoakes wrote: > > I'm genuinely not opposed to a horrible, awful: > > #ifdef CONFIG_ARM64 > if (file && file->f_ops == shmem_file_operations) > vm_flags |= VM_MTE_ALLOWED; > #endif > > Early in the operation prior to the arch_validate_flags() check. I would just put it inside the arm64 code itself. IOW, get rid of the VM_MTE_ALLOWED flag entirely, and just make the arm64 arch_validate_flags() code do something like if (flags & VM_MTE) { if (file->f_ops != shmem_file_operations) return false; } and be done with it. Considering that we only have that horrendous arch_validate_flags() for two architectures, and that they both just have magical special cases for MTE-like behavior, I do think that just making it be a hack inside those functions is the way to go. Linus